32713 2009-12-18 07:45:52 -0800 [Qt] make wtf/Assertions.h compile in winscw compiler. 2009-12-30 01:47:37 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) S60 Emulator S60 3rd edition RESOLVED FIXED P2 Normal --- 27065 1 yongjun.zhang webkit-unassigned commit-queue hausmann webkit.review.bot oldest_to_newest 173151 0 yongjun.zhang 2009-12-18 07:45:52 -0800 In wtf/Assertion.h, for variadic macro like ASSERT_WITH_MESSAGE(assertion, ...), winscw compiler doesn't recognize ellipsis alone in the macro definition; adding string arg before ellipsis make it compile fine. 173155 1 45151 yongjun.zhang 2009-12-18 07:59:14 -0800 Created attachment 45151 adding arg string before ellipsis to fix the issue. 173156 2 webkit.review.bot 2009-12-18 08:01:25 -0800 style-queue ran check-webkit-style on attachment 45151 without any errors. 173162 3 45151 hausmann 2009-12-18 08:23:07 -0800 Comment on attachment 45151 adding arg string before ellipsis to fix the issue. r=me 173295 4 45151 commit-queue 2009-12-18 13:18:23 -0800 Comment on attachment 45151 adding arg string before ellipsis to fix the issue. Clearing flags on attachment: 45151 Committed r52337: <http://trac.webkit.org/changeset/52337> 173296 5 commit-queue 2009-12-18 13:18:27 -0800 All reviewed patches have been landed. Closing bug. 175848 6 hausmann 2009-12-30 01:19:05 -0800 It turns out that this patch breaks the rvct release build: WebCore\loader\documentloader.cpp", line 793: Error: #135: class "WebCore::String" has no member "ascii" I'm investigating 175854 7 hausmann 2009-12-30 01:47:37 -0800 Sorry, false alarm. I merged this fix incorrectly (fixed now in c07df5686b431aa5d11643d00308d8f8f59d88b1 ) 45151 2009-12-18 07:59:14 -0800 2009-12-18 13:18:22 -0800 adding arg string before ellipsis to fix the issue. Assertions.patch text/plain 3082 yongjun.zhang SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUyMzExKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTItMTggIFlvbmdqdW4g WmhhbmcgIDx5b25nanVuLnpoYW5nQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzI3MTMKKyAgICAgICAgW1F0XSBtYWtlIHd0Zi9Bc3NlcnRpb25zLmggY29tcGls ZSBpbiB3aW5zY3cgY29tcGlsZXIuCisKKyAgICAgICAgQWRkIHN0cmluZyBhcmcgYmVmb3JlIGVs bGlwc2lzIHRvIGhlbHAgd2luc2N3IGNvbXBpbGVyIHJlc29sdmUgdmFyaWFkaWMKKyAgICAgICAg bWFjcm8gZGVmaW5pdGlvbnMgaW4gd3RmL0Fzc2VydGlvbnMuaC4gCisKKyAgICAgICAgKiB3dGYv QXNzZXJ0aW9ucy5oOgorCiAyMDA5LTEyLTE4ICBNYXJ0aW4gUm9iaW5zb24gIDxtYXJ0aW4uamFt ZXMucm9iaW5zb25AZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9y b25oYSBTaWx2YS4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9Bc3NlcnRpb25zLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuaAkocmV2aXNpb24gNTIzMTAp CisrKyBKYXZhU2NyaXB0Q29yZS93dGYvQXNzZXJ0aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC0x NTYsOCArMTU2LDEwIEBAIHZvaWQgV1RGTG9nVmVyYm9zZShjb25zdCBjaGFyKiBmaWxlLCBpbnQK ICNpZiBBU1NFUlRfRElTQUJMRUQKIAogI2RlZmluZSBBU1NFUlQoYXNzZXJ0aW9uKSAoKHZvaWQp MCkKLSNpZiBDT01QSUxFUihNU1ZDNykgfHwgQ09NUElMRVIoV0lOU0NXKQorI2lmIENPTVBJTEVS KE1TVkM3KQogI2RlZmluZSBBU1NFUlRfV0lUSF9NRVNTQUdFKGFzc2VydGlvbikgKCh2b2lkKTAp CisjZWxpZiBDT01QSUxFUihXSU5TQ1cpCisjZGVmaW5lIEFTU0VSVF9XSVRIX01FU1NBR0UoYXNz ZXJ0aW9uLCBhcmcuLi4pICgodm9pZCkwKQogI2Vsc2UKICNkZWZpbmUgQVNTRVJUX1dJVEhfTUVT U0FHRShhc3NlcnRpb24sIC4uLikgKCh2b2lkKTApCiAjZW5kaWYgLyogQ09NUElMRVIoTVNWQzcp ICovCkBAIC0xNzIsOCArMTc0LDEwIEBAIHZvaWQgV1RGTG9nVmVyYm9zZShjb25zdCBjaGFyKiBm aWxlLCBpbnQKICAgICAgICAgQ1JBU0goKTsgXAogICAgIH0gXAogd2hpbGUgKDApCi0jaWYgQ09N UElMRVIoTVNWQzcpIHx8IENPTVBJTEVSKFdJTlNDVykKKyNpZiBDT01QSUxFUihNU1ZDNykgCiAj ZGVmaW5lIEFTU0VSVF9XSVRIX01FU1NBR0UoYXNzZXJ0aW9uKSAoKHZvaWQpMCkKKyNlbGlmIENP TVBJTEVSKFdJTlNDVykKKyNkZWZpbmUgQVNTRVJUX1dJVEhfTUVTU0FHRShhc3NlcnRpb24sIGFy Zy4uLikgKCh2b2lkKTApCiAjZWxzZQogI2RlZmluZSBBU1NFUlRfV0lUSF9NRVNTQUdFKGFzc2Vy dGlvbiwgLi4uKSBkbyBcCiAgICAgaWYgKCEoYXNzZXJ0aW9uKSkgeyBcCkBAIC0yMzAsOCArMjM0 LDEwIEBAIHdoaWxlICgwKQogCiAjaWYgRVJST1JfRElTQUJMRUQgJiYgIUNPTVBJTEVSKE1TVkM3 KSAmJiAhQ09NUElMRVIoV0lOU0NXKQogI2RlZmluZSBMT0dfRVJST1IoLi4uKSAoKHZvaWQpMCkK LSNlbGlmIENPTVBJTEVSKE1TVkM3KSB8fCBDT01QSUxFUihXSU5TQ1cpCisjZWxpZiBDT01QSUxF UihNU1ZDNykKICNkZWZpbmUgTE9HX0VSUk9SKCkgKCh2b2lkKTApCisjZWxpZiBDT01QSUxFUihX SU5TQ1cpCisjZGVmaW5lIExPR19FUlJPUihhcmcuLi4pICAoKHZvaWQpMCkKICNlbHNlCiAjZGVm aW5lIExPR19FUlJPUiguLi4pIFdURlJlcG9ydEVycm9yKF9fRklMRV9fLCBfX0xJTkVfXywgV1RG X1BSRVRUWV9GVU5DVElPTiwgX19WQV9BUkdTX18pCiAjZW5kaWYKQEAgLTI0MCw4ICsyNDYsMTAg QEAgd2hpbGUgKDApCiAKICNpZiBMT0dfRElTQUJMRUQgJiYgIUNPTVBJTEVSKE1TVkM3KSAmJiAh Q09NUElMRVIoV0lOU0NXKQogI2RlZmluZSBMT0coY2hhbm5lbCwgLi4uKSAoKHZvaWQpMCkKLSNl bGlmIENPTVBJTEVSKE1TVkM3KSB8fCBDT01QSUxFUihXSU5TQ1cpCisjZWxpZiBDT01QSUxFUihN U1ZDNykKICNkZWZpbmUgTE9HKCkgKCh2b2lkKTApCisjZWxpZiBDT01QSUxFUihXSU5TQ1cpCisj ZGVmaW5lIExPRyhhcmcuLi4pICgodm9pZCkwKQogI2Vsc2UKICNkZWZpbmUgTE9HKGNoYW5uZWws IC4uLikgV1RGTG9nKCZKT0lOX0xPR19DSEFOTkVMX1dJVEhfUFJFRklYKExPR19DSEFOTkVMX1BS RUZJWCwgY2hhbm5lbCksIF9fVkFfQVJHU19fKQogI2RlZmluZSBKT0lOX0xPR19DSEFOTkVMX1dJ VEhfUFJFRklYKHByZWZpeCwgY2hhbm5lbCkgSk9JTl9MT0dfQ0hBTk5FTF9XSVRIX1BSRUZJWF9M RVZFTF8yKHByZWZpeCwgY2hhbm5lbCkKQEAgLTI1Miw4ICsyNjAsMTAgQEAgd2hpbGUgKDApCiAK ICNpZiBMT0dfRElTQUJMRUQgJiYgIUNPTVBJTEVSKE1TVkM3KSAmJiAhQ09NUElMRVIoV0lOU0NX KQogI2RlZmluZSBMT0dfVkVSQk9TRShjaGFubmVsLCAuLi4pICgodm9pZCkwKQotI2VsaWYgQ09N UElMRVIoTVNWQzcpIHx8IENPTVBJTEVSKFdJTlNDVykKKyNlbGlmIENPTVBJTEVSKE1TVkM3KQog I2RlZmluZSBMT0dfVkVSQk9TRShjaGFubmVsKSAoKHZvaWQpMCkKKyNlbGlmIENPTVBJTEVSKFdJ TlNDVykKKyNkZWZpbmUgTE9HX1ZFUkJPU0UoY2hhbm5lbCwgYXJnLi4uKSAoKHZvaWQpMCkKICNl bHNlCiAjZGVmaW5lIExPR19WRVJCT1NFKGNoYW5uZWwsIC4uLikgV1RGTG9nVmVyYm9zZShfX0ZJ TEVfXywgX19MSU5FX18sIFdURl9QUkVUVFlfRlVOQ1RJT04sICZKT0lOX0xPR19DSEFOTkVMX1dJ VEhfUFJFRklYKExPR19DSEFOTkVMX1BSRUZJWCwgY2hhbm5lbCksIF9fVkFfQVJHU19fKQogI2Vu ZGlmCg==