<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>32699</bug_id>
          
          <creation_ts>2009-12-17 22:18:00 -0800</creation_ts>
          <short_desc>[V8] Date binding support</short_desc>
          <delta_ts>2009-12-21 13:27:29 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore JavaScript</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>32698</dependson>
          <blocked>32697</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Kent Tamura">tkent</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>dglazkov</cc>
    
    <cc>eric</cc>
    
    <cc>pkasting</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>173044</commentid>
    <comment_count>0</comment_count>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2009-12-17 22:18:00 -0800</bug_when>
    <thetext>HTML5&apos;s HTMLInputElement IDL has
&gt;          attribute Date valueAsDate;

We need to support binding for Date.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>173073</commentid>
    <comment_count>1</comment_count>
      <attachid>45131</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2009-12-18 01:38:28 -0800</bug_when>
    <thetext>Created attachment 45131
Proposed patch

Generated code for &quot;Date valueAsDate setter raises(DOMException)&quot; will be like:

  static v8::Handle&lt;v8::Value&gt; valueAsDateAttrGetter(v8::Local&lt;v8::String&gt; name, const v8::AccessorInfo&amp; info) {
    INC_STATS(&quot;DOM.HTMLInputElement.valueAsDate._get&quot;);
    v8::Handle&lt;v8::Object&gt; holder = info.Holder();
    HTMLInputElement* imp = v8DOMWrapperToNode&lt;HTMLInputElement&gt;(info);
    double v = imp-&gt;valueAsDate();
    if (isnan(v) || isinf(v))
        return v8::Null();
    else
        return v8::Date::New(v);
  }

  static void valueAsDateAttrSetter(v8::Local&lt;v8::String&gt; name, v8::Local&lt;v8::Value&gt; value, const v8::AccessorInfo&amp; info) {
    INC_STATS(&quot;DOM.HTMLInputElement.valueAsDate._set&quot;);
    v8::Handle&lt;v8::Object&gt; holder = info.Holder();
    HTMLInputElement* imp = v8DOMWrapperToNode&lt;HTMLInputElement&gt;(info);
    double v = value-&gt;IsDate() ? value-&gt;NumberValue() : std::numeric_limits&lt;double&gt;::quiet_NaN();
    ExceptionCode ec = 0;
    imp-&gt;setValueAsDate(v, ec);
    if (UNLIKELY(ec))
        V8Proxy::setDOMException(ec);
    return;
  }</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>173633</commentid>
    <comment_count>2</comment_count>
      <attachid>45256</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2009-12-19 21:17:57 -0800</bug_when>
    <thetext>Created attachment 45256
Proposed patch

Note: This depends on a patch in Bug#32698, and EWS will report a failure.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>173634</commentid>
    <comment_count>3</comment_count>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2009-12-19 21:19:29 -0800</bug_when>
    <thetext>(In reply to comment #2)

Generated code for &quot;Date valueAsDate setter raises(DOMException)&quot; will be like:

  static v8::Handle&lt;v8::Value&gt; valueAsDateAttrGetter(v8::Local&lt;v8::String&gt; name, const v8::AccessorInfo&amp; info) {
    INC_STATS(&quot;DOM.HTMLInputElement.valueAsDate._get&quot;);
    v8::Handle&lt;v8::Object&gt; holder = info.Holder();
    HTMLInputElement* imp = v8DOMWrapperToNode&lt;HTMLInputElement&gt;(info);
    return v8DateOrNull(imp-&gt;valueAsDate());;
  }

  static void valueAsDateAttrSetter(v8::Local&lt;v8::String&gt; name, v8::Local&lt;v8::Value&gt; value, const v8::AccessorInfo&amp; info) {
    INC_STATS(&quot;DOM.HTMLInputElement.valueAsDate._set&quot;);
    v8::Handle&lt;v8::Object&gt; holder = info.Holder();
    HTMLInputElement* imp = v8DOMWrapperToNode&lt;HTMLInputElement&gt;(info);
    double v = toWebCoreDate(value);
    ExceptionCode ec = 0;
    imp-&gt;setValueAsDate(v, ec);
    if (UNLIKELY(ec))
        V8Proxy::setDOMException(ec);
    return;
  }</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>174048</commentid>
    <comment_count>4</comment_count>
      <attachid>45256</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-12-21 12:56:36 -0800</bug_when>
    <thetext>Comment on attachment 45256
Proposed patch

This looks fine.  Please update the FIXME to match the patch:

&quot;FIXME: Add Date support for V8, Objective-C, and COM.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>174065</commentid>
    <comment_count>5</comment_count>
    <who name="Peter Kasting">pkasting</who>
    <bug_when>2009-12-21 13:27:29 -0800</bug_when>
    <thetext>Landed in r52454.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>45131</attachid>
            <date>2009-12-18 01:38:28 -0800</date>
            <delta_ts>2009-12-19 21:17:57 -0800</delta_ts>
            <desc>Proposed patch</desc>
            <filename>0001-v8-date-1.patch</filename>
            <type>text/plain</type>
            <size>3866</size>
            <attacher name="Kent Tamura">tkent</attacher>
            
              <data encoding="base64">RnJvbSA3NmUyOWUyZDY5NjYzNzViYWVlNWVjMTU1NzkxNTQ1ZWVhYTVlOTkxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW50IFRhbXVyYSA8dGtlbnRAY2hyb21pdW0ub3JnPgpEYXRl
OiBGcmksIDE4IERlYyAyMDA5IDE4OjMzOjQwICswOTAwClN1YmplY3Q6IFtQQVRDSF0gdjgtZGF0
ZS0xCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAg
IDIwICsrKysrKysrKysrKysrKysrKysrCiBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdl
bmVyYXRvclY4LnBtIHwgICAxNCArKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAzNCBp
bnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdl
TG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjdmM2M5Zi4uMmJhNzdhZiAxMDA2NDQKLS0t
IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy
MyBAQAorMjAwOS0xMi0xOCAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQg
Zm9yIFY4IERhdGUgYmluZGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTMyNjk5CisKKyAgICAgICAgVGhpcyBpcyBuZWVkZWQgZm9yIEhUTUxJbnB1
dEVsZW1lbnQ6OnZhbHVlQXNEYXRlIGFuZAorICAgICAgICBIVE1MVGltZUVsZW1lbnQ6OnZhbHVl
QXNEYXRlLgorCisgICAgICAgIEEgRGF0ZSBpbnN0YW5jZSBpcyBtYXBwZWQgdG8gYSBkb3VibGUg
dmFsdWUgaW4gQysrLgorICAgICAgICAgLSBJZiBhIG51bGwgb3IgdW5kZWZpbmVkIGlzIHBhc3Nl
ZCB0byBhIHNldHRlciBDKysgZnVuY3Rpb24sIGEgZG91YmxlCisgICAgICAgICAgIE5hTiB2YWx1
ZSBpcyBwYXNzZWQKKyAgICAgICAgIC0gSWYgYSBnZXR0ZXIgQysrIGZ1bmN0aW9uIHJldHVybnMg
TmFOIG9yIEluZmluaXR5LCBKYXZhU2NyaXB0CisgICAgICAgICAgIHJlY2VpdmVzIG51bGwuCisK
KyAgICAgICAgTm8gdGVzdHMgYmVjYXVzZSB0aGlzIGJpbmRpbmcgaXMgbm90IHVzZWQgeWV0Lgor
CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisKIDIwMDkt
MTItMTcgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2
aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw
dHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l
cmF0b3JWOC5wbQppbmRleCA3NTA3ZmNiLi43YzcwMjRkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Jp
bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1dlYkNvcmUvYmluZGluZ3Mv
c2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTE1Nyw2ICsxNTcsOCBAQCBzdWIgQWRkSW5j
bHVkZXNGb3JUeXBlCiAgICAgIyBXaGVuIHdlJ3JlIGZpbmlzaGVkIHdpdGggdGhlIG9uZS1maWxl
LXBlci1jbGFzcwogICAgICMgcmVvcmdhbml6YXRpb24sIHdlIHdvbid0IG5lZWQgdGhlc2Ugc3Bl
Y2lhbCBjYXNlcy4KICAgICBpZiAoJGNvZGVHZW5lcmF0b3ItPklzUHJpbWl0aXZlVHlwZSgkdHlw
ZSkgb3IgQXZvaWRJbmNsdXNpb25PZlR5cGUoJHR5cGUpKSB7CisgICAgfSBlbHNpZiAoJHR5cGUg
ZXEgIkRhdGUiKSB7CisgICAgICAgICRpbXBsSW5jbHVkZXN7Ind0Zi9NYXRoRXh0cmFzLmgifSA9
IDE7CiAgICAgfSBlbHNpZiAoJHR5cGUgPX4gL1NWR1BhdGhTZWcvKSB7CiAgICAgICAgICRqb2lu
ZWROYW1lID0gJHR5cGU7CiAgICAgICAgICRqb2luZWROYW1lID1+IHMvQWJzfFJlbC8vOwpAQCAt
NjQwLDYgKzY0Miw5IEBAIEVORAogICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywg
R2VuZXJhdGVTZXRET01FeGNlcHRpb24oIiAgICAiKSk7CiAgICAgICAgICAgICAkcmVzdWx0ID0g
InYiOwogICAgICAgICAgICAgJHJlc3VsdCAuPSAiLnJlbGVhc2UoKSIgaWYgKElzUmVmUHRyVHlw
ZSgkcmV0dXJuVHlwZSkpOworICAgICAgICB9IGVsc2lmICgkYXR0clR5cGUgZXEgIkRhdGUiKSB7
CisgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCAiICAgICRuYXRpdmVUeXBlIHYg
PSAkZ2V0dGVyU3RyaW5nO1xuIik7CisgICAgICAgICAgICAkcmVzdWx0ID0gInYiOwogICAgICAg
ICB9IGVsc2UgewogICAgICAgICAgICAgIyBDYW4gaW5saW5lIHRoZSBmdW5jdGlvbiBjYWxsIGlu
dG8gdGhlIHJldHVybiBzdGF0ZW1lbnQgdG8gYXZvaWQgb3ZlcmhlYWQgb2YgdXNpbmcgYSBSZWY8
PiB0ZW1wb3JhcnkKICAgICAgICAgICAgICRyZXN1bHQgPSAkZ2V0dGVyU3RyaW5nOwpAQCAtMTk3
MSw2ICsxOTc2LDcgQEAgc3ViIEdldE5hdGl2ZVR5cGUKICAgICByZXR1cm4gIkRPTVRpbWVTdGFt
cCIgaWYgJHR5cGUgZXEgIkRPTVRpbWVTdGFtcCI7CiAgICAgcmV0dXJuICJ1bnNpZ25lZCIgaWYg
JHR5cGUgZXEgInVuc2lnbmVkIGludCI7CiAgICAgcmV0dXJuICJOb2RlKiIgaWYgJHR5cGUgZXEg
IkV2ZW50VGFyZ2V0IiBhbmQgJGlzUGFyYW1ldGVyOworICAgIHJldHVybiAiZG91YmxlIiBpZiAk
dHlwZSBlcSAiRGF0ZSI7CiAKICAgICByZXR1cm4gIlN0cmluZyIgaWYgJHR5cGUgZXEgIkRPTVVz
ZXJEYXRhIjsgICMgRklYTUU6IFRlbXBvcmFyeSBoYWNrPwogCkBAIC0yMTAyLDYgKzIxMDgsNyBA
QCBzdWIgSlNWYWx1ZVRvTmF0aXZlCiAgICAgcmV0dXJuICJ0b0ludDMyKCR2YWx1ZSR7bWF5YmVP
a1BhcmFtfSkiIGlmICR0eXBlIGVxICJ1bnNpZ25lZCBsb25nIiBvciAkdHlwZSBlcSAidW5zaWdu
ZWQgc2hvcnQiIG9yICR0eXBlIGVxICJsb25nIjsKICAgICByZXR1cm4gInN0YXRpY19jYXN0PFJh
bmdlOjpDb21wYXJlSG93PigkdmFsdWUtPkludDMyVmFsdWUoKSkiIGlmICR0eXBlIGVxICJDb21w
YXJlSG93IjsKICAgICByZXR1cm4gInN0YXRpY19jYXN0PFNWR1BhaW50OjpTVkdQYWludFR5cGU+
KCR2YWx1ZS0+VG9JbnQzMigpLT5JbnQzMlZhbHVlKCkpIiBpZiAkdHlwZSBlcSAiU1ZHUGFpbnRU
eXBlIjsKKyAgICByZXR1cm4gIiR2YWx1ZS0+SXNEYXRlKCkgPyB2YWx1ZS0+TnVtYmVyVmFsdWUo
KSA6IHN0ZDo6bnVtZXJpY19saW1pdHM8ZG91YmxlPjo6cXVpZXRfTmFOKCkiIGlmICR0eXBlIGVx
ICJEYXRlIjsKIAogICAgIGlmICgkdHlwZSBlcSAiRE9NU3RyaW5nIiBvciAkdHlwZSBlcSAiRE9N
VXNlckRhdGEiKSB7CiAgICAgICAgIHJldHVybiAkdmFsdWU7CkBAIC0yMzYyLDYgKzIzNjksMTMg
QEAgc3ViIFJldHVybk5hdGl2ZVRvSlNWYWx1ZQogICAgICAgICByZXR1cm4gInJldHVybiBXb3Jr
ZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6OmNvbnZlcnRUb1Y4T2JqZWN0KFY4Q2xhc3NJbmRleDo6
JGNsYXNzSW5kZXgsICR2YWx1ZSkiOwogICAgIH0KIAorICAgIGlmICgkdHlwZSBlcSAiRGF0ZSIp
IHsKKyAgICAgICAgcmV0dXJuICJpZiAoaXNuYW4oJHZhbHVlKSB8fCBpc2luZigkdmFsdWUpKVxu
IiAuCisgICAgICAgICAgICAkaW5kZW50IC4gIiAgICByZXR1cm4gdjg6Ok51bGwoKTtcbiIgLgor
ICAgICAgICAgICAgJGluZGVudCAuICJlbHNlXG4iIC4KKyAgICAgICAgICAgICRpbmRlbnQgLiAi
ICAgIHJldHVybiB2ODo6RGF0ZTo6TmV3KCR2YWx1ZSkiOworICAgIH0KKwogICAgIGVsc2Ugewog
ICAgICAgICAkaW1wbEluY2x1ZGVzeyJ3dGYvUmVmQ291bnRlZC5oIn0gPSAxOwogICAgICAgICAk
aW1wbEluY2x1ZGVzeyJ3dGYvUmVmUHRyLmgifSA9IDE7Ci0tIAoxLjYuMy4zCgo=
</data>
<flag name="review"
          id="27110"
          type_id="1"
          status="-"
          setter="tkent"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>45256</attachid>
            <date>2009-12-19 21:17:57 -0800</date>
            <delta_ts>2009-12-21 12:56:35 -0800</delta_ts>
            <desc>Proposed patch</desc>
            <filename>0001-v8-date-2.patch</filename>
            <type>text/plain</type>
            <size>5621</size>
            <attacher name="Kent Tamura">tkent</attacher>
            
              <data encoding="base64">RnJvbSA4NTZkODEyMzU5OTlkNTNkZjZlZDY3YTIxODU5YTMyZWI5NWZkNTVkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW50IFRhbXVyYSA8dGtlbnRAY2hyb21pdW0ub3JnPgpEYXRl
OiBTdW4sIDIwIERlYyAyMDA5IDAzOjEyOjExICswOTAwClN1YmplY3Q6IFtQQVRDSF0gdjgtZGF0
ZS0yCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAg
IDIwICsrKysrKysrKysrKysrKysrKysrCiBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdl
bmVyYXRvclY4LnBtIHwgICAgOCArKysrKysrLQogV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRp
bmcuY3BwICAgICAgICAgICB8ICAgMTEgKysrKysrKysrKysKIFdlYkNvcmUvYmluZGluZ3Mvdjgv
VjhCaW5kaW5nLmggICAgICAgICAgICAgfCAgICA0ICsrKysKIFdlYkNvcmUvaHRtbC9IVE1MSW5w
dXRFbGVtZW50LmlkbCAgICAgICAgICAgfCAgICAyICstCiA1IGZpbGVzIGNoYW5nZWQsIDQzIGlu
c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM
b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4NGM1ZjQ5Li4xNmNjNjNkIDEwMDY0NAotLS0g
YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz
IEBACisyMDA5LTEyLTE5ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc3VwcG9ydCBm
b3IgVjggRGF0ZSBiaW5kaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MzI2OTkKKworICAgICAgICBUaGlzIGltcGxlbWVudHMgdGhlIHNhbWUgYmVo
YXZpb3IgYXMgdGhlIHJlY2VudCBjaGFuZ2Ugb2YKKyAgICAgICAgQ29kZUdlbmVyYXRvckpTLnBt
IGFuZCBKU0RPTUJpbmRpbmcuY3BwLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2Rl
R2VuZXJhdG9yVjgucG06CisgICAgICAgICAgUHJvZHVjZSB0b1dlYkNvcmVEYXRlKCkgb3IgdjhE
YXRlT3JOdWxsKCkgZm9yIERhdGUgdHlwZS4KKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEJpbmRp
bmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dG9XZWJDb3JlRGF0ZSk6CisgICAgICAgICAgQ29u
dmVydHMgYSBKYXZhU2NyaXB0IG9iamVjdCB0byBhIGRvdWJsZSByZXByZXNlbnRpbmcgRGF0ZS4K
KyAgICAgICAgKFdlYkNvcmU6OnY4RGF0ZU9yTnVsbCk6CisgICAgICAgICAgQ29udmVydHMgYSBk
b3VibGUgcmVwcmVzZW50aW5nIERhdGUgdG8gYSBKYXZhU2NyaXB0IERhdGUgb2JqZWN0IG9yIG51
bGwuCisgICAgICAgICogYmluZGluZ3MvdjgvVjhCaW5kaW5nLmg6IERlY2xhcmUgdG9XZWJDb3Jl
RGF0ZSgpIGFuZCB2OERhdGVPck51bGwoKS4KKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1l
bnQuaWRsOiBEZWxldGUgVjhfQklOR0lOIGV4Y2x1c2lvbiBmb3IgdmFsdWVBc0RhdGUuCisKIDIw
MDktMTItMTggIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9z
Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl
R2VuZXJhdG9yVjgucG0KaW5kZXggNzUwN2ZjYi4uZmU5ZTI2ZCAxMDA2NDQKLS0tIGEvV2ViQ29y
ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9XZWJDb3JlL2JpbmRp
bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0xNTYsNyArMTU2LDcgQEAgc3ViIEFk
ZEluY2x1ZGVzRm9yVHlwZQogCiAgICAgIyBXaGVuIHdlJ3JlIGZpbmlzaGVkIHdpdGggdGhlIG9u
ZS1maWxlLXBlci1jbGFzcwogICAgICMgcmVvcmdhbml6YXRpb24sIHdlIHdvbid0IG5lZWQgdGhl
c2Ugc3BlY2lhbCBjYXNlcy4KLSAgICBpZiAoJGNvZGVHZW5lcmF0b3ItPklzUHJpbWl0aXZlVHlw
ZSgkdHlwZSkgb3IgQXZvaWRJbmNsdXNpb25PZlR5cGUoJHR5cGUpKSB7CisgICAgaWYgKCRjb2Rl
R2VuZXJhdG9yLT5Jc1ByaW1pdGl2ZVR5cGUoJHR5cGUpIG9yIEF2b2lkSW5jbHVzaW9uT2ZUeXBl
KCR0eXBlKSBvciAkdHlwZSBlcSAiRGF0ZSIpIHsKICAgICB9IGVsc2lmICgkdHlwZSA9fiAvU1ZH
UGF0aFNlZy8pIHsKICAgICAgICAgJGpvaW5lZE5hbWUgPSAkdHlwZTsKICAgICAgICAgJGpvaW5l
ZE5hbWUgPX4gcy9BYnN8UmVsLy87CkBAIC0xOTcxLDYgKzE5NzEsNyBAQCBzdWIgR2V0TmF0aXZl
VHlwZQogICAgIHJldHVybiAiRE9NVGltZVN0YW1wIiBpZiAkdHlwZSBlcSAiRE9NVGltZVN0YW1w
IjsKICAgICByZXR1cm4gInVuc2lnbmVkIiBpZiAkdHlwZSBlcSAidW5zaWduZWQgaW50IjsKICAg
ICByZXR1cm4gIk5vZGUqIiBpZiAkdHlwZSBlcSAiRXZlbnRUYXJnZXQiIGFuZCAkaXNQYXJhbWV0
ZXI7CisgICAgcmV0dXJuICJkb3VibGUiIGlmICR0eXBlIGVxICJEYXRlIjsKIAogICAgIHJldHVy
biAiU3RyaW5nIiBpZiAkdHlwZSBlcSAiRE9NVXNlckRhdGEiOyAgIyBGSVhNRTogVGVtcG9yYXJ5
IGhhY2s/CiAKQEAgLTIxMDIsNiArMjEwMyw3IEBAIHN1YiBKU1ZhbHVlVG9OYXRpdmUKICAgICBy
ZXR1cm4gInRvSW50MzIoJHZhbHVlJHttYXliZU9rUGFyYW19KSIgaWYgJHR5cGUgZXEgInVuc2ln
bmVkIGxvbmciIG9yICR0eXBlIGVxICJ1bnNpZ25lZCBzaG9ydCIgb3IgJHR5cGUgZXEgImxvbmci
OwogICAgIHJldHVybiAic3RhdGljX2Nhc3Q8UmFuZ2U6OkNvbXBhcmVIb3c+KCR2YWx1ZS0+SW50
MzJWYWx1ZSgpKSIgaWYgJHR5cGUgZXEgIkNvbXBhcmVIb3ciOwogICAgIHJldHVybiAic3RhdGlj
X2Nhc3Q8U1ZHUGFpbnQ6OlNWR1BhaW50VHlwZT4oJHZhbHVlLT5Ub0ludDMyKCktPkludDMyVmFs
dWUoKSkiIGlmICR0eXBlIGVxICJTVkdQYWludFR5cGUiOworICAgIHJldHVybiAidG9XZWJDb3Jl
RGF0ZSgkdmFsdWUpIiBpZiAkdHlwZSBlcSAiRGF0ZSI7CiAKICAgICBpZiAoJHR5cGUgZXEgIkRP
TVN0cmluZyIgb3IgJHR5cGUgZXEgIkRPTVVzZXJEYXRhIikgewogICAgICAgICByZXR1cm4gJHZh
bHVlOwpAQCAtMjM2Miw2ICsyMzY0LDEwIEBAIHN1YiBSZXR1cm5OYXRpdmVUb0pTVmFsdWUKICAg
ICAgICAgcmV0dXJuICJyZXR1cm4gV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5Ojpjb252ZXJ0
VG9WOE9iamVjdChWOENsYXNzSW5kZXg6OiRjbGFzc0luZGV4LCAkdmFsdWUpIjsKICAgICB9CiAK
KyAgICBpZiAoJHR5cGUgZXEgIkRhdGUiKSB7CisgICAgICAgIHJldHVybiAicmV0dXJuIHY4RGF0
ZU9yTnVsbCgkdmFsdWUpOyI7CisgICAgfQorCiAgICAgZWxzZSB7CiAgICAgICAgICRpbXBsSW5j
bHVkZXN7Ind0Zi9SZWZDb3VudGVkLmgifSA9IDE7CiAgICAgICAgICRpbXBsSW5jbHVkZXN7Ind0
Zi9SZWZQdHIuaCJ9ID0gMTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5k
aW5nLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcAppbmRleCAwMDI4NmU1
Li5kMjFlMWY4IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAK
KysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCkBAIC0yMzksNiArMjM5LDE3
IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2OFN0cmluZ09yRmFsc2UoY29uc3QgU3RyaW5nJiBz
dHIpCiAgICAgcmV0dXJuIHN0ci5pc051bGwoKSA/IHY4OjpIYW5kbGU8djg6OlZhbHVlPih2ODo6
RmFsc2UoKSkgOiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4odjhTdHJpbmcoc3RyKSk7CiB9CiAKK2Rv
dWJsZSB0b1dlYkNvcmVEYXRlKHY4OjpIYW5kbGU8djg6OlZhbHVlPiBvYmplY3QpCit7CisgICAg
cmV0dXJuIChvYmplY3QtPklzRGF0ZSgpIHx8IG9iamVjdC0+SXNOdW1iZXIoKSkgPyBvYmplY3Qt
Pk51bWJlclZhbHVlKCkgOiBzdGQ6Om51bWVyaWNfbGltaXRzPGRvdWJsZT46OnF1aWV0X05hTigp
OworfQorCit2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdjhEYXRlT3JOdWxsKGRvdWJsZSB2YWx1ZSkK
K3sKKyAgICBpZiAoaXNmaW5pdGUodmFsdWUpKQorICAgICAgICByZXR1cm4gdjg6OkRhdGU6Ok5l
dyh2YWx1ZSk7CisgICAgcmV0dXJuIHY4OjpOdWxsKCk7Cit9CiAKIHRlbXBsYXRlIDxjbGFzcyBT
PiBzdHJ1Y3QgU3RyaW5nVHJhaXRzCiB7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4
L1Y4QmluZGluZy5oIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaAppbmRleCBmOWY5
NGQ3Li5hYTRhMzI2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5o
CisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKQEAgLTIwNSw2ICsyMDUsMTAg
QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2OFN0cmlu
Z09yVW5kZWZpbmVkKGNvbnN0IFN0cmluZyYgc3RyKTsKIAogICAgIHY4OjpIYW5kbGU8djg6OlZh
bHVlPiB2OFN0cmluZ09yRmFsc2UoY29uc3QgU3RyaW5nJiBzdHIpOworCisgICAgZG91YmxlIHRv
V2ViQ29yZURhdGUodjg6OkhhbmRsZTx2ODo6VmFsdWU+IG9iamVjdCk7CisKKyAgICB2ODo6SGFu
ZGxlPHY4OjpWYWx1ZT4gdjhEYXRlT3JOdWxsKGRvdWJsZSB2YWx1ZSk7CiAgICAgCiAgICAgdjg6
OlBlcnNpc3RlbnQ8djg6OkZ1bmN0aW9uVGVtcGxhdGU+IGNyZWF0ZVJhd1RlbXBsYXRlKCk7CiAK
ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmlkbCBiL1dlYkNvcmUv
aHRtbC9IVE1MSW5wdXRFbGVtZW50LmlkbAppbmRleCA3OGE0MDNhLi41ZjEwYzBmIDEwMDY0NAot
LS0gYS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5pZGwKKysrIGIvV2ViQ29yZS9odG1s
L0hUTUxJbnB1dEVsZW1lbnQuaWRsCkBAIC02Nyw3ICs2Nyw3IEBAIG1vZHVsZSBodG1sIHsKICAg
ICAgICAgICAgICAgICAgYXR0cmlidXRlIFtDb252ZXJ0TnVsbFRvTnVsbFN0cmluZywgSlNDQ3Vz
dG9tR2V0dGVyXSBET01TdHJpbmcgdHlwZTsgLy8gcmVhZG9ubHkgZHJvcHBlZCBhcyBwYXJ0IG9m
IERPTSBsZXZlbCAyCiAgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSBbQ29udmVydE51bGxUb051
bGxTdHJpbmddIERPTVN0cmluZyB1c2VNYXA7CiAgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSBb
Q29udmVydE51bGxUb051bGxTdHJpbmddIERPTVN0cmluZyB2YWx1ZTsKLSNpZiBkZWZpbmVkKExB
TkdVQUdFX0pBVkFTQ1JJUFQpICYmIExBTkdVQUdFX0pBVkFTQ1JJUFQgJiYgIShkZWZpbmVkKFY4
X0JJTkRJTkcpICYmIFY4X0JJTkRJTkcpCisjaWYgZGVmaW5lZChMQU5HVUFHRV9KQVZBU0NSSVBU
KSAmJiBMQU5HVUFHRV9KQVZBU0NSSVBUCiAgICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBBZGQg
RGF0ZSBzdXBwb3J0IGZvciBWOCwgT2JqZWN0aXZlLUMsIGFuZCBDT00uCiAgICAgICAgICAgICAg
ICAgIGF0dHJpYnV0ZSBEYXRlICAgICAgICAgICAgdmFsdWVBc0RhdGUgc2V0dGVyIHJhaXNlcyhE
T01FeGNlcHRpb24pOwogI2VuZGlmCi0tIAoxLjYuMy4zCgo=
</data>
<flag name="review"
          id="27255"
          type_id="1"
          status="+"
          setter="abarth"
    />
    <flag name="commit-queue"
          id="27256"
          type_id="3"
          status="-"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>