32652 2009-12-17 02:55:39 -0800 forward-declare libsoup types 2014-03-25 15:22:49 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Other OS X 10.5 RESOLVED INVALID P2 Normal --- 52451 1 evan webkit-unassigned danw gustavo levin mrobinson tonyg webkit.review.bot xan.lopez oldest_to_newest 172697 0 45049 evan 2009-12-17 02:55:39 -0800 Created attachment 45049 Patch Reduce header interdependencies by forward-declaring types in headers. 172698 1 45049 evan 2009-12-17 02:56:48 -0800 Comment on attachment 45049 Patch Please don't cq+ this, it requires a change in libsoup. 172699 2 45050 evan 2009-12-17 02:58:34 -0800 Created attachment 45050 patch 172700 3 45050 evan 2009-12-17 02:59:31 -0800 Comment on attachment 45050 patch (Fixed ChangeLog) Please don't cq+ this, it requires a change in libsoup. 172701 4 webkit.review.bot 2009-12-17 03:00:51 -0800 style-queue ran check-webkit-style on attachment 45050 without any errors. 172703 5 danw 2009-12-17 03:04:00 -0800 the soup change is now there in git master 172781 6 evan 2009-12-17 08:08:17 -0800 I guess to finish this patch I should add a change to configure.ac to depend on whatever libsoup version ends up coming out. 175400 7 45050 eric 2009-12-28 22:23:10 -0800 Comment on attachment 45050 patch Do we have an expected timeline for when this should be landed? Or should we just remove the r+ until then? I'm not in any huge rush, but it's silly to have non-actionable patches in the pending-commit list. 175599 8 evan 2009-12-29 09:38:58 -0800 Can you leave a comment saying you officially R+ this so that a later reviewer can see that? Then it's fine with me to r- it until it's ready. 175633 9 45050 eric 2009-12-29 10:54:39 -0800 Comment on attachment 45050 patch Yes. You should feel free to land this once the soup change is in. You have both mine and Dave Levin's review for such. Clearing the r+ for now. Feel free to mark this r?/cq+ again if you'd prefer to have the commit-queue land this for you. If you email me, I'l be happy to do the official r+ing again at that time. Unfortunately we don't have an easy way to exclude non-actionable patches form the pending-commit list. Adam Barth suggested we create a "CommitBlocked" keyword, which is one option. I should probably bring it up on WebKit-dev. 211740 10 evan 2010-04-12 16:14:11 -0700 BTW, maybe Xan could r+/cq+ this if it looks good? 211746 11 53190 evan 2010-04-12 16:16:03 -0700 Created attachment 53190 reupload of patch to trigger bots Just want bots to test this again. 211747 12 webkit.review.bot 2010-04-12 16:19:37 -0700 Attachment 53190 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/network/soup/ResourceResponseSoup.cpp:30: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/network/soup/CookieJarSoup.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 211771 13 webkit.review.bot 2010-04-12 16:54:58 -0700 Attachment 53190 did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/1671278 212080 14 levin 2010-04-13 14:17:30 -0700 This appears to break gtk. Please consider uploading anew patch (and canceling this one). 212817 15 gustavo 2010-04-15 05:47:07 -0700 (In reply to comment #14) > This appears to break gtk. Please consider uploading anew patch (and canceling > this one). That's probably because the bots need a newer soup. What exactly is the change that is required, though? 212854 16 evan 2010-04-15 08:01:48 -0700 To avoid the soup headers, I was forward-declaring like this: +typedef struct _SoupMessage SoupMessage; At the December hackfest, I think danw modified libsoup to allow such a forward declaration. But maybe it hasn't been released yet... 212863 17 danw 2010-04-15 08:18:47 -0700 When we did the patches, webkit wasn't using SoupMessageFlags, but now it is, so removing the soup.h include breaks it. I don't know if it's allowed stylistically, but you could make m_soupFlags a uint in ResourceRequest.h and ResourceResponse.h, and only cast to/from SoupMessageFlags in ResourceResponseSoup.cpp. Otherwise you'd need to submit a patch to libsoup to make SoupMessageFlags also be "enum _SoupMessageFlags" (and probably fix everything else while you're there too, so this doesn't happen again in the future), and then update the patch here to use that. 212869 18 evan 2010-04-15 08:26:29 -0700 gcc doesn't allow forward-declaring enums. :~( (I believe it comes from the fact that in principle an enum with < 256 entries can be stored as a byte, while < 65536 a short, etc.) I wouldn't be opposed to using a uint for this, but this is also not code I frequently have to deal with. If you guys think using a uint and casting isn't nice, I'll just close this bug. 367203 19 tonyg 2011-03-14 14:04:26 -0700 Is this bug obsolete? 994379 20 mrobinson 2014-03-25 15:22:49 -0700 I think at this point we need to restart the process if we are interested. 45049 2009-12-17 02:55:39 -0800 2009-12-17 02:58:10 -0800 Patch 20091217025530.patch text/plain 2821 evan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDc4OGNjNi4uMTEyYzZlYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMi0xNyAgRXZhbiBNYXJ0aW4g IDxtYXJ0aW5lQGRhbmdhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBndGs6IGZvcndhcmQtZGVjbGFyZSBsaWJzb3VwIHR5cGVzIHNvIHdlIGRv bid0IGluY2x1ZGUgaXQgZnJvbSBoZWFkZXJzLgorCisgICAgICAgIFB1bGxpbmcgaW4gbGlic291 cCBpbiBSZXNvdXJjZVJlcXVlc3QgcHVsbHMgaW4gZ2xpYiBmb3IgbW9zdCBvZiBXZWJDb3JlLgor CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL0Nvb2tpZUphclNvdXAuY3BwOgorICAg ICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmg6CisgICAgICAgICog cGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVxdWVzdC5oOgorICAgICAgICAqIHBsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlc3BvbnNlLmg6CisgICAgICAgICogcGxhdGZvcm0v bmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9uc2VTb3VwLmNwcDoKKwogMjAwOS0xMi0xNSAgTmF0 ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29v a2llSmFyU291cC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJT b3VwLmNwcAppbmRleCAzZWI1NzhhLi44MTVmNDkyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmNwcApAQCAtMjYsNiArMjYsOCBAQAogI2luY2x1 ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiS1VSTC5oIgogCisjaW5jbHVkZSA8bGlic291cC9z b3VwLmg+CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIGJvb2wgY29va2llc0luaXRp YWxpemVkOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2ll SmFyU291cC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291cC5o CmluZGV4IGFiMWY5NWMuLjQxOGYxMjkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9zb3VwL0Nvb2tpZUphclNvdXAuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv c291cC9Db29raWVKYXJTb3VwLmgKQEAgLTI4LDcgKzI4LDggQEAKICNkZWZpbmUgQ29va2llSmFy U291cF9oCiAKICNpbmNsdWRlICJDb29raWVKYXIuaCIKLSNpbmNsdWRlIDxsaWJzb3VwL3NvdXAu aD4KKwordHlwZWRlZiBzdHJ1Y3QgX1NvdXBDb29raWVKYXIgU291cENvb2tpZUphcjsKIAogbmFt ZXNwYWNlIFdlYkNvcmUgewogICAgIFNvdXBDb29raWVKYXIqIGRlZmF1bHRDb29raWVKYXIoKTsK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVxdWVz dC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXF1ZXN0LmgKaW5k ZXggODI3MDg2My4uNDRjOWNkNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3NvdXAvUmVzb3VyY2VSZXF1ZXN0LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvUmVzb3VyY2VSZXF1ZXN0LmgKQEAgLTI5LDcgKzI5LDcgQEAKIAogI2luY2x1ZGUgIlJlc291 cmNlUmVxdWVzdEJhc2UuaCIKIAotI2luY2x1ZGUgPGxpYnNvdXAvc291cC5oPgordHlwZWRlZiBz dHJ1Y3QgX1NvdXBNZXNzYWdlIFNvdXBNZXNzYWdlOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9u c2UuaCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9uc2UuaApp bmRleCBlY2Q5ZjIxLi5kZjEyZWU5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvc291cC9SZXNvdXJjZVJlc3BvbnNlLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3NvdXAvUmVzb3VyY2VSZXNwb25zZS5oCkBAIC0yOCw3ICsyOCw3IEBACiAKICNpbmNsdWRlICJS ZXNvdXJjZVJlc3BvbnNlQmFzZS5oIgogCi0jaW5jbHVkZSA8bGlic291cC9zb3VwLmg+Cit0eXBl ZGVmIHN0cnVjdCBfU291cE1lc3NhZ2UgU291cE1lc3NhZ2U7CiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VS ZXNwb25zZVNvdXAuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VS ZXNwb25zZVNvdXAuY3BwCmluZGV4IGNhZjBiMzEuLjUxZTA3Y2YgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9uc2VTb3VwLmNwcAorKysgYi9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlc3BvbnNlU291cC5jcHAKQEAg LTI1LDYgKzI1LDggQEAKICNpbmNsdWRlICJHT3duUHRyLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1T dHJpbmcuaCIKIAorI2luY2x1ZGUgPGxpYnNvdXAvc291cC5oPgorCiB1c2luZyBuYW1lc3BhY2Ug c3RkOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7Cg== 45050 2009-12-17 02:58:34 -0800 2010-04-12 16:16:03 -0700 patch bug-32652-20091217025831.patch text/plain 2821 evan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDc4OGNjNi4uMTNjYjZkNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMi0xNyAgRXZhbiBNYXJ0aW4g IDxldmFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBndGs6IGZvcndhcmQtZGVjbGFyZSBsaWJzb3VwIHR5cGVzIHNvIHdlIGRv bid0IGluY2x1ZGUgaXQgZnJvbSBoZWFkZXJzLgorCisgICAgICAgIFB1bGxpbmcgaW4gbGlic291 cCBpbiBSZXNvdXJjZVJlcXVlc3QgcHVsbHMgaW4gZ2xpYiBmb3IgbW9zdCBvZiBXZWJDb3JlLgor CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL0Nvb2tpZUphclNvdXAuY3BwOgorICAg ICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmg6CisgICAgICAgICog cGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVxdWVzdC5oOgorICAgICAgICAqIHBsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlc3BvbnNlLmg6CisgICAgICAgICogcGxhdGZvcm0v bmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9uc2VTb3VwLmNwcDoKKwogMjAwOS0xMi0xNSAgTmF0 ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29v a2llSmFyU291cC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJT b3VwLmNwcAppbmRleCAzZWI1NzhhLi44MTVmNDkyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmNwcApAQCAtMjYsNiArMjYsOCBAQAogI2luY2x1 ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiS1VSTC5oIgogCisjaW5jbHVkZSA8bGlic291cC9z b3VwLmg+CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIGJvb2wgY29va2llc0luaXRp YWxpemVkOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2ll SmFyU291cC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291cC5o CmluZGV4IGFiMWY5NWMuLjQxOGYxMjkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9zb3VwL0Nvb2tpZUphclNvdXAuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv c291cC9Db29raWVKYXJTb3VwLmgKQEAgLTI4LDcgKzI4LDggQEAKICNkZWZpbmUgQ29va2llSmFy U291cF9oCiAKICNpbmNsdWRlICJDb29raWVKYXIuaCIKLSNpbmNsdWRlIDxsaWJzb3VwL3NvdXAu aD4KKwordHlwZWRlZiBzdHJ1Y3QgX1NvdXBDb29raWVKYXIgU291cENvb2tpZUphcjsKIAogbmFt ZXNwYWNlIFdlYkNvcmUgewogICAgIFNvdXBDb29raWVKYXIqIGRlZmF1bHRDb29raWVKYXIoKTsK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVxdWVz dC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXF1ZXN0LmgKaW5k ZXggODI3MDg2My4uNDRjOWNkNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3NvdXAvUmVzb3VyY2VSZXF1ZXN0LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvUmVzb3VyY2VSZXF1ZXN0LmgKQEAgLTI5LDcgKzI5LDcgQEAKIAogI2luY2x1ZGUgIlJlc291 cmNlUmVxdWVzdEJhc2UuaCIKIAotI2luY2x1ZGUgPGxpYnNvdXAvc291cC5oPgordHlwZWRlZiBz dHJ1Y3QgX1NvdXBNZXNzYWdlIFNvdXBNZXNzYWdlOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9u c2UuaCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9uc2UuaApp bmRleCBlY2Q5ZjIxLi5kZjEyZWU5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvc291cC9SZXNvdXJjZVJlc3BvbnNlLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3NvdXAvUmVzb3VyY2VSZXNwb25zZS5oCkBAIC0yOCw3ICsyOCw3IEBACiAKICNpbmNsdWRlICJS ZXNvdXJjZVJlc3BvbnNlQmFzZS5oIgogCi0jaW5jbHVkZSA8bGlic291cC9zb3VwLmg+Cit0eXBl ZGVmIHN0cnVjdCBfU291cE1lc3NhZ2UgU291cE1lc3NhZ2U7CiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VS ZXNwb25zZVNvdXAuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VS ZXNwb25zZVNvdXAuY3BwCmluZGV4IGNhZjBiMzEuLjUxZTA3Y2YgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9uc2VTb3VwLmNwcAorKysgYi9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlc3BvbnNlU291cC5jcHAKQEAg LTI1LDYgKzI1LDggQEAKICNpbmNsdWRlICJHT3duUHRyLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1T dHJpbmcuaCIKIAorI2luY2x1ZGUgPGxpYnNvdXAvc291cC5oPgorCiB1c2luZyBuYW1lc3BhY2Ug c3RkOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7Cg== 53190 2010-04-12 16:16:03 -0700 2010-06-11 10:54:20 -0700 reupload of patch to trigger bots repatch.txt text/plain 2821 evan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDc4OGNjNi4uMTNjYjZkNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMi0xNyAgRXZhbiBNYXJ0aW4g IDxldmFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBndGs6IGZvcndhcmQtZGVjbGFyZSBsaWJzb3VwIHR5cGVzIHNvIHdlIGRv bid0IGluY2x1ZGUgaXQgZnJvbSBoZWFkZXJzLgorCisgICAgICAgIFB1bGxpbmcgaW4gbGlic291 cCBpbiBSZXNvdXJjZVJlcXVlc3QgcHVsbHMgaW4gZ2xpYiBmb3IgbW9zdCBvZiBXZWJDb3JlLgor CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL0Nvb2tpZUphclNvdXAuY3BwOgorICAg ICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmg6CisgICAgICAgICog cGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVxdWVzdC5oOgorICAgICAgICAqIHBsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlc3BvbnNlLmg6CisgICAgICAgICogcGxhdGZvcm0v bmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9uc2VTb3VwLmNwcDoKKwogMjAwOS0xMi0xNSAgTmF0 ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29v a2llSmFyU291cC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJT b3VwLmNwcAppbmRleCAzZWI1NzhhLi44MTVmNDkyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmNwcApAQCAtMjYsNiArMjYsOCBAQAogI2luY2x1 ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiS1VSTC5oIgogCisjaW5jbHVkZSA8bGlic291cC9z b3VwLmg+CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIGJvb2wgY29va2llc0luaXRp YWxpemVkOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2ll SmFyU291cC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291cC5o CmluZGV4IGFiMWY5NWMuLjQxOGYxMjkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9zb3VwL0Nvb2tpZUphclNvdXAuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv c291cC9Db29raWVKYXJTb3VwLmgKQEAgLTI4LDcgKzI4LDggQEAKICNkZWZpbmUgQ29va2llSmFy U291cF9oCiAKICNpbmNsdWRlICJDb29raWVKYXIuaCIKLSNpbmNsdWRlIDxsaWJzb3VwL3NvdXAu aD4KKwordHlwZWRlZiBzdHJ1Y3QgX1NvdXBDb29raWVKYXIgU291cENvb2tpZUphcjsKIAogbmFt ZXNwYWNlIFdlYkNvcmUgewogICAgIFNvdXBDb29raWVKYXIqIGRlZmF1bHRDb29raWVKYXIoKTsK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVxdWVz dC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXF1ZXN0LmgKaW5k ZXggODI3MDg2My4uNDRjOWNkNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3NvdXAvUmVzb3VyY2VSZXF1ZXN0LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvUmVzb3VyY2VSZXF1ZXN0LmgKQEAgLTI5LDcgKzI5LDcgQEAKIAogI2luY2x1ZGUgIlJlc291 cmNlUmVxdWVzdEJhc2UuaCIKIAotI2luY2x1ZGUgPGxpYnNvdXAvc291cC5oPgordHlwZWRlZiBz dHJ1Y3QgX1NvdXBNZXNzYWdlIFNvdXBNZXNzYWdlOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9u c2UuaCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9uc2UuaApp bmRleCBlY2Q5ZjIxLi5kZjEyZWU5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvc291cC9SZXNvdXJjZVJlc3BvbnNlLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3NvdXAvUmVzb3VyY2VSZXNwb25zZS5oCkBAIC0yOCw3ICsyOCw3IEBACiAKICNpbmNsdWRlICJS ZXNvdXJjZVJlc3BvbnNlQmFzZS5oIgogCi0jaW5jbHVkZSA8bGlic291cC9zb3VwLmg+Cit0eXBl ZGVmIHN0cnVjdCBfU291cE1lc3NhZ2UgU291cE1lc3NhZ2U7CiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VS ZXNwb25zZVNvdXAuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VS ZXNwb25zZVNvdXAuY3BwCmluZGV4IGNhZjBiMzEuLjUxZTA3Y2YgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9uc2VTb3VwLmNwcAorKysgYi9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlc3BvbnNlU291cC5jcHAKQEAg LTI1LDYgKzI1LDggQEAKICNpbmNsdWRlICJHT3duUHRyLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1T dHJpbmcuaCIKIAorI2luY2x1ZGUgPGxpYnNvdXAvc291cC5oPgorCiB1c2luZyBuYW1lc3BhY2Ug c3RkOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7Cg==