32617 2009-12-16 10:03:03 -0800 [dom] make dom/Node.cpp compile if DUMP_NODE_STATISTICS is on 2009-12-16 17:49:34 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 antonm webkit-unassigned commit-queue eric webkit.review.bot zoltan oldest_to_newest 172360 0 antonm 2009-12-16 10:03:03 -0800 Currently Node.cpp doesn't compile at least MSVC 8 as a part of Chromium project. Let's fix it. 172363 1 44988 antonm 2009-12-16 10:05:16 -0800 Created attachment 44988 First take 172365 2 webkit.review.bot 2009-12-16 10:07:55 -0800 style-queue ran check-webkit-style on attachment 44988 without any errors. 172371 3 44988 darin 2009-12-16 10:14:23 -0800 Comment on attachment 44988 First take Seems OK, r=me 172372 4 44988 antonm 2009-12-16 10:18:48 -0800 Comment on attachment 44988 First take Thanks a lot for review, Darin. 172385 5 44988 commit-queue 2009-12-16 10:35:38 -0800 Comment on attachment 44988 First take Rejecting patch 44988 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11779 test cases. fast/profiler/stop-profiling-after-setTimeout.html -> crashed Exiting early after 1 failures. 7790 tests run. 257.70s total testing time 7789 test cases (99%) succeeded 1 test case (<1%) crashed 3 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/127624 172387 6 antonm 2009-12-16 10:38:13 -0800 (In reply to comment #5) > (From update of attachment 44988 [details]) > Rejecting patch 44988 from commit-queue. > > Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', > '--exit-after-n-failures=1', '--quiet']" exit_code: 1 > Running build-dumprendertree > Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests > Testing 11779 test cases. > fast/profiler/stop-profiling-after-setTimeout.html -> crashed > > Exiting early after 1 failures. 7790 tests run. > 257.70s total testing time > > 7789 test cases (99%) succeeded > 1 test case (<1%) crashed > 3 test cases (<1%) had stderr output > > Full output: http://webkit-commit-queue.appspot.com/results/127624 Is there a way to see full output? I am somewhat sceptical that my change could have cause this as modulo another include altered code is most probably is not compiled at all. 172425 7 44988 zoltan 2009-12-16 11:16:29 -0800 Comment on attachment 44988 First take It's okay on my system. Let's try it again with the bot. 172430 8 antonm 2009-12-16 11:27:24 -0800 (In reply to comment #7) > (From update of attachment 44988 [details]) > It's okay on my system. Let's try it again with the bot. Thanks a lot, Zlotan. 172432 9 44988 commit-queue 2009-12-16 11:34:08 -0800 Comment on attachment 44988 First take Clearing flags on attachment: 44988 Committed r52212: <http://trac.webkit.org/changeset/52212> 172433 10 commit-queue 2009-12-16 11:34:17 -0800 All reviewed patches have been landed. Closing bug. 172438 11 zoltan 2009-12-16 11:36:29 -0800 Patch is committed :) In the future feel free to CCing me! 172603 12 eric 2009-12-16 17:49:34 -0800 Filed bug 32643 about the flakey test. 44988 2009-12-16 10:05:16 -0800 2009-12-16 11:34:08 -0800 First take WC.patch text/plain 1731 antonm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzcxODU0ZC4uYTlkNTljMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMi0xNiAgYW50b24gbXVoaW4g IDxhbnRvbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtkb21dIG1ha2UgZG9tL05vZGUuY3BwIGNvbXBpbGUgaWYgRFVNUF9O T0RFX1NUQVRJU1RJQ1MgaXMgb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMyNjE3CisKKyAgICAgICAgKiBkb20vTm9kZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpOb2RlOjpkdW1wU3RhdGlzdGljcyk6CisKIDIwMDktMTItMTYgIEVucmljYSBDYXN1 Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGVsZSBQZXRl cnNvbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL05vZGUuY3BwIGIvV2ViQ29yZS9kb20vTm9k ZS5jcHAKaW5kZXggMzQwNjkxNS4uNjg3ZDdkYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vTm9k ZS5jcHAKKysrIGIvV2ViQ29yZS9kb20vTm9kZS5jcHAKQEAgLTUzLDYgKzUzLDcgQEAKICNpbmNs dWRlICJJbnNwZWN0b3JUaW1lbGluZUFnZW50LmgiCiAjaW5jbHVkZSAiS2V5Ym9hcmRFdmVudC5o IgogI2luY2x1ZGUgIkxvZ2dpbmcuaCIKKyNpbmNsdWRlICJNYXBwZWRBdHRyaWJ1dGUuaCIKICNp bmNsdWRlICJNb3VzZUV2ZW50LmgiCiAjaW5jbHVkZSAiTXV0YXRpb25FdmVudC5oIgogI2luY2x1 ZGUgIk5hbWVOb2RlTGlzdC5oIgpAQCAtMTQzLDcgKzE0NCw3IEBAIHZvaWQgTm9kZTo6ZHVtcFN0 YXRpc3RpY3MoKQogICAgIHNpemVfdCBhdHRyTWFwcyA9IDA7CiAgICAgc2l6ZV90IG1hcHBlZEF0 dHJNYXBzID0gMDsKIAotICAgIGZvciAoSGFzaFNldDxOb2RlKj46OmNvbnN0X2l0ZXJhdG9yIGl0 ID0gbGl2ZU5vZGVTZXQuYmVnaW4oKTsgaXQgIT0gbGl2ZU5vZGVTZXQuZW5kKCk7ICsraXQpIHsK KyAgICBmb3IgKEhhc2hTZXQ8Tm9kZSo+OjppdGVyYXRvciBpdCA9IGxpdmVOb2RlU2V0LmJlZ2lu KCk7IGl0ICE9IGxpdmVOb2RlU2V0LmVuZCgpOyArK2l0KSB7CiAgICAgICAgIE5vZGUqIG5vZGUg PSAqaXQ7CiAKICAgICAgICAgaWYgKG5vZGUtPmhhc1JhcmVEYXRhKCkpCkBAIC0yNDksNyArMjUw LDcgQEAgdm9pZCBOb2RlOjpkdW1wU3RhdGlzdGljcygpCiAgICAgcHJpbnRmKCIgIE51bWJlciBv ZiBYUGF0aE5TIG5vZGVzOiAlenVcbiIsIHhwYXRoTlNOb2Rlcyk7CiAKICAgICBwcmludGYoIkVs ZW1lbnQgdGFnIG5hbWUgZGlzdGlidXRpb246XG4iKTsKLSAgICBmb3IgKEhhc2hNYXA8U3RyaW5n LCBzaXplX3Q+Ojpjb25zdF9pdGVyYXRvciBpdCA9IHBlclRhZ0NvdW50LmJlZ2luKCk7IGl0ICE9 IHBlclRhZ0NvdW50LmVuZCgpOyArK2l0KQorICAgIGZvciAoSGFzaE1hcDxTdHJpbmcsIHNpemVf dD46Oml0ZXJhdG9yIGl0ID0gcGVyVGFnQ291bnQuYmVnaW4oKTsgaXQgIT0gcGVyVGFnQ291bnQu ZW5kKCk7ICsraXQpCiAgICAgICAgIHByaW50ZigiICBOdW1iZXIgb2YgPCVzPiB0YWdzOiAlenVc biIsIGl0LT5maXJzdC51dGY4KCkuZGF0YSgpLCBpdC0+c2Vjb25kKTsKIAogICAgIHByaW50Zigi QXR0cmlidXRlIE1hcHM6XG4iKTsK