32429 2009-12-11 06:39:31 -0800 Add capability for ChromeClient implementations to refer 'accept' attribute value of an INPUT element 2009-12-12 11:59:27 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED http://www.whatwg.org/specs/web-apps/current-work/multipage/number-state.html#attr-input-accept P2 Normal --- 19264 32473 1 tkent tkent webkit.review.bot oldest_to_newest 170737 0 tkent 2009-12-11 06:39:31 -0800 ChromeClient::runOpenPanel() implementation should be able to refer 'accept' attribute to support it. 170741 1 44685 tkent 2009-12-11 06:49:22 -0800 Created attachment 44685 Proposed patch 170744 2 webkit.review.bot 2009-12-11 06:53:53 -0800 style-queue ran check-webkit-style on attachment 44685 without any errors. 170785 3 44685 fishd 2009-12-11 09:25:35 -0800 Comment on attachment 44685 Proposed patch > +++ b/WebCore/rendering/RenderFileUploadControl.cpp ... > +String RenderFileUploadControl::acceptTypes() > +{ > + HTMLInputElement* input = static_cast<HTMLInputElement*>(node()); > + return input->accept(); > +} nit: no need for the input variable, just do: return static_cast<HTMLInputElement*>(node())->accept(); Otherwise, R=me 170813 4 tkent 2009-12-11 10:16:35 -0800 (In reply to comment #3) Thank you for reviewing. > nit: no need for the input variable, just do: > > return static_cast<HTMLInputElement*>(node())->accept(); > > Otherwise, R=me Fixed it, and commit manually as r52003. 44685 2009-12-11 06:49:22 -0800 2009-12-11 10:16:56 -0800 Proposed patch 0001-accept-1.patch text/plain 2934 tkent ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjhiMTU1MS4uZWEyNTRlYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAwOS0xMi0xMSAgS2VudCBUYW11cmEg IDx0a2VudEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIGFjY2VwdFR5cGVzKCkgbWV0aG9kIHRvIEZpbGVDaG9vc2VyLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI0MjkKKwor ICAgICAgICBUaGlzIG1ldGhvZCByZXR1cm5zIGFuICdhY2NlcHQnIGF0dHJpYnV0ZSB2YWx1ZSBv ZiB0aGUKKyAgICAgICAgY29ycmVzcG9uZGluZyBJTlBVVCBlbGVtZW50LiBBIENocm9tZUNsaWVu dDo6cnVuT3BlblBhbmVsKCkKKyAgICAgICAgaW1wbGVtZW50YXRpb24gY2FuIHJlZmVyIGl0IHRo cm91Z2ggYSBGaWxlQ2hvb3NlciBpbnN0YW5jZSB0bworICAgICAgICBzdXBwb3J0IHR5cGUtcmVz dHJpY3RlZCBmaWxlIHNlbGVjdGluZy4KKworICAgICAgICBUaGlzIG1ha2VzIG5vIHVzZXItdmlz aWJsZSBjaGFuZ2VzIGZvciBub3cuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9GaWxlQ2hvb3Nlci5o OgorICAgICAgICAoV2ViQ29yZTo6RmlsZUNob29zZXI6OmFjY2VwdFR5cGVzKToKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyRmlsZVVwbG9hZENvbnRyb2w6OmFjY2VwdFR5cGVzKToKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuaDoKKwogMjAwOS0xMi0xMCAgUGF2ZWwgRmVs ZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1v dGh5IEhhdGNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVDaG9vc2VyLmgg Yi9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVDaG9vc2VyLmgKaW5kZXggMWQ0ZTk3MC4uMDc2NGE2YSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlQ2hvb3Nlci5oCisrKyBiL1dlYkNvcmUv cGxhdGZvcm0vRmlsZUNob29zZXIuaApAQCAtNDIsNiArNDIsNyBAQCBjbGFzcyBGaWxlQ2hvb3Nl ckNsaWVudCB7CiBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHZhbHVlQ2hhbmdlZCgpID0gMDsK ICAgICB2aXJ0dWFsIGJvb2wgYWxsb3dzTXVsdGlwbGVGaWxlcygpID0gMDsKKyAgICB2aXJ0dWFs IFN0cmluZyBhY2NlcHRUeXBlcygpID0gMDsKICAgICB2aXJ0dWFsIH5GaWxlQ2hvb3NlckNsaWVu dCgpOwogfTsKIApAQCAtNjQsNiArNjUsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBjaG9vc2VGaWxl cyhjb25zdCBWZWN0b3I8U3RyaW5nPiYgcGF0aHMpOwogICAgIAogICAgIGJvb2wgYWxsb3dzTXVs dGlwbGVGaWxlcygpIGNvbnN0IHsgcmV0dXJuIG1fY2xpZW50ID8gbV9jbGllbnQtPmFsbG93c011 bHRpcGxlRmlsZXMoKSA6IGZhbHNlOyB9CisgICAgLy8gQWNjZXB0YWJsZSBNSU1FIHR5cGVzLiAg SXQncyBhbiAnYWNjZXB0JyBhdHRyaWJ1dGUgdmFsdWUgb2YgdGhlIGNvcnJlc3BvbmRpbmcgSU5Q VVQgZWxlbWVudC4KKyAgICBTdHJpbmcgYWNjZXB0VHlwZXMoKSBjb25zdCB7IHJldHVybiBtX2Ns aWVudCA/IG1fY2xpZW50LT5hY2NlcHRUeXBlcygpIDogU3RyaW5nKCk7IH0KIAogcHJpdmF0ZToK ICAgICBGaWxlQ2hvb3NlcihGaWxlQ2hvb3NlckNsaWVudCosIGNvbnN0IFZlY3RvcjxTdHJpbmc+ JiBpbml0aWFsRmlsZW5hbWVzKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckZpbGVVcGxvYWRDb250cm9sLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZpbGVVcGxv YWRDb250cm9sLmNwcAppbmRleCAzN2VlOGZiLi5iZDFmMGIzIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJGaWxlVXBsb2FkQ29udHJvbC5jcHAKKysrIGIvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3BwCkBAIC0xMDgsNiArMTA4LDEyIEBAIGJv b2wgUmVuZGVyRmlsZVVwbG9hZENvbnRyb2w6OmFsbG93c011bHRpcGxlRmlsZXMoKQogICAgIHJl dHVybiAhaW5wdXQtPmdldEF0dHJpYnV0ZShtdWx0aXBsZUF0dHIpLmlzTnVsbCgpOwogfQogCitT dHJpbmcgUmVuZGVyRmlsZVVwbG9hZENvbnRyb2w6OmFjY2VwdFR5cGVzKCkKK3sKKyAgICBIVE1M SW5wdXRFbGVtZW50KiBpbnB1dCA9IHN0YXRpY19jYXN0PEhUTUxJbnB1dEVsZW1lbnQqPihub2Rl KCkpOworICAgIHJldHVybiBpbnB1dC0+YWNjZXB0KCk7Cit9CisKIHZvaWQgUmVuZGVyRmlsZVVw bG9hZENvbnRyb2w6OmNsaWNrKCkKIHsKICAgICBGcmFtZSogZnJhbWUgPSBub2RlKCktPmRvY3Vt ZW50KCktPmZyYW1lKCk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGaWxl VXBsb2FkQ29udHJvbC5oIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRy b2wuaAppbmRleCA3MmJhMzA4Li5kY2RjZTRkIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJGaWxlVXBsb2FkQ29udHJvbC5oCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckZpbGVVcGxvYWRDb250cm9sLmgKQEAgLTQ5LDYgKzQ5LDcgQEAgcHVibGljOgogICAgIFN0cmlu ZyBmaWxlVGV4dFZhbHVlKCkgY29uc3Q7CiAgICAgCiAgICAgYm9vbCBhbGxvd3NNdWx0aXBsZUZp bGVzKCk7CisgICAgU3RyaW5nIGFjY2VwdFR5cGVzKCk7CiAKIHByaXZhdGU6CiAgICAgdmlydHVh bCBjb25zdCBjaGFyKiByZW5kZXJOYW1lKCkgY29uc3QgeyByZXR1cm4gIlJlbmRlckZpbGVVcGxv YWRDb250cm9sIjsgfQotLSAKMS42LjMuMwoK