32226 2009-12-07 09:18:19 -0800 Random crashes in WebSocket tests on Leopard Debug 2009-12-07 13:06:04 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac (Intel) OS X 10.5 RESOLVED FIXED http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r51768%20(7949)/results.html P2 Critical --- 1 zimmermann ap ap ukai webkit.review.bot oldest_to_newest 169338 0 zimmermann 2009-12-07 09:18:19 -0800 See Leopard Intel Debug slave, the new test in websocket/tests/url-with-credential.html crashes. Adding to the skipped list, until anyone resolves it. 169384 1 ap 2009-12-07 10:56:47 -0800 Disabling the test didn't help - now the next test fails, so it's one of earlier tests that is to blame. Investigating. 169387 2 ap 2009-12-07 11:12:34 -0800 Un-skipped the test. Running 'run-webkit-tests websocket --repeat-each 5 -v' locally, I'm getting a crash in websocket/tests/handshake-error.html, which looks like memory corruption. Thread 0 Crashed: 0 com.apple.CoreFoundation 0x94b7fde6 CFEqual + 38 1 com.apple.CoreFoundation 0x94b81835 __CFSetFindBuckets2 + 293 2 com.apple.CoreFoundation 0x94b82be8 CFSetAddValue + 360 3 com.apple.CoreFoundation 0x94b7c07e CFRunLoopAddTimer + 478 4 com.apple.WebCore 0x04c65929 WebCore::setSharedTimerFireTime(double) + 291 (SharedTimerMac.mm:103) 5 com.apple.WebCore 0x04daa5a5 WebCore::MainThreadSharedTimer::setFireTime(double) + 33 (SharedTimer.h:65) 6 com.apple.WebCore 0x04daa09d WebCore::ThreadTimers::updateSharedTimer() + 141 (ThreadTimers.cpp:85) 7 com.apple.WebCore 0x04daa23b WebCore::ThreadTimers::sharedTimerFiredInternal() + 381 (ThreadTimers.cpp:122) 8 com.apple.WebCore 0x04daa2ef WebCore::ThreadTimers::sharedTimerFired() + 27 (ThreadTimers.cpp:91) 9 com.apple.WebCore 0x04c657b0 __ZN7WebCoreL10timerFiredEP16__CFRunLoopTimerPv + 78 (SharedTimerMac.mm:87) 10 com.apple.CoreFoundation 0x94b7d8f5 CFRunLoopRunSpecific + 4469 169434 3 44426 ap 2009-12-07 12:56:40 -0800 Created attachment 44426 proposed fix 169436 4 webkit.review.bot 2009-12-07 13:00:25 -0800 style-queue ran check-webkit-style on attachment 44426 without any errors. 169437 5 44426 zimmermann 2009-12-07 13:04:36 -0800 Comment on attachment 44426 proposed fix Looks good. r=me. 169438 6 ap 2009-12-07 13:06:04 -0800 Committed revision 51790. 44426 2009-12-07 12:56:40 -0800 2009-12-07 13:04:36 -0800 proposed fix WSLeoCrash2.txt text/plain 1417 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTc4OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMTItMDcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMjI2CisgICAgICAgIFJh bmRvbSBjcmFzaGVzIGluIFdlYlNvY2tldCB0ZXN0cyBvbiBMZW9wYXJkIERlYnVnIGJ1aWxib3QK KworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvU29ja2V0U3RyZWFtSGFuZGxlQmFzZS5jcHA6 IChXZWJDb3JlOjpTb2NrZXRTdHJlYW1IYW5kbGVCYXNlOjpjbG9zZSk6CisgICAgICAgIE1ha2Ug c3VyZSB0aGUgb2JqZWN0IHN0aWxsIGV4aXN0cyB3aGVuIHNldHRpbmcgbV9zdGF0ZS4KKwogMjAw OS0xMi0wNyAgU2hpa2kgT2thc2FrYSAgPHNoaWtpQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGlyayBTY2h1bHplLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Nv Y2tldFN0cmVhbUhhbmRsZUJhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9Tb2NrZXRTdHJlYW1IYW5kbGVCYXNlLmNwcAkocmV2aXNpb24gNTE3ODMpCisrKyBX ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvU29ja2V0U3RyZWFtSGFuZGxlQmFzZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRl ICJTb2NrZXRTdHJlYW1IYW5kbGVCYXNlLmgiCiAKKyNpbmNsdWRlICJTb2NrZXRTdHJlYW1IYW5k bGUuaCIKICNpbmNsdWRlICJTb2NrZXRTdHJlYW1IYW5kbGVDbGllbnQuaCIKIAogbmFtZXNwYWNl IFdlYkNvcmUgewpAQCAtNzcsNiArNzgsOCBAQCBib29sIFNvY2tldFN0cmVhbUhhbmRsZUJhc2U6 OnNlbmQoY29uc3QgCiAKIHZvaWQgU29ja2V0U3RyZWFtSGFuZGxlQmFzZTo6Y2xvc2UoKQogewor ICAgIFJlZlB0cjxTb2NrZXRTdHJlYW1IYW5kbGU+IHByb3RlY3Qoc3RhdGljX2Nhc3Q8U29ja2V0 U3RyZWFtSGFuZGxlKj4odGhpcykpOyAvLyBwbGF0Zm9ybUNsb3NlIGNhbGxzIHRoZSBjbGllbnQs IHdoaWNoIG1heSBtYWtlIHRoZSBoYW5kbGUgZ2V0IGRlYWxsb2NhdGVkIGltbWVkaWF0ZWx5Lgor CiAgICAgcGxhdGZvcm1DbG9zZSgpOwogICAgIG1fc3RhdGUgPSBDbG9zZWQ7CiB9Cg==