32225 2009-12-07 09:14:41 -0800 [check-webkit-style] S_OK is a fine identifier 2009-12-07 21:59:00 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth hamaji levin webkit.review.bot oldest_to_newest 169335 0 abarth 2009-12-07 09:14:41 -0800 WebCore/platform/text/wince/TextCodecWince.cpp:125: S_OK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] https://bugs.webkit.org/show_bug.cgi?id=32169#c2 That's a false positive. 169597 1 44458 hamaji 2009-12-07 21:15:39 -0800 Created attachment 44458 Patch v1 169598 2 webkit.review.bot 2009-12-07 21:18:03 -0800 style-queue ran check-webkit-style on attachment 44458 without any errors. 169599 3 hamaji 2009-12-07 21:20:06 -0800 This happened because the style checker considered it is the declaration of S_OK. if (mli && S_OK == mli->EnumCodePages(MIMECONTF_BROWSER, &enumInterface)) { Note that we should warn about the following statement. if (int & S_OK = intValue) { My patch checks the character after the first '='. 169604 4 44458 hamaji 2009-12-07 21:58:51 -0800 Comment on attachment 44458 Patch v1 Clearing flags on attachment: 44458 Committed r51835: <http://trac.webkit.org/changeset/51835> 169605 5 hamaji 2009-12-07 21:59:00 -0800 All reviewed patches have been landed. Closing bug. 44458 2009-12-07 21:15:39 -0800 2009-12-07 21:58:51 -0800 Patch v1 bug-32225-20091208141537.patch text/plain 2204 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzOTNiZjYxLi45NmQ1NGE3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTIt MDcgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hlY2std2Via2l0LXN0eWxl XSBTX09LIGlzIGEgZmluZSBpZGVudGlmaWVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMjIyNQorCisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2Nw cF9zdHlsZS5weToKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlX3VuaXR0ZXN0 LnB5OgorCiAyMDA5LTEyLTA3ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0u Y29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZS5weSBiL1dlYktp dFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUucHkKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBt b2RlIDEwMDc1NQppbmRleCBmYzE0M2E5Li41YjYyZDZkCi0tLSBhL1dlYktpdFRvb2xzL1Njcmlw dHMvbW9kdWxlcy9jcHBfc3R5bGUucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVz L2NwcF9zdHlsZS5weQpAQCAtMjcwNCw3ICsyNzA0LDcgQEAgZGVmIGNoZWNrX2lkZW50aWZpZXJf bmFtZV9pbl9kZWNsYXJhdGlvbihmaWxlbmFtZSwgbGluZV9udW1iZXIsIGxpbmUsIGVycm9yKToK ICAgICAjIERldGVjdCB2YXJpYWJsZSBhbmQgZnVuY3Rpb25zLgogICAgIHR5cGVfcmVnZXhwID0g cidcdyhbXHddfFxzKlsqJl1ccyp8OjopKycKICAgICBpZGVudGlmaWVyX3JlZ2V4cCA9IHInKD9Q PGlkZW50aWZpZXI+W1x3Ol0rKScKLSAgICBjaGFyYWN0ZXJfYWZ0ZXJfaWRlbnRpZmllcl9yZWdl eHAgPSByJyg/UDxjaGFyYWN0ZXJfYWZ0ZXJfaWRlbnRpZmllcj5bWzsoKT0sXSknCisgICAgY2hh cmFjdGVyX2FmdGVyX2lkZW50aWZpZXJfcmVnZXhwID0gcicoP1A8Y2hhcmFjdGVyX2FmdGVyX2lk ZW50aWZpZXI+W1s7KCk9LF0pKD8hPSknCiAgICAgZGVjbGFyYXRpb25fd2l0aG91dF90eXBlX3Jl Z2V4cCA9IHInXHMqJyArIGlkZW50aWZpZXJfcmVnZXhwICsgcidccyonICsgY2hhcmFjdGVyX2Fm dGVyX2lkZW50aWZpZXJfcmVnZXhwCiAgICAgZGVjbGFyYXRpb25fd2l0aF90eXBlX3JlZ2V4cCA9 IHInXHMqJyArIHR5cGVfcmVnZXhwICsgcidccycgKyBkZWNsYXJhdGlvbl93aXRob3V0X3R5cGVf cmVnZXhwCiAgICAgaXNfZnVuY3Rpb25fYXJndW1lbnRzID0gRmFsc2UKZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGVfdW5pdHRlc3QucHkgYi9XZWJLaXRU b29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5Cm9sZCBtb2RlIDEwMDY0 NApuZXcgbW9kZSAxMDA3NTUKaW5kZXggM2YwZjIzMC4uNTllNzUyZQotLS0gYS9XZWJLaXRUb29s cy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xz L1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGVfdW5pdHRlc3QucHkKQEAgLTM2NjAsNiArMzY2MCw3 IEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAg ICAgICAgICAgICAgICAndW5kZXJfc2NvcmUnICsgbmFtZV9lcnJvcl9tZXNzYWdlKQogICAgICAg ICBzZWxmLmFzc2VydF9saW50KCd3aGlsZSAoZm9vICYgdmFsdWVfaW5fdGhpcmRwYXJ0eV9saWJy YXJ5KSB7JywgJycpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3doaWxlIChmb28gKiB2YWx1 ZV9pbl90aGlyZHBhcnR5X2xpYnJhcnkpIHsnLCAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGlu dCgnaWYgKG1saSAmJiBTX09LID09IG1saS0+Zm9vKCkpIHsnLCAnJykKIAogICAgICAgICAjIE1v cmUgbWVtYmVyIHZhcmlhYmxlcyBhbmQgZnVuY3Rpb25zLgogICAgICAgICBzZWxmLmFzc2VydF9s aW50KCdpbnQgU29tZUNsYXNzOjpzX3ZhbGlkTmFtZScsICcnKQo=