<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>32189</bug_id>
          
          <creation_ts>2009-12-05 21:58:29 -0800</creation_ts>
          <short_desc>[GTK] Integrate running of API tests into buildbot run</short_desc>
          <delta_ts>2010-02-18 05:32:38 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gustavo Noronha (kov)">gustavo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cjerdonek</cc>
    
    <cc>eric</cc>
    
    <cc>mrowe</cc>
    
    <cc>nsylvain</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>169063</commentid>
    <comment_count>0</comment_count>
      <attachid>44353</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-12-05 21:58:29 -0800</bug_when>
    <thetext>Created attachment 44353
proposed patch

We have some API tests we name &apos;unittests&apos;. It&apos;s important to have them running automatically for each commit like we do with layout tests. I&apos;m attaching a patch to implement this - the run-gtk-tests script is not very sophisticated, but should be enough for our current needs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>169064</commentid>
    <comment_count>1</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2009-12-05 22:00:52 -0800</bug_when>
    <thetext>style-queue ran check-webkit-style on attachment 44353 without any errors.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>182474</commentid>
    <comment_count>2</comment_count>
      <attachid>44353</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-19 14:50:51 -0800</bug_when>
    <thetext>Comment on attachment 44353
proposed patch

We have shared code for how to get the configuration directory in webkitdirs.pm.  I think we should re-use that here.  Meaning we should just make run-gtk-tests a perl script.  Unfortunately we don&apos;t have any equivalent detection code for python or I would suggest we write this in python instead. :)

In general the code looks OK.  I&apos;m not really an expert on the internals of buildbot.  There might be a more concise way to write parts of the class.

No need to call bash directly, or?
+    command = [&quot;bash&quot;, &quot;./WebKitTools/Scripts/run-gtk-tests&quot;, WithProperties(&quot;--%(configuration)s&quot;)]

r- for not re-using existing configuration directory detection logic.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>182480</commentid>
    <comment_count>3</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2010-01-19 15:20:13 -0800</bug_when>
    <thetext>Thanks for the review!

(In reply to comment #2)
&gt; (From update of attachment 44353 [details])
&gt; We have shared code for how to get the configuration directory in
&gt; webkitdirs.pm.  I think we should re-use that here.  Meaning we should just
&gt; make run-gtk-tests a perl script.  Unfortunately we don&apos;t have any equivalent
&gt; detection code for python or I would suggest we write this in python instead.
&gt; :)

OK; I was kind of avoiding this, but I think it makes sense to keep this kind of logic in a centralized place.
 
&gt; No need to call bash directly, or?
&gt; +    command = [&quot;bash&quot;, &quot;./WebKitTools/Scripts/run-gtk-tests&quot;,
&gt; WithProperties(&quot;--%(configuration)s&quot;)]

That&apos;s to keep consistency. Perl also theoretically does not need to be called directly, but all commands include it explicitely.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>182509</commentid>
    <comment_count>4</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-19 16:39:05 -0800</bug_when>
    <thetext>bug 33432 is also very similar.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>188230</commentid>
    <comment_count>5</comment_count>
      <attachid>48245</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2010-02-05 11:23:54 -0800</bug_when>
    <thetext>Created attachment 48245
Run GTK+ API tests

Addresses the concerns raised by Eric.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>191243</commentid>
    <comment_count>6</comment_count>
      <attachid>48245</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-02-17 15:04:07 -0800</bug_when>
    <thetext>Comment on attachment 48245
Run GTK+ API tests

Looks OK to me.

It&apos;s actually now possible to write this sort of thing in python now that we&apos;ve added &quot;webkit-build-directory&quot; which is able to let non-perl scripts access these sorts of things. :)

Anyway, this looks fine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>191546</commentid>
    <comment_count>7</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2010-02-18 05:32:38 -0800</bug_when>
    <thetext>Landed as r54956.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>44353</attachid>
            <date>2009-12-05 21:58:29 -0800</date>
            <delta_ts>2010-02-05 11:23:54 -0800</delta_ts>
            <desc>proposed patch</desc>
            <filename>0001-Enable-running-of-GTK-API-tests.patch</filename>
            <type>text/plain</type>
            <size>4172</size>
            <attacher name="Gustavo Noronha (kov)">gustavo</attacher>
            
              <data encoding="base64">RnJvbSAyZjNiMGU1OGNiMzUxZmU1ZmIzMTYwN2U1N2JlNDRmYjM5YzRjN2JlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o
YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IFN1biwgNiBEZWMgMjAwOSAwMzo1MToxMCAtMDIwMApT
dWJqZWN0OiBbUEFUQ0hdIEVuYWJsZSBydW5uaW5nIG9mIEdUSysgQVBJIHRlc3RzCgotLS0KIC4u
Li9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnICAgICAgICAgICAgIHwgICAzOCAr
KysrKysrKysrKysrKysrKysrKwogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfCAgICA5ICsrKysrCiBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi1ndGst
dGVzdHMgICAgICAgICAgICAgICAgICB8ICAgMjYgKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFu
Z2VkLCA3MyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNzU1
IFdlYktpdFRvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwoKZGlmZiAtLWdpdCBhL1dlYktpdFRv
b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcg
Yi9XZWJLaXRUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9t
YXN0ZXIuY2ZnCmluZGV4IGNkODExMDguLmRjZWEzZjggMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xz
L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKKysr
IGIvV2ViS2l0VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv
bWFzdGVyLmNmZwpAQCAtMjMwLDYgKzIzMCw0MiBAQCBjbGFzcyBSdW5XZWJLaXRUZXN0cyhzaGVs
bC5UZXN0KToKICAgICAgICAgcmV0dXJuIFtzZWxmLm5hbWVdCiAKIAorY2xhc3MgUnVuR3RrQVBJ
VGVzdHMoc2hlbGwuVGVzdCk6CisgICAgbmFtZSA9ICJBUEkgdGVzdHMiCisgICAgZGVzY3JpcHRp
b24gPSBbIkFQSSB0ZXN0cyBydW5uaW5nIl0KKyAgICBkZXNjcmlwdGlvbkRvbmUgPSBbIkFQSSB0
ZXN0cyJdCisgICAgY29tbWFuZCA9IFsiYmFzaCIsICIuL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVu
LWd0ay10ZXN0cyIsIFdpdGhQcm9wZXJ0aWVzKCItLSUoY29uZmlndXJhdGlvbilzIildCisKKyAg
ICBkZWYgY29tbWFuZENvbXBsZXRlKHNlbGYsIGNtZCk6CisgICAgICAgIHNoZWxsLlRlc3QuY29t
bWFuZENvbXBsZXRlKHNlbGYsIGNtZCkKKworICAgICAgICBsb2dUZXh0ID0gY21kLmxvZ3NbJ3N0
ZGlvJ10uZ2V0VGV4dCgpCisgICAgICAgIGluY29ycmVjdExpbmVzID0gW10KKyAgICAgICAgZm9y
IGxpbmUgaW4gbG9nVGV4dC5zcGxpdGxpbmVzKCk6CisgICAgICAgICAgICBpZiBsaW5lLnN0YXJ0
c3dpdGgoJ0VSUk9SJyk6CisgICAgICAgICAgICAgICAgaW5jb3JyZWN0TGluZXMuYXBwZW5kKGxp
bmUpCisKKyAgICAgICAgc2VsZi5pbmNvcnJlY3RMaW5lcyA9IGluY29ycmVjdExpbmVzCisKKyAg
ICBkZWYgZXZhbHVhdGVDb21tYW5kKHNlbGYsIGNtZCk6CisgICAgICAgIGlmIHNlbGYuaW5jb3Jy
ZWN0TGluZXM6CisgICAgICAgICAgICByZXR1cm4gRkFJTFVSRQorCisgICAgICAgIGlmIGNtZC5y
YyAhPSAwOgorICAgICAgICAgICAgcmV0dXJuIEZBSUxVUkUKKworICAgICAgICByZXR1cm4gU1VD
Q0VTUworCisgICAgZGVmIGdldFRleHQoc2VsZiwgY21kLCByZXN1bHRzKToKKyAgICAgICAgcmV0
dXJuIHNlbGYuZ2V0VGV4dDIoY21kLCByZXN1bHRzKQorCisgICAgZGVmIGdldFRleHQyKHNlbGYs
IGNtZCwgcmVzdWx0cyk6CisgICAgICAgIGlmIHJlc3VsdHMgIT0gU1VDQ0VTUyBhbmQgc2VsZi5p
bmNvcnJlY3RMaW5lczoKKyAgICAgICAgICAgIHJldHVybiBbIiVkIEFQSSB0ZXN0cyBmYWlsZWQi
ICUgc2VsZi5pbmNvcnJlY3RMaW5lc10KKworICAgICAgICByZXR1cm4gW3NlbGYubmFtZV0KKwor
CiBjbGFzcyBSdW5XZWJLaXRMZWFrVGVzdHMoUnVuV2ViS2l0VGVzdHMpOgogICAgIGRlZiBzdGFy
dChzZWxmKToKICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCArIFsiLS1sZWFr
cyJdKQpAQCAtMzEyLDYgKzM0OCw4IEBAIGNsYXNzIEJ1aWxkQW5kVGVzdEZhY3RvcnkoRmFjdG9y
eSk6CiAgICAgICAgIHNlbGYuYWRkU3RlcChBcmNoaXZlVGVzdFJlc3VsdHMpCiAgICAgICAgIHNl
bGYuYWRkU3RlcChVcGxvYWRUZXN0UmVzdWx0cykKICAgICAgICAgc2VsZi5hZGRTdGVwKEV4dHJh
Y3RUZXN0UmVzdWx0cykKKyAgICAgICAgaWYgcGxhdGZvcm0gPT0gImd0ayI6CisgICAgICAgICAg
ICBzZWxmLmFkZFN0ZXAoUnVuR3RrQVBJVGVzdHMpCiAKIGNsYXNzIEJ1aWxkQW5kVGVzdExlYWtz
RmFjdG9yeShCdWlsZEFuZFRlc3RGYWN0b3J5KToKICAgICBUZXN0Q2xhc3MgPSBSdW5XZWJLaXRM
ZWFrVGVzdHMKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xz
L0NoYW5nZUxvZwppbmRleCA5NzIwM2RlLi5iMGViMmI3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s
cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK
KzIwMDktMTItMDUgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5hYmxlIHJ1bm5p
bmcgb2YgR1RLKyBBUEkgdGVzdHMuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWls
ZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAgICAgICAqIFNjcmlwdHMvcnVuLWd0
ay10ZXN0czogQWRkZWQuCisKIDIwMDktMTItMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0
Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dl
YktpdFRvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVu
LWd0ay10ZXN0cwpuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwLi5hY2Y0NjcwCi0t
LSAvZGV2L251bGwKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCkBAIC0w
LDAgKzEsMjYgQEAKKyMhL2Jpbi9iYXNoCisjCisjIENvcHlyaWdodCAoQykgMjAwOSBHdXN0YXZv
IE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+CisjCisjIFRoaXMgbGlicmFyeSBpcyBmcmVl
IHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKKyMgbW9kaWZ5IGl0IHVu
ZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKKyMgTGljZW5z
ZSBhcyBwdWJsaXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyCisj
IHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIg
dmVyc2lvbi4KKyMKKyMgVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRo
YXQgaXQgd2lsbCBiZSB1c2VmdWwsCisjIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91
dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisjIE1FUkNIQU5UQUJJTElUWSBvciBGSVRO
RVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCisjIExpYnJhcnkgR2Vu
ZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorIworIyBZb3Ugc2hvdWxkIGhh
dmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNl
bnNlCisjIGFsb25nIHdpdGggdGhpcyBsaWJyYXJ5OyBzZWUgdGhlIGZpbGUgQ09QWUlORy5MSUIu
ICBJZiBub3QsIHdyaXRlIHRvCisjIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4s
IDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsCisjIEJvc3RvbiwgTUEgMDIxMTAtMTMw
MSwgVVNBLgorCitpZiBbICIkMSIgPSAiLS1kZWJ1ZyIgXTsgdGhlbgorICAgIENPTkZJR1VSQVRJ
T049RGVidWcKK2Vsc2UKKyAgICBDT05GSUdVUkFUSU9OPVJlbGVhc2UKK2ZpCisKK2d0ZXN0ZXIg
LWsgLi9XZWJLaXRCdWlsZC8ke0NPTkZJR1VSQVRJT059L1Byb2dyYW1zL3VuaXR0ZXN0cy8qCi0t
IAoxLjYuNS4zCgo=
</data>
<flag name="review"
          id="26187"
          type_id="1"
          status="-"
          setter="eric"
    />
    <flag name="commit-queue"
          id="26188"
          type_id="3"
          status="-"
          setter="gustavo"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>48245</attachid>
            <date>2010-02-05 11:23:54 -0800</date>
            <delta_ts>2010-02-17 15:04:07 -0800</delta_ts>
            <desc>Run GTK+ API tests</desc>
            <filename>0001-Enable-running-of-GTK-API-tests.patch</filename>
            <type>text/plain</type>
            <size>4417</size>
            <attacher name="Gustavo Noronha (kov)">gustavo</attacher>
            
              <data encoding="base64">RnJvbSAwY2Q4NjdlMjM1YjcxZjIxZDVmYWEzMGIyOGZjZDAxZDZjNDlhYWVlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o
YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IFN1biwgNiBEZWMgMjAwOSAwMzo1MToxMCAtMDIwMApT
dWJqZWN0OiBbUEFUQ0hdIEVuYWJsZSBydW5uaW5nIG9mIEdUSysgQVBJIHRlc3RzCgotLS0KIC4u
Li9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnICAgICAgICAgICAgIHwgICAzOCAr
KysrKysrKysrKysrKysrKysrKwogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfCAgICA5ICsrKysrCiBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi1ndGst
dGVzdHMgICAgICAgICAgICAgICAgICB8ICAgMzUgKysrKysrKysrKysrKysrKysrCiAzIGZpbGVz
IGNoYW5nZWQsIDgyIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAx
MDA2NDQgV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCgpkaWZmIC0tZ2l0IGEvV2Vi
S2l0VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVy
LmNmZyBiL1dlYktpdFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u
ZmlnL21hc3Rlci5jZmcKaW5kZXggY2Q4MTEwOC4uMTgyMzI3NyAxMDA2NDQKLS0tIGEvV2ViS2l0
VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNm
ZworKysgYi9XZWJLaXRUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv
bmZpZy9tYXN0ZXIuY2ZnCkBAIC0yMzAsNiArMjMwLDQyIEBAIGNsYXNzIFJ1bldlYktpdFRlc3Rz
KHNoZWxsLlRlc3QpOgogICAgICAgICByZXR1cm4gW3NlbGYubmFtZV0KIAogCitjbGFzcyBSdW5H
dGtBUElUZXN0cyhzaGVsbC5UZXN0KToKKyAgICBuYW1lID0gIkFQSSB0ZXN0cyIKKyAgICBkZXNj
cmlwdGlvbiA9IFsiQVBJIHRlc3RzIHJ1bm5pbmciXQorICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsi
QVBJIHRlc3RzIl0KKyAgICBjb21tYW5kID0gWyJwZXJsIiwgIi4vV2ViS2l0VG9vbHMvU2NyaXB0
cy9ydW4tZ3RrLXRlc3RzIiwgV2l0aFByb3BlcnRpZXMoIi0tJShjb25maWd1cmF0aW9uKXMiKV0K
KworICAgIGRlZiBjb21tYW5kQ29tcGxldGUoc2VsZiwgY21kKToKKyAgICAgICAgc2hlbGwuVGVz
dC5jb21tYW5kQ29tcGxldGUoc2VsZiwgY21kKQorCisgICAgICAgIGxvZ1RleHQgPSBjbWQubG9n
c1snc3RkaW8nXS5nZXRUZXh0KCkKKyAgICAgICAgaW5jb3JyZWN0TGluZXMgPSBbXQorICAgICAg
ICBmb3IgbGluZSBpbiBsb2dUZXh0LnNwbGl0bGluZXMoKToKKyAgICAgICAgICAgIGlmIGxpbmUu
c3RhcnRzd2l0aCgnRVJST1InKToKKyAgICAgICAgICAgICAgICBpbmNvcnJlY3RMaW5lcy5hcHBl
bmQobGluZSkKKworICAgICAgICBzZWxmLmluY29ycmVjdExpbmVzID0gaW5jb3JyZWN0TGluZXMK
KworICAgIGRlZiBldmFsdWF0ZUNvbW1hbmQoc2VsZiwgY21kKToKKyAgICAgICAgaWYgc2VsZi5p
bmNvcnJlY3RMaW5lczoKKyAgICAgICAgICAgIHJldHVybiBGQUlMVVJFCisKKyAgICAgICAgaWYg
Y21kLnJjICE9IDA6CisgICAgICAgICAgICByZXR1cm4gRkFJTFVSRQorCisgICAgICAgIHJldHVy
biBTVUNDRVNTCisKKyAgICBkZWYgZ2V0VGV4dChzZWxmLCBjbWQsIHJlc3VsdHMpOgorICAgICAg
ICByZXR1cm4gc2VsZi5nZXRUZXh0MihjbWQsIHJlc3VsdHMpCisKKyAgICBkZWYgZ2V0VGV4dDIo
c2VsZiwgY21kLCByZXN1bHRzKToKKyAgICAgICAgaWYgcmVzdWx0cyAhPSBTVUNDRVNTIGFuZCBz
ZWxmLmluY29ycmVjdExpbmVzOgorICAgICAgICAgICAgcmV0dXJuIFsiJWQgQVBJIHRlc3RzIGZh
aWxlZCIgJSBzZWxmLmluY29ycmVjdExpbmVzXQorCisgICAgICAgIHJldHVybiBbc2VsZi5uYW1l
XQorCisKIGNsYXNzIFJ1bldlYktpdExlYWtUZXN0cyhSdW5XZWJLaXRUZXN0cyk6CiAgICAgZGVm
IHN0YXJ0KHNlbGYpOgogICAgICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5jb21tYW5kICsgWyIt
LWxlYWtzIl0pCkBAIC0zMTIsNiArMzQ4LDggQEAgY2xhc3MgQnVpbGRBbmRUZXN0RmFjdG9yeShG
YWN0b3J5KToKICAgICAgICAgc2VsZi5hZGRTdGVwKEFyY2hpdmVUZXN0UmVzdWx0cykKICAgICAg
ICAgc2VsZi5hZGRTdGVwKFVwbG9hZFRlc3RSZXN1bHRzKQogICAgICAgICBzZWxmLmFkZFN0ZXAo
RXh0cmFjdFRlc3RSZXN1bHRzKQorICAgICAgICBpZiBwbGF0Zm9ybSA9PSAiZ3RrIjoKKyAgICAg
ICAgICAgIHNlbGYuYWRkU3RlcChSdW5HdGtBUElUZXN0cykKIAogY2xhc3MgQnVpbGRBbmRUZXN0
TGVha3NGYWN0b3J5KEJ1aWxkQW5kVGVzdEZhY3RvcnkpOgogICAgIFRlc3RDbGFzcyA9IFJ1bldl
YktpdExlYWtUZXN0cwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0
VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDQwZDE5ZDIuLjA2ZGY3NmIgMTAwNjQ0Ci0tLSBhL1dlYktp
dFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx
MiBAQAorMjAwOS0xMi0wNSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUg
cnVubmluZyBvZiBHVEsrIEFQSSB0ZXN0cy4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0
L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmc6CisgICAgICAgICogU2NyaXB0cy9y
dW4tZ3RrLXRlc3RzOiBBZGRlZC4KKwogMjAxMC0wMi0wNSAgVG9yIEFybmUgVmVzdGLDuCAgPHRv
ci5hcm5lLnZlc3Rib0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1
c21hbm4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMgYi9X
ZWJLaXRUb29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k
ZXggMDAwMDAwMC4uOWE1NzMxOQotLS0gL2Rldi9udWxsCisrKyBiL1dlYktpdFRvb2xzL1Njcmlw
dHMvcnVuLWd0ay10ZXN0cwpAQCAtMCwwICsxLDM1IEBACisjIS91c3IvYmluL3BlcmwKKyMKKyMg
Q29weXJpZ2h0IChDKSAyMDA5IEd1c3Rhdm8gTm9yb25oYSBTaWx2YSA8Z25zQGdub21lLm9yZz4K
KyMKKyMgVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRl
IGl0IGFuZC9vcgorIyBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFy
eSBHZW5lcmFsIFB1YmxpYworIyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0
d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyMgdmVyc2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvciAo
YXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgorIworIyBUaGlzIGxpYnJhcnkgaXMg
ZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyMgYnV0IFdJ
VEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YK
KyMgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAg
U2VlIHRoZSBHTlUKKyMgTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRl
dGFpbHMuCisjCisjIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBM
aWJyYXJ5IEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKyMgYWxvbmcgd2l0aCB0aGlzIGxpYnJhcnk7
IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJQi4gIElmIG5vdCwgd3JpdGUgdG8KKyMgdGhlIEZyZWUg
U29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLiwgNTEgRnJhbmtsaW4gU3RyZWV0LCBGaWZ0aCBGbG9v
ciwKKyMgQm9zdG9uLCBNQSAwMjExMC0xMzAxLCBVU0EuCisKK3VzZSBzdHJpY3Q7Cit1c2Ugd2Fy
bmluZ3M7CisKK3VzZSBGaW5kQmluOwordXNlIGxpYiAkRmluZEJpbjo6QmluOwordXNlIHdlYmtp
dGRpcnM7CisKKyMgVGhpcyBpbml0aWFsaXplcyB0aGUgY29ycmVjdCBjb25maWd1cmF0aW9uIChS
ZWxlYXNlL0RlYnVnKQorc2V0Q29uZmlndXJhdGlvbigpOworCitteSAkcHJvZHVjdERpciA9IHBy
b2R1Y3REaXIoKTsKK215IEB1bml0VGVzdHMgPSBnbG9iICAkcHJvZHVjdERpciAuICIvUHJvZ3Jh
bXMvdW5pdHRlc3RzLyoiOworaWYgKCQjdW5pdFRlc3RzIDwgMSkgeworICAgIGRpZSAiRVJST1I6
IHRlc3RzIG5vdCBmb3VuZCBpbiAkcHJvZHVjdERpci5cbiI7Cit9CitzeXN0ZW0gImd0ZXN0ZXIg
LWsgQHVuaXRUZXN0cyIKLS0gCjEuNi42LjEKCg==
</data>
<flag name="review"
          id="30893"
          type_id="1"
          status="+"
          setter="eric"
    />
    <flag name="commit-queue"
          id="30894"
          type_id="3"
          status="-"
          setter="gustavo"
    />
          </attachment>
      

    </bug>

</bugzilla>