32042 2009-12-01 17:16:46 -0800 style-queue (or something) should r- patches missing ChangeLogs 2013-03-25 13:46:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 NEW P2 Normal --- 1 eric webkit-unassigned abarth levin webkit.review.bot oldest_to_newest 167795 0 eric 2009-12-01 17:16:46 -0800 style-queue (or something) should r- patches missing ChangeLogs Or at least make a nasty comment in the bug. Rarely can one actually review a patch w/o a ChangeLog. We have at least one other bug about our tools warning us sooner, but if style-queue is the earliest we can get a warning, then so be it. It's better than the current pre-commit hook or reviewers spending time on it. The bot should point people to http://webkit.org/coding/contributing.html or possibly http://webkit.org/coding/contributing.html#changelogs 168061 1 ap 2009-12-02 10:48:48 -0800 A helpful comment would be OK, but you'd need to nominate the tool for reviewer status to actually r-. And there are cases when it makes more sense to just manually adapt and land a one time contributor's patch than to educate them about our process. Sometimes people do useful things without long-term involvement with the project. 863030 2 ap 2013-03-25 13:46:23 -0700 *** Bug 61458 has been marked as a duplicate of this bug. *** 863034 3 ap 2013-03-25 13:46:42 -0700 *** Bug 62021 has been marked as a duplicate of this bug. ***