31920 2009-11-26 11:36:24 -0800 REGRESSION (r38898): Using the up arrow in a textarea gets "stuck" at the beginning 2009-12-18 01:50:41 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 25676 1 alex webkit-unassigned ap bdakin commit-queue ddkilzer eric jdiggs justin.garcia webkit.review.bot oldest_to_newest 166767 0 alex 2009-11-26 11:36:24 -0800 The patch uploaded to fix the bug 13736 breaks the up arrow action. In order to reproduce the problem you can: 1. Open the test LayoutTests/editing/selection/wrapped-line-caret-2.html 2. Move the cursor to a position in the second line after the character 3, in the middle of the xs 3. Use up arrow to move to the first line The expected result: the up arrow should move the cursor to the end of the first line, after the space. The actual result: the cursor moves to the beginning of the second line and if you press up again the cursor does not move. The regression is caused after the patch committed to solve that bug if we comment the call to the searchAheadForBetterMatch we can move to the end of the line with the up arrow. I've checked it can be solved modifying the affinity. 166768 1 43928 alex 2009-11-26 11:38:25 -0800 Created attachment 43928 Patch fixing the problem I have attached a patch that fixes the problem setting the affinity in that case to UPSTREAM. Not sure if it is a good option because the patch breaks some tests, but just because of the log message, the problem is the dump text, it prints a message about the affinity and makes some tests to fail because the expected did not include that message. In case the patch is correct we would have to include the modifications of the expected values of the tests. 167899 2 alex 2009-12-02 00:12:57 -0800 I forgot to mention that this is also causing a regression in the caret browsing, bug 25676, which btw is not fixed with the modification I've uploaded and fixes this problem, I would try to check the rationale of the loops of the original patch that is causing the problems. 171803 3 44862 alex 2009-12-15 04:09:54 -0800 Created attachment 44862 New proposed patch This patch fixes both regressions and does not break any of the editing tests. I'm going to create two patches with test to show the problems because we need reference about the change in that logic. I also have to create a new test function to set the caret browsing from tests. 172266 4 44965 alex 2009-12-16 05:50:39 -0800 Created attachment 44965 Proposed patch This patch solves this regression, I've added a test to check it. I'll upload the patch fixing the other regression to the bug 25676. 172269 5 webkit.review.bot 2009-12-16 05:55:58 -0800 style-queue ran check-webkit-style on attachment 44965 without any errors. 172306 6 ap 2009-12-16 08:50:03 -0800 When adding a pixel test, please include pixel results in the patch. But the included test can (and should) be text-only: if (window.layoutTestController) layoutTestController.dumpAsText(); > Not sure if it is a good option because the patch breaks some > tests, but just because of the log message Please include changed test results in the patch - it's hard to tell if it's an OK change without seeing it. 172330 7 44965 darin 2009-12-16 09:28:12 -0800 Comment on attachment 44965 Proposed patch r=me I don't se how this test case tests the bug. Does the test fail without the patch? While I think the test works as a manual test, I don't think it's effective as an automated test. 172332 8 44965 darin 2009-12-16 09:29:16 -0800 Comment on attachment 44965 Proposed patch Changing to review- because of the incomplete test in the patch. This patch includes test results only for the gtk platform and does not include pixel test results. 172348 9 alex 2009-12-16 09:52:09 -0800 (In reply to comment #8) > (From update of attachment 44965 [details]) > Changing to review- because of the incomplete test in the patch. > > This patch includes test results only for the gtk platform and does not include > pixel test results. The test fails without the patch because the caret position does not reach the one specified in the expected result, if you check it manually it means the caret stays in the first position of the first line. The test uses exactly the same technique as the editing/selection/wrapped-line-caret-2.html. Maybe I can try to avoid it using getSelection().baseOffset and getting the position of the cursor, that way I could use dumpAsText, would that be ok? 172351 10 alex 2009-12-16 09:53:16 -0800 (In reply to comment #9) > (In reply to comment #8) > > (From update of attachment 44965 [details] [details]) > > Changing to review- because of the incomplete test in the patch. > > > > This patch includes test results only for the gtk platform and does not include > > pixel test results. > > The test fails without the patch because the caret position does not reach the > one specified in the expected result, if you check it manually it means the > caret stays in the first position of the first line. ^^^ I meant, second line 172364 11 ap 2009-12-16 10:07:13 -0800 > Maybe I can try to avoid it using > getSelection().baseOffset and getting the position of the cursor, that way I > could use dumpAsText, would that be ok? I was going to say yes, but looking at bug 13736 comment 19, I'm no longer sure. If you can make a text-only test case that fails before your fix and passes with it, it would definitely be much better than a pixel test. 172395 12 44992 alex 2009-12-16 10:46:37 -0800 Created attachment 44992 Proposed fix patch This one uses dumpAsText and checks the position of the caret. I fails before the patch and passes after it. 172397 13 44992 darin 2009-12-16 10:48:54 -0800 Comment on attachment 44992 Proposed fix patch > + * platform/gtk/editing/selection/wrapped-line-caret-3-expected.txt: This is the wrong path for the added file now. r=me -- the minor mistake in ChangeLog is no big deal 172398 14 44993 alex 2009-12-16 10:49:23 -0800 Created attachment 44993 Proposed fix Small fix in the paths of the Changelog. 173072 15 alex 2009-12-18 01:36:25 -0800 There is another patch that fixes another regression caused by the same patch in the bug 25676, could someone check it? 173074 16 44993 xan.lopez 2009-12-18 01:38:33 -0800 Comment on attachment 44993 Proposed fix Set cq+ 173076 17 44993 commit-queue 2009-12-18 01:50:35 -0800 Comment on attachment 44993 Proposed fix Clearing flags on attachment: 44993 Committed r52303: <http://trac.webkit.org/changeset/52303> 173077 18 commit-queue 2009-12-18 01:50:41 -0800 All reviewed patches have been landed. Closing bug. 43928 2009-11-26 11:38:25 -0800 2009-12-15 04:09:54 -0800 Patch fixing the problem up_arrow_affinity.patch text/plain 524 alex ZGlmZiAtLWdpdCBhL1dlYkNvcmUvZWRpdGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNwcCBiL1dl YkNvcmUvZWRpdGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNwcAppbmRleCBhZjg5Y2NiLi42Mzg2 NGUwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2VkaXRpbmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHAK KysrIGIvV2ViQ29yZS9lZGl0aW5nL1NlbGVjdGlvbkNvbnRyb2xsZXIuY3BwCkBAIC01OTcsNiAr NTk3LDcgQEAgYm9vbCBTZWxlY3Rpb25Db250cm9sbGVyOjptb2RpZnkoRUFsdGVyYXRpb24gYWx0 ZXIsIEVEaXJlY3Rpb24gZGlyLCBUZXh0R3JhbnVsYXIKICAgICAgICAgICAgICAgICBwb3MgPSBt b2RpZnlFeHRlbmRpbmdCYWNrd2FyZChncmFudWxhcml0eSk7CiAgICAgICAgICAgICBlbHNlCiAg ICAgICAgICAgICAgICAgcG9zID0gbW9kaWZ5TW92aW5nQmFja3dhcmQoZ3JhbnVsYXJpdHkpOwor ICAgICAgICAgICAgcG9zLnNldEFmZmluaXR5KFVQU1RSRUFNKTsKICAgICAgICAgICAgIGJyZWFr OwogICAgIH0KIAo= 44862 2009-12-15 04:09:54 -0800 2009-12-16 05:50:39 -0800 New proposed patch caret_browsing.patch text/plain 1336 alex ZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcCBiL1dlYkNvcmUvZG9tL1Bvc2l0 aW9uLmNwcAppbmRleCAwZmY4MjYyLi5kNTU3ZTFiIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Q b3NpdGlvbi5jcHAKKysrIGIvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCkBAIC0xMDM1LDcgKzEw MzUsNyBAQCB2b2lkIFBvc2l0aW9uOjpnZXRJbmxpbmVCb3hBbmRPZmZzZXQoRUFmZmluaXR5IGFm ZmluaXR5LCBUZXh0RGlyZWN0aW9uIHByaW1hcnlEaQogCiAgICAgICAgICAgICBjYW5kaWRhdGUg PSBib3g7CiAgICAgICAgIH0KLSAgICAgICAgaWYgKGNhbmRpZGF0ZSAmJiAhYm94ICYmIGFmZmlu aXR5ID09IERPV05TVFJFQU0pIHsKKyAgICAgICAgaWYgKGNhbmRpZGF0ZSAmJiAhYm94ICYmIGFm ZmluaXR5ID09IERPV05TVFJFQU0gJiYgY2FuZGlkYXRlID09IHRleHRSZW5kZXJlci0+bGFzdFRl eHRCb3goKSkgewogICAgICAgICAgICAgYm94ID0gc2VhcmNoQWhlYWRGb3JCZXR0ZXJNYXRjaCh0 ZXh0UmVuZGVyZXIpOwogICAgICAgICAgICAgaWYgKGJveCkKICAgICAgICAgICAgICAgICBjYXJl dE9mZnNldCA9IGJveC0+Y2FyZXRNaW5PZmZzZXQoKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRleHQuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAK aW5kZXggOTVhYTI3Ny4uMzdjMzVlOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGV4dC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAKQEAgLTMz OCw3ICszMzgsNyBAQCBWaXNpYmxlUG9zaXRpb24gUmVuZGVyVGV4dDo6cG9zaXRpb25Gb3JQb2lu dChjb25zdCBJbnRQb2ludCYgcG9pbnQpCiAgICAgICAgIC8vIGF0IHRoZSB5IGNvb3JkaW5hdGUg b2YgdGhlIGxhc3QgbGluZSBvciBiZWxvdwogICAgICAgICAvLyBhbmQgdGhlIHggY29vcmRpbmF0 ZSBpcyB0byB0aGUgcmlnaHQgb2YgdGhlIGxhc3QgdGV4dCBib3ggcmlnaHQgZWRnZQogICAgICAg ICBvZmZzZXQgPSBsYXN0VGV4dEJveCgpLT5vZmZzZXRGb3JQb3NpdGlvbihwb2ludC54KCkpOwot ICAgICAgICByZXR1cm4gY3JlYXRlVmlzaWJsZVBvc2l0aW9uKG9mZnNldCArIGxhc3RUZXh0Qm94 KCktPnN0YXJ0KCksIERPV05TVFJFQU0pOworICAgICAgICByZXR1cm4gY3JlYXRlVmlzaWJsZVBv c2l0aW9uKG9mZnNldCArIGxhc3RUZXh0Qm94KCktPnN0YXJ0KCksIG9mZnNldCA+IDAgPyBWUF9V UFNUUkVBTV9JRl9QT1NTSUJMRSA6IERPV05TVFJFQU0pOwogICAgIH0KIAogICAgIElubGluZVRl eHRCb3gqIGxhc3RCb3hBYm92ZSA9IDA7Cg== 44965 2009-12-16 05:50:39 -0800 2009-12-16 10:46:37 -0800 Proposed patch upstream_affinity.patch text/plain 4356 alex ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkYTgyMjU5Li45YWQwMzBmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MTYgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTiAocjM4ODk4KTog VXNpbmcgdGhlIHVwIGFycm93IGluIGEgdGV4dGFyZWEgZ2V0cyAic3R1Y2siCisgICAgICAgIGF0 IHRoZSBiZWdpbm5pbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zMTkyMAorCisgICAgICAgIEFkZGVkIHRlc3Qgc2hvd2luZyB0aGUgcHJvYmxlbSBk ZXNjcmliZWQgaW4gdGhlIGJ1Zy4KKworICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL3dyYXBw ZWQtbGluZS1jYXJldC0zLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vZ3RrL2VkaXRpbmcvc2Vs ZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0zLWV4cGVjdGVkLnR4dDoKKwogMjAwOS0xMi0xMyAg Um9sYW5kIFN0ZWluZXIgIDxyb2xhbmRzdGVpbmVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9z ZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTMuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcv c2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0zLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMC4uZmM1NDFhZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Vk aXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0zLmh0bWwKQEAgLTAsMCArMSw5IEBA Cis8c3Bhbj5UaGlzIHRlc3QgcGFzc2VzIGlmIHRoZSBjYXJldCBpcyBhdCB0aGUgc3RhcnQgb2Yg dGhlIGZpcnN0IGxpbmUuPC9zcGFuPgorCis8ZGl2IGlkPSJlZGl0IiBjb250ZW50RWRpdGFibGU9 InRydWUiIHN0eWxlPSJ3aWR0aDogMzUwcHg7IGhlaWdodDogMTAwcHg7IGJvcmRlcjogMXB4IHNv bGlkIGJsdWU7Ij5hJm5ic3A7PHNwYW4gc3R5bGU9Y29sb3I6Ymx1ZTsiPnh4eHh4eHh4eHh4eHh4 eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHg8L3NwYW4+PC9kaXY+Cis8c2NyaXB0PgordmFy IGVkaXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZWRpdCIpOword2luZG93LmdldFNlbGVj dGlvbigpLnNldFBvc2l0aW9uKGVkaXQuY2hpbGROb2Rlcy5pdGVtKDEpLmNoaWxkTm9kZXMuaXRl bSgwKSwgMik7Cit3aW5kb3cuZ2V0U2VsZWN0aW9uKCkubW9kaWZ5KCJtb3ZlIiwgImJhY2t3YXJk IiwgImxpbmUiKTsKK3dpbmRvdy5nZXRTZWxlY3Rpb24oKS5tb2RpZnkoIm1vdmUiLCAiYmFja3dh cmQiLCAibGluZSIpOworPC9zY3JpcHQ+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvZWRpdGluZy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTMtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2VkaXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQtbGlu ZS1jYXJldC0zLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw Li5mZTBkZGJlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Vk aXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0zLWV4cGVjdGVkLnR4dApAQCAtMCww ICsxLDE4IEBACitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAo MCwwKSBzaXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJC bG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgICAgUmVuZGVyQm9keSB7Qk9EWX0g YXQgKDgsOCkgc2l6ZSA3ODR4NTg0CisgICAgICBSZW5kZXJCbG9jayAoYW5vbnltb3VzKSBhdCAo MCwwKSBzaXplIDc4NHgyMAorICAgICAgICBSZW5kZXJJbmxpbmUge1NQQU59IGF0ICgwLDApIHNp emUgMzQ4eDIwCisgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMzQ4 eDIwCisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAzNDg6ICJUaGlzIHRlc3Qg cGFzc2VzIGlmIHRoZSBjYXJldCBpcyBhdCB0aGUgc3RhcnQgb2YgdGhlIGZpcnN0IGxpbmUuIgor ICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAweDAKKyAgICAgIFJlbmRl ckJsb2NrIHtESVZ9IGF0ICgwLDIwKSBzaXplIDM1MngxMDIgW2JvcmRlcjogKDFweCBzb2xpZCAj MDAwMEZGKV0KKyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgxLDEpIHNpemUgMTF4MjAK KyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMSwxKSB3aWR0aCA3OiAiYSIKKyAgICAgICAgICB0ZXh0 IHJ1biBhdCAoOCwxKSB3aWR0aCA0OiAiICIKKyAgICAgICAgUmVuZGVySW5saW5lIHtTUEFOfSBh dCAoMCwwKSBzaXplIDM0NHgyMCBbY29sb3I9IzAwMDBGRl0KKyAgICAgICAgICBSZW5kZXJUZXh0 IHsjdGV4dH0gYXQgKDEsMjEpIHNpemUgMzQ0eDIwCisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAo MSwyMSkgd2lkdGggMzQ0OiAieHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4 eHh4eCIKK2NhcmV0OiBwb3NpdGlvbiAwIG9mIGNoaWxkIDAgeyN0ZXh0fSBvZiBjaGlsZCAyIHtE SVZ9IG9mIGNoaWxkIDEge0JPRFl9IG9mIGNoaWxkIDAge0hUTUx9IG9mIGRvY3VtZW50CmRpZmYg LS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGU2YTJh NGIuLjM4ODg5OWMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMTItMTYgIEFsZWphbmRybyBHLiBDYXN0 cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUkVHUkVTU0lPTiAocjM4ODk4KTogVXNpbmcgdGhlIHVwIGFycm93IGlu IGEgdGV4dGFyZWEgZ2V0cyAic3R1Y2siCisgICAgICAgIGF0IHRoZSBiZWdpbm5pbmcuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTkyMAorCisgICAg ICAgIE1vdmluZyB1cCBmcm9tIGEgcG9zaXRpb24gYWZ0ZXIgdGhlIGVuZCBvZiB0aGUgcHJldmlv dXMgbGluZXMKKyAgICAgICAgc2hvdWxkIHVzZSBVUFNUUkVBTSBhZmZpbml0eSB0byByZW5kZXIg dGhlIGNhcmV0IGluIHRoZSBwcmV2aW91cworICAgICAgICBsaW5lLgorCisgICAgICAgIFRlc3Q6 IGVkaXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0zLmh0bWwKKworICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJUZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRleHQ6 OnBvc2l0aW9uRm9yUG9pbnQpOgorCiAyMDA5LTEyLTEzICBSb2xhbmQgU3RlaW5lciAgPHJvbGFu ZHN0ZWluZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGgu CmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcCBiL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRleHQuY3BwCmluZGV4IDk1YWEyNzcuLjVmZTRkNjQgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRleHQuY3BwCkBAIC0zMzgsNyArMzM4LDcgQEAgVmlzaWJsZVBvc2l0aW9uIFJl bmRlclRleHQ6OnBvc2l0aW9uRm9yUG9pbnQoY29uc3QgSW50UG9pbnQmIHBvaW50KQogICAgICAg ICAvLyBhdCB0aGUgeSBjb29yZGluYXRlIG9mIHRoZSBsYXN0IGxpbmUgb3IgYmVsb3cKICAgICAg ICAgLy8gYW5kIHRoZSB4IGNvb3JkaW5hdGUgaXMgdG8gdGhlIHJpZ2h0IG9mIHRoZSBsYXN0IHRl eHQgYm94IHJpZ2h0IGVkZ2UKICAgICAgICAgb2Zmc2V0ID0gbGFzdFRleHRCb3goKS0+b2Zmc2V0 Rm9yUG9zaXRpb24ocG9pbnQueCgpKTsKLSAgICAgICAgcmV0dXJuIGNyZWF0ZVZpc2libGVQb3Np dGlvbihvZmZzZXQgKyBsYXN0VGV4dEJveCgpLT5zdGFydCgpLCBET1dOU1RSRUFNKTsKKyAgICAg ICAgcmV0dXJuIGNyZWF0ZVZpc2libGVQb3NpdGlvbihvZmZzZXQgKyBsYXN0VGV4dEJveCgpLT5z dGFydCgpLCBWUF9VUFNUUkVBTV9JRl9QT1NTSUJMRSk7CiAgICAgfQogCiAgICAgSW5saW5lVGV4 dEJveCogbGFzdEJveEFib3ZlID0gMDsK 44992 2009-12-16 10:46:37 -0800 2009-12-16 10:49:23 -0800 Proposed fix patch upstream_affinity.patch text/plain 3622 alex ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkYTgyMjU5Li45YWQwMzBmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MTYgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTiAocjM4ODk4KTog VXNpbmcgdGhlIHVwIGFycm93IGluIGEgdGV4dGFyZWEgZ2V0cyAic3R1Y2siCisgICAgICAgIGF0 IHRoZSBiZWdpbm5pbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zMTkyMAorCisgICAgICAgIEFkZGVkIHRlc3Qgc2hvd2luZyB0aGUgcHJvYmxlbSBk ZXNjcmliZWQgaW4gdGhlIGJ1Zy4KKworICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL3dyYXBw ZWQtbGluZS1jYXJldC0zLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vZ3RrL2VkaXRpbmcvc2Vs ZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0zLWV4cGVjdGVkLnR4dDoKKwogMjAwOS0xMi0xMyAg Um9sYW5kIFN0ZWluZXIgIDxyb2xhbmRzdGVpbmVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9z ZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZWRpdGluZy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTMtZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmE0ZjE5ZWMKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMy1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSw0IEBACitUaGlzIHRlc3QgcGFzc2VzIGlmIHRoZSBjYXJldCBp cyBhdCB0aGUgc3RhcnQgb2YgdGhlIGZpcnN0IGxpbmUuCitQQVNTCisKK2EgeHh4eHh4eHh4eHh4 eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZWRpdGluZy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTMuaHRtbCBiL0xheW91dFRlc3Rz L2VkaXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0zLmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZDZhNzc1YgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0zLmh0bWwKQEAgLTAs MCArMSwxNyBAQAorPHNwYW4+VGhpcyB0ZXN0IHBhc3NlcyBpZiB0aGUgY2FyZXQgaXMgYXQgdGhl IHN0YXJ0IG9mIHRoZSBmaXJzdCBsaW5lLjwvc3Bhbj4KKworPHAgaWQ9InJlc3VsdCI+PC9wPgor Cis8ZGl2IGlkPSJlZGl0IiBjb250ZW50RWRpdGFibGU9InRydWUiIHN0eWxlPSJ3aWR0aDogMzUw cHg7IGhlaWdodDogMTAwcHg7IGJvcmRlcjogMXB4IHNvbGlkIGJsdWU7Ij5hIDxzcGFuIHN0eWxl PWNvbG9yOmJsdWU7Ij54eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4 PC9zcGFuPjwvZGl2PgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCit2YXIgZWRpdCA9IGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJlZGl0Iik7Cit3aW5kb3cuZ2V0U2VsZWN0aW9uKCkuc2V0 UG9zaXRpb24oZWRpdC5jaGlsZE5vZGVzLml0ZW0oMSkuY2hpbGROb2Rlcy5pdGVtKDApLCAyKTsK K3dpbmRvdy5nZXRTZWxlY3Rpb24oKS5tb2RpZnkoIm1vdmUiLCAiYmFja3dhcmQiLCAibGluZSIp Oword2luZG93LmdldFNlbGVjdGlvbigpLm1vZGlmeSgibW92ZSIsICJiYWNrd2FyZCIsICJsaW5l Iik7CisKK2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lclRleHQgPSBnZXRT ZWxlY3Rpb24oKS5iYXNlT2Zmc2V0ID09IDAgPyAiUEFTUyIgOiAiRkFJTCI7CisKKzwvc2NyaXB0 PgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBlNmEyYTRiLi4zODg4OTljIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDA5LTEyLTE2ICBBbGVqYW5kcm8g Ry4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04gKHIzODg5OCk6IFVzaW5nIHRoZSB1cCBh cnJvdyBpbiBhIHRleHRhcmVhIGdldHMgInN0dWNrIgorICAgICAgICBhdCB0aGUgYmVnaW5uaW5n LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE5MjAK KworICAgICAgICBNb3ZpbmcgdXAgZnJvbSBhIHBvc2l0aW9uIGFmdGVyIHRoZSBlbmQgb2YgdGhl IHByZXZpb3VzIGxpbmVzCisgICAgICAgIHNob3VsZCB1c2UgVVBTVFJFQU0gYWZmaW5pdHkgdG8g cmVuZGVyIHRoZSBjYXJldCBpbiB0aGUgcHJldmlvdXMKKyAgICAgICAgbGluZS4KKworICAgICAg ICBUZXN0OiBlZGl0aW5nL3NlbGVjdGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMy5odG1sCisKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJUZXh0Ojpwb3NpdGlvbkZvclBvaW50KToKKwogMjAwOS0xMi0xMyAgUm9sYW5kIFN0ZWluZXIg IDxyb2xhbmRzdGVpbmVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFt IEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAgYi9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcAppbmRleCA5NWFhMjc3Li41ZmU0ZDY0IDEw MDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcAorKysgYi9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcApAQCAtMzM4LDcgKzMzOCw3IEBAIFZpc2libGVQb3Np dGlvbiBSZW5kZXJUZXh0Ojpwb3NpdGlvbkZvclBvaW50KGNvbnN0IEludFBvaW50JiBwb2ludCkK ICAgICAgICAgLy8gYXQgdGhlIHkgY29vcmRpbmF0ZSBvZiB0aGUgbGFzdCBsaW5lIG9yIGJlbG93 CiAgICAgICAgIC8vIGFuZCB0aGUgeCBjb29yZGluYXRlIGlzIHRvIHRoZSByaWdodCBvZiB0aGUg bGFzdCB0ZXh0IGJveCByaWdodCBlZGdlCiAgICAgICAgIG9mZnNldCA9IGxhc3RUZXh0Qm94KCkt Pm9mZnNldEZvclBvc2l0aW9uKHBvaW50LngoKSk7Ci0gICAgICAgIHJldHVybiBjcmVhdGVWaXNp YmxlUG9zaXRpb24ob2Zmc2V0ICsgbGFzdFRleHRCb3goKS0+c3RhcnQoKSwgRE9XTlNUUkVBTSk7 CisgICAgICAgIHJldHVybiBjcmVhdGVWaXNpYmxlUG9zaXRpb24ob2Zmc2V0ICsgbGFzdFRleHRC b3goKS0+c3RhcnQoKSwgVlBfVVBTVFJFQU1fSUZfUE9TU0lCTEUpOwogICAgIH0KIAogICAgIElu bGluZVRleHRCb3gqIGxhc3RCb3hBYm92ZSA9IDA7Cg== 44993 2009-12-16 10:49:23 -0800 2009-12-18 01:50:34 -0800 Proposed fix upstream_affinity.patch text/plain 3609 alex ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkYTgyMjU5Li44Y2Q1MWExIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MTYgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTiAocjM4ODk4KTog VXNpbmcgdGhlIHVwIGFycm93IGluIGEgdGV4dGFyZWEgZ2V0cyAic3R1Y2siCisgICAgICAgIGF0 IHRoZSBiZWdpbm5pbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zMTkyMAorCisgICAgICAgIEFkZGVkIHRlc3Qgc2hvd2luZyB0aGUgcHJvYmxlbSBk ZXNjcmliZWQgaW4gdGhlIGJ1Zy4KKworICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL3dyYXBw ZWQtbGluZS1jYXJldC0zLmh0bWw6CisgICAgICAgICogZWRpdGluZy9zZWxlY3Rpb24vd3JhcHBl ZC1saW5lLWNhcmV0LTMtZXhwZWN0ZWQudHh0OgorCiAyMDA5LTEyLTEzICBSb2xhbmQgU3RlaW5l ciAgPHJvbGFuZHN0ZWluZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFk YW0gQmFydGguCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi93cmFw cGVkLWxpbmUtY2FyZXQtMy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVj dGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMC4uYTRmMTllYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2VkaXRpbmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0zLWV4cGVjdGVkLnR4dApAQCAt MCwwICsxLDQgQEAKK1RoaXMgdGVzdCBwYXNzZXMgaWYgdGhlIGNhcmV0IGlzIGF0IHRoZSBzdGFy dCBvZiB0aGUgZmlyc3QgbGluZS4KK1BBU1MKKworYSB4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4 eHh4eHh4eHh4eHh4eHh4eHh4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVj dGlvbi93cmFwcGVkLWxpbmUtY2FyZXQtMy5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxl Y3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwLi5kNmE3NzViCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGlu Zy9zZWxlY3Rpb24vd3JhcHBlZC1saW5lLWNhcmV0LTMuaHRtbApAQCAtMCwwICsxLDE3IEBACis8 c3Bhbj5UaGlzIHRlc3QgcGFzc2VzIGlmIHRoZSBjYXJldCBpcyBhdCB0aGUgc3RhcnQgb2YgdGhl IGZpcnN0IGxpbmUuPC9zcGFuPgorCis8cCBpZD0icmVzdWx0Ij48L3A+CisKKzxkaXYgaWQ9ImVk aXQiIGNvbnRlbnRFZGl0YWJsZT0idHJ1ZSIgc3R5bGU9IndpZHRoOiAzNTBweDsgaGVpZ2h0OiAx MDBweDsgYm9yZGVyOiAxcHggc29saWQgYmx1ZTsiPmEgPHNwYW4gc3R5bGU9Y29sb3I6Ymx1ZTsi Pnh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHg8L3NwYW4+PC9kaXY+ Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKK3ZhciBlZGl0ID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoImVkaXQiKTsKK3dpbmRvdy5nZXRTZWxlY3Rpb24oKS5zZXRQb3NpdGlvbihlZGl0 LmNoaWxkTm9kZXMuaXRlbSgxKS5jaGlsZE5vZGVzLml0ZW0oMCksIDIpOword2luZG93LmdldFNl bGVjdGlvbigpLm1vZGlmeSgibW92ZSIsICJiYWNrd2FyZCIsICJsaW5lIik7Cit3aW5kb3cuZ2V0 U2VsZWN0aW9uKCkubW9kaWZ5KCJtb3ZlIiwgImJhY2t3YXJkIiwgImxpbmUiKTsKKworZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLmlubmVyVGV4dCA9IGdldFNlbGVjdGlvbigpLmJh c2VPZmZzZXQgPT0gMCA/ICJQQVNTIiA6ICJGQUlMIjsKKworPC9zY3JpcHQ+CmRpZmYgLS1naXQg YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGU2YTJhNGIuLjM4 ODg5OWMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMTItMTYgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxh bGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUkVHUkVTU0lPTiAocjM4ODk4KTogVXNpbmcgdGhlIHVwIGFycm93IGluIGEgdGV4 dGFyZWEgZ2V0cyAic3R1Y2siCisgICAgICAgIGF0IHRoZSBiZWdpbm5pbmcuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTkyMAorCisgICAgICAgIE1v dmluZyB1cCBmcm9tIGEgcG9zaXRpb24gYWZ0ZXIgdGhlIGVuZCBvZiB0aGUgcHJldmlvdXMgbGlu ZXMKKyAgICAgICAgc2hvdWxkIHVzZSBVUFNUUkVBTSBhZmZpbml0eSB0byByZW5kZXIgdGhlIGNh cmV0IGluIHRoZSBwcmV2aW91cworICAgICAgICBsaW5lLgorCisgICAgICAgIFRlc3Q6IGVkaXRp bmcvc2VsZWN0aW9uL3dyYXBwZWQtbGluZS1jYXJldC0zLmh0bWwKKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJUZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRleHQ6OnBvc2l0 aW9uRm9yUG9pbnQpOgorCiAyMDA5LTEyLTEzICBSb2xhbmQgU3RlaW5lciAgPHJvbGFuZHN0ZWlu ZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYg LS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcCBiL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRleHQuY3BwCmluZGV4IDk1YWEyNzcuLjVmZTRkNjQgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRleHQuY3BwCkBAIC0zMzgsNyArMzM4LDcgQEAgVmlzaWJsZVBvc2l0aW9uIFJlbmRlclRl eHQ6OnBvc2l0aW9uRm9yUG9pbnQoY29uc3QgSW50UG9pbnQmIHBvaW50KQogICAgICAgICAvLyBh dCB0aGUgeSBjb29yZGluYXRlIG9mIHRoZSBsYXN0IGxpbmUgb3IgYmVsb3cKICAgICAgICAgLy8g YW5kIHRoZSB4IGNvb3JkaW5hdGUgaXMgdG8gdGhlIHJpZ2h0IG9mIHRoZSBsYXN0IHRleHQgYm94 IHJpZ2h0IGVkZ2UKICAgICAgICAgb2Zmc2V0ID0gbGFzdFRleHRCb3goKS0+b2Zmc2V0Rm9yUG9z aXRpb24ocG9pbnQueCgpKTsKLSAgICAgICAgcmV0dXJuIGNyZWF0ZVZpc2libGVQb3NpdGlvbihv ZmZzZXQgKyBsYXN0VGV4dEJveCgpLT5zdGFydCgpLCBET1dOU1RSRUFNKTsKKyAgICAgICAgcmV0 dXJuIGNyZWF0ZVZpc2libGVQb3NpdGlvbihvZmZzZXQgKyBsYXN0VGV4dEJveCgpLT5zdGFydCgp LCBWUF9VUFNUUkVBTV9JRl9QT1NTSUJMRSk7CiAgICAgfQogCiAgICAgSW5saW5lVGV4dEJveCog bGFzdEJveEFib3ZlID0gMDsK