31773 2009-11-21 14:34:37 -0800 [Symbian] Fix lastIndexOf() for Symbian 2009-11-24 00:34:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC S60 3rd edition RESOLVED FIXED Qt P2 Normal --- 1 laszlo.gombos webkit-unassigned hausmann koshuin oldest_to_newest 165653 0 laszlo.gombos 2009-11-21 14:34:37 -0800 Symbian soft floating point library has problems with operators comparing NAN to numbers. Without a workaround lastIndexOf() function does not work. 165654 1 43657 laszlo.gombos 2009-11-21 14:40:16 -0800 Created attachment 43657 Add an extra test to check for NAN. 165655 2 43658 laszlo.gombos 2009-11-21 14:56:19 -0800 Created attachment 43658 Give credits to David Leong. 165714 3 43658 commit-queue 2009-11-22 07:07:56 -0800 Comment on attachment 43658 Give credits to David Leong. Rejecting patch 43658 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11652 test cases. inspector/console-format.html -> crashed Exiting early after 1 failures. 9346 tests run. 465.10s total testing time 9345 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output 165725 4 hausmann 2009-11-22 09:14:12 -0800 Does this happens with the x86 toolchain as well as rvct? Does it only apply to builds that use software emulation for floating point operations or also for vfp builds? What about other places in the source code where we do similar things? What are the chances of getting this fixed upstream? (I'm okay with the workaround, I'm just curious about the background :) 165822 5 hausmann 2009-11-23 05:02:41 -0800 Committed r51307: <http://trac.webkit.org/changeset/51307> 165823 6 hausmann 2009-11-23 05:06:56 -0800 Cherry-picked into qtwebkit-4.6 as commit efa69b6181ce5c045097351cdcf6c158da3f4888 165977 7 43658 eric 2009-11-23 19:55:38 -0800 Comment on attachment 43658 Give credits to David Leong. Sorry, this was a false rejection due to bug 31817. 166015 8 koshuin 2009-11-24 00:24:46 -0800 Meh... http://bugreports.qt.nokia.com/browse/QTBUG-4621 This is Open C bug where NaN is a Number (check the pure Open C test case) and must be fixed there instead. 166016 9 hausmann 2009-11-24 00:34:25 -0800 (In reply to comment #8) > Meh... > http://bugreports.qt.nokia.com/browse/QTBUG-4621 > > This is Open C bug where NaN is a Number (check the pure Open C test case) and > must be fixed there instead. Ironically the workaround for this bug is to call isnan() ;-) 43657 2009-11-21 14:40:16 -0800 2009-11-21 14:56:19 -0800 Add an extra test to check for NAN. 31773.patch text/plain 1447 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxMjg3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMTEtMjEgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtTeW1iaWFuXSBGaXggbGFzdEluZGV4T2YoKSBm b3IgU3ltYmlhbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzE3NzMKKworICAgICAgICBTeW1iaWFuIHNvZnQgZmxvYXRpbmcgcG9pbnQgbGlicmFyeSBo YXMgcHJvYmxlbXMgd2l0aCBvcGVyYXRvcnMKKyAgICAgICAgY29tcGFyaW5nIE5hTiB0byBudW1i ZXJzLiBXaXRob3V0IGEgd29ya2Fyb3VuZCBsYXN0SW5kZXhPZigpIAorICAgICAgICBmdW5jdGlv biBkb2VzIG5vdCB3b3JrLgorCisgICAgICAgICogcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3Bw OgorICAgICAgICAoSlNDOjpzdHJpbmdQcm90b0Z1bmNMYXN0SW5kZXhPZik6QWRkIGFuIGV4dHJh IHRlc3QgCisgICAgICAgIHRvIGNoZWNrIGZvciBOYU4gZm9yIFN5bWJpYW4uCisKIDIwMDktMTEt MTkgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgogCiAgICAgICAgIEFuZHJv aWQgcG9ydCBsYWNrcyBjb25maWd1cmF0aW9uIGluIFBsYXRmb3JtLmggYW5kIGNvbmZpZy5oLgpJ bmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAkocmV2aXNp b24gNTEyODcpCisrKyBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQ2OSw2ICs0NjksMTEgQEAgSlNWYWx1ZSBKU0NfSE9TVF9DQUxM IHN0cmluZ1Byb3RvRnVuY0xhcwogICAgICAgICBkcG9zID0gMDsKICAgICBlbHNlIGlmICghKGRw b3MgPD0gbGVuKSkgLy8gdHJ1ZSBmb3IgTmFOCiAgICAgICAgIGRwb3MgPSBsZW47CisjaWYgUExB VEZPUk0oU1lNQklBTikKKyAgICAvLyBXb3JrIGFyb3VuZCBmb3IgYnJva2VuIE5hTiBjb21wYXJl IG9wZXJhdG9yCisgICAgZWxzZSBpZiAoaXNuYW4oZHBvcykpCisgICAgICAgIGRwb3MgPSBsZW47 CisjZW5kaWYKICAgICByZXR1cm4ganNOdW1iZXIoZXhlYywgcy5yZmluZCh1Miwgc3RhdGljX2Nh c3Q8aW50PihkcG9zKSkpOwogfQogCg== 43658 2009-11-21 14:56:19 -0800 2009-11-23 19:55:38 -0800 Give credits to David Leong. 31773.patch text/plain 1490 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxMjg3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMTEtMjEgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtTeW1iaWFuXSBGaXggbGFzdEluZGV4T2YoKSBm b3IgU3ltYmlhbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzE3NzMKKworICAgICAgICBTeW1iaWFuIHNvZnQgZmxvYXRpbmcgcG9pbnQgbGlicmFyeSBo YXMgcHJvYmxlbXMgd2l0aCBvcGVyYXRvcnMKKyAgICAgICAgY29tcGFyaW5nIE5hTiB0byBudW1i ZXJzLiBXaXRob3V0IGEgd29ya2Fyb3VuZCBsYXN0SW5kZXhPZigpIAorICAgICAgICBmdW5jdGlv biBkb2VzIG5vdCB3b3JrLgorCisgICAgICAgIFBhdGNoIGRldmVsb3BlZCBieSBEYXZpZCBMZW9u Zy4KKworICAgICAgICAqIHJ1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpT Qzo6c3RyaW5nUHJvdG9GdW5jTGFzdEluZGV4T2YpOkFkZCBhbiBleHRyYSB0ZXN0IAorICAgICAg ICB0byBjaGVjayBmb3IgTmFOIGZvciBTeW1iaWFuLgorCiAyMDA5LTExLTE5ICBTdGV2ZSBCbG9j ayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAgICBBbmRyb2lkIHBvcnQgbGFja3Mg Y29uZmlndXJhdGlvbiBpbiBQbGF0Zm9ybS5oIGFuZCBjb25maWcuaC4KSW5kZXg6IEphdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAJKHJldmlzaW9uIDUxMjg3KQorKysg SmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00NjksNiArNDY5LDExIEBAIEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBzdHJpbmdQcm90b0Z1 bmNMYXMKICAgICAgICAgZHBvcyA9IDA7CiAgICAgZWxzZSBpZiAoIShkcG9zIDw9IGxlbikpIC8v IHRydWUgZm9yIE5hTgogICAgICAgICBkcG9zID0gbGVuOworI2lmIFBMQVRGT1JNKFNZTUJJQU4p CisgICAgLy8gV29yayBhcm91bmQgZm9yIGJyb2tlbiBOYU4gY29tcGFyZSBvcGVyYXRvcgorICAg IGVsc2UgaWYgKGlzbmFuKGRwb3MpKQorICAgICAgICBkcG9zID0gbGVuOworI2VuZGlmCiAgICAg cmV0dXJuIGpzTnVtYmVyKGV4ZWMsIHMucmZpbmQodTIsIHN0YXRpY19jYXN0PGludD4oZHBvcykp KTsKIH0KIAo=