<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>31670</bug_id>
          
          <creation_ts>2009-11-19 08:56:57 -0800</creation_ts>
          <short_desc>[Qt] Remove the definition of WTF_CHANGES guards from the build system</short_desc>
          <delta_ts>2010-03-28 14:46:55 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>35784</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Laszlo Gombos">laszlo.gombos</reporter>
          <assigned_to name="QtWebKit Unassigned">webkit-qt-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>hausmann</cc>
    
    <cc>kent.hansen</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>164991</commentid>
    <comment_count>0</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-11-19 08:56:57 -0800</bug_when>
    <thetext>Both HAVE(STDINT_H) and WTF_CHANGES are only used within WTF and WTF (code under JavaScriptCode/wtf) expect these to be defined, yet these guards are defined in WebCore and JavaScriptCore config.h files and in a few cases port specific makefiles.

As WTF does not build without these flags and these flags are only used (at the moment) within WTF I think it make sense to move them to wtf/Platfrom.h.

Patch will follow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164992</commentid>
    <comment_count>1</comment_count>
      <attachid>43510</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-11-19 09:04:10 -0800</bug_when>
    <thetext>Created attachment 43510
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>164993</commentid>
    <comment_count>2</comment_count>
      <attachid>43511</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-11-19 09:05:32 -0800</bug_when>
    <thetext>Created attachment 43511
fix typo - s/sett/set</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>165029</commentid>
    <comment_count>3</comment_count>
      <attachid>43511</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-11-19 11:15:34 -0800</bug_when>
    <thetext>Comment on attachment 43511
fix typo - s/sett/set

It&apos;s good to get rid of all the duplication. But this is a step in the wrong direction as far as what Platform.h is supposed to be. It&apos;s clearly wrong to define a platform-independent thing such as WTF_CHANGES in there.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>165565</commentid>
    <comment_count>4</comment_count>
      <attachid>43511</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-11-20 20:49:19 -0800</bug_when>
    <thetext>Comment on attachment 43511
fix typo - s/sett/set

Cancel review based on Darin&apos;s comment. I might make this into a QtWebkit port-only patch. 

As I was working on this, noticed that when JSC is compiled for QtWebkit config.h is coming from WebCore and config.h from JavaScriptCore does not get used to compile the JSC part. This seems wrong and I will try to address it in my next patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>165585</commentid>
    <comment_count>5</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2009-11-21 00:44:45 -0800</bug_when>
    <thetext>I believe that is an inherent problem from compiling WebCore and JavaScriptCore at the same time into one shared library.

A while ago we had the two separated for a while, with JSC built as static library (PIC) and linked into QtWebKit. That however created the problem that QtWebKit&apos;s .prl file included a link reference to libJavaScriptCore.a, which made it impossible to link any application against QtWebKit as it always tried to drag in libJavaScriptCore.a.

Now with the recently introduced LIBS_PRIVATE feature in qmake we _might_ now be able to try that earlier approach again. I believe however that the right thing to do - also with the other ports in mind - is to move towards building JavaScriptCore as a shared library. See also bug #27551 for some work in that area.

If you agree about the latter approach, then we should probably make this bug depend on #27551.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>165768</commentid>
    <comment_count>6</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-11-22 14:44:10 -0800</bug_when>
    <thetext>Thanks Simon for the comments - making this bug dependent on 27551. 

In fact bug 27551 would probably solve the problem mentioned in the title entirely, but we can use this bug to clean up WebCore.pro (as it is proposed in the patch) after 27551 is fixed. in theory we could do some if the clean-up right now, but I consider that risky.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>204714</commentid>
    <comment_count>7</comment_count>
      <attachid>51771</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-03-26 12:34:18 -0700</bug_when>
    <thetext>Created attachment 51771
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>205121</commentid>
    <comment_count>8</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-03-28 02:27:59 -0700</bug_when>
    <thetext>Removing dependency, as in ToT they&apos;re built separately now at least.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>205246</commentid>
    <comment_count>9</comment_count>
      <attachid>51771</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-03-28 14:41:57 -0700</bug_when>
    <thetext>Comment on attachment 51771
proposed patch

Clearing flags on attachment: 51771

Committed r56700: &lt;http://trac.webkit.org/changeset/56700&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>205247</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-03-28 14:42:02 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>205250</commentid>
    <comment_count>11</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-03-28 14:46:24 -0700</bug_when>
    <thetext>Revision r56700 cherry-picked into qtwebkit-2.0 with commit 8f84e1115edba4a317c3a0d955fa94ba1824171d</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43510</attachid>
            <date>2009-11-19 09:04:10 -0800</date>
            <delta_ts>2009-11-19 09:05:32 -0800</delta_ts>
            <desc>proposed patch</desc>
            <filename>31670.patch</filename>
            <type>text/plain</type>
            <size>5421</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDUxMTg3
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEt
MTkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgdGhlIGRlZmluaXRp
b24gb2YgSEFWRShTVERJTlRfSCkgYW5kIFdURl9DSEFOR0VTIGd1YXJkcyBpbnRvIFBsYXRmb3Jt
LmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNjcw
CisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTogUmVtb3ZlIFdURl9DSEFOR0VTLiBJdCBkb2Vz
IG5vdCBuZWVkIHRvIGJlCisgICAgICAgIGRlZmluZWQgaW4gcG9ydCBzcGVjaWZpYyBtYWtlIHN5
c3RlbSBhbnltb3JlLgorCiAyMDA5LTExLTA5ICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3Jn
PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpJbmRleDogR05VbWFrZWZpbGUu
YW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gR05VbWFrZWZpbGUuYW0JKHJldmlzaW9uIDUxMTg3KQorKysgR05V
bWFrZWZpbGUuYW0JKHdvcmtpbmcgY29weSkKQEAgLTI3Myw4ICsyNzMsNyBAQCBsaWJ3ZWJraXRf
MV8wX2xhX0xJQkFERCA9IFwKICMgRXh0cmEgY2hlY2tzIGFuZCBmbGFncwogZ2xvYmFsX2NwcGZs
YWdzICs9IFwKIAktREJVSUxESU5HX0NBSVJPX189MSBcCi0JLURCVUlMRElOR19HVEtfXz0xIFwK
LQktRFdURl9DSEFOR0VTCisJLURCVUlMRElOR19HVEtfXz0xCiAKIGlmIFVTRV9JQ1VfVU5JQ09E
RQogZ2xvYmFsX2NwcGZsYWdzICs9IFwKSW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxMTg3KQor
KysgSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg
QEAKKzIwMDktMTEtMTkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUg
dGhlIGRlZmluaXRpb24gb2YgSEFWRShTVERJTlRfSCkgYW5kIFdURl9DSEFOR0VTIGd1YXJkcyBp
bnRvIFBsYXRmb3JtLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTMxNjcwCisKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS5wcm86IFJlbW92ZSBXVEZf
Q0hBTkdFUyBhbmQgSEFWRShTVERJTlRfSCkgZGVmaW5lcworICAgICAgICBhcyB0aGV5IGFyZSBh
bHJlYWR5IGRlZmluZWQgaW4gUGxhdGZvcm0uaAorICAgICAgICAqIGNvbmZpZy5oOiBEaXR0by4K
KyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDogQWx3YXlzIGRlZmluZSBXVEZfQ0hBTkdFUyBhbmQg
SEFWRShTVERJTlRfSCkKKwogMjAwOS0xMS0xOSAgVGhpYWdvIE1hY2llaXJhIDx0aGlhZ28ubWFj
aWVpcmFAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJ
bmRleDogSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJvCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEph
dmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnBybwkocmV2aXNpb24gNTExODcpCisrKyBKYXZh
U2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTM3LDcgKzM3
LDYgQEAgQ09ORklHKHJlbGVhc2UpOiFDT05GSUcoUVRESVJfYnVpbGQpIHsKICAgICB1bml4OmNv
bnRhaW5zKFFUX0NPTkZJRywgcmVkdWNlX3JlbG9jYXRpb25zKTpDT05GSUcgKz0gYnN5bWJvbGlj
X2Z1bmN0aW9ucwogfQogCi1saW51eC0qOiBERUZJTkVTICs9IEhBVkVfU1RESU5UX0gKIGZyZWVi
c2QtKjogREVGSU5FUyArPSBIQVZFX1BUSFJFQURfTlBfSAogCiBERUZJTkVTICs9IEJVSUxEX1dF
QktJVApAQCAtNTIsOCArNTEsNiBAQCB3aW4zMi1nKysgewogICAgIFFNQUtFX0xJQkRJUl9QT1NU
ICs9ICQkc3BsaXQoVE1QUEFUSCwiOyIpCiB9CiAKLURFRklORVMgKz0gV1RGX0NIQU5HRVM9MQot
CiBpbmNsdWRlKEphdmFTY3JpcHRDb3JlLnByaSkKIAogUU1BS0VfRVhUUkFfVEFSR0VUUyArPSBn
ZW5lcmF0ZWRfZmlsZXMKSW5kZXg6IEphdmFTY3JpcHRDb3JlL2NvbmZpZy5oCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIEphdmFTY3JpcHRDb3JlL2NvbmZpZy5oCShyZXZpc2lvbiA1MTE4NykKKysrIEphdmFTY3Jp
cHRDb3JlL2NvbmZpZy5oCSh3b3JraW5nIGNvcHkpCkBAIC01NSwxMiArNTUsOCBAQAogI2RlZmlu
ZSBIQVZFX1BUSFJFQURfTlBfSCAxCiAjZW5kaWYKIAotLyogRklYTUU6IGlmIGFsbCBwbGF0Zm9y
bXMgaGF2ZSB0aGVzZSwgZG8gdGhleSByZWFsbHkgbmVlZCAjZGVmaW5lcz8gKi8KLSNkZWZpbmUg
SEFWRV9TVERJTlRfSCAxCiAjZGVmaW5lIEhBVkVfU1RSSU5HX0ggMQogCi0jZGVmaW5lIFdURl9D
SEFOR0VTIDEKLQogI2lmZGVmIF9fY3BsdXNwbHVzCiAjdW5kZWYgbmV3CiAjdW5kZWYgZGVsZXRl
CkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZh
U2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gNTExODcpCisrKyBKYXZhU2NyaXB0
Q29yZS93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtNjM2LDYgKzYzNiwxMiBAQAog
CiAjZW5kaWYKIAorLyogVGhpcyBkZWZpbmUgaXMgdXNlZCBpbiAzcmQgcGFydHkgY29tcG9uZW50
cyB0aGF0IHd0ZiBpbmNvcnBvcmF0ZWQgLSBlLmcuIEZhc3RNYWxsb2MuIEZvciB3dGYgdGhpcyBt
YWNybyBzaG91bGQgYmUgYWx3YXlzIHNldHQgKi8KKyNkZWZpbmUgSEFWRV9TVERJTlRfSCAxCisK
Ky8qIFRoaXMgZGVmaW5lIGlzIHVzZWQgdG8gbWFyayBjaGFuZ2VzIGluIDNyZCBwYXJ0eSBjb21w
b25lbnRzIHRoYXQgd3RmIGluY29ycG9yYXRlZCAtIGUuZy4gRmFzdE1hbGxvYy4gRm9yIHd0ZiB0
aGlzIG1hY3JvIHNob3VsZCBiZSBhbHdheXMgc2V0ICovCisjZGVmaW5lIFdURl9DSEFOR0VTIDEK
KwogLyogRU5BQkxFIG1hY3JvIGRlZmF1bHRzICovCiAKIC8qIGZhc3RNYWxsb2MgbWF0Y2ggdmFs
aWRhdGlvbiBhbGxvd3MgZm9yIHJ1bnRpbWUgdmVyaWZpY2F0aW9uIHRoYXQKSW5kZXg6IFdlYkNv
cmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA1
MTE4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYg
QEAKKzIwMDktMTEtMTkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUg
dGhlIGRlZmluaXRpb24gb2YgSEFWRShTVERJTlRfSCkgYW5kIFdURl9DSEFOR0VTIGd1YXJkcyBp
bnRvIFBsYXRmb3JtLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTMxNjcwCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIHRoZXJlIGlzIG5vIGZ1bmN0
aW9uYWwgY2hhbmdlLgorCisgICAgICAgICogV2ViQ29yZS5wcm86IFJlbW92ZSBXVEZfQ0hBTkdF
UyBhbmQgSEFWRShTVERJTlRfSCkgZGVmaW5lcworICAgICAgICBhcyB0aGV5IGFyZSBhbHJlYWR5
IGRlZmluZWQgaW4gUGxhdGZvcm0uaAorICAgICAgICAqIGNvbmZpZy5oOiBEaXR0by4KKwogMjAw
OS0xMS0xOSAgT2xpdmllciBHb2ZmYXJ0ICA8b2dvZmZhcnRAdHJvbGx0ZWNoLmNvbT4KIAogICAg
ICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5w
cm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3JlLnBybwkocmV2aXNpb24gNTExODcpCisr
KyBXZWJDb3JlL1dlYkNvcmUucHJvCSh3b3JraW5nIGNvcHkpCkBAIC02MCw3ICs2MCw2IEBAIENP
TkZJRyhyZWxlYXNlKTohQ09ORklHKFFURElSX2J1aWxkKSB7CiAgICAgdW5peDpjb250YWlucyhR
VF9DT05GSUcsIHJlZHVjZV9yZWxvY2F0aW9ucyk6Q09ORklHICs9IGJzeW1ib2xpY19mdW5jdGlv
bnMKIH0KIAotbGludXgtKjogREVGSU5FUyArPSBIQVZFX1NURElOVF9ICiBmcmVlYnNkLSo6IERF
RklORVMgKz0gSEFWRV9QVEhSRUFEX05QX0gKIAogREVGSU5FUyArPSBCVUlMRF9XRUJLSVQKQEAg
LTE3OSw4ICsxNzgsNiBAQCBjb250YWlucyhERUZJTkVTLCBFTkFCTEVfU0lOR0xFX1RIUkVBREVE
CiAgICAgZWxzZTpERUZJTkVTICs9IEVOQUJMRV9YU0xUPTAKIH0KIAotREVGSU5FUyArPSBXVEZf
Q0hBTkdFUz0xCi0KICMgVXNlZCB0byBjb21wdXRlIGRlZmF1bHRzIGZvciB0aGUgYnVpbGQtd2Vi
a2l0IHNjcmlwdAogQ09ORklHKGNvbXB1dGVfZGVmYXVsdHMpIHsKICAgICBtZXNzYWdlKCQkREVG
SU5FUykKSW5kZXg6IFdlYkNvcmUvY29uZmlnLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jb25m
aWcuaAkocmV2aXNpb24gNTExODcpCisrKyBXZWJDb3JlL2NvbmZpZy5oCSh3b3JraW5nIGNvcHkp
CkBAIC0xNjQsMTEgKzE2NCw2IEBACiAjZGVmaW5lIFdURl9QTEFURk9STV9TS0lBIDEKICNlbmRp
ZiAvKiAhUExBVEZPUk0oREFSV0lOKSAqLwogCi0vLyBDaHJvbWl1bSB1c2VzIHRoaXMgZmlsZSBp
bnN0ZWFkIG9mIEphdmFTY3JpcHRDb3JlL2NvbmZpZy5oIHRvIGNvbXBpbGUKLS8vIEphdmFTY3Jp
cHRDb3JlL3d0ZiAoY2hyb21pdW0gZG9lc24ndCBjb21waWxlIHRoZSByZXN0IG9mIEpTQykuIFRo
ZXJlZm9yZSwKLS8vIHRoaXMgZGVmaW5lIGlzIHJlcXVpcmVkLgotI2RlZmluZSBXVEZfQ0hBTkdF
UyAxCi0KICNkZWZpbmUgV1RGX1VTRV9HT09HTEVVUkwgMQogCiAjaWYgIWRlZmluZWQoV1RGX1VT
RV9WOCkK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43511</attachid>
            <date>2009-11-19 09:05:32 -0800</date>
            <delta_ts>2010-03-26 12:34:18 -0700</delta_ts>
            <desc>fix typo - s/sett/set</desc>
            <filename>31670.patch</filename>
            <type>text/plain</type>
            <size>5420</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDUxMTg3
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEt
MTkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgdGhlIGRlZmluaXRp
b24gb2YgSEFWRShTVERJTlRfSCkgYW5kIFdURl9DSEFOR0VTIGd1YXJkcyBpbnRvIFBsYXRmb3Jt
LmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNjcw
CisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTogUmVtb3ZlIFdURl9DSEFOR0VTLiBJdCBkb2Vz
IG5vdCBuZWVkIHRvIGJlCisgICAgICAgIGRlZmluZWQgaW4gcG9ydCBzcGVjaWZpYyBtYWtlIHN5
c3RlbSBhbnltb3JlLgorCiAyMDA5LTExLTA5ICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3Jn
PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpJbmRleDogR05VbWFrZWZpbGUu
YW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gR05VbWFrZWZpbGUuYW0JKHJldmlzaW9uIDUxMTg3KQorKysgR05V
bWFrZWZpbGUuYW0JKHdvcmtpbmcgY29weSkKQEAgLTI3Myw4ICsyNzMsNyBAQCBsaWJ3ZWJraXRf
MV8wX2xhX0xJQkFERCA9IFwKICMgRXh0cmEgY2hlY2tzIGFuZCBmbGFncwogZ2xvYmFsX2NwcGZs
YWdzICs9IFwKIAktREJVSUxESU5HX0NBSVJPX189MSBcCi0JLURCVUlMRElOR19HVEtfXz0xIFwK
LQktRFdURl9DSEFOR0VTCisJLURCVUlMRElOR19HVEtfXz0xCiAKIGlmIFVTRV9JQ1VfVU5JQ09E
RQogZ2xvYmFsX2NwcGZsYWdzICs9IFwKSW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxMTg3KQor
KysgSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg
QEAKKzIwMDktMTEtMTkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUg
dGhlIGRlZmluaXRpb24gb2YgSEFWRShTVERJTlRfSCkgYW5kIFdURl9DSEFOR0VTIGd1YXJkcyBp
bnRvIFBsYXRmb3JtLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTMxNjcwCisKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS5wcm86IFJlbW92ZSBXVEZf
Q0hBTkdFUyBhbmQgSEFWRShTVERJTlRfSCkgZGVmaW5lcworICAgICAgICBhcyB0aGV5IGFyZSBh
bHJlYWR5IGRlZmluZWQgaW4gUGxhdGZvcm0uaAorICAgICAgICAqIGNvbmZpZy5oOiBEaXR0by4K
KyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDogQWx3YXlzIGRlZmluZSBXVEZfQ0hBTkdFUyBhbmQg
SEFWRShTVERJTlRfSCkKKwogMjAwOS0xMS0xOSAgVGhpYWdvIE1hY2llaXJhIDx0aGlhZ28ubWFj
aWVpcmFAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJ
bmRleDogSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJvCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEph
dmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnBybwkocmV2aXNpb24gNTExODcpCisrKyBKYXZh
U2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTM3LDcgKzM3
LDYgQEAgQ09ORklHKHJlbGVhc2UpOiFDT05GSUcoUVRESVJfYnVpbGQpIHsKICAgICB1bml4OmNv
bnRhaW5zKFFUX0NPTkZJRywgcmVkdWNlX3JlbG9jYXRpb25zKTpDT05GSUcgKz0gYnN5bWJvbGlj
X2Z1bmN0aW9ucwogfQogCi1saW51eC0qOiBERUZJTkVTICs9IEhBVkVfU1RESU5UX0gKIGZyZWVi
c2QtKjogREVGSU5FUyArPSBIQVZFX1BUSFJFQURfTlBfSAogCiBERUZJTkVTICs9IEJVSUxEX1dF
QktJVApAQCAtNTIsOCArNTEsNiBAQCB3aW4zMi1nKysgewogICAgIFFNQUtFX0xJQkRJUl9QT1NU
ICs9ICQkc3BsaXQoVE1QUEFUSCwiOyIpCiB9CiAKLURFRklORVMgKz0gV1RGX0NIQU5HRVM9MQot
CiBpbmNsdWRlKEphdmFTY3JpcHRDb3JlLnByaSkKIAogUU1BS0VfRVhUUkFfVEFSR0VUUyArPSBn
ZW5lcmF0ZWRfZmlsZXMKSW5kZXg6IEphdmFTY3JpcHRDb3JlL2NvbmZpZy5oCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIEphdmFTY3JpcHRDb3JlL2NvbmZpZy5oCShyZXZpc2lvbiA1MTE4NykKKysrIEphdmFTY3Jp
cHRDb3JlL2NvbmZpZy5oCSh3b3JraW5nIGNvcHkpCkBAIC01NSwxMiArNTUsOCBAQAogI2RlZmlu
ZSBIQVZFX1BUSFJFQURfTlBfSCAxCiAjZW5kaWYKIAotLyogRklYTUU6IGlmIGFsbCBwbGF0Zm9y
bXMgaGF2ZSB0aGVzZSwgZG8gdGhleSByZWFsbHkgbmVlZCAjZGVmaW5lcz8gKi8KLSNkZWZpbmUg
SEFWRV9TVERJTlRfSCAxCiAjZGVmaW5lIEhBVkVfU1RSSU5HX0ggMQogCi0jZGVmaW5lIFdURl9D
SEFOR0VTIDEKLQogI2lmZGVmIF9fY3BsdXNwbHVzCiAjdW5kZWYgbmV3CiAjdW5kZWYgZGVsZXRl
CkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZh
U2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gNTExODcpCisrKyBKYXZhU2NyaXB0
Q29yZS93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtNjM2LDYgKzYzNiwxMiBAQAog
CiAjZW5kaWYKIAorLyogVGhpcyBkZWZpbmUgaXMgdXNlZCBpbiAzcmQgcGFydHkgY29tcG9uZW50
cyB0aGF0IHd0ZiBpbmNvcnBvcmF0ZWQgLSBlLmcuIEZhc3RNYWxsb2MuIEZvciB3dGYgdGhpcyBt
YWNybyBzaG91bGQgYmUgYWx3YXlzIHNldCAqLworI2RlZmluZSBIQVZFX1NURElOVF9IIDEKKwor
LyogVGhpcyBkZWZpbmUgaXMgdXNlZCB0byBtYXJrIGNoYW5nZXMgaW4gM3JkIHBhcnR5IGNvbXBv
bmVudHMgdGhhdCB3dGYgaW5jb3Jwb3JhdGVkIC0gZS5nLiBGYXN0TWFsbG9jLiBGb3Igd3RmIHRo
aXMgbWFjcm8gc2hvdWxkIGJlIGFsd2F5cyBzZXQgKi8KKyNkZWZpbmUgV1RGX0NIQU5HRVMgMQor
CiAvKiBFTkFCTEUgbWFjcm8gZGVmYXVsdHMgKi8KIAogLyogZmFzdE1hbGxvYyBtYXRjaCB2YWxp
ZGF0aW9uIGFsbG93cyBmb3IgcnVudGltZSB2ZXJpZmljYXRpb24gdGhhdApJbmRleDogV2ViQ29y
ZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUx
MTg3KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBA
QAorMjAwOS0xMS0xOSAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSB0
aGUgZGVmaW5pdGlvbiBvZiBIQVZFKFNURElOVF9IKSBhbmQgV1RGX0NIQU5HRVMgZ3VhcmRzIGlu
dG8gUGxhdGZvcm0uaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MzE2NzAKKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhlcmUgaXMgbm8gZnVuY3Rp
b25hbCBjaGFuZ2UuCisKKyAgICAgICAgKiBXZWJDb3JlLnBybzogUmVtb3ZlIFdURl9DSEFOR0VT
IGFuZCBIQVZFKFNURElOVF9IKSBkZWZpbmVzCisgICAgICAgIGFzIHRoZXkgYXJlIGFscmVhZHkg
ZGVmaW5lZCBpbiBQbGF0Zm9ybS5oCisgICAgICAgICogY29uZmlnLmg6IERpdHRvLgorCiAyMDA5
LTExLTE5ICBPbGl2aWVyIEdvZmZhcnQgIDxvZ29mZmFydEB0cm9sbHRlY2guY29tPgogCiAgICAg
ICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogV2ViQ29yZS9XZWJDb3JlLnBy
bwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmUucHJvCShyZXZpc2lvbiA1MTE4NykKKysr
IFdlYkNvcmUvV2ViQ29yZS5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTYwLDcgKzYwLDYgQEAgQ09O
RklHKHJlbGVhc2UpOiFDT05GSUcoUVRESVJfYnVpbGQpIHsKICAgICB1bml4OmNvbnRhaW5zKFFU
X0NPTkZJRywgcmVkdWNlX3JlbG9jYXRpb25zKTpDT05GSUcgKz0gYnN5bWJvbGljX2Z1bmN0aW9u
cwogfQogCi1saW51eC0qOiBERUZJTkVTICs9IEhBVkVfU1RESU5UX0gKIGZyZWVic2QtKjogREVG
SU5FUyArPSBIQVZFX1BUSFJFQURfTlBfSAogCiBERUZJTkVTICs9IEJVSUxEX1dFQktJVApAQCAt
MTc5LDggKzE3OCw2IEBAIGNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9TSU5HTEVfVEhSRUFERUQK
ICAgICBlbHNlOkRFRklORVMgKz0gRU5BQkxFX1hTTFQ9MAogfQogCi1ERUZJTkVTICs9IFdURl9D
SEFOR0VTPTEKLQogIyBVc2VkIHRvIGNvbXB1dGUgZGVmYXVsdHMgZm9yIHRoZSBidWlsZC13ZWJr
aXQgc2NyaXB0CiBDT05GSUcoY29tcHV0ZV9kZWZhdWx0cykgewogICAgIG1lc3NhZ2UoJCRERUZJ
TkVTKQpJbmRleDogV2ViQ29yZS9jb25maWcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2NvbmZp
Zy5oCShyZXZpc2lvbiA1MTE4NykKKysrIFdlYkNvcmUvY29uZmlnLmgJKHdvcmtpbmcgY29weSkK
QEAgLTE2NCwxMSArMTY0LDYgQEAKICNkZWZpbmUgV1RGX1BMQVRGT1JNX1NLSUEgMQogI2VuZGlm
IC8qICFQTEFURk9STShEQVJXSU4pICovCiAKLS8vIENocm9taXVtIHVzZXMgdGhpcyBmaWxlIGlu
c3RlYWQgb2YgSmF2YVNjcmlwdENvcmUvY29uZmlnLmggdG8gY29tcGlsZQotLy8gSmF2YVNjcmlw
dENvcmUvd3RmIChjaHJvbWl1bSBkb2Vzbid0IGNvbXBpbGUgdGhlIHJlc3Qgb2YgSlNDKS4gVGhl
cmVmb3JlLAotLy8gdGhpcyBkZWZpbmUgaXMgcmVxdWlyZWQuCi0jZGVmaW5lIFdURl9DSEFOR0VT
IDEKLQogI2RlZmluZSBXVEZfVVNFX0dPT0dMRVVSTCAxCiAKICNpZiAhZGVmaW5lZChXVEZfVVNF
X1Y4KQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>51771</attachid>
            <date>2010-03-26 12:34:18 -0700</date>
            <delta_ts>2010-03-28 14:41:57 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>31670.patch</filename>
            <type>text/plain</type>
            <size>2256</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU2NjM1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMtMjYgIExhc3psbyBH
b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmVtb3ZlIHRoZSBkZWZpbml0aW9uIG9m
IFdURl9DSEFOR0VTIGd1YXJkcyBmcm9tIHRoZSBidWlsZCBzeXN0ZW0KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNjcwCisgIAorICAgICAgICAqIEph
dmFTY3JpcHRDb3JlLnBybzogUmVtb3ZlIHRoZSBkZWZpbml0aW9uIG9mIFdURl9DSEFOR0VTCisg
ICAgICAgIGFzIGl0IGlzIGFscmVhZHkgZGVmaW5lZCBpbiBjb25maWcuaAorCiAyMDEwLTAzLTI2
ICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CiAKICAgICAg
ICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9KYXZh
U2NyaXB0Q29yZS5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENv
cmUucHJvCShyZXZpc2lvbiA1NjYyNikKKysrIEphdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3Jl
LnBybwkod29ya2luZyBjb3B5KQpAQCAtMzYsOCArMzYsNiBAQCB3aW4zMi1nKysgewogICAgIFFN
QUtFX0xJQkRJUl9QT1NUICs9ICQkc3BsaXQoVE1QUEFUSCwiOyIpCiB9CiAKLURFRklORVMgKz0g
V1RGX0NIQU5HRVM9MQotCiAqLWcrKyo6UU1BS0VfQ1hYRkxBR1NfUkVMRUFTRSAtPSAtTzIKICot
ZysrKjpRTUFLRV9DWFhGTEFHU19SRUxFQVNFICs9IC1PMwogCkluZGV4OiBXZWJDb3JlL0NoYW5n
ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNTY2MzUpCisr
KyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEw
LTAzLTI2ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFJlbW92ZSB0
aGUgZGVmaW5pdGlvbiBvZiBXVEZfQ0hBTkdFUyBndWFyZHMgZnJvbSB0aGUgYnVpbGQgc3lzdGVt
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTY3MAor
CisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGVyZSBpcyBubyBuZXcgZnVuY3Rpb25hbGl0eS4K
KworICAgICAgICAqIFdlYkNvcmUucHJpOiBSZW1vdmUgdGhlIGRlZmluaXRpb24gb2YgV1RGX0NI
QU5HRVMKKyAgICAgICAgYXMgaXQgaXMgYWxyZWFkeSBkZWZpbmVkIGluIGNvbmZpZy5oCisKIDIw
MTAtMDMtMjYgIEphbm5lIEtvc2tpbmVuICA8amFubmUucC5rb3NraW5lbkBkaWdpYS5jb20+CiAK
ICAgICAgICAgUmV2aWV3ZWQgYnkgTGFzemxvIEdvbWJvcy4KSW5kZXg6IFdlYkNvcmUvV2ViQ29y
ZS5wcmkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3JlLnByaQkocmV2aXNpb24gNTY2MjYp
CisrKyBXZWJDb3JlL1dlYkNvcmUucHJpCSh3b3JraW5nIGNvcHkpCkBAIC0xMTQsOCArMTE0LDYg
QEAgZ3JlYXRlclRoYW4oUVRfTUlOT1JfVkVSU0lPTiwgNSkgewogIyBCZWFyZXIgbWFuYWdlbWVu
dCBpcyBwYXJ0IG9mIFF0IDQuNwogIWxlc3NUaGFuKFFUX01JTk9SX1ZFUlNJT04sIDcpOiFjb250
YWlucyhERUZJTkVTLCBFTkFCTEVfUVRfQkVBUkVSPS4pOkRFRklORVMgKz0gRU5BQkxFX1FUX0JF
QVJFUj0xCiAKLURFRklORVMgKz0gV1RGX0NIQU5HRVM9MQotCiAjIEVuYWJsZSB0b3VjaCBldmVu
dCBzdXBwb3J0IHdpdGggUXQgNC42CiAhbGVzc1RoYW4oUVRfTUlOT1JfVkVSU0lPTiwgNik6IERF
RklORVMgKz0gRU5BQkxFX1RPVUNIX0VWRU5UUz0xCiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>