31647 2009-11-18 14:25:36 -0800 Make KeyboardEvent::m_keyEvent use OwnPtr 2009-11-21 13:27:08 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates alice.barraclough ap commit-queue darin oldest_to_newest 164715 0 dbates 2009-11-18 14:25:36 -0800 On a suggestion by Darin <https://bugs.webkit.org/show_bug.cgi?id=16735#c11>: We should make KeyboardEvent::m_keyEvent use an OwnPtr instead of a raw pointer. 164719 1 43461 dbates 2009-11-18 14:28:50 -0800 Created attachment 43461 Patch 164767 2 43461 eric 2009-11-18 15:29:54 -0800 Comment on attachment 43461 Patch Yay! 165646 3 43461 commit-queue 2009-11-21 13:27:03 -0800 Comment on attachment 43461 Patch Clearing flags on attachment: 43461 Committed r51285: <http://trac.webkit.org/changeset/51285> 165647 4 commit-queue 2009-11-21 13:27:08 -0800 All reviewed patches have been landed. Closing bug. 43461 2009-11-18 14:28:50 -0800 2009-11-21 13:27:03 -0800 Patch Bug31647.patch text/plain 2253 dbates SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTEyMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTEtMTggIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTY0NworCisgICAgICAgIENo YW5nZWQgS2V5Ym9hcmRFdmVudDo6bV9rZXlFdmVudCBmcm9tIGEgcmF3IHBvaW50ZXIgdG8gYW4g T3duUHRyLgorCisgICAgICAgIE5vIGZ1bmN0aW9uYWxpdHkgd2FzIGNoYW5nZWQuIFNvLCBubyBu ZXcgdGVzdHMuCisKKyAgICAgICAgKiBkb20vS2V5Ym9hcmRFdmVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpLZXlib2FyZEV2ZW50Ojp+S2V5Ym9hcmRFdmVudCk6CisgICAgICAgICogZG9tL0tl eWJvYXJkRXZlbnQuaDogQ2hhbmdlZCBtX2tleUV2ZW50IHRvIE93blB0ci4KKyAgICAgICAgKFdl YkNvcmU6OktleWJvYXJkRXZlbnQ6OmtleUV2ZW50KToKKwogMjAwOS0xMS0xOCAgUGF2ZWwgRmVs ZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1v dGh5IEhhdGNoZXIuCkluZGV4OiBXZWJDb3JlL2RvbS9LZXlib2FyZEV2ZW50LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL2RvbS9LZXlib2FyZEV2ZW50LmNwcAkocmV2aXNpb24gNTA4NjUpCisr KyBXZWJDb3JlL2RvbS9LZXlib2FyZEV2ZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODAsNyAr ODAsNiBAQCBLZXlib2FyZEV2ZW50OjpLZXlib2FyZEV2ZW50KGNvbnN0IEF0b21pCiAKIEtleWJv YXJkRXZlbnQ6On5LZXlib2FyZEV2ZW50KCkKIHsKLSAgICBkZWxldGUgbV9rZXlFdmVudDsKIH0K IAogdm9pZCBLZXlib2FyZEV2ZW50Ojppbml0S2V5Ym9hcmRFdmVudChjb25zdCBBdG9taWNTdHJp bmcmIHR5cGUsIGJvb2wgY2FuQnViYmxlLCBib29sIGNhbmNlbGFibGUsIEFic3RyYWN0Vmlldyog dmlldywKSW5kZXg6IFdlYkNvcmUvZG9tL0tleWJvYXJkRXZlbnQuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2RvbS9LZXlib2FyZEV2ZW50LmgJKHJldmlzaW9uIDUwODY1KQorKysgV2ViQ29yZS9k b20vS2V5Ym9hcmRFdmVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC03OSw3ICs3OSw3IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAogICAgICAgICBib29sIGFsdEdyYXBoS2V5KCkgY29uc3QgeyByZXR1 cm4gbV9hbHRHcmFwaEtleTsgfQogICAgIAotICAgICAgICBjb25zdCBQbGF0Zm9ybUtleWJvYXJk RXZlbnQqIGtleUV2ZW50KCkgY29uc3QgeyByZXR1cm4gbV9rZXlFdmVudDsgfQorICAgICAgICBj b25zdCBQbGF0Zm9ybUtleWJvYXJkRXZlbnQqIGtleUV2ZW50KCkgY29uc3QgeyByZXR1cm4gbV9r ZXlFdmVudC5nZXQoKTsgfQogCiAgICAgICAgIGludCBrZXlDb2RlKCkgY29uc3Q7IC8vIGtleSBj b2RlIGZvciBrZXlkb3duIGFuZCBrZXl1cCwgY2hhcmFjdGVyIGZvciBrZXlwcmVzcwogICAgICAg ICBpbnQgY2hhckNvZGUoKSBjb25zdDsgLy8gY2hhcmFjdGVyIGNvZGUgZm9yIGtleXByZXNzLCAw IGZvciBrZXlkb3duIGFuZCBrZXl1cApAQCAtOTksNyArOTksNyBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgU3RyaW5nJiBrZXlJZGVudGlmaWVyLCB1 bnNpZ25lZCBrZXlMb2NhdGlvbiwKICAgICAgICAgICAgICAgICAgICAgICBib29sIGN0cmxLZXks IGJvb2wgYWx0S2V5LCBib29sIHNoaWZ0S2V5LCBib29sIG1ldGFLZXksIGJvb2wgYWx0R3JhcGhL ZXkpOwogCi0gICAgICAgIFBsYXRmb3JtS2V5Ym9hcmRFdmVudCogbV9rZXlFdmVudDsKKyAgICAg ICAgT3duUHRyPFBsYXRmb3JtS2V5Ym9hcmRFdmVudD4gbV9rZXlFdmVudDsKICAgICAgICAgU3Ry aW5nIG1fa2V5SWRlbnRpZmllcjsKICAgICAgICAgdW5zaWduZWQgbV9rZXlMb2NhdGlvbjsKICAg ICAgICAgYm9vbCBtX2FsdEdyYXBoS2V5IDogMTsK