31504 2009-11-13 20:08:56 -0800 InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR) 2009-11-18 14:26:03 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 nicolasroard webkit-unassigned android-webkit-unforking commit-queue oldest_to_newest 163637 0 nicolasroard 2009-11-13 20:08:56 -0800 InspectorTimelineAgent.h defines an inline function that calls a function on the document, returning the inspector... But if you try compiling webkit without inspectors, that document's function is not defined, and InspectorTimelineAgent.h thus cause a compile error. I'll upload a patch soon. 163639 1 43221 nicolasroard 2009-11-13 20:17:30 -0800 Created attachment 43221 Add a guard to compile the class only if ENABLE(INSPECTOR) 163640 2 43221 dglazkov 2009-11-13 20:22:20 -0800 Comment on attachment 43221 Add a guard to compile the class only if ENABLE(INSPECTOR) Don't forget to mark the attachment as patch. And may I interest you in the wonderful world of WebKitTools/Scripts/bugzilla-tool? (eseidel, how does you commission scheme work again?) 163641 3 43221 dglazkov 2009-11-13 20:23:07 -0800 Comment on attachment 43221 Add a guard to compile the class only if ENABLE(INSPECTOR) r=me. 163860 4 43221 abarth 2009-11-15 23:52:06 -0800 Comment on attachment 43221 Add a guard to compile the class only if ENABLE(INSPECTOR) Rejecting patch 43221 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/abarth/git/webkit-kr/LayoutTests Testing 11625 test cases. plugins/document-open.html -> failed Exiting early after 1 failures. 9531 tests run. 498.78s total testing time 9530 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 10 test cases (<1%) had stderr output 163861 5 43221 abarth 2009-11-15 23:53:50 -0800 Comment on attachment 43221 Add a guard to compile the class only if ENABLE(INSPECTOR) Likely a false rejection... 164130 6 43221 commit-queue 2009-11-16 18:13:55 -0800 Comment on attachment 43221 Add a guard to compile the class only if ENABLE(INSPECTOR) Rejecting patch 43221 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: mmitting to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorTimelineAgent.h A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/libexec/git-core//git-svn line 469 164131 7 43221 eric 2009-11-16 18:15:50 -0800 Comment on attachment 43221 Add a guard to compile the class only if ENABLE(INSPECTOR) ChangeLog looks fine to me. I suspect something is wrong with our re-born commit-queue. I'll investigate tomorrow. 164298 8 43221 commit-queue 2009-11-17 12:03:04 -0800 Comment on attachment 43221 Add a guard to compile the class only if ENABLE(INSPECTOR) Rejecting patch 43221 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11628 test cases. http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header.html -> crashed Exiting early after 1 failures. 9160 tests run. 479.50s total testing time 9159 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output 164300 9 43221 eric 2009-11-17 12:08:45 -0800 Comment on attachment 43221 Add a guard to compile the class only if ENABLE(INSPECTOR) Bah! Looks like bug 31461 is still plaguing us. :( 164306 10 43221 commit-queue 2009-11-17 12:31:16 -0800 Comment on attachment 43221 Add a guard to compile the class only if ENABLE(INSPECTOR) Rejecting patch 43221 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11628 test cases. inspector/console-dir.html -> crashed Exiting early after 1 failures. 9322 tests run. 383.17s total testing time 9321 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output 164320 11 43221 eric 2009-11-17 13:04:59 -0800 Comment on attachment 43221 Add a guard to compile the class only if ENABLE(INSPECTOR) Sigh. Bug 31461. 164716 12 43221 commit-queue 2009-11-18 14:25:51 -0800 Comment on attachment 43221 Add a guard to compile the class only if ENABLE(INSPECTOR) Clearing flags on attachment: 43221 Committed r51136: <http://trac.webkit.org/changeset/51136> 164717 13 commit-queue 2009-11-18 14:26:03 -0800 All reviewed patches have been landed. Closing bug. 43221 2009-11-13 20:17:30 -0800 2009-11-18 14:25:50 -0800 Add a guard to compile the class only if ENABLE(INSPECTOR) patch.txt text/plain 1172 nicolasroard SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDk5MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMTEtMTMgIE5pY29sYXMgUm9hcmQgICA8bmljb2xhc0Byb2Fy ZC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW5zcGVjdG9yVGltZWxpbmVBZ2VudC5oIHNob3VsZCBiZSBndWFyZGVkIGJ5IEVOQUJMRShJTlNQ RUNUT1IpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MTUwNAorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5lQWdlbnQuaDpBZGRl ZCB0aGUgZ3VhcmQuCisKIDIwMDktMTEtMTMgIEFhcm9uIEJvb2RtYW4gIDxhYUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBmaXggZm9yIENocm9taXVtIGJ1aWxkLgpJbmRleDog V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yVGltZWxpbmVBZ2VudC5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5lQWdlbnQuaAkocmV2aXNpb24gNTAy NTgpCisrKyBXZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JUaW1lbGluZUFnZW50LmgJKHdvcmtp bmcgY29weSkKQEAgLTMxLDYgKzMxLDggQEAKICNpZm5kZWYgSW5zcGVjdG9yVGltZWxpbmVBZ2Vu dF9oCiAjZGVmaW5lIEluc3BlY3RvclRpbWVsaW5lQWdlbnRfaAogCisjaWYgRU5BQkxFKElOU1BF Q1RPUikKKwogI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiU2NyaXB0RXhlY3V0aW9u Q29udGV4dC5oIgogI2luY2x1ZGUgIlNjcmlwdE9iamVjdC5oIgpAQCAtMTI0LDQgKzEyNiw1IEBA IGlubGluZSBJbnNwZWN0b3JUaW1lbGluZUFnZW50KiBJbnNwZWN0b3IKIAogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQogCisjZW5kaWYgLy8gIUVOQUJMRShJTlNQRUNUT1IpCiAjZW5kaWYgLy8gIWRl ZmluZWQoSW5zcGVjdG9yVGltZWxpbmVBZ2VudF9oKQo=