31474 2009-11-13 08:32:16 -0800 [V8] Protect SVG animated properties from destruction in bindings. 2009-11-13 12:02:53 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vitalyr webkit-unassigned commit-queue dglazkov eric oldest_to_newest 163316 0 vitalyr 2009-11-13 08:32:16 -0800 [V8] Protect SVG animated properties from destruction in bindings. 163318 1 43159 vitalyr 2009-11-13 08:37:20 -0800 Created attachment 43159 patch 163324 2 43159 dglazkov 2009-11-13 08:49:27 -0800 Comment on attachment 43159 patch > + // > + // where PassRefPtr::~PassRefPtr() is invoked only after foo() is > + // called. > + template <typename T> > + static PassRefPtr<T> withSVGContext(PassRefPtr<T> object, SVGElement* context) { Brace on new line. > + setSVGContext(object.get(), context); > + return object; > + } > + static void* withSVGContext(void* object, SVGElement* context) { Brace on new line. > + setSVGContext(object, context); > + return object; Use check-webkit-style :) 163332 3 43163 vitalyr 2009-11-13 09:03:35 -0800 Created attachment 43163 patch v2 163333 4 43163 dglazkov 2009-11-13 09:06:59 -0800 Comment on attachment 43163 patch v2 One day we will drive stupid void* out of V8 bindings. But it's not going to be today. 163350 5 43163 commit-queue 2009-11-13 09:42:22 -0800 Comment on attachment 43163 patch v2 Rejecting patch 43163 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11617 test cases. inspector/console-dir.html -> crashed Exiting early after 1 failures. 9312 tests run. 488.96s total testing time 9311 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output 163392 6 43163 dglazkov 2009-11-13 11:45:52 -0800 Comment on attachment 43163 patch v2 spin again. 163406 7 43163 commit-queue 2009-11-13 11:56:50 -0800 Comment on attachment 43163 patch v2 Clearing flags on attachment: 43163 Committed r50958: <http://trac.webkit.org/changeset/50958> 163407 8 commit-queue 2009-11-13 11:56:55 -0800 All reviewed patches have been landed. Closing bug. 163415 9 eric 2009-11-13 12:02:53 -0800 Added the crash log to bug 30835. 43159 2009-11-13 08:37:20 -0800 2009-11-13 09:03:35 -0800 patch fix_svg.patch text/plain 3179 vitalyr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjAxNzBiNS4uNDY4N2IzOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0xMS0xMyAgVml0YWx5IFJlcGVz aGtvICA8dml0YWx5ckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW1Y4XSBQcm90ZWN0IFNWRyBhbmltYXRlZCBwcm9wZXJ0aWVz IGZyb20gZGVzdHJ1Y3Rpb24gaW4gYmluZGluZ3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTQ3NAorCisgICAgICAgIFNlZSBodHRwOi8vY3JidWcu Y29tLzI2NzE5LgorCisgICAgICAgIFRlc3RlZCBieSBMYXlvdXRUZXN0cy9zdmcvY3VzdG9tL2pz LXVwZGF0ZS10cmFuc2Zvcm0tYWRkaXRpb24uc3ZnCisgICAgICAgIHVuZGVyIFZhbGdyaW5kLgor CisgICAgICAgIE1hZGUgc3VyZSB3ZSBrZWVwIGEgcmVmZXJlbmNlIHRvIFNWRyBwcm9wZXJ0aWVz IHdoaWxlIHNldHRpbmcgYQorICAgICAgICBjb250ZXh0OgorICAgICAgICAqIGJpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4UHJveHku aDoKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6OndpdGhTVkdDb250ZXh0KToKKwogMjAwOS0x MS0xMSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JWOC5wbQppbmRleCBmYzNiMjljLi4wZDFmZjhlIDEwMDY0NAotLS0gYS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTYzNyw4ICs2MzcsOCBAQCBFTkQK ICAgICAgICAgaWYgKCRhdHRySXNQb2RUeXBlKSB7CiAgICAgICAgICAgICAkcmVzdWx0T2JqZWN0 ID0gIndyYXBwZXIiOwogICAgICAgICB9Ci0gICAgICAgICRyZXN1bHRPYmplY3QgPSAiV1RGOjpn ZXRQdHIoIiAuICRyZXN1bHRPYmplY3QgLiAiKSI7Ci0gICAgICAgIHB1c2goQGltcGxDb250ZW50 RGVjbHMsIEdlbmVyYXRlU1ZHQ29udGV4dEFzc2lnbm1lbnQoJGltcGxDbGFzc05hbWUsICRyZXN1 bHRPYmplY3QsICIgICAgIikpOworICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCBHZW5l cmF0ZVNWR0NvbnRleHRSZXRyaWV2YWwoJGltcGxDbGFzc05hbWUsICIgICAgIikpOworICAgICAg ICAkcmVzdWx0ID0gIlY4UHJveHk6OndpdGhTVkdDb250ZXh0KCRyZXN1bHRPYmplY3QsIGNvbnRl eHQpIjsKICAgICB9CiAKICAgICBpZiAoJGF0dHJJc1BvZFR5cGUpIHsKZGlmZiAtLWdpdCBhL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5 LmgKaW5kZXggOTg4MmE0Yy4uZWNlZjAwOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOFByb3h5LmgKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmgKQEAgLTE2Niw2 ICsxNjYsMzEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogI2lmIEVOQUJMRShTVkcpCiAgICAgICAg IHN0YXRpYyB2b2lkIHNldFNWR0NvbnRleHQodm9pZCosIFNWR0VsZW1lbnQqKTsKICAgICAgICAg c3RhdGljIFNWR0VsZW1lbnQqIHN2Z0NvbnRleHQodm9pZCopOworCisgICAgICAgIC8vIFRoZXNl IGhlbHBlciBmdW5jdGlvbnMgYXJlIHJlcXVpcmVkIGluIGNhc2Ugd2UgYXJlIGdpdmVuIGEgUGFz c1JlZlB0cgorICAgICAgICAvLyB0byBhIChwb3NzaWJseSkgbmV3bHkgY3JlYXRlZCBvYmplY3Qg YW5kIG11c3QgcHJldmVudCBpdHMgcmVmZXJlbmNlCisgICAgICAgIC8vIGNvdW50IGZyb20gZHJv cHBpbmcgdG8gemVybyBhcyB3b3VsZCBoYXBwZW4gaW4gY29kZSBsaWtlCisgICAgICAgIC8vCisg ICAgICAgIC8vICAgVjhQcm94eTo6c2V0U1ZHQ29udGV4dChpbXAtPmdldE5ld2x5Q3JlYXRlZE9i amVjdCgpLmdldCgpLCBjb250ZXh0KTsKKyAgICAgICAgLy8gICBmb28oaW1wLT5nZXROZXdseUNy ZWF0ZWRPYmplY3QoKS5nZXQoKSk7CisgICAgICAgIC8vCisgICAgICAgIC8vIEluIHRoZSBhYm92 ZSB0d28gbGluZXMgZWFjaCB0aW1lIGdldE5ld2x5Q3JlYXRlZE9iamVjdCgpIGlzIGNhbGxlZCBp dAorICAgICAgICAvLyBjcmVhdGVzIGEgbmV3IG9iamVjdCBiZWNhdXNlIHdlIGRvbid0IHJlZigp IGl0LiAoU28gb3VyIGF0dGVtdHMgdG8KKyAgICAgICAgLy8gYXNzb2NpYXRlIGEgY29udGV4dCB3 aXRoIGl0IGZhaWwuKSBTdWNoIGNvZGUgc2hvdWxkIGJlIHJld3JpdHRlbiB0bworICAgICAgICAv LworICAgICAgICAvLyAgIGZvbyhWOFByb3h5Ojp3aXRoU1ZHQ29udGV4dChpbXAtPmdldE5ld2x5 Q3JlYXRlZE9iamVjdCgpLCBjb250ZXh0KS5nZXQoKSk7CisgICAgICAgIC8vCisgICAgICAgIC8v IHdoZXJlIFBhc3NSZWZQdHI6On5QYXNzUmVmUHRyKCkgaXMgaW52b2tlZCBvbmx5IGFmdGVyIGZv bygpIGlzCisgICAgICAgIC8vIGNhbGxlZC4KKyAgICAgICAgdGVtcGxhdGUgPHR5cGVuYW1lIFQ+ CisgICAgICAgIHN0YXRpYyBQYXNzUmVmUHRyPFQ+IHdpdGhTVkdDb250ZXh0KFBhc3NSZWZQdHI8 VD4gb2JqZWN0LCBTVkdFbGVtZW50KiBjb250ZXh0KSB7CisgICAgICAgICAgICBzZXRTVkdDb250 ZXh0KG9iamVjdC5nZXQoKSwgY29udGV4dCk7CisgICAgICAgICAgICByZXR1cm4gb2JqZWN0Owor ICAgICAgICB9CisgICAgICAgIHN0YXRpYyB2b2lkKiB3aXRoU1ZHQ29udGV4dCh2b2lkKiBvYmpl Y3QsIFNWR0VsZW1lbnQqIGNvbnRleHQpIHsKKyAgICAgICAgICAgIHNldFNWR0NvbnRleHQob2Jq ZWN0LCBjb250ZXh0KTsKKyAgICAgICAgICAgIHJldHVybiBvYmplY3Q7CisgICAgICAgIH0KICNl bmRpZgogCiAgICAgICAgIHZvaWQgc2V0RXZlbnRIYW5kbGVyTGluZU51bWJlcihpbnQgbGluZU51 bWJlcikgeyBtX2hhbmRsZXJMaW5lTnVtYmVyID0gbGluZU51bWJlcjsgfQo= 43163 2009-11-13 09:03:35 -0800 2009-11-13 11:56:50 -0800 patch v2 fix_svg.patch text/plain 3197 vitalyr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjAxNzBiNS4uNDY4N2IzOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0xMS0xMyAgVml0YWx5IFJlcGVz aGtvICA8dml0YWx5ckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW1Y4XSBQcm90ZWN0IFNWRyBhbmltYXRlZCBwcm9wZXJ0aWVz IGZyb20gZGVzdHJ1Y3Rpb24gaW4gYmluZGluZ3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTQ3NAorCisgICAgICAgIFNlZSBodHRwOi8vY3JidWcu Y29tLzI2NzE5LgorCisgICAgICAgIFRlc3RlZCBieSBMYXlvdXRUZXN0cy9zdmcvY3VzdG9tL2pz LXVwZGF0ZS10cmFuc2Zvcm0tYWRkaXRpb24uc3ZnCisgICAgICAgIHVuZGVyIFZhbGdyaW5kLgor CisgICAgICAgIE1hZGUgc3VyZSB3ZSBrZWVwIGEgcmVmZXJlbmNlIHRvIFNWRyBwcm9wZXJ0aWVz IHdoaWxlIHNldHRpbmcgYQorICAgICAgICBjb250ZXh0OgorICAgICAgICAqIGJpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4UHJveHku aDoKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6OndpdGhTVkdDb250ZXh0KToKKwogMjAwOS0x MS0xMSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JWOC5wbQppbmRleCBmYzNiMjljLi4wZDFmZjhlIDEwMDY0NAotLS0gYS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTYzNyw4ICs2MzcsOCBAQCBFTkQK ICAgICAgICAgaWYgKCRhdHRySXNQb2RUeXBlKSB7CiAgICAgICAgICAgICAkcmVzdWx0T2JqZWN0 ID0gIndyYXBwZXIiOwogICAgICAgICB9Ci0gICAgICAgICRyZXN1bHRPYmplY3QgPSAiV1RGOjpn ZXRQdHIoIiAuICRyZXN1bHRPYmplY3QgLiAiKSI7Ci0gICAgICAgIHB1c2goQGltcGxDb250ZW50 RGVjbHMsIEdlbmVyYXRlU1ZHQ29udGV4dEFzc2lnbm1lbnQoJGltcGxDbGFzc05hbWUsICRyZXN1 bHRPYmplY3QsICIgICAgIikpOworICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCBHZW5l cmF0ZVNWR0NvbnRleHRSZXRyaWV2YWwoJGltcGxDbGFzc05hbWUsICIgICAgIikpOworICAgICAg ICAkcmVzdWx0ID0gIlY4UHJveHk6OndpdGhTVkdDb250ZXh0KCRyZXN1bHRPYmplY3QsIGNvbnRl eHQpIjsKICAgICB9CiAKICAgICBpZiAoJGF0dHJJc1BvZFR5cGUpIHsKZGlmZiAtLWdpdCBhL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5 LmgKaW5kZXggOTg4MmE0Yy4uZmJhNTJmNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOFByb3h5LmgKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmgKQEAgLTE2Niw2 ICsxNjYsMzMgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogI2lmIEVOQUJMRShTVkcpCiAgICAgICAg IHN0YXRpYyB2b2lkIHNldFNWR0NvbnRleHQodm9pZCosIFNWR0VsZW1lbnQqKTsKICAgICAgICAg c3RhdGljIFNWR0VsZW1lbnQqIHN2Z0NvbnRleHQodm9pZCopOworCisgICAgICAgIC8vIFRoZXNl IGhlbHBlciBmdW5jdGlvbnMgYXJlIHJlcXVpcmVkIGluIGNhc2Ugd2UgYXJlIGdpdmVuIGEgUGFz c1JlZlB0cgorICAgICAgICAvLyB0byBhIChwb3NzaWJseSkgbmV3bHkgY3JlYXRlZCBvYmplY3Qg YW5kIG11c3QgcHJldmVudCBpdHMgcmVmZXJlbmNlCisgICAgICAgIC8vIGNvdW50IGZyb20gZHJv cHBpbmcgdG8gemVybyBhcyB3b3VsZCBoYXBwZW4gaW4gY29kZSBsaWtlCisgICAgICAgIC8vCisg ICAgICAgIC8vICAgVjhQcm94eTo6c2V0U1ZHQ29udGV4dChpbXAtPmdldE5ld2x5Q3JlYXRlZE9i amVjdCgpLmdldCgpLCBjb250ZXh0KTsKKyAgICAgICAgLy8gICBmb28oaW1wLT5nZXROZXdseUNy ZWF0ZWRPYmplY3QoKS5nZXQoKSk7CisgICAgICAgIC8vCisgICAgICAgIC8vIEluIHRoZSBhYm92 ZSB0d28gbGluZXMgZWFjaCB0aW1lIGdldE5ld2x5Q3JlYXRlZE9iamVjdCgpIGlzIGNhbGxlZCBp dAorICAgICAgICAvLyBjcmVhdGVzIGEgbmV3IG9iamVjdCBiZWNhdXNlIHdlIGRvbid0IHJlZigp IGl0LiAoU28gb3VyIGF0dGVtdHMgdG8KKyAgICAgICAgLy8gYXNzb2NpYXRlIGEgY29udGV4dCB3 aXRoIGl0IGZhaWwuKSBTdWNoIGNvZGUgc2hvdWxkIGJlIHJld3JpdHRlbiB0bworICAgICAgICAv LworICAgICAgICAvLyAgIGZvbyhWOFByb3h5Ojp3aXRoU1ZHQ29udGV4dChpbXAtPmdldE5ld2x5 Q3JlYXRlZE9iamVjdCgpLCBjb250ZXh0KS5nZXQoKSk7CisgICAgICAgIC8vCisgICAgICAgIC8v IHdoZXJlIFBhc3NSZWZQdHI6On5QYXNzUmVmUHRyKCkgaXMgaW52b2tlZCBvbmx5IGFmdGVyIGZv bygpIGlzCisgICAgICAgIC8vIGNhbGxlZC4KKyAgICAgICAgdGVtcGxhdGUgPHR5cGVuYW1lIFQ+ CisgICAgICAgIHN0YXRpYyBQYXNzUmVmUHRyPFQ+IHdpdGhTVkdDb250ZXh0KFBhc3NSZWZQdHI8 VD4gb2JqZWN0LCBTVkdFbGVtZW50KiBjb250ZXh0KQorICAgICAgICB7CisgICAgICAgICAgICBz ZXRTVkdDb250ZXh0KG9iamVjdC5nZXQoKSwgY29udGV4dCk7CisgICAgICAgICAgICByZXR1cm4g b2JqZWN0OworICAgICAgICB9CisgICAgICAgIHN0YXRpYyB2b2lkKiB3aXRoU1ZHQ29udGV4dCh2 b2lkKiBvYmplY3QsIFNWR0VsZW1lbnQqIGNvbnRleHQpCisgICAgICAgIHsKKyAgICAgICAgICAg IHNldFNWR0NvbnRleHQob2JqZWN0LCBjb250ZXh0KTsKKyAgICAgICAgICAgIHJldHVybiBvYmpl Y3Q7CisgICAgICAgIH0KICNlbmRpZgogCiAgICAgICAgIHZvaWQgc2V0RXZlbnRIYW5kbGVyTGlu ZU51bWJlcihpbnQgbGluZU51bWJlcikgeyBtX2hhbmRsZXJMaW5lTnVtYmVyID0gbGluZU51bWJl cjsgfQo=