31456 2009-11-12 22:33:55 -0800 WAI-ARIA: checkbox does not determine its label from text content 2009-11-13 22:25:23 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach oldest_to_newest 163225 0 cfleizach 2009-11-12 22:33:55 -0800 accessible name computation needs to work on checkboxes 163228 1 43135 cfleizach 2009-11-12 23:04:40 -0800 Created attachment 43135 patch 163329 2 cfleizach 2009-11-13 08:58:16 -0800 adding to commit-queue 163356 3 43135 commit-queue 2009-11-13 10:00:11 -0800 Comment on attachment 43135 patch Rejecting patch 43135 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11618 test cases. inspector/console-dir.html -> crashed Exiting early after 1 failures. 9313 tests run. 461.55s total testing time 9312 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output 163367 4 cfleizach 2009-11-13 10:49:28 -0800 totally not the fault of this patch, but iʻll take care of this patch tonite 163420 5 43135 eric 2009-11-13 12:07:13 -0800 Comment on attachment 43135 patch Agreed. You just hit a recent JSC crasher. I've added the crash report to bug 30835 and we'll spin this one through the queue again. 163645 6 cfleizach 2009-11-13 22:12:08 -0800 will commit now 163646 7 cfleizach 2009-11-13 22:25:23 -0800 http://trac.webkit.org/changeset/50994 43135 2009-11-12 23:04:40 -0800 2009-11-13 22:12:15 -0800 patch patch.txt text/plain 5507 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDkyOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMTIgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXQUktQVJJQTogY2hlY2tib3ggZG9lcyBub3QgZGV0ZXJtaW5lIGl0cyBsYWJlbCBmcm9tIHRl eHQgY29udGVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzE0NTYKKworICAgICAgICBUZXN0OiBhY2Nlc3NpYmlsaXR5L2FyaWEtY2hlY2tib3gtdGV4 dC5odG1sCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmpl Y3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6dGl0 bGUpOgorCiAyMDA5LTExLTEyICBBbmFudGFuYXJheWFuYW4gRyBJeWVuZ2FyICA8YW5hbnRhQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNw cAkocmV2aXNpb24gNTA5MjgpCisrKyBXZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0 eVJlbmRlck9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNTQsNiArMTA1NCw3IEBAIFN0 cmluZyBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojp0aXRsZSgKICAgICAgICAgfHwgYXJpYVJv bGUgPT0gTWVudUl0ZW1Sb2xlCiAgICAgICAgIHx8IGFyaWFSb2xlID09IE1lbnVCdXR0b25Sb2xl CiAgICAgICAgIHx8IGFyaWFSb2xlID09IFJhZGlvQnV0dG9uUm9sZQorICAgICAgICB8fCBhcmlh Um9sZSA9PSBDaGVja0JveFJvbGUKICAgICAgICAgfHwgYXJpYVJvbGUgPT0gVGFiUm9sZQogICAg ICAgICB8fCBpc0hlYWRpbmcoKSkKICAgICAgICAgcmV0dXJuIHRleHRVbmRlckVsZW1lbnQoKTsK SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUwOTI5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMTIgIENocmlzIEZsZWl6YWNoICA8 Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXQUktQVJJQTogY2hlY2tib3ggZG9lcyBub3QgZGV0ZXJtaW5lIGl0cyBs YWJlbCBmcm9tIHRleHQgY29udGVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzE0NTYKKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXJpYS1jaGVj a2JveC10ZXh0Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOgor ICAgICAgICAqIHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2FyaWEtY2hlY2tib3gtdGV4dC1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL3dpbi9Ta2lwcGVkOgorCiAy MDA5LTExLTEyICBBbmFudGFuYXJheWFuYW4gRyBJeWVuZ2FyICA8YW5hbnRhQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogTGF5b3V0VGVzdHMv YWNjZXNzaWJpbGl0eS9hcmlhLWNoZWNrYm94LXRleHQuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2FyaWEtY2hlY2tib3gtdGV4dC5odG1sCShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9hcmlhLWNoZWNrYm94LXRleHQuaHRtbAko cmV2aXNpb24gMCkKQEAgLTAsMCArMSw0OCBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9J RVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVl dCIgaHJlZj0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlw dD4KK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSBmYWxzZTsKKzwvc2NyaXB0PgorPHNjcmlwdCBz cmM9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5IGlkPSJib2R5Ij4KKworPGRpdiByb2xlPSJyYWRpb2J1dHRvbmdyb3VwIj4KKwk8 ZGl2IHJvbGU9ImNoZWNrYm94IiBpZD0iY2hlY2sxIiB0YWJpbmRleD0iMCIgYXJpYS1jaGVja2Vk PSJ0cnVlIj5PbmU8L2Rpdj4KKwk8ZGl2IHJvbGU9ImNoZWNrYm94IiBpZD0iY2hlY2syIiB0YWJp bmRleD0iMCI+VHdvPC9kaXY+CisJPGRpdiByb2xlPSJjaGVja2JveCIgaWQ9ImNoZWNrMyIgdGFi aW5kZXg9IjAiIGlkPSJmb28iIGFyaWEtbGFiZWxsZWRieT0iZm9vIj5UaHJlZTwvZGl2PgorPC9k aXY+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+ CisKKzxzY3JpcHQ+CisKKyAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0aGF0IEFSSUEgY2hl Y2tib3hlcyB1c2UgYWNjZXNzaWJsZSBuYW1lIGNvbXB1dGF0aW9uLiIpOworCisgICAgaWYgKHdp bmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgeworCisgICAgICAgICAgdmFyIGNoZWNrYm94 ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNoZWNrMSIpOworICAgICAgICAgIGNoZWNrYm94 LmZvY3VzKCk7CisgICAgICAgICAgY2hlY2tib3ggPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5m b2N1c2VkRWxlbWVudDsKKyAgICAgICAgICBzaG91bGRCZSgiY2hlY2tib3gudGl0bGUiLCAiJ0FY VGl0bGU6IE9uZSciKTsKKworICAgICAgICAgIGNoZWNrYm94ID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoImNoZWNrMiIpOworICAgICAgICAgIGNoZWNrYm94LmZvY3VzKCk7CisgICAgICAgICAg Y2hlY2tib3ggPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudDsKKyAgICAg ICAgICBzaG91bGRCZSgiY2hlY2tib3gudGl0bGUiLCAiJ0FYVGl0bGU6IFR3byciKTsKKworICAg ICAgICAgIGNoZWNrYm94ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNoZWNrMyIpOworICAg ICAgICAgIGNoZWNrYm94LmZvY3VzKCk7CisgICAgICAgICAgY2hlY2tib3ggPSBhY2Nlc3NpYmls aXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudDsKKyAgICAgICAgICBzaG91bGRCZSgiY2hlY2ti b3gudGl0bGUiLCAiJ0FYVGl0bGU6IFRocmVlJyIpOworICAgIH0KKworICAgIHN1Y2Nlc3NmdWxs eVBhcnNlZCA9IHRydWU7Cis8L3NjcmlwdD4KKworPHNjcmlwdCBzcmM9Ii4uL2Zhc3QvanMvcmVz b3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4 OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAkocmV2aXNpb24gNTA5MjgpCisrKyBMYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAkod29ya2luZyBjb3B5KQpAQCAtNDQsNiArNDQsNyBAQAog IyBUZXN0cyBpbiBhY2Nlc3NpYmlsaXR5LyBkaXJlY3RvcnkKICMgQW4gaW1wbGVtZW50YXRpb24g b2YgYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIgaXMgcmVxdWlyZWQuCiAjICAgVGVzdHMgZmFpbGlu ZworYWNjZXNzaWJpbGl0eS9hcmlhLWNoZWNrYm94LXRleHQuaHRtbAogYWNjZXNzaWJpbGl0eS9h cmlhLWNvbWJvYm94Lmh0bWwKIGFjY2Vzc2liaWxpdHkvYXJpYS1kaXNhYmxlZC5odG1sCiBhY2Nl c3NpYmlsaXR5L2FyaWEtaGlkZGVuLmh0bWwKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9hY2Nlc3NpYmlsaXR5L2FyaWEtY2hlY2tib3gtdGV4dC1leHBlY3RlZC50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1jaGVja2Jv eC10ZXh0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3Jt L21hYy9hY2Nlc3NpYmlsaXR5L2FyaWEtY2hlY2tib3gtdGV4dC1leHBlY3RlZC50eHQJKHJldmlz aW9uIDApCkBAIC0wLDAgKzEsMTUgQEAKK09uZQorVHdvCitUaHJlZQorVGhpcyB0ZXN0cyB0aGF0 IEFSSUEgY2hlY2tib3hlcyB1c2UgYWNjZXNzaWJsZSBuYW1lIGNvbXB1dGF0aW9uLgorCitPbiBz dWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dl ZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBjaGVja2JveC50aXRsZSBpcyAnQVhUaXRs ZTogT25lJworUEFTUyBjaGVja2JveC50aXRsZSBpcyAnQVhUaXRsZTogVHdvJworUEFTUyBjaGVj a2JveC50aXRsZSBpcyAnQVhUaXRsZTogVGhyZWUnCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBp cyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2lu L1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQJ KHJldmlzaW9uIDUwOTI4KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQJKHdv cmtpbmcgY29weSkKQEAgLTM1NCw2ICszNTQsNyBAQCBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0 L2FjY2Vzcy1jb250cm9sCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2FjY2Vzcy1jb250cm9s LWJhc2ljLW5vbi1zaW1wbGUtYWxsb3cuaHRtbAogCiAjIEFjY2Vzc2liaWxpdHkgdGVzdHMgd2l0 aG91dCByZXN1bHRzIG9yIHdpdGggTWFjLXNwZWNpZmljIHJlc3VsdHMuCithY2Nlc3NpYmlsaXR5 L2FyaWEtY2hlY2tib3gtdGV4dC5odG1sCiBhY2Nlc3NpYmlsaXR5L2FyaWEtY29tYm9ib3guaHRt bAogYWNjZXNzaWJpbGl0eS9hcmlhLWNvbnRyb2xzLXdpdGgtdGFicy5odG1sCiBhY2Nlc3NpYmls aXR5L2FyaWEtZGVzY3JpYmVkYnktb24taW5wdXQuaHRtbAo=