31295 2009-11-10 08:08:01 -0800 [Qt] Rendering of html select elements is broken 2010-06-16 06:17:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED Qt P3 Normal --- 29799 1 hausmann jturcotte commit-queue darin hausmann hyatt jesus kenneth koivisto mitz tonikitoo vestbo oldest_to_newest 162051 0 hausmann 2009-11-10 08:08:01 -0800 The background is drawn in black. 162071 1 42869 tonikitoo 2009-11-10 09:29:41 -0800 Created attachment 42869 testcase test case, open it in QVGLauncher to see the problem 162073 2 42870 jturcotte 2009-11-10 09:37:37 -0800 Created attachment 42870 Patch, hardcode the color in the constructor 162095 3 kenneth 2009-11-10 10:30:53 -0800 Doesn't seem right. It seems more right that the method doing the painting would take care of that. No color was defined, thus the default color is invalid right? 162097 4 kenneth 2009-11-10 10:33:22 -0800 Hi David, do you have any comments on this? 162114 5 jturcotte 2009-11-10 10:58:16 -0800 To copy here what we talked on irc, it all depend if the invalid flag in the background is intended to mean "don't draw" or not. This flag don't seem to be verified in different GraphicContext implementations. Currently this cause problems since we don't check this and Qt has an undefined behavior when painting with a brush that has an invalid color (the default invalid color is black, and it gets painted anyway). 162120 6 42879 jturcotte 2009-11-10 11:05:20 -0800 Created attachment 42879 Patch, use a RenderStyle static init function This patch uses an initialization function instead of hardcoding the value in the constructor. This seems to be done in both way and I don't know which style is prefered. Pick your favorite if the behavior is satisfying. 162171 7 42879 eric 2009-11-10 12:47:40 -0800 Comment on attachment 42879 Patch, use a RenderStyle static init function Seems we should set m_outline to the initial outline as well. This patch looks correct though. If you want it auto-committed you should set commit-queue=? as well. 162172 8 42870 eric 2009-11-10 12:48:03 -0800 Comment on attachment 42870 Patch, hardcode the color in the constructor The other patch is correct. 162401 9 42879 commit-queue 2009-11-11 01:38:46 -0800 Comment on attachment 42879 Patch, use a RenderStyle static init function Clearing flags on attachment: 42879 Committed r50796: <http://trac.webkit.org/changeset/50796> 162402 10 commit-queue 2009-11-11 01:38:50 -0800 All reviewed patches have been landed. Closing bug. 162406 11 jturcotte 2009-11-11 01:57:59 -0800 (In reply to comment #7) > Seems we should set m_outline to the initial outline as well. This patch looks I had a look at m_outline initialization. This members object take care of more than one style property and their initialization seems to be scattered around. Nothing is broken so I will let it as it is. 237674 12 mitz 2010-06-13 19:57:05 -0700 <http://trac.webkit.org/changeset/50796> caused a regression affecting WebKit clients on Mac OS X (because now an NSAttributedString created from a DOM range has the background color attribute (set to transparent), whereas before it didn’t). I would like to revert r50796, but not break Qt. One way to do so would be to also revert <http://trac.webkit.org/changeset/49242>, but its change log gives no motivation. Can someone explain why r49242 was needed? Thanks! 238047 13 kenneth 2010-06-14 14:36:53 -0700 (In reply to comment #12) > <http://trac.webkit.org/changeset/50796> caused a regression affecting WebKit clients on Mac OS X (because now an NSAttributedString created from a DOM range has the background color attribute (set to transparent), whereas before it didn’t). I would like to revert r50796, but not break Qt. One way to do so would be to also revert <http://trac.webkit.org/changeset/49242>, but its change log gives no motivation. Can someone explain why r49242 was needed? Thanks! I do not remember why that change was needed. Unfortunately that was long ago. But on one hand it seems strange that a color has a m_valid, and uses the color even if m_valid is false. 238052 14 mitz 2010-06-14 14:41:42 -0700 (In reply to comment #13) > (In reply to comment #12) > > <http://trac.webkit.org/changeset/50796> caused a regression affecting WebKit clients on Mac OS X (because now an NSAttributedString created from a DOM range has the background color attribute (set to transparent), whereas before it didn’t). I would like to revert r50796, but not break Qt. One way to do so would be to also revert <http://trac.webkit.org/changeset/49242>, but its change log gives no motivation. Can someone explain why r49242 was needed? Thanks! > > I do not remember why that change was needed. Unfortunately that was long ago. > > But on one hand it seems strange that a color has a m_valid, and uses the color even if m_valid is false. The invalid color is conveniently transparent, so in many contexts you can just use it without checking for validity. 238056 15 kenneth 2010-06-14 14:48:21 -0700 > The invalid color is conveniently transparent, so in many contexts you can just use it without checking for validity. Then I suggest that we remove my original patch and leave this comment instead. 238364 16 hausmann 2010-06-15 06:56:26 -0700 I believe https://trac.webkit.org/changeset/58949 makes the earlier changes obsolete and safe to back out. Tor Arne, what do you think? 238371 17 mitz 2010-06-15 07:16:25 -0700 Thanks for your help, Kenneth and Simon! After thinking about this some more and talking to Darin, I’ve decided to address the issue for Mac OS X clients by making a change in WebKit/mac rather than reverting the RenderStyle changes. 238377 18 58775 jesus 2010-06-15 07:35:55 -0700 Created attachment 58775 revert r49242 Patch for reverting the previous changes if needed. 238378 19 jesus 2010-06-15 07:37:31 -0700 (In reply to comment #17) > Thanks for your help, Kenneth and Simon! > > After thinking about this some more and talking to Darin, I’ve decided to address the issue for Mac OS X clients by making a change in WebKit/mac rather than reverting the RenderStyle changes. I've attached a patch as Kenneth suggested, but maybe it's too late, right?! :) I didn't mark it for review as it might not be needed anymore. 238740 20 vestbo 2010-06-16 02:03:42 -0700 r58949 should make it safe to pass invalid colors down to the Qt graphics context, as we won't draw anything in that case, so 50796 can be reverted, but we still have to keep 49242 since the QColor(r,g,b,a) constructor will create a valid QColor. 238741 21 58775 vestbo 2010-06-16 02:05:11 -0700 Comment on attachment 58775 revert r49242 > + // The invalid WebCore::Color is conveniently transparent, so in many contexts you can just use it without checking for validity. > + return QColor(red(), green(), blue(), alpha()); This is wrong, in the Qt context is is not transparent, so we cant use it without checking for validity, we have to keep the check to make the guards from r58949 catch it. 238743 22 vestbo 2010-06-16 02:08:09 -0700 (In reply to comment #17) > Thanks for your help, Kenneth and Simon! > > After thinking about this some more and talking to Darin, I’ve decided to address the issue for Mac OS X clients by making a change in WebKit/mac rather than reverting the RenderStyle changes. Feel free to go the original way of reverting r50796 238753 23 mitz 2010-06-16 02:17:00 -0700 (In reply to comment #22) > (In reply to comment #17) > > Thanks for your help, Kenneth and Simon! > > > > After thinking about this some more and talking to Darin, I’ve decided to address the issue for Mac OS X clients by making a change in WebKit/mac rather than reverting the RenderStyle changes. > > Feel free to go the original way of reverting r50796 No need for that after <http://trac.webkit.org/changeset/61189>. Thanks again for your help! 238829 24 hausmann 2010-06-16 06:17:03 -0700 Closing again after http://trac.webkit.org/changeset/61189 42869 2009-11-10 09:29:41 -0800 2009-11-10 09:29:41 -0800 testcase select_dropdown.html text/html 366 tonikitoo PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMCBUcmFuc2l0aW9uYWwv L0VOIj4KPGh0bWw+Cjxib2R5Pgo8IS0tIFRleHQgbGlzdGJveCBzaW5nbGUgc2VsZWN0aW9uLS0+ CjxzZWxlY3QgbmFtZT0ibGlzdGJveHNpbmdsZXNlbGVjdGlvbiIgc2l6ZT0iMiIgbXVsdGlwbGU9 Im11bHRpcGxlIj4KICA8b3B0aW9uIHZhbHVlPSIxIj5vcHRpb24gMTwvb3B0aW9uPgogIDxvcHRp b24gdmFsdWU9IjIiPm9wdGlvbiAyPC9vcHRpb24+CiAgPG9wdGlvbiB2YWx1ZT0iMyI+b3B0aW9u IDM8L29wdGlvbj4KICA8b3B0aW9uIHZhbHVlPSI0Ij5vcHRpb24gNDwvb3B0aW9uPgo8L3NlbGVj dD4KPGJyPgo8L2JvZHk+CjwvaHRtbD4K 42870 2009-11-10 09:37:37 -0800 2009-11-10 12:48:02 -0800 Patch, hardcode the color in the constructor webcore_validbackgroundcolor_simple.patch text/plain 1147 jturcotte ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yzc2ZDRhZC4uYTA4OGI2NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMS0xMCAgSm9jZWx5biBUdXJj b3R0ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTWFrZSB0aGUgZGVmYXVsdCBzdHlsZSBi YWNrZ3JvdW5kIGNvbG9yIHZhbGlkLgorICAgICAgICBDdXJyZW50bHkgdGhlIGNvbG9yIGlzIHRy YW5zcGFyZW50IGJ1dCBpbnZhbGlkLCB0aGlzIGNhdXNlcworICAgICAgICBsaXN0IGJveGVzIGlu IFF0V2ViS2l0IHRvIGJlIGRyYXduIHdpdGggYSBibGFjayBiYWNrZ3JvdW5kCisgICAgICAgIHNp bmNlIHI0OTI0Mi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMxMjk1CisKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvU3R5bGVCYWNrZ3JvdW5kRGF0 YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZUJhY2tncm91bmREYXRhOjpTdHlsZUJhY2tn cm91bmREYXRhKToKKwogMjAwOS0xMS0xMCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGln YWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQg YS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZUJhY2tncm91bmREYXRhLmNwcCBiL1dlYkNv cmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlQmFja2dyb3VuZERhdGEuY3BwCmluZGV4IDY4YTlkZGQu LjcwMDRmNTggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlQmFja2dy b3VuZERhdGEuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlQmFja2dyb3Vu ZERhdGEuY3BwCkBAIC0yOCw2ICsyOCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogU3R5bGVC YWNrZ3JvdW5kRGF0YTo6U3R5bGVCYWNrZ3JvdW5kRGF0YSgpCiAgICAgOiBtX2JhY2tncm91bmQo QmFja2dyb3VuZEZpbGxMYXllcikKKyAgICAsIG1fY29sb3IoQ29sb3I6OnRyYW5zcGFyZW50KQog ewogfQogCg== 42879 2009-11-10 11:05:20 -0800 2010-06-16 02:10:15 -0700 Patch, use a RenderStyle static init function webcore_validbackgroundcolor_initializingfunction.patch text/plain 2002 jturcotte ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yzc2ZDRhZC4uNDA1YzRkYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0xMS0xMCAgSm9jZWx5biBUdXJj b3R0ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTWFrZSB0aGUgZGVmYXVsdCBzdHlsZSBi YWNrZ3JvdW5kIGNvbG9yIHZhbGlkLgorICAgICAgICBDdXJyZW50bHkgdGhlIGNvbG9yIGlzIHRy YW5zcGFyZW50IGJ1dCBpbnZhbGlkLCB0aGlzIGNhdXNlcworICAgICAgICBsaXN0IGJveGVzIGlu IFF0V2ViS2l0IHRvIGJlIGRyYXduIHdpdGggYSBibGFjayBiYWNrZ3JvdW5kCisgICAgICAgIHNp bmNlIHI0OTI0Mi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMxMjk1CisKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaDoKKyAg ICAgICAgKFdlYkNvcmU6OkluaGVyaXRlZEZsYWdzOjppbml0aWFsQmFja2dyb3VuZENvbG9yKToK KyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvU3R5bGVCYWNrZ3JvdW5kRGF0YS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTdHlsZUJhY2tncm91bmREYXRhOjpTdHlsZUJhY2tncm91bmREYXRhKToK KwogMjAwOS0xMS0xMCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oIGIvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVu ZGVyU3R5bGUuaAppbmRleCBkM2RlZTViLi5jYzA2NDZlIDEwMDY0NAotLS0gYS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxl L1JlbmRlclN0eWxlLmgKQEAgLTExNzgsNiArMTE3OCw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMg ZmxvYXQgaW5pdGlhbFBlcnNwZWN0aXZlKCkgeyByZXR1cm4gMDsgfQogICAgIHN0YXRpYyBMZW5n dGggaW5pdGlhbFBlcnNwZWN0aXZlT3JpZ2luWCgpIHsgcmV0dXJuIExlbmd0aCg1MC4wLCBQZXJj ZW50KTsgfQogICAgIHN0YXRpYyBMZW5ndGggaW5pdGlhbFBlcnNwZWN0aXZlT3JpZ2luWSgpIHsg cmV0dXJuIExlbmd0aCg1MC4wLCBQZXJjZW50KTsgfQorICAgIHN0YXRpYyBDb2xvciBpbml0aWFs QmFja2dyb3VuZENvbG9yKCkgeyByZXR1cm4gQ29sb3I6OnRyYW5zcGFyZW50OyB9CiAKICAgICAv LyBLZWVwIHRoZXNlIGF0IHRoZSBlbmQuCiAgICAgc3RhdGljIGludCBpbml0aWFsTGluZUNsYW1w KCkgeyByZXR1cm4gLTE7IH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0 eWxlQmFja2dyb3VuZERhdGEuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVCYWNr Z3JvdW5kRGF0YS5jcHAKaW5kZXggNjhhOWRkZC4uMDhmNTUyNyAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVCYWNrZ3JvdW5kRGF0YS5jcHAKKysrIGIvV2ViQ29yZS9y ZW5kZXJpbmcvc3R5bGUvU3R5bGVCYWNrZ3JvdW5kRGF0YS5jcHAKQEAgLTIyLDEyICsyMiwxNCBA QAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlN0eWxlQmFja2dyb3VuZERhdGEuaCIK IAorI2luY2x1ZGUgIlJlbmRlclN0eWxlLmgiCiAjaW5jbHVkZSAiUmVuZGVyU3R5bGVDb25zdGFu dHMuaCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBTdHlsZUJhY2tncm91bmREYXRhOjpTdHls ZUJhY2tncm91bmREYXRhKCkKICAgICA6IG1fYmFja2dyb3VuZChCYWNrZ3JvdW5kRmlsbExheWVy KQorICAgICwgbV9jb2xvcihSZW5kZXJTdHlsZTo6aW5pdGlhbEJhY2tncm91bmRDb2xvcigpKQog ewogfQogCg== 58775 2010-06-15 07:35:55 -0700 2010-06-16 02:05:11 -0700 revert r49242 0001-Revert-r49242-because-an-invalid-WebCore-Color-is-co.patch text/plain 2027 jesus RnJvbSAzMGVkMGIzYzYzNDYyOGNmZTJlZGRiODk0ZDE3YjYxMjY3NTU1NjQ4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXN1cyBTYW5jaGV6LVBhbGVuY2lhIDxqZXN1c0B3ZWJraXQu b3JnPgpEYXRlOiBUdWUsIDE1IEp1biAyMDEwIDExOjM2OjIxIC0wMzAwClN1YmplY3Q6IFtQQVRD SF0gUmV2ZXJ0IHI0OTI0MiBiZWNhdXNlIGFuIGludmFsaWQgV2ViQ29yZTo6Q29sb3IgaXMgY29u dmVuaWVudGx5IHRyYW5zcGFyZW50LAogc28gaW4gbWFueSBjb250ZXh0cyB5b3UgY2FuIGp1c3Qg dXNlIGl0IHdpdGhvdXQgY2hlY2tpbmcgZm9yIHZhbGlkaXR5LgoKW1F0XSBSZW5kZXJpbmcgb2Yg aHRtbCBzZWxlY3QgZWxlbWVudHMgaXMgYnJva2VuCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMTI5NQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIHBsYXRm b3JtL2dyYXBoaWNzL3F0L0NvbG9yUXQuY3BwOgooV2ViQ29yZTo6Q29sb3I6Om9wZXJhdG9yIFFD b2xvcik6Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICB8ICAg MTMgKysrKysrKysrKysrKwogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Db2xvclF0LmNw cCB8ICAgIDYgKystLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDQgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCBmNWI4M2EzLi44MDE0YzYxIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTA2LTE1ICBK ZXN1cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXNAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFJlbmRlcmluZyBvZiBodG1s IHNlbGVjdCBlbGVtZW50cyBpcyBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMxMjk1CisKKyAgICAgICAgUmV2ZXJ0IHI0OTI0MiBiZWNhdXNl IGFuIGludmFsaWQgV2ViQ29yZTo6Q29sb3IgaXMgY29udmVuaWVudGx5IHRyYW5zcGFyZW50LAor ICAgICAgICBzbyBpbiBtYW55IGNvbnRleHRzIHlvdSBjYW4ganVzdCB1c2UgaXQgd2l0aG91dCBj aGVja2luZyBmb3IgdmFsaWRpdHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9D b2xvclF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbG9yOjpvcGVyYXRvciBRQ29sb3IpOgor CiAyMDEwLTA2LTE1ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUBwYXJvZ2EuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9xdC9Db2xvclF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv cXQvQ29sb3JRdC5jcHAKaW5kZXggMTUxNzY2YS4uYjBhNTI5ZiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Db2xvclF0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3F0L0NvbG9yUXQuY3BwCkBAIC00MCwxMCArNDAsOCBAQCBDb2xvcjo6Q29sb3Io Y29uc3QgUUNvbG9yJiBjKQogCiBDb2xvcjo6b3BlcmF0b3IgUUNvbG9yKCkgY29uc3QKIHsKLSAg ICBpZiAobV92YWxpZCkKLSAgICAgICAgcmV0dXJuIFFDb2xvcihyZWQoKSwgZ3JlZW4oKSwgYmx1 ZSgpLCBhbHBoYSgpKTsKLSAgICBlbHNlCi0gICAgICAgIHJldHVybiBRQ29sb3IoKTsKKyAgICAv LyBUaGUgaW52YWxpZCBXZWJDb3JlOjpDb2xvciBpcyBjb252ZW5pZW50bHkgdHJhbnNwYXJlbnQs IHNvIGluIG1hbnkgY29udGV4dHMgeW91IGNhbiBqdXN0IHVzZSBpdCB3aXRob3V0IGNoZWNraW5n IGZvciB2YWxpZGl0eS4KKyAgICByZXR1cm4gUUNvbG9yKHJlZCgpLCBncmVlbigpLCBibHVlKCks IGFscGhhKCkpOwogfQogCiB9Ci0tIAoxLjcuMC4zCgo=