31286 2009-11-09 22:39:39 -0800 fast/js/date-proto-generic-invocation breaks another test 2009-11-30 17:19:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P1 Critical --- 1 hamaji webkit-unassigned darin dimich eric mrowe sam yutak oldest_to_newest 161955 0 hamaji 2009-11-09 22:39:39 -0800 fast/js/date-proto-generic-invocation.html creates a toString() which raises an exception and this makes fast/js/global-constructors.html fail. The easiest way to re-produce this fail is ./WebKitTools/Scripts/run-webkit-tests --release LayoutTests/fast/js/date-proto-generic-invocation.html LayoutTests/fast/js/global-constructors.html This is the reason of the commit-queue failure https://bugs.webkit.org/show_bug.cgi?id=30423#c11 161956 1 42848 hamaji 2009-11-09 22:40:54 -0800 Created attachment 42848 Patch v1 161959 2 42849 hamaji 2009-11-09 23:23:22 -0800 Created attachment 42849 Patch v2 161963 3 42849 sam 2009-11-09 23:34:05 -0800 Comment on attachment 42849 Patch v2 This seems to just be papering over another issue. It is important to understand why this test is failing. 161968 4 hamaji 2009-11-10 00:05:22 -0800 (In reply to comment #3) > (From update of attachment 42849 [details]) > This seems to just be papering over another issue. It is important to > understand why this test is failing. I see. Yeah, it would be better to make test harness free from context leakage. Unfortunately, I think I don't have enough knowledge on this area to fix this issue soon. I hope someone fix this quickly as this issue prevents landing patches which add tests before fast/js/date-proto-generic-invocation.html (once one more test is added, these two tests will run in same DumpRenderTree). 163532 5 eric 2009-11-13 14:43:33 -0800 Is this also the reason for this bot failure? http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r50968%20(7227)/results.html --- layout-test-results/fast/js/global-constructors-expected.txt 2009-11-13 14:09:05.000000000 -0800 +++ layout-test-results/fast/js/global-constructors-actual.txt 2009-11-13 14:09:05.000000000 -0800 @@ -1,182 +1,10 @@ +CONSOLE MESSAGE: line 8: TypeError: Type error This test documents our set of global constructors we expose on the window object (FF and Opera don't expose them on the window, btw). This also checks to make sure than any constructor attribute we expose has the expected constructor type. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS Attr.toString() is '[object AttrConstructor]' [snip] 163636 6 yutak 2009-11-13 19:42:18 -0800 (In reply to comment #5) > Is this also the reason for this bot failure? I think so. 163863 7 hamaji 2009-11-16 00:04:26 -0800 Yeah, I think this is the same bug. Interestingly, this this failure isn't happening for now. It seems that this fail happens only when date-proto-generic-invocation is the first test for a DumpRenderTree process. For example, ./WebKitTools/Scripts/run-webkit-tests --release LayoutTests/fast/js/date-proto-generic-invocation.html LayoutTests/fast/js/global-constructors.html is still failing, but ./WebKitTools/Scripts/run-webkit-tests --release LayoutTests/fast/js/date-preserve-milliseconds.html LayoutTests/fast/js/date-proto-generic-invocation.html LayoutTests/fast/js/global-constructors.html doesn't fail. I think that's why we aren't seeing this failure in buildbot after the failure Eric mentioned. Anyway, I think we can land blocked patches now. We may want to reduce priority of this bug as this bug may not block other patches, I guess? 164067 8 darin 2009-11-16 13:55:03 -0800 Sam, can you suggest a better approach to fixing the bug? 166861 9 hamaji 2009-11-27 01:27:16 -0800 Hmm... this seems to cause failure again for Tiger build bot. http://build.webkit.org/results/Tiger%20Intel%20Release/r51430%20(6488)/fast/js/global-constructors-pretty-diff.html I believe this will continue failing until someone add a test before fast/js/date-proto-generic-invocation... 167479 10 sam 2009-11-30 17:12:22 -0800 The real issue is that we are sharing the JSClassRef for the LayoutTestController JS object between runs by using a static in LayoutTestController::getJSClass(). The fix is not generate a new JSClassRef each time the method is called. This seems like a deficiency in the JSC API, I will discuss this with Geoff. 167482 11 sam 2009-11-30 17:19:03 -0800 Fixed in r51523. 42848 2009-11-09 22:40:54 -0800 2009-11-09 23:23:16 -0800 Patch v1 bug-31286-20091110154052.patch text/plain 1711 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5OWIxNjk5Li4xMjhjOTI4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEt MDkgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBmYXN0L2pzL2RhdGUtcHJvdG8t Z2VuZXJpYy1pbnZvY2F0aW9uIGJyZWFrIGFub3RoZXIgdGVzdAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEyODYKKworICAgICAgICBSZXN0b3JlIHRo ZSBmdW5jdGlvbnMgdXNpbmcgdGhlIG9yaWdpbmFsIHZhbHVlLgorCisgICAgICAgICogZmFzdC9q cy9zY3JpcHQtdGVzdHMvZGF0ZS1wcm90by1nZW5lcmljLWludm9jYXRpb24uanM6CisKIDIwMDkt MTEtMDMgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv anMvc2NyaXB0LXRlc3RzL2RhdGUtcHJvdG8tZ2VuZXJpYy1pbnZvY2F0aW9uLmpzIGIvTGF5b3V0 VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvZGF0ZS1wcm90by1nZW5lcmljLWludm9jYXRpb24u anMKaW5kZXggZDBkZGE1MS4uNGEzOWY3OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9q cy9zY3JpcHQtdGVzdHMvZGF0ZS1wcm90by1nZW5lcmljLWludm9jYXRpb24uanMKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvZGF0ZS1wcm90by1nZW5lcmljLWludm9jYXRp b24uanMKQEAgLTM0LDggKzM0LDEyIEBAIHZhciBmdW5jdGlvbk5hbWVzID0gWwogCiB2YXIgbyA9 IG5ldyBPYmplY3QoKTsKIGZvciAodmFyIGkgPSAwOyBpIDwgZnVuY3Rpb25OYW1lcy5sZW5ndGg7 IGkrKykgewotICAgIHZhciB0ZXN0RnVuY3Rpb25OYW1lID0gIm8uX19wcm90b19fLiIgKyBmdW5j dGlvbk5hbWVzW2ldLnNwbGl0KCcuJylbMl07Ci0gICAgZXZhbCh0ZXN0RnVuY3Rpb25OYW1lICsg IiA9ICIgKyBmdW5jdGlvbk5hbWVzW2ldKTsKLSAgICBzaG91bGRUaHJvdyh0ZXN0RnVuY3Rpb25O YW1lICsgIigpIiwgJyJUeXBlRXJyb3I6IFR5cGUgZXJyb3IiJyk7CisgICAgdmFyIHRlc3RGdW5j dGlvbk5hbWUgPSBmdW5jdGlvbk5hbWVzW2ldLnNwbGl0KCcuJylbMl07CisgICAgdmFyIG9yaWdG dW5jdGlvbiA9IG8uX19wcm90b19fW3Rlc3RGdW5jdGlvbk5hbWVdOworICAgIHZhciB0ZXN0RnVu Y3Rpb25JblByb3RvID0gIm8uX19wcm90b19fLiIgKyB0ZXN0RnVuY3Rpb25OYW1lOworICAgIGV2 YWwodGVzdEZ1bmN0aW9uSW5Qcm90byArICIgPSAiICsgZnVuY3Rpb25OYW1lc1tpXSk7CisgICAg c2hvdWxkVGhyb3codGVzdEZ1bmN0aW9uSW5Qcm90byArICIoKSIsICciVHlwZUVycm9yOiBUeXBl IGVycm9yIicpOworICAgIC8vIFJlc3RvcmUgdGhlIG9yaWdpbmFsIGZ1bmN0aW9uIHNvIHRoYXQg dGhpcyB3b24ndCBicmVhayBvdGhlciB0ZXN0cy4KKyAgICBvLl9fcHJvdG9fX1t0ZXN0RnVuY3Rp b25OYW1lXSA9IG9yaWdGdW5jdGlvbjsKIH0KIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVl Ow== 42849 2009-11-09 23:23:22 -0800 2009-11-09 23:34:04 -0800 Patch v2 bug-31286-20091110162319.patch text/plain 1822 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5OWIxNjk5Li4yZTg1MGYzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEt MDkgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBmYXN0L2pzL2RhdGUtcHJvdG8t Z2VuZXJpYy1pbnZvY2F0aW9uIGJyZWFrcyBhbm90aGVyIHRlc3QKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMjg2CisKKyAgICAgICAgU2tpcCBnbG9i YWwgb2JqZWN0cyB3aGljaCBhcmUgbm90IHJlbGF0ZWQgdG8gdGhpcyB0ZXN0LgorCisgICAgICAg ICogZmFzdC9qcy9zY3JpcHQtdGVzdHMvZ2xvYmFsLWNvbnN0cnVjdG9ycy5qczoKKwogMjAwOS0x MS0wMyAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9q cy9zY3JpcHQtdGVzdHMvZ2xvYmFsLWNvbnN0cnVjdG9ycy5qcyBiL0xheW91dFRlc3RzL2Zhc3Qv anMvc2NyaXB0LXRlc3RzL2dsb2JhbC1jb25zdHJ1Y3RvcnMuanMKaW5kZXggZWE5NjFhYy4uZTdm YWNlZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvZ2xvYmFs LWNvbnN0cnVjdG9ycy5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9n bG9iYWwtY29uc3RydWN0b3JzLmpzCkBAIC0yLDcgKzIsMjggQEAgZGVzY3JpcHRpb24oIlRoaXMg dGVzdCBkb2N1bWVudHMgb3VyIHNldCBvZiBnbG9iYWwgY29uc3RydWN0b3JzIHdlIGV4cG9zZSBv biB0aGUKIAogdmFyIGNvbnN0cnVjdG9yTmFtZXMgPSBbXTsKIAordmFyIF9fc2tpcF9fID0gewor ICAgICJfX3NraXBfXyIgOiAxLAorICAgICJvcGVuZXIiIDogMSwgLy8gV29yayBhcm91bmQgRHVt cFJlbmRlclRyZWUgYnVnIHdoZXJlIHByZXZpb3VzIHRlc3RzIGFkZCB3aW5kb3cgcHJvcGVydGll cworICAgICJDb21wb25lbnRzIiA6IDEsIC8vIFdvcmsgYXJvdW5kIEZpcmVmb3ggZXhjZXB0aW9u CisKKyAgICAvLyBEb24ndCBsb2cgRHVtcFJlbmRlclRyZWUgaW5qZWN0ZWQgb2JqZWN0cworICAg ICJsYXlvdXRUZXN0Q29udHJvbGxlciIgOiAxLCAvLyBXb3JrIGFyb3VuZCBodHRwOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM3MworICAgICJHQ0NvbnRyb2xsZXIiIDogMSwK KyAgICAiYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIiIDogMSwKKyAgICAiYXBwbGVTY3JpcHRDb250 cm9sbGVyIiA6IDEsCisgICAgImV2ZW50U2VuZGVyIiA6IDEsCisgICAgIm5hdmlnYXRpb25Db250 cm9sbGVyIiA6IDEsCisgICAgIm9iakNDb250cm9sbGVyIiA6IDEsCisgICAgIm9iakNQbHVnaW4i IDogMSwKKyAgICAib2JqQ1BsdWdpbkZ1bmN0aW9uIiA6IDEsCisgICAgInBsYWluVGV4dCIgOiAx LAorICAgICJ0ZXh0SW5wdXRDb250cm9sbGVyIiA6IDEsCit9OworCiBmb3IgKHZhciBuYW1lIGlu IHdpbmRvdykgeworICAgIGlmIChfX3NraXBfX1tuYW1lXSkKKyAgICAgICAgY29udGludWU7CiAg ICAgdmFyIHZhbHVlID0gd2luZG93W25hbWVdOwogICAgIHZhciByZSA9IG5ldyBSZWdFeHAoIkNv bnN0cnVjdG9yXSQiKTsKICAgICB2YXIgaXNDb25zdHJ1Y3RvciA9IHJlLmV4ZWModmFsdWUpOw==