<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>31273</bug_id>
          
          <creation_ts>2009-11-09 13:11:18 -0800</creation_ts>
          <short_desc>[Qt][Symbian] Make sure WebKit headers are included before platform headers on Symbian</short_desc>
          <delta_ts>2011-01-08 07:02:54 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore JavaScript</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>S60 3rd edition</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>27065</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Norbert Leser">norbert.leser</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ariya.hidayat</cc>
    
    <cc>commit-queue</cc>
    
    <cc>diegohcg</cc>
    
    <cc>eric</cc>
    
    <cc>hausmann</cc>
    
    <cc>koshuin</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>s.mathur</cc>
    
    <cc>yongjun.zhang</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>161739</commentid>
    <comment_count>0</comment_count>
      <attachid>42790</attachid>
    <who name="Norbert Leser">norbert.leser</who>
    <bug_when>2009-11-09 13:11:18 -0800</bug_when>
    <thetext>Created attachment 42790
Patch for USERINCLUDE paths for symbian

Added macros for USERINCLUDE paths within symbian blocks to guarantee inclusion of respective header files from local path first (to avoid clashes with same names of header files in system include path).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>161751</commentid>
    <comment_count>1</comment_count>
      <attachid>42790</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2009-11-09 13:23:00 -0800</bug_when>
    <thetext>Comment on attachment 42790
Patch for USERINCLUDE paths for symbian

Looks plausable. How do you ensure that you don&apos;t have this problem with other includes?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>161760</commentid>
    <comment_count>2</comment_count>
    <who name="Norbert Leser">norbert.leser</who>
    <bug_when>2009-11-09 13:36:17 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; (From update of attachment 42790 [details])
&gt; Looks plausable. How do you ensure that you don&apos;t have this problem with other
&gt; includes?

We have verified that it is currently not the case, but unfortunately, there is no guarantee that this will happen with other include file name clashes in the future, at least not with this current version of the symbian tools chain.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>161846</commentid>
    <comment_count>3</comment_count>
      <attachid>42790</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-09 17:16:14 -0800</bug_when>
    <thetext>Comment on attachment 42790
Patch for USERINCLUDE paths for symbian

Rejecting patch 42790 from commit-queue.

Failed to run &quot;[&apos;/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply&apos;, &apos;--reviewer&apos;, &apos;Kenneth Rohde Christiansen&apos;, &apos;--force&apos;]&quot; exit_code: 1
Last 500 characters of output:
.pm line 397, &lt;&gt; line 66.
Use of uninitialized value in subtraction (-) at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 397, &lt;&gt; line 66.
Use of uninitialized value in subtraction (-) at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 398, &lt;&gt; line 66.
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/WebCore.pro
Hunk #1 FAILED at 12.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/WebCore.pro.rej</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>161849</commentid>
    <comment_count>4</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-09 17:20:45 -0800</bug_when>
    <thetext>Filed bug 31280 about the perl error.  This might be a false rejection.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163130</commentid>
    <comment_count>5</comment_count>
      <attachid>42790</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-11-12 18:15:32 -0800</bug_when>
    <thetext>Comment on attachment 42790
Patch for USERINCLUDE paths for symbian

Let&apos;s try again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163137</commentid>
    <comment_count>6</comment_count>
      <attachid>42790</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-12 18:20:40 -0800</bug_when>
    <thetext>Comment on attachment 42790
Patch for USERINCLUDE paths for symbian

Rejecting patch 42790 from commit-queue.

Failed to run &quot;[&apos;/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply&apos;, &apos;--reviewer&apos;, &apos;Kenneth Rohde Christiansen&apos;, &apos;--force&apos;]&quot; exit_code: 1
Last 500 characters of output:
.pm line 396, &lt;&gt; line 66.
Use of uninitialized value in subtraction (-) at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 396, &lt;&gt; line 66.
Use of uninitialized value in subtraction (-) at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 397, &lt;&gt; line 66.
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/WebCore.pro
Hunk #1 FAILED at 12.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/WebCore.pro.rej</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163395</commentid>
    <comment_count>7</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-13 11:47:02 -0800</bug_when>
    <thetext>There is definitely a bug in svn-apply here, but I don&apos;t think it&apos;s causing this failure.  I think the patch simply no longer applies.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163522</commentid>
    <comment_count>8</comment_count>
      <attachid>43203</attachid>
    <who name="Norbert Leser">norbert.leser</who>
    <bug_when>2009-11-13 14:24:22 -0800</bug_when>
    <thetext>Created attachment 43203
2nd update of patch file for bug #31273

Created a new patch (no content change). Apparently, the committer process thought there is a merge conflict.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163524</commentid>
    <comment_count>9</comment_count>
      <attachid>43203</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-13 14:27:43 -0800</bug_when>
    <thetext>Comment on attachment 43203
2nd update of patch file for bug #31273

It is possible I&apos;ve broken svn-apply with my recent fixes to the fixChangeLog function, and that this patch is triggering a bug there.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163527</commentid>
    <comment_count>10</comment_count>
    <who name="Norbert Leser">norbert.leser</who>
    <bug_when>2009-11-13 14:34:04 -0800</bug_when>
    <thetext>(In reply to comment #9)
&gt; (From update of attachment 43203 [details])
&gt; It is possible I&apos;ve broken svn-apply with my recent fixes to the fixChangeLog
&gt; function, and that this patch is triggering a bug there.

It more likely is a perceived conflict with checkin to bug#31272, which added a couple of lines to WebCore.pro at the same place as this one does.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163533</commentid>
    <comment_count>11</comment_count>
      <attachid>43203</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-13 14:44:45 -0800</bug_when>
    <thetext>Comment on attachment 43203
2nd update of patch file for bug #31273

Rejecting patch 43203 from commit-queue.

Failed to run &quot;WebKitTools/Scripts/build-webkit&quot; exit_code: 1
Last 500 characters of output:
ld/WebCore.build/Release/WebCore.build/Objects-normal/i386/JSCompositionEvent.o /Users/eseidel/Projects/CommitQueue/WebKitBuild/Release/DerivedSources/WebCore/JSCompositionEvent.cpp normal i386 c++ com.apple.compilers.gcc.4_2
	Distributed-CompileC /Users/eseidel/Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/i386/JSEventCustom.o /Users/eseidel/Projects/CommitQueue/WebCore/bindings/js/JSEventCustom.cpp normal i386 c++ com.apple.compilers.gcc.4_2
(2 failures)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163535</commentid>
    <comment_count>12</comment_count>
      <attachid>43203</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-13 14:47:03 -0800</bug_when>
    <thetext>Comment on attachment 43203
2nd update of patch file for bug #31273

My continued apologies.  I&apos;ve reverted back to the old commit-queue machine until I can figure out the build issue.  Hopefully the next run will not hit the JSC crasher. :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163548</commentid>
    <comment_count>13</comment_count>
      <attachid>43203</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-13 15:11:29 -0800</bug_when>
    <thetext>Comment on attachment 43203
2nd update of patch file for bug #31273

Rejecting patch 43203 from commit-queue.

Failed to run &quot;[&apos;WebKitTools/Scripts/run-webkit-tests&apos;, &apos;--no-launch-safari&apos;, &apos;--quiet&apos;, &apos;--exit-after-n-failures=1&apos;]&quot; exit_code: 1
Last 500 characters of output:
outTests
Testing 11622 test cases.
fast/canvas/canvas-longlived-context.html -&gt; timed out
Sampling process 46111 for 10 seconds with 10 milliseconds of run time between samples
Sampling completed, processing symbols...
Sample analysis of process 46111 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt

Exiting early after 1 failures. 4894 tests run.
838.61s total testing time

4893 test cases (99%) succeeded
1 test case (&lt;1%) timed out
3 test cases (&lt;1%) had stderr output</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163549</commentid>
    <comment_count>14</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-13 15:17:40 -0800</bug_when>
    <thetext>OK.  I&apos;m just gonna land this by hand, and let some other bug feel the brunt of the current commit-queue headaches. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163550</commentid>
    <comment_count>15</comment_count>
      <attachid>43203</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-13 15:19:30 -0800</bug_when>
    <thetext>Comment on attachment 43203
2nd update of patch file for bug #31273

Rejecting patch 43203 from commit-queue.

Failed to run &quot;[&apos;git&apos;, &apos;svn&apos;, &apos;dcommit&apos;]&quot; exit_code: 1
Last 500 characters of output:
tory/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/JavaScriptCore.pri
	M	WebCore/ChangeLog
	M	WebCore/WebCore.pro
A repository hook failed: MERGE request failed on &apos;/repository/webkit/trunk&apos;: Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can&apos;t write to stream: Broken pipe

    The following ChangeLog files contain OOPS:

        trunk/WebCore/ChangeLog

    Please don&apos;t ever say &quot;OOPS&quot; in a ChangeLog file.
 at /usr/local/libexec/git-core//git-svn line 469</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163551</commentid>
    <comment_count>16</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-13 15:20:05 -0800</bug_when>
    <thetext>Ha!  There is actually a real error in the ChangeLog in the end.  I&apos;ll fix and land this by hand.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163553</commentid>
    <comment_count>17</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-13 15:21:45 -0800</bug_when>
    <thetext>Committed r50970: &lt;http://trac.webkit.org/changeset/50970&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163557</commentid>
    <comment_count>18</comment_count>
    <who name="Norbert Leser">norbert.leser</who>
    <bug_when>2009-11-13 15:29:03 -0800</bug_when>
    <thetext>Wow, that was a rough landing ;)
I am sorry for the trouble you had to go through for this little patch (I thought) - and thanks, for the time!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163558</commentid>
    <comment_count>19</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-13 15:34:11 -0800</bug_when>
    <thetext>The trouble was self-inflicted. :)  I run the commit-queue and aside from the JSC crashes, these failures were all my fault. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163896</commentid>
    <comment_count>20</comment_count>
    <who name="Janne Koskinen">koshuin</who>
    <bug_when>2009-11-16 02:01:19 -0800</bug_when>
    <thetext>sigh.. why on earth this was landed.
I know what it tries to solve, but did you try this on 3.1,3.2,5.0,5.1 MCL, product and public SDK variants ?
Patch alters the inclusion order and is most likely to break.
Another reason not to have it is that it is specific to only some directories. If this kinda of fix is really necessary (I&apos;ve yet to see any broken builds due to this) then do it for all directories. i.e. use userinclude . and try it on all above variants. userinclude . makes it consistent will solve all #include &quot;localheader.h&quot; cases.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163946</commentid>
    <comment_count>21</comment_count>
    <who name="Norbert Leser">norbert.leser</who>
    <bug_when>2009-11-16 04:39:50 -0800</bug_when>
    <thetext>(In reply to comment #20)
&gt; sigh.. why on earth this was landed.
&gt; I know what it tries to solve, but did you try this on 3.1,3.2,5.0,5.1 MCL,
&gt; product and public SDK variants ?
&gt; Patch alters the inclusion order and is most likely to break.
&gt; Another reason not to have it is that it is specific to only some directories.
&gt; If this kinda of fix is really necessary (I&apos;ve yet to see any broken builds due
&gt; to this) then do it for all directories. i.e. use userinclude . and try it on
&gt; all above variants. userinclude . makes it consistent will solve all #include
&gt; &quot;localheader.h&quot; cases.

On which targets did it break for you? What was the error? (The targets I did not try it on are 3.x).

I agree with you that it would be preferable to apply this change to all localheader include cases. I am not sure what you mean with using &quot;userinclude&quot; and how to easily achieve that with current qmake for symbian? I used USERINCLUDE by mapping via MMP_RULES. If there is another way of generally applying userinclude, I&apos;d love to use that.

The patch for these particular include paths on targets beyond 5.0 due to changes in the (abld) tools chain. The first SYSTEMINCLUDE always becomes /epoc32/include, regardless of declarations in mmp files. That is, we must use USERINCLUDE to guarantee inclusion before that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163960</commentid>
    <comment_count>22</comment_count>
    <who name="Janne Koskinen">koshuin</who>
    <bug_when>2009-11-16 05:28:15 -0800</bug_when>
    <thetext>(In reply to comment #21)

I haven&apos;t tried the patch yet so don&apos;t know if it broke anything.
Headers are moved about in MCL releases and I would assume this could potentially break anyways.

&gt; I agree with you that it would be preferable to apply this change to all
&gt; localheader include cases. I am not sure what you mean with using &quot;userinclude&quot;

MMP_RULES += &quot;USERINCLUDE .&quot;

or change each include not under epoc32\include to be user includes.

Would be the only 2 alternatives I can live with :)

&gt; 
&gt; The patch for these particular include paths on targets beyond 5.0 due to
&gt; changes in the (abld) tools chain. The first SYSTEMINCLUDE always becomes
&gt; /epoc32/include, regardless of declarations in mmp files. That is, we must use
&gt; USERINCLUDE to guarantee inclusion before that.

This was a bug in SBSv2 and also on abld and has been fixed from SBSv2 already. It was added to fix some silly test case without thinking...

Toolchain is bugged, but we are trying to fix it instead of trying to work around it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>163976</commentid>
    <comment_count>23</comment_count>
    <who name="Norbert Leser">norbert.leser</who>
    <bug_when>2009-11-16 06:10:00 -0800</bug_when>
    <thetext>(In reply to comment #22)
&gt; (In reply to comment #21)
&gt; 
&gt; I haven&apos;t tried the patch yet so don&apos;t know if it broke anything.
&gt; Headers are moved about in MCL releases and I would assume this could
&gt; potentially break anyways.
&gt; 
&gt; &gt; I agree with you that it would be preferable to apply this change to all
&gt; &gt; localheader include cases. I am not sure what you mean with using &quot;userinclude&quot;
&gt; 
&gt; MMP_RULES += &quot;USERINCLUDE .&quot;
&gt; 
&gt; or change each include not under epoc32\include to be user includes.
&gt; 
&gt; Would be the only 2 alternatives I can live with :)

Wouldn&apos;t your first option still require some of the webkit code to be changed to define includes relative to &quot;.&quot;, such as #include &quot;profiler/profiler.h&quot;? That is what I wanted to avoid (I believe there was a request with this patch earlier this year which was either rejected or reversed).

The 2nd option seems to be very invasive, if I understand that right (would that require to special case for SYMBIAN almost all include paths in JavaScripCore.pri?

&gt; &gt; 
&gt; &gt; The patch for these particular include paths on targets beyond 5.0 due to
&gt; &gt; changes in the (abld) tools chain. The first SYSTEMINCLUDE always becomes
&gt; &gt; /epoc32/include, regardless of declarations in mmp files. That is, we must use
&gt; &gt; USERINCLUDE to guarantee inclusion before that.
&gt; 
&gt; This was a bug in SBSv2 and also on abld and has been fixed from SBSv2 already.
&gt; It was added to fix some silly test case without thinking...
&gt; 
&gt; Toolchain is bugged, but we are trying to fix it instead of trying to work
&gt; around it.

I am with you, to fix the toolchain, but we are facing the problem of build breaks right now and I have no idea when the fixed toolchain will be available. Besides, it is not a specific but a structural issue that the symbian toolchain uses USERINCLUDE paths instead of honoring the &quot;localinclude.h&quot; property. I haven&apos;t seen any attempt to fix that, and we have to work around that, somehow, in the least intrusive way (I still think, if we proof that these 3 USERINCLUDE declarations of this patch don&apos;t break other targets, it seems to be a useful workaround for the current situation).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>243912</commentid>
    <comment_count>24</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-06-28 14:48:54 -0700</bug_when>
    <thetext>As anticipated we now have more directories to special case (bridge, platform/animation). I agree with Janne that we need to find a better approach. 

Re-opening the bug with the intention of reverting 50970 and other possible workarounds. We need to re-evaulate which tool chain issues are fixed and which ones are remains to be fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244176</commentid>
    <comment_count>25</comment_count>
      <attachid>42790</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-06-29 03:15:47 -0700</bug_when>
    <thetext>Comment on attachment 42790
Patch for USERINCLUDE paths for symbian

Cleared Kenneth Rohde Christiansen&apos;s review+ from obsolete attachment 42790 so that this bug does not appear in http://webkit.org/pending-commit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244287</commentid>
    <comment_count>26</comment_count>
      <attachid>43203</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-06-29 07:40:22 -0700</bug_when>
    <thetext>Comment on attachment 43203
2nd update of patch file for bug #31273

clearing flags on the already committed patch to avoid confusion.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244392</commentid>
    <comment_count>27</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-06-29 11:30:39 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/62120 committed as a temporary workaround to get the builds going.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>254237</commentid>
    <comment_count>28</comment_count>
    <who name="Diego Gonzalez">diegohcg</who>
    <bug_when>2010-07-21 05:51:42 -0700</bug_when>
    <thetext>Should this bug be marked as fixed o wait for a definitive solution?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>266255</commentid>
    <comment_count>29</comment_count>
      <attachid>64739</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-08-18 11:05:39 -0700</bug_when>
    <thetext>Created attachment 64739
proposed solution

On Symbian PREPEND_INCLUDEPATH is the best way to make sure that WebKit headers are included before platform headers. On all other platforms continue to use INCLUDEPATH (as before).

This patch also removed the workarounds that are put in place now that we have a better solution.

Still testing the patch will put up for review once testing is finished.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>266331</commentid>
    <comment_count>30</comment_count>
      <attachid>64739</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-08-18 13:10:43 -0700</bug_when>
    <thetext>Comment on attachment 64739
proposed solution

patch does the trick for me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267660</commentid>
    <comment_count>31</comment_count>
    <who name="Ariya Hidayat">ariya.hidayat</who>
    <bug_when>2010-08-22 01:28:47 -0700</bug_when>
    <thetext>Janne: any comment about the latest patch/fix from Laszlo?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>268408</commentid>
    <comment_count>32</comment_count>
      <attachid>64739</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-08-24 01:50:47 -0700</bug_when>
    <thetext>Comment on attachment 64739
proposed solution

Landing manually</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>268412</commentid>
    <comment_count>33</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-08-24 01:52:16 -0700</bug_when>
    <thetext>Committed r65877: &lt;http://trac.webkit.org/changeset/65877&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>268447</commentid>
    <comment_count>34</comment_count>
      <attachid>64739</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-08-24 02:31:37 -0700</bug_when>
    <thetext>Comment on attachment 64739
proposed solution

Rejecting patch 64739 from commit-queue.

Failed to run &quot;[&apos;WebKitTools/Scripts/run-webkit-tests&apos;, &apos;--no-launch-safari&apos;, &apos;--exit-after-n-failures=1&apos;, &apos;--wait-for-httpd&apos;, &apos;--ignore-tests&apos;, &apos;compositing&apos;, &apos;--quiet&apos;]&quot; exit_code: 1
Last 500 characters of output:
mmitQueue/LayoutTests
Testing 20899 test cases.
media/video-autoplay.html -&gt; timed out
Sampling process 77784 for 10 seconds with 10 milliseconds of run time between samples
Sampling completed, processing symbols...
Sample analysis of process 77784 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt

Exiting early after 1 failures. 17221 tests run.
679.55s total testing time

17220 test cases (99%) succeeded
1 test case (&lt;1%) timed out
34 test cases (&lt;1%) had stderr output

Full output: http://queues.webkit.org/results/3740592</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>268542</commentid>
    <comment_count>35</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-08-24 07:14:23 -0700</bug_when>
    <thetext>Revision r50970 cherry-picked into qtwebkit-2.1 with commit 73452d5a19888918ffb19249ffd4a5c9e45f5c7c
Revision r65877 cherry-picked into qtwebkit-2.1 with commit 72b063270b1f7b6b909429ff9b02fdeb42b89cc4</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>328962</commentid>
    <comment_count>36</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-01-04 05:19:40 -0800</bug_when>
    <thetext>REOPEN as this hasn&apos;t been resolved for JavaScriptCore. Patch will follow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>328963</commentid>
    <comment_count>37</comment_count>
      <attachid>77880</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-01-04 05:20:41 -0800</bug_when>
    <thetext>Created attachment 77880
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>329096</commentid>
    <comment_count>38</comment_count>
      <attachid>77880</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-04 11:16:52 -0800</bug_when>
    <thetext>Comment on attachment 77880
proposed patch

Clearing flags on attachment: 77880

Committed r74978: &lt;http://trac.webkit.org/changeset/74978&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>329144</commentid>
    <comment_count>39</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-04 12:47:31 -0800</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 77880:

http/tests/appcache/simple.html bug 51891 (authors: andersca@apple.com and ap@webkit.org)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331059</commentid>
    <comment_count>40</comment_count>
      <attachid>78284</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-01-07 15:35:46 -0800</bug_when>
    <thetext>Created attachment 78284
fix for WebKit2

As it turns out WebKit2 part of the build needs this fix as well for Symbian. I wanted to minimize the &quot;Symbian only&quot; sections, that is why this work is being done piecemeal on a need bases.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331065</commentid>
    <comment_count>41</comment_count>
      <attachid>78284</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2011-01-07 15:39:39 -0800</bug_when>
    <thetext>Comment on attachment 78284
fix for WebKit2

View in context: https://bugs.webkit.org/attachment.cgi?id=78284&amp;action=review

&gt; WebKit2/WebKit2.pro:168
&gt;  
&gt; +symbian {
&gt; +    PREPEND_INCLUDEPATH = $$WEBKIT2_INCLUDEPATH $$PREPEND_INCLUDEPATH
&gt; +} else {
&gt; +    INCLUDEPATH = $$WEBKIT2_INCLUDEPATH $$INCLUDEPATH
&gt; +}

I think it would be nice with a comment here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331188</commentid>
    <comment_count>42</comment_count>
      <attachid>78284</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-01-08 07:01:52 -0800</bug_when>
    <thetext>Comment on attachment 78284
fix for WebKit2

Committed as http://trac.webkit.org/changeset/75320.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331190</commentid>
    <comment_count>43</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-01-08 07:02:54 -0800</bug_when>
    <thetext>Closing the bug as this has been resolved for JavaScriptCore, WebCore and WebKit2.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>42790</attachid>
            <date>2009-11-09 13:11:18 -0800</date>
            <delta_ts>2010-06-29 03:15:47 -0700</delta_ts>
            <desc>Patch for USERINCLUDE paths for symbian</desc>
            <filename>webcore_jsc_USERINCLUDE.patch</filename>
            <type>text/plain</type>
            <size>2415</size>
            <attacher name="Norbert Leser">norbert.leser</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIEphdmFTY3Jp
cHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNTA2NzgpCisrKyBKYXZhU2NyaXB0Q29yZS9DaGFu
Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMS0wOSAgTm9yYmVy
dCBMZXNlciAgPG5vcmJlcnQubGVzZXJAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIG1hY3JvcyBmb3IgVVNFUklOQ0xVREUg
cGF0aHMgd2l0aGluIHN5bWJpYW4gYmxvY2tzCisgICAgICAgIHRvIGd1YXJhbnRlZSBpbmNsdXNp
b24gb2YgcmVzcGVjdGl2ZSBoZWFkZXIgZmlsZXMgZnJvbSBsb2NhbCBwYXRoCisgICAgICAgIGZp
cnN0ICh0byBhdm9pZCBjbGFzaGVzIHdpdGggc2FtZSBuYW1lcyBvZiBoZWFkZXIgZmlsZXMgaW4g
c3lzdGVtIGluY2x1ZGUgcGF0aCkuCisKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS5wcmk6CisK
IDIwMDktMTEtMDkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgog
CiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpJbmRleDog
SmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpDQo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gSmF2YVNj
cmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpCShyZXZpc2lvbiA1MDY3NSkKKysrIEphdmFTY3Jp
cHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaQkod29ya2luZyBjb3B5KQpAQCAtOSw2ICs5LDExIEBA
IENPTkZJRyhkZWJ1ZywgZGVidWd8cmVsZWFzZSkgewogICAgIE9CSkVDVFNfRElSID0gb2JqL3Jl
bGVhc2UKIH0KIAorc3ltYmlhbjogeworICAgICMgTmVlZCB0byBndWFyYW50ZWUgdGhpcyBjb21l
cyBiZWZvcmUgc3lzdGVtIGluY2x1ZGVzIG9mIC9lcG9jMzIvaW5jbHVkZQorICAgIE1NUF9SVUxF
UyArPSAiVVNFUklOQ0xVREUgLi4vSmF2YVNjcmlwdENvcmUvcHJvZmlsZXIiCit9CisKIElOQ0xV
REVQQVRIID0gXAogICAgICQkUFdEIFwKICAgICAkJFBXRC8uLiBcCkluZGV4OiBXZWJDb3JlL0No
YW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA1MDY3
OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK
KzIwMDktMTEtMDkgIE5vcmJlcnQgTGVzZXIgIDxub3JiZXJ0Lmxlc2VyQG5va2lhLmNvbT4KKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBtYWNy
b3MgZm9yIFVTRVJJTkNMVURFIHBhdGhzIHdpdGhpbiBzeW1iaWFuIGJsb2NrcworICAgICAgICB0
byBndWFyYW50ZWUgaW5jbHVzaW9uIG9mIHJlc3BlY3RpdmUgaGVhZGVyIGZpbGVzIGZyb20gbG9j
YWwgcGF0aAorICAgICAgICBmaXJzdCAodG8gYXZvaWQgY2xhc2hlcyB3aXRoIHNhbWUgbmFtZXMg
b2YgaGVhZGVyIGZpbGVzIGluIHN5c3RlbSBpbmNsdWRlIHBhdGgpLgorCisgICAgICAgICogV2Vi
Q29yZS5wcm86CisKIDIwMDktMTEtMDkgIFZhZGltIFplaXRsaW4gIDx2YWRpbUB3eHdpZGdldHMu
b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtldmluIE9sbGl2aWVyLgpJbmRleDogV2ViQ29y
ZS9XZWJDb3JlLnBybw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUvV2ViQ29yZS5wcm8JKHJldmlz
aW9uIDUwNjc3KQorKysgV2ViQ29yZS9XZWJDb3JlLnBybwkod29ya2luZyBjb3B5KQpAQCAtMTIs
NiArMTIsOSBAQCBzeW1iaWFuOiB7CiAgICAgREVQTE9ZTUVOVCArPSB3ZWJraXRsaWJzCiAKICAg
ICBUQVJHRVQuVUlEMyA9IDB4MjAwMjY3QzIKKyAgICAjIE5lZWQgdG8gZ3VhcmFudGVlIHRoYXQg
dGhlc2UgY29tZSBiZWZvcmUgc3lzdGVtIGluY2x1ZGVzIG9mIC9lcG9jMzIvaW5jbHVkZQorICAg
IE1NUF9SVUxFUyArPSAiVVNFUklOQ0xVREUgcmVuZGVyaW5nIgorICAgIE1NUF9SVUxFUyArPSAi
VVNFUklOQ0xVREUgcGxhdGZvcm0vdGV4dCIKIH0KICMgUk8tc2VjdGlvbiBpbiBxdHdlYmtpdC5k
bGwgZXhjZWVkcyBhbGxvY2F0ZWQgc3BhY2UgaW4gU0JTdjIuIE1vdmUgUlctc2VjdGlvbgogIyBi
YXNlIGFkZHJlc3MgdG8gc3RhcnQgZnJvbSAweDgwMDAwMCBpbnN0ZWFkIG9mIHRoZSB0b29sY2hh
aW4gZGVmYXVsdCAweDQwMDAwMC4K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43203</attachid>
            <date>2009-11-13 14:24:22 -0800</date>
            <delta_ts>2010-08-18 11:05:39 -0700</delta_ts>
            <desc>2nd update of patch file for bug #31273</desc>
            <filename>webcore_jsc_USERINCLUDE_2.patch</filename>
            <type>text/plain</type>
            <size>2506</size>
            <attacher name="Norbert Leser">norbert.leser</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIEphdmFTY3Jp
cHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNTA5NjgpCisrKyBKYXZhU2NyaXB0Q29yZS9DaGFu
Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMS0xMyAgTm9yYmVy
dCBMZXNlciAgPG5vcmJlcnQubGVzZXImbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIG1hY3JvcyBmb3IgVVNFUklOQ0xVREUg
cGF0aHMgd2l0aGluIHN5bWJpYW4gYmxvY2tzCisgICAgICAgIHRvIGd1YXJhbnRlZSBpbmNsdXNp
b24gb2YgcmVzcGVjdGl2ZSBoZWFkZXIgZmlsZXMgZnJvbSBsb2NhbCBwYXRoCisgICAgICAgIGZp
cnN0ICh0byBhdm9pZCBjbGFzaGVzIHdpdGggc2FtZSBuYW1lcyBvZiBoZWFkZXIgZmlsZXMgaW4g
c3lzdGVtIGluY2x1ZGUgcGF0aCkuCisKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS5wcmk6CisK
IDIwMDktMTEtMTMgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBS
ZXZpZXdlZCBieSBHZW9mZiBHYXJlbi4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRD
b3JlLnByaQ0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQ0KLS0tIEphdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnBy
aQkocmV2aXNpb24gNTA5NjcpCisrKyBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkJ
KHdvcmtpbmcgY29weSkKQEAgLTksNiArOSwxMSBAQCBDT05GSUcoZGVidWcsIGRlYnVnfHJlbGVh
c2UpIHsKICAgICBPQkpFQ1RTX0RJUiA9IG9iai9yZWxlYXNlCiB9CiAKK3N5bWJpYW46IHsKKyAg
ICAjIE5lZWQgdG8gZ3VhcmFudGVlIHRoaXMgY29tZXMgYmVmb3JlIHN5c3RlbSBpbmNsdWRlcyBv
ZiAvZXBvYzMyL2luY2x1ZGUKKyAgICBNTVBfUlVMRVMgKz0gIlVTRVJJTkNMVURFIC4uL0phdmFT
Y3JpcHRDb3JlL3Byb2ZpbGVyIgorfQorCiBJTkNMVURFUEFUSCA9IFwKICAgICAkJFBXRCBcCiAg
ICAgJCRQV0QvLi4gXApJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBX
ZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNTA5NjgpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwko
d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDA5LTExLTEzICBOb3JiZXJ0IExlc2Vy
ICA8bm9yYmVydC5sZXNlciZub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgbWFjcm9zIGZvciBVU0VSSU5DTFVERSBwYXRocyB3
aXRoaW4gc3ltYmlhbiBibG9ja3MKKyAgICAgICAgdG8gZ3VhcmFudGVlIGluY2x1c2lvbiBvZiBy
ZXNwZWN0aXZlIGhlYWRlciBmaWxlcyBmcm9tIGxvY2FsIHBhdGgKKyAgICAgICAgZmlyc3QgKHRv
IGF2b2lkIGNsYXNoZXMgd2l0aCBzYW1lIG5hbWVzIG9mIGhlYWRlciBmaWxlcyBpbiBzeXN0ZW0g
aW5jbHVkZSBwYXRoKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAg
ICAqIFdlYkNvcmUucHJvOgorCiAyMDA5LTExLTEzICBIaXJvbm9yaSBCb25vICA8aGJvbm9AY2hy
b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpJbmRleDogV2Vi
Q29yZS9XZWJDb3JlLnBybw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUvV2ViQ29yZS5wcm8JKHJl
dmlzaW9uIDUwOTY3KQorKysgV2ViQ29yZS9XZWJDb3JlLnBybwkod29ya2luZyBjb3B5KQpAQCAt
MTIsNiArMTIsOSBAQCBzeW1iaWFuOiB7CiAgICAgREVQTE9ZTUVOVCArPSB3ZWJraXRsaWJzCiAK
ICAgICBUQVJHRVQuVUlEMyA9IDB4MjAwMjY3QzIKKyAgICAjIE5lZWQgdG8gZ3VhcmFudGVlIHRo
YXQgdGhlc2UgY29tZSBiZWZvcmUgc3lzdGVtIGluY2x1ZGVzIG9mIC9lcG9jMzIvaW5jbHVkZQor
ICAgIE1NUF9SVUxFUyArPSAiVVNFUklOQ0xVREUgcmVuZGVyaW5nIgorICAgIE1NUF9SVUxFUyAr
PSAiVVNFUklOQ0xVREUgcGxhdGZvcm0vdGV4dCIKICAgICAjIFJPIHRleHQgKGNvZGUpIHNlY3Rp
b24gaW4gcXR3ZWJraXQuZGxsIGV4Y2VlZHMgYWxsb2NhdGVkIHNwYWNlIGZvciBnY2NlIHVkZWIg
dGFyZ2V0LgogICAgICMgTW92ZSBSVy1zZWN0aW9uIGJhc2UgYWRkcmVzcyB0byBzdGFydCBmcm9t
IDB4RTAwMDAwIGluc3RlYWQgb2YgdGhlIHRvb2xjaGFpbiBkZWZhdWx0IDB4NDAwMDAwLgogICAg
IE1NUF9SVUxFUyArPSAiTElOS0VST1BUSU9OICBhcm1jYyAtLXJ3LWJhc2UgMHhFMDAwMDAiCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>64739</attachid>
            <date>2010-08-18 11:05:39 -0700</date>
            <delta_ts>2010-08-24 02:31:36 -0700</delta_ts>
            <desc>proposed solution</desc>
            <filename>31273.patch</filename>
            <type>text/plain</type>
            <size>2524</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA2NTYxNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMjEgQEAKKzIwMTAtMDgtMTggIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i
b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIFtRdF1bU3ltYmlhbl0gTWFrZSBzdXJlIFdlYktpdCBoZWFkZXJzIGFyZSBpbmNsdWRl
ZCBiZWZvcmUgcGxhdGZvcm0gaGVhZGVycyBvbiBTeW1iaWFuCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTI3MworCisgICAgICAgIE9uIFN5bWJpYW4g
UFJFUEVORF9JTkNMVURFUEFUSCBpcyB0aGUgYmVzdCB3YXkgdG8gbWFrZSBzdXJlIHRoYXQKKyAg
ICAgICAgV2ViS2l0IGhlYWRlcnMgYXJlIGluY2x1ZGVkIGJlZm9yZSBwbGF0Zm9ybSBoZWFkZXJz
LiBPbiBhbGwgb3RoZXIKKyAgICAgICAgcGxhdGZvcm1zIGNvbnRpbnVlIHRvIHVzZSBJTkNMVURF
UEFUSCAoYXMgYmVmb3JlKS4KKworICAgICAgICBUaGlzIHBhdGNoIGFsc28gcmVtb3ZlZCB0aGUg
d29ya2Fyb3VuZHMgdGhhdCBhcmUgcHV0IGluIHBsYWNlIAorICAgICAgICBub3cgdGhhdCB3ZSBo
YXZlIGEgYmV0dGVyIHNvbHV0aW9uLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGVyZSBp
cyBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIFdlYkNvcmUucHJvOgorCiAyMDEw
LTA4LTE4ICBNYWhlc2ggS3Vsa2FybmkgIDxtYWhlc2gua3Vsa2FybmlAbm9raWEuY29tPgogCiAg
ICAgICAgIFJldmlld2VkIGJ5IFN0ZXZlIEJsb2NrLgpJbmRleDogV2ViQ29yZS9XZWJDb3JlLnBy
bwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmUucHJvCShyZXZpc2lvbiA2NTYxMSkKKysr
IFdlYkNvcmUvV2ViQ29yZS5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTM4LDExICszOCw2IEBAIHN5
bWJpYW46IHsKIAogICAgIERFUExPWU1FTlQgKz0gd2Via2l0bGlicyB3ZWJraXRiYWNrdXAKIAot
ICAgICMgTmVlZCB0byBndWFyYW50ZWUgdGhhdCB0aGVzZSBjb21lIGJlZm9yZSBzeXN0ZW0gaW5j
bHVkZXMgb2YgL2Vwb2MzMi9pbmNsdWRlCi0gICAgTU1QX1JVTEVTICs9ICJVU0VSSU5DTFVERSBi
cmlkZ2UiCi0gICAgTU1QX1JVTEVTICs9ICJVU0VSSU5DTFVERSBwbGF0Zm9ybS9hbmltYXRpb24i
Ci0gICAgTU1QX1JVTEVTICs9ICJVU0VSSU5DTFVERSBwbGF0Zm9ybS90ZXh0IgotICAgIE1NUF9S
VUxFUyArPSAiVVNFUklOQ0xVREUgcmVuZGVyaW5nIgogICAgIHN5bWJpYW4tYWJsZHxzeW1iaWFu
LXNic3YyIHsKICAgICAgICAgIyBSTyB0ZXh0IChjb2RlKSBzZWN0aW9uIGluIHF0d2Via2l0LmRs
bCBleGNlZWRzIGFsbG9jYXRlZCBzcGFjZSBmb3IgZ2NjZSB1ZGViIHRhcmdldC4KICAgICAgICAg
IyBNb3ZlIFJXLXNlY3Rpb24gYmFzZSBhZGRyZXNzIHRvIHN0YXJ0IGZyb20gMHhFMDAwMDAgaW5z
dGVhZCBvZiB0aGUgdG9vbGNoYWluIGRlZmF1bHQgMHg0MDAwMDAuCkBAIC0xNzUsNyArMTcwLDcg
QEAgZGVmaW5lVGVzdChhZGRFeHRyYUNvbXBpbGVyKSB7CiB9CiBpbmNsdWRlKFdlYkNvcmUucHJp
KQogCi1JTkNMVURFUEFUSCA9IFwKK1dFQkNPUkVfSU5DTFVERVBBVEggPSBcCiAgICAgJCRQV0Qg
XAogICAgICQkUFdEL2FjY2Vzc2liaWxpdHkgXAogICAgICQkUFdEL2JpbmRpbmdzIFwKQEAgLTIy
MywxMCArMjE4LDkgQEAgSU5DTFVERVBBVEggPSBcCiAgICAgJCRQV0Qvd21sIFwKICAgICAkJFBX
RC93b3JrZXJzIFwKICAgICAkJFBXRC94bWwgXAotICAgICQkV0NfR0VORVJBVEVEX1NPVVJDRVNf
RElSIFwKLSAgICAkJElOQ0xVREVQQVRICisgICAgJCRXQ19HRU5FUkFURURfU09VUkNFU19ESVIK
IAotSU5DTFVERVBBVEggPSBcCitXRUJDT1JFX0lOQ0xVREVQQVRIID0gXAogICAgICQkUFdEL2Jy
aWRnZS9xdCBcCiAgICAgJCRQV0QvcGFnZS9xdCBcCiAgICAgJCRQV0QvcGxhdGZvcm0vZ3JhcGhp
Y3MvcXQgXApAQCAtMjM0LDcgKzIyOCwxMyBAQCBJTkNMVURFUEFUSCA9IFwKICAgICAkJFBXRC9w
bGF0Zm9ybS9xdCBcCiAgICAgJCRQV0QvLi4vV2ViS2l0L3F0L0FwaSBcCiAgICAgJCRQV0QvLi4v
V2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0IFwKLSAgICAkJElOQ0xVREVQQVRICisgICAgJCRXRUJD
T1JFX0lOQ0xVREVQQVRICisKK3N5bWJpYW4geworICAgIFBSRVBFTkRfSU5DTFVERVBBVEggPSAk
JFdFQkNPUkVfSU5DTFVERVBBVEggJCRQUkVQRU5EX0lOQ0xVREVQQVRICit9IGVsc2UgeworICAg
IElOQ0xVREVQQVRIID0gJCRXRUJDT1JFX0lOQ0xVREVQQVRIICQkSU5DTFVERVBBVEgKK30KIAog
UVQgKz0gbmV0d29yawogCg==
</data>
<flag name="review"
          id="53389"
          type_id="1"
          status="+"
          setter="hausmann"
    />
    <flag name="commit-queue"
          id="53973"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>77880</attachid>
            <date>2011-01-04 05:20:41 -0800</date>
            <delta_ts>2011-01-04 11:16:52 -0800</delta_ts>
            <desc>proposed patch</desc>
            <filename>31273.patch</filename>
            <type>text/plain</type>
            <size>2129</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzQ5NjQpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAK
KzIwMTEtMDEtMDQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bU3lt
Ymlhbl0gTWFrZSBzdXJlIHRoYXQgV2ViS2l0IGhlYWRlcnMgYXJlIGluY2x1ZGVkIGJlZm9yZSBw
bGF0Zm9ybSBoZWFkZXJzIG9uIFN5bWJpYW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTMxMjczCisKKyAgICAgICAgT24gU3ltYmlhbiBQUkVQRU5EX0lO
Q0xVREVQQVRIIGlzIHRoZSBiZXN0IHdheSB0byBtYWtlIHN1cmUgdGhhdCBXZWJLaXQgaGVhZGVy
cworICAgICAgICBhcmUgaW5jbHVkZWQgYmVmb3JlIHBsYXRmb3JtIGhlYWRlcnMuIE9uIGFsbCBv
dGhlciBwbGF0Zm9ybXMgY29udGludWUgdG8gdXNlCisgICAgICAgIElOQ0xVREVQQVRIIChhcyBi
ZWZvcmUpLiBUaGlzIGlzIGEgY29udGludWF0aW9uIG9mIHI2NTg3Ny4KKworICAgICAgICBObyBu
ZXcgdGVzdHMgYXMgdGhlcmUgaXMgbm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBK
YXZhU2NyaXB0Q29yZS5wcmk6CisKIDIwMTEtMDEtMDMgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBw
bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJyYWR5IEVpZHNvbi4KSW5kZXg6IFNvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl
L0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaQkocmV2aXNpb24gNzQ5NjQpCisrKyBT
b3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpCSh3b3JraW5nIGNvcHkpCkBA
IC0yMCwxNSArMjAsNyBAQCBDT05GSUcoc3RhbmRhbG9uZV9wYWNrYWdlKSB7CiAKIENPTkZJRyhz
dGFuZGFsb25lX3BhY2thZ2UpOiBERUZJTkVTICo9IE5ERUJVRwogCi1zeW1iaWFuOiB7Ci0gICAg
IyBOZWVkIHRvIGd1YXJhbnRlZSB0aGlzIGNvbWVzIGJlZm9yZSBzeXN0ZW0gaW5jbHVkZXMgb2Yg
L2Vwb2MzMi9pbmNsdWRlCi0gICAgTU1QX1JVTEVTICs9ICJVU0VSSU5DTFVERSAuLi9KYXZhU2Ny
aXB0Q29yZS9wcm9maWxlciIKLSAgICBMSUJTICs9IC1saGFsCi0gICAgIyBGb3IgaGFsLmgKLSAg
ICBJTkNMVURFUEFUSCAqPSAkJE1XX0xBWUVSX1NZU1RFTUlOQ0xVREUKLX0KLQotSU5DTFVERVBB
VEggPSBcCitKQVZBU0NSSVBUQ09SRV9JTkNMVURFUEFUSCA9IFwKICAgICAkJFBXRCBcCiAgICAg
JCRQV0QvLi4gXAogICAgICQkUFdELy4uLy4uIFwgIyBGSVhNRTogUmVtb3ZlIHRoaXMgaW5jbHVk
ZSBvbmNlIHdlIGZpbmlzaCBtb3ZpbmcgdGhlIHNvdXJjZSB0byBTb3VyY2UKQEAgLTQ5LDggKzQx
LDE5IEBAIElOQ0xVREVQQVRIID0gXAogICAgICQkUFdEL3lhcnIgXAogICAgICQkUFdEL0FQSSBc
CiAgICAgJCRQV0QvRm9yd2FyZGluZ0hlYWRlcnMgXAotICAgICQkSlNDX0dFTkVSQVRFRF9TT1VS
Q0VTX0RJUiBcCi0gICAgJCRJTkNMVURFUEFUSAorICAgICQkSlNDX0dFTkVSQVRFRF9TT1VSQ0VT
X0RJUgorCitzeW1iaWFuIHsKKyAgICBQUkVQRU5EX0lOQ0xVREVQQVRIID0gJCRKQVZBU0NSSVBU
Q09SRV9JTkNMVURFUEFUSCAkJFBSRVBFTkRfSU5DTFVERVBBVEgKK30gZWxzZSB7CisgICAgSU5D
TFVERVBBVEggPSAkJEpBVkFTQ1JJUFRDT1JFX0lOQ0xVREVQQVRIICQkSU5DTFVERVBBVEgKK30K
Kworc3ltYmlhbjogeworICAgIExJQlMgKz0gLWxoYWwKKyAgICAjIEZvciBoYWwuaAorICAgIElO
Q0xVREVQQVRIICo9ICQkTVdfTEFZRVJfU1lTVEVNSU5DTFVERQorfQogCiB3aW4zMi0qOiBERUZJ
TkVTICs9IF9IQVNfVFIxPTAKIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>78284</attachid>
            <date>2011-01-07 15:35:46 -0800</date>
            <delta_ts>2011-01-08 07:01:51 -0800</delta_ts>
            <desc>fix for WebKit2</desc>
            <filename>31273.patch</filename>
            <type>text/plain</type>
            <size>3008</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n
CShyZXZpc2lvbiA3NTI3OSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDEtMDcgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i
b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIFtRdF1bU3ltYmlhbl0gTWFrZSBzdXJlIFdlYktpdCBoZWFkZXJzIGFyZSBpbmNsdWRl
ZCBiZWZvcmUgcGxhdGZvcm0gaGVhZGVycyBvbiBTeW1iaWFuCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTI3MworCisgICAgICAgIE9uIFN5bWJpYW4g
UFJFUEVORF9JTkNMVURFUEFUSCBpcyB0aGUgYmVzdCB3YXkgdG8gbWFrZSBzdXJlIHRoYXQgV2Vi
S2l0IGhlYWRlcnMKKyAgICAgICAgYXJlIGluY2x1ZGVkIGJlZm9yZSBwbGF0Zm9ybSBoZWFkZXJz
LiBPbiBhbGwgb3RoZXIgcGxhdGZvcm1zIGNvbnRpbnVlIHRvIHVzZQorICAgICAgICBJTkNMVURF
UEFUSCAoYXMgYmVmb3JlKS4KKworICAgICAgICAqIFdlYktpdDIucHJvOgorCiAyMDExLTAxLTA3
ICBKZXNzaWUgQmVybGluICA8amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg
YnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFdlYktpdDIvV2ViS2l0Mi5wcm8KPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot
LS0gV2ViS2l0Mi9XZWJLaXQyLnBybwkocmV2aXNpb24gNzUyNzUpCisrKyBXZWJLaXQyL1dlYktp
dDIucHJvCSh3b3JraW5nIGNvcHkpCkBAIC0zMywxMiArMzMsMTEgQEAgREVTVERJUiA9ICQkV0VC
S0lUMl9ERVNURElSCiAjIEJ1aWxkIGJvdGggZGVidWcgYW5kIHJlbGVhc2UgY29uZmlndXJhdGlv
bnMKIG1hYzogQ09ORklHICs9IGJ1aWxkX2FsbAogCi1JTkNMVURFUEFUSCA9IFwKK1dFQktJVDJf
SU5DTFVERVBBVEggPSBcCiAgICAgJCRQV0QvLi4gXCAjIEZJWE1FOiBSZW1vdmUgdGhpcyBpbmNs
dWRlIG9uY2Ugd2UgbW92ZSBhbGwgdGhlIHNvdXJjZSB0byBTb3VyY2UuCiAgICAgJCRQV0QvLi4v
U291cmNlIFwKLSAgICAkJElOQ0xVREVQQVRICiAKLUlOQ0xVREVQQVRIID0gXAorV0VCS0lUMl9J
TkNMVURFUEFUSCA9IFwKICAgICAkJFBXRC8uLi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUgXAogICAg
ICQkUFdELy4uL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIgXAogICAgICQkUFdELy4u
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZSBcCkBAIC01Niw5ICs1NSw5IEBAIElOQ0xV
REVQQVRIID0gXAogICAgICQkUFdELy4uL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS95YXJyIFwKICAg
ICAkJFBXRC8uLi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJIFwKICAgICAkJFBXRC8uLi9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvRm9yd2FyZGluZ0hlYWRlcnMgXAotICAgICQkSU5DTFVERVBBVEgK
KyAgICAkJFdFQktJVDJfSU5DTFVERVBBVEgKIAotSU5DTFVERVBBVEggPSBcCitXRUJLSVQyX0lO
Q0xVREVQQVRIID0gXAogICAgICQkUFdELy4uL1dlYkNvcmUgXAogICAgICQkUFdELy4uL1dlYkNv
cmUvYWNjZXNzaWJpbGl0eSBcCiAgICAgJCRQV0QvLi4vV2ViQ29yZS9iaW5kaW5ncyBcCkBAIC0x
MDgsOSArMTA3LDkgQEAgSU5DTFVERVBBVEggPSBcCiAgICAgJCRQV0QvLi4vV2ViQ29yZS93bWwg
XAogICAgICQkUFdELy4uL1dlYkNvcmUvd29ya2VycyBcCiAgICAgJCRQV0QvLi4vV2ViQ29yZS94
bWwgXAotICAgICQkSU5DTFVERVBBVEgKKyAgICAkJFdFQktJVDJfSU5DTFVERVBBVEgKIAotSU5D
TFVERVBBVEggPSBcCitXRUJLSVQyX0lOQ0xVREVQQVRIID0gXAogICAgICQkUFdELy4uL1dlYkNv
cmUvYnJpZGdlL3F0IFwKICAgICAkJFBXRC8uLi9XZWJDb3JlL3BhZ2UvcXQgXAogICAgICQkUFdE
Ly4uL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQgXApAQCAtMTE4LDkgKzExNyw5IEBAIElO
Q0xVREVQQVRIID0gXAogICAgICQkUFdELy4uL1dlYkNvcmUvcGxhdGZvcm0vcXQgXAogICAgICQk
UFdELy4uL1dlYktpdC9xdC9BcGkgXAogICAgICQkUFdELy4uL1dlYktpdC9xdC9XZWJDb3JlU3Vw
cG9ydCBcCi0gICAgJCRJTkNMVURFUEFUSAorICAgICQkV0VCS0lUMl9JTkNMVURFUEFUSAogCi1J
TkNMVURFUEFUSCA9IFwKK1dFQktJVDJfSU5DTFVERVBBVEggPSBcCiAgICAgJCRQV0QgXAogICAg
IFBsYXRmb3JtIFwKICAgICBQbGF0Zm9ybS9Db3JlSVBDIFwKQEAgLTE1NCwxMyArMTUzLDE5IEBA
IElOQ0xVREVQQVRIID0gXAogICAgIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvcXQgXAogICAg
IFdlYlByb2Nlc3MvV2ViUGFnZSBcCiAgICAgV2ViUHJvY2Vzcy9xdCBcCi0gICAgJCRJTkNMVURF
UEFUSAorICAgICQkV0VCS0lUMl9JTkNMVURFUEFUSAogCi1JTkNMVURFUEFUSCArPSBcCitXRUJL
SVQyX0lOQ0xVREVQQVRIICs9IFwKICAgICAkJE9VVFBVVF9ESVIvaW5jbHVkZSBcCiAgICAgJCRX
Q19HRU5FUkFURURfU09VUkNFU19ESVIgXAotICAgICQkV0VCS0lUMl9HRU5FUkFURURfU09VUkNF
U19ESVIKKyAgICAkJFdFQktJVDJfR0VORVJBVEVEX1NPVVJDRVNfRElSIFwKKyAgICAkJFdFQktJ
VDJfSU5DTFVERVBBVEgKIAorc3ltYmlhbiB7CisgICAgUFJFUEVORF9JTkNMVURFUEFUSCA9ICQk
V0VCS0lUMl9JTkNMVURFUEFUSCAkJFBSRVBFTkRfSU5DTFVERVBBVEgKK30gZWxzZSB7CisgICAg
SU5DTFVERVBBVEggPSAkJFdFQktJVDJfSU5DTFVERVBBVEggJCRJTkNMVURFUEFUSAorfQogCiBQ
UkVGSVhfSEVBREVSID0gJCRQV0QvLi4vV2ViS2l0Mi9XZWJLaXQyUHJlZml4LmgKICotZysrKjpR
TUFLRV9DWFhGTEFHUyArPSAiLWluY2x1ZGUgJCRQUkVGSVhfSEVBREVSIgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>