31249 2009-11-08 19:21:02 -0800 [Qt] Remove the sessionStorage setting (per Page) 2009-11-09 11:04:40 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 29843 1 laszlo.gombos webkit-unassigned hausmann jorlow kenneth oldest_to_newest 161479 0 laszlo.gombos 2009-11-08 19:21:02 -0800 This setting does not quite work as a per Page setting (can not turn it off once it has been turned on). The setting does not control persistent data - I do not believe QtWebKit had a strong use-case for this. Note that this setting API is now in QtWebKit 4.6 production branch - so this patch can only be landed on the trunk if there is a commitment to cherry-pick this change to Qt 4.6 final - I think there is still time. This is a response to some discussion with Jeremy Orlow on #qtwebkit. Jeremy had a patch related to sessionStorage setting - if the setting will be removed from the Qt API Jeremy's patch should be re-landed as well - see http://trac.webkit.org/changeset/50569. 161480 1 42728 laszlo.gombos 2009-11-08 19:47:00 -0800 Created attachment 42728 remove sessionStorage setting API 161543 2 kenneth 2009-11-09 05:09:09 -0800 If it is not right, we should remove it for now. But one other thing. Session storage is per page group, and according to the spec, if you create a tab or new window from a page group (like open a "next" link in a wizard in another tab) it should clone the session storage. I wonder if we need a class for dealing with these issues. Does local storage suffer from any of these issues? 161544 3 kenneth 2009-11-09 05:11:13 -0800 One question. Is it turned on by default? I at least think we should do that. 161566 4 42728 laszlo.gombos 2009-11-09 07:09:36 -0800 Comment on attachment 42728 remove sessionStorage setting API missing change in qwebsettings.h. 161650 5 laszlo.gombos 2009-11-09 11:04:40 -0800 Landed as r50659 - http://trac.webkit.org/changeset/50659. 42728 2009-11-08 19:47:00 -0800 2009-11-09 07:09:36 -0800 remove sessionStorage setting API 31249.patch text/plain 4249 laszlo.gombos SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTA2MzQpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMTEtMDggIExhc3psbyBHb21ib3MgIDxsYXN6bG8u MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gUmVtb3ZlIHRoZSBzZXNzaW9uU3RvcmFnZSBzZXR0aW5nIChwZXIg UGFnZSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMx MjQ5CisKKyAgICAgICAgVGhpcyBzZXR0aW5nIGFsbG93cyB0byBydW4gc2Vzc2lvblN0b3JhZ2Ug b24vb2ZmIG9uIGEgcGVyIHBhZ2UKKyAgICAgICAgYmFzaXMuIFJlbW92ZSB0aGlzIHByZW1hdHVy ZWx5IGV4cG9zZWQgQVBJLgorCisgICAgICAgICogQXBpL3F3ZWJzZXR0aW5ncy5jcHA6CisgICAg ICAgIChRV2ViU2V0dGluZ3NQcml2YXRlOjphcHBseSk6CisgICAgICAgIChRV2ViU2V0dGluZ3M6 OlFXZWJTZXR0aW5ncyk6CisgICAgICAgICogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNw cDoKKyAgICAgICAgKHRzdF9RV2ViUGFnZTo6ZGF0YWJhc2UpOgorICAgICAgICAodHN0X1FXZWJQ YWdlOjp0ZXN0T3B0aW9uYWxKU09iamVjdHMpOgorCiAyMDA5LTExLTA1ICBTaHUgQ2hhbmcgIDxD aGFuZy5TaHVAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvciBBcm5lIFZlc3Ri w7guCkluZGV4OiBXZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCShyZXZpc2lvbiA1MDYyOCkKKysrIFdlYktp dC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA2LDEwICsyMDYs NiBAQCB2b2lkIFFXZWJTZXR0aW5nc1ByaXZhdGU6OmFwcGx5KCkKICAgICAgICAgdmFsdWUgPSBh dHRyaWJ1dGVzLnZhbHVlKFFXZWJTZXR0aW5nczo6TG9jYWxDb250ZW50Q2FuQWNjZXNzUmVtb3Rl VXJscywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2xvYmFsLT5hdHRy aWJ1dGVzLnZhbHVlKFFXZWJTZXR0aW5nczo6TG9jYWxDb250ZW50Q2FuQWNjZXNzUmVtb3RlVXJs cykpOwogICAgICAgICBzZXR0aW5ncy0+c2V0QWxsb3dVbml2ZXJzYWxBY2Nlc3NGcm9tRmlsZVVS THModmFsdWUpOwotCi0gICAgICAgIHZhbHVlID0gYXR0cmlidXRlcy52YWx1ZShRV2ViU2V0dGlu Z3M6OlNlc3Npb25TdG9yYWdlRW5hYmxlZCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGdsb2JhbC0+YXR0cmlidXRlcy52YWx1ZShRV2ViU2V0dGluZ3M6OlNlc3Npb25TdG9y YWdlRW5hYmxlZCkpOwotICAgICAgICBzZXR0aW5ncy0+c2V0U2Vzc2lvblN0b3JhZ2VFbmFibGVk KHZhbHVlKTsKICAgICB9IGVsc2UgewogICAgICAgICBRTGlzdDxRV2ViU2V0dGluZ3NQcml2YXRl Kj4gc2V0dGluZ3MgPSAqOjphbGxTZXR0aW5ncygpOwogICAgICAgICBmb3IgKGludCBpID0gMDsg aSA8IHNldHRpbmdzLmNvdW50KCk7ICsraSkKQEAgLTM1MSw4ICszNDcsNiBAQCBRV2ViU2V0dGlu Z3MqIFFXZWJTZXR0aW5nczo6Z2xvYmFsU2V0dGluCiAgICAgXHZhbHVlIExvY2FsU3RvcmFnZUVu YWJsZWQgU3BlY2lmaWVzIHdoZXRoZXIgc3VwcG9ydCBmb3IgdGhlIEhUTUwgNQogICAgICAgICBs b2NhbCBzdG9yYWdlIGZlYXR1cmUgaXMgZW5hYmxlZCBvciBub3QuIERpc2FibGVkIGJ5IGRlZmF1 bHQuCiAgICAgXHZhbHVlIExvY2FsQ29udGVudENhbkFjY2Vzc1JlbW90ZVVybHMgU3BlY2lmaWVz IHdoZXRoZXIgbG9jYWxseSBsb2FkZWQgZG9jdW1lbnRzIGFyZSBhbGxvd2VkIHRvIGFjY2VzcyBy ZW1vdGUgdXJscy4KLSAgICBcdmFsdWUgU2Vzc2lvblN0b3JhZ2VFbmFibGVkIFNwZWNpZmllcyB3 aGV0aGVyIHN1cHBvcnQgZm9yIHRoZSBIVE1MIDUKLSAgICAgICAgc2Vzc2lvbiBzdG9yYWdlIGZl YXR1cmUgaXMgZW5hYmxlZCBvciBub3QuIEVuYWJsZWQgYnkgZGVmYXVsdC4gICAgICAgICAgICAg ICAgCiAqLwogCiAvKiEKQEAgLTM4Myw3ICszNzcsNiBAQCBRV2ViU2V0dGluZ3M6OlFXZWJTZXR0 aW5ncygpCiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpPZmZsaW5lV2Vi QXBwbGljYXRpb25DYWNoZUVuYWJsZWQsIGZhbHNlKTsKICAgICBkLT5hdHRyaWJ1dGVzLmluc2Vy dChRV2ViU2V0dGluZ3M6OkxvY2FsU3RvcmFnZUVuYWJsZWQsIGZhbHNlKTsKICAgICBkLT5hdHRy aWJ1dGVzLmluc2VydChRV2ViU2V0dGluZ3M6OkxvY2FsQ29udGVudENhbkFjY2Vzc1JlbW90ZVVy bHMsIGZhbHNlKTsKLSAgICBkLT5hdHRyaWJ1dGVzLmluc2VydChRV2ViU2V0dGluZ3M6OlNlc3Np b25TdG9yYWdlRW5hYmxlZCwgdHJ1ZSk7CiAgICAgZC0+b2ZmbGluZVN0b3JhZ2VEZWZhdWx0UXVv dGEgPSA1ICogMTAyNCAqIDEwMjQ7CiAgICAgZC0+ZGVmYXVsdFRleHRFbmNvZGluZyA9IFFMYXRp bjFTdHJpbmcoImlzby04ODU5LTEiKTsKICAgICBkLT5wcmludGluZ01pbmltdW1TaHJpbmtGYWN0 b3IgPSAwLjBmOwpJbmRleDogV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5j cHAJKHJldmlzaW9uIDUwNjI4KQorKysgV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2Vi cGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1Niw3ICs0NTYsNiBAQCB2b2lkIHRzdF9RV2Vi UGFnZTo6ZGF0YWJhc2UoKQogICAgIFFWRVJJRlkoUVdlYlNldHRpbmdzOjpvZmZsaW5lU3RvcmFn ZURlZmF1bHRRdW90YSgpID09IDEwMjQgKiAxMDI0KTsKIAogICAgIG1fcGFnZS0+c2V0dGluZ3Mo KS0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6TG9jYWxTdG9yYWdlRW5hYmxlZCwgdHJ1ZSk7 Ci0gICAgbV9wYWdlLT5zZXR0aW5ncygpLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpTZXNz aW9uU3RvcmFnZUVuYWJsZWQsIHRydWUpOwogICAgIG1fcGFnZS0+c2V0dGluZ3MoKS0+c2V0QXR0 cmlidXRlKFFXZWJTZXR0aW5nczo6T2ZmbGluZVN0b3JhZ2VEYXRhYmFzZUVuYWJsZWQsIHRydWUp OwogCiAgICAgUVN0cmluZyBkYkZpbGVOYW1lID0gcGF0aCArICJEYXRhYmFzZXMuZGIiOwpAQCAt MTUwNSwxMSArMTUwNCw2IEBAIHZvaWQgdHN0X1FXZWJQYWdlOjp0ZXN0T3B0aW9uYWxKU09iamVj dHMKICAgICBRQ09NUEFSRSh0ZXN0RmxhZyh3ZWJQYWdlMiwgUVdlYlNldHRpbmdzOjpMb2NhbFN0 b3JhZ2VFbmFibGVkLCAibG9jYWxTdG9yYWdlIiwgdHJ1ZSksICB0cnVlKTsKICAgICBRQ09NUEFS RSh0ZXN0RmxhZyh3ZWJQYWdlMSwgUVdlYlNldHRpbmdzOjpMb2NhbFN0b3JhZ2VFbmFibGVkLCAi bG9jYWxTdG9yYWdlIiwgZmFsc2UpLCBmYWxzZSk7CiAgICAgUUNPTVBBUkUodGVzdEZsYWcod2Vi UGFnZTIsIFFXZWJTZXR0aW5nczo6TG9jYWxTdG9yYWdlRW5hYmxlZCwgImxvY2FsU3RvcmFnZSIs IGZhbHNlKSwgdHJ1ZSk7Ci0KLSAgICBRQ09NUEFSRSh0ZXN0RmxhZyh3ZWJQYWdlMSwgUVdlYlNl dHRpbmdzOjpTZXNzaW9uU3RvcmFnZUVuYWJsZWQsICJzZXNzaW9uU3RvcmFnZSIsIGZhbHNlKSwg ZmFsc2UpOwotICAgIFFDT01QQVJFKHRlc3RGbGFnKHdlYlBhZ2UyLCBRV2ViU2V0dGluZ3M6OlNl c3Npb25TdG9yYWdlRW5hYmxlZCwgInNlc3Npb25TdG9yYWdlIiwgdHJ1ZSksICB0cnVlKTsKLSAg ICBRQ09NUEFSRSh0ZXN0RmxhZyh3ZWJQYWdlMSwgUVdlYlNldHRpbmdzOjpTZXNzaW9uU3RvcmFn ZUVuYWJsZWQsICJzZXNzaW9uU3RvcmFnZSIsIGZhbHNlKSwgZmFsc2UpOwotICAgIFFDT01QQVJF KHRlc3RGbGFnKHdlYlBhZ2UyLCBRV2ViU2V0dGluZ3M6OlNlc3Npb25TdG9yYWdlRW5hYmxlZCwg InNlc3Npb25TdG9yYWdlIiwgZmFsc2UpLCB0cnVlKTsKIH0KIAogdm9pZCB0c3RfUVdlYlBhZ2U6 OnRlc3RFbmFibGVQZXJzaXN0ZW50U3RvcmFnZSgpCg==