31208 2009-11-06 10:12:02 -0800 [Qt] Pass credentials provided by XMLHTTPRequest to the network request. 2009-11-16 06:53:05 -0800 1 1 1 Unclassified WebKit XML 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 29799 1 yael webkit-unassigned commit-queue eric hausmann kenneth laszlo.gombos oldest_to_newest 161165 0 yael 2009-11-06 10:12:02 -0800 When XMLHTTPRequest gets credentials in the open() method, they should be passed to the network request. 161172 1 42659 yael 2009-11-06 10:48:39 -0800 Created attachment 42659 Patch Follow other ports and re-attach the credentials to the request URL. 161320 2 42659 zecke 2009-11-07 00:40:09 -0800 Comment on attachment 42659 Patch Sorry specially as this is a regression we will need a test case for this... I don't want to see it failing again. 161553 3 yael 2009-11-09 06:20:10 -0800 (In reply to comment #2) > (From update of attachment 42659 [details]) > Sorry specially as this is a regression we will need a test case for this... I > don't want to see it failing again. Test cases are already in place for this. Please take a look at LayOutTests/http/xmlhttprequest/basic-auth.html. Running this test, I found out that my patch fixes only async XHR, so I will submit a new patch soon, that will take care of sync XHR as well. 161558 4 kenneth 2009-11-09 06:29:02 -0800 Patch looks good, but should this: // so that they can be passed to QNetworkRequest. be // so that they will be passed to QNetworkRequest. ? 161575 5 42752 yael 2009-11-09 08:01:45 -0800 Created attachment 42752 Patch Fix authentication for sync XHR too. Also changed the comment as requested in comment #4, and added comment that LayOutTests/http/xmlhttprequest/basic-auth.html now passes. 161578 6 42752 commit-queue 2009-11-09 08:08:29 -0800 Comment on attachment 42752 Patch Rejecting patch 42752 from review queue. kenneth@webkit.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. 161580 7 kenneth 2009-11-09 08:15:41 -0800 Trying again after: Changeset [50660] by hausmann@webkit.org Adding Kenneth to the reviewers list. * Scripts/modules/committers.py: 161583 8 42752 commit-queue 2009-11-09 08:18:43 -0800 Comment on attachment 42752 Patch Rejecting patch 42752 from review queue. kenneth@webkit.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. 161586 9 yael 2009-11-09 08:34:43 -0800 (In reply to comment #8) > (From update of attachment 42752 [details]) > Rejecting patch 42752 from review queue. > > kenneth@webkit.org does not have reviewer permissions according to > http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. Congratulations Kenneth! I think it takes a few days before a new reviewer can approve patches. 161589 10 kenneth 2009-11-09 08:38:01 -0800 (In reply to comment #9) > (In reply to comment #8) > > (From update of attachment 42752 [details] [details]) > > Rejecting patch 42752 from review queue. > > > > kenneth@webkit.org does not have reviewer permissions according to > > http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. > > Congratulations Kenneth! > I think it takes a few days before a new reviewer can approve patches. Thanks. But it is the script that checks against that file, so maybe the commit bot doesn't check again the newest version or something else is wrong. I'm trying to talk to Eric on irc. 161600 11 eric 2009-11-09 09:24:24 -0800 Yes, sorry. Due to bug 30084 the commit-queue requires a restart to pick up committers.py modifications. I've restarted the queue now. 161603 12 kenneth 2009-11-09 09:28:37 -0800 Landed in 50662. 161604 13 kenneth 2009-11-09 09:30:38 -0800 OK, thanks Eric! :-) I committed one minute, before you restarted it. So I hope I was fast enough to clear the cq field. 161609 14 eric 2009-11-09 09:42:11 -0800 You can always see what the commit-queue is currently working on via: http://webkit-commit-queue.appspot.com/ Basically you can always outrun the commit-queue. Its commit will fail if you manage to commit before it. 42659 2009-11-06 10:48:39 -0800 2009-11-09 08:01:45 -0800 Patch 31208.patch text/plain 1808 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDYwMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTEtMDYgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gUGFzcyBjcmVkZW50aWFscyBwcm92aWRlZCBieSBYTUxIVFRQUmVxdWVzdCB0byB0aGUg bmV0d29yayByZXF1ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzEyMDgKKworICAgICAgICBBZnRlciByNDI0ODMsIHRoZSBjcmVkZW50aWFscyBh cmUgbm8gbG9uZ2VyIHBhc3NlZCB0byB0aGUgbmV0d29yayByZXF1ZXN0CisgICAgICAgIGluIHRo ZSBVUkwgb2YgdGhlIHJlcXVlc3QuCisgICAgICAgIFBhc3MgdGhlIGNyZWRlbnRpYWxzIGZyb20g WE1MSFRUUFJlcXVlc3QgdG8gdGhlIG5ldHdvcmsgcmVxdWVzdCwgdGhlIHNhbWUKKyAgICAgICAg d2F5IHRoYXQgb3RoZXIgcG9ydHMgZG8uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0 L1Jlc291cmNlSGFuZGxlUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6 OnN0YXJ0KToKKwogMjAwOS0xMS0wNiAgRHJldyBXaWxzb24gIDxhdHdpbHNvbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBXZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvcXQvUmVzb3VyY2VIYW5kbGVRdC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlSGFuZGxlUXQuY3BwCShyZXZpc2lvbiA1 MDU3NikKKysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9SZXNvdXJjZUhhbmRsZVF0LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTMxLDYgKzEzMSwxNSBAQAogICAgIGlmICghcGFnZSkKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgaWYgKCEoZC0+bV91c2VyLmlzRW1wdHkoKSB8fCBk LT5tX3Bhc3MuaXNFbXB0eSgpKSkgeworICAgICAgICAvLyBJZiBjcmVkZW50aWFscyB3ZXJlIHNw ZWNpZmllZCBmb3IgdGhpcyByZXF1ZXN0LCBhZGQgdGhlbSB0byB0aGUgdXJsLAorICAgICAgICAv LyBzbyB0aGF0IHRoZXkgY2FuIGJlIHBhc3NlZCB0byBRTmV0d29ya1JlcXVlc3QuCisgICAgICAg IEtVUkwgdXJsV2l0aENyZWRlbnRpYWxzKGQtPm1fcmVxdWVzdC51cmwoKSk7CisgICAgICAgIHVy bFdpdGhDcmVkZW50aWFscy5zZXRVc2VyKGQtPm1fdXNlcik7CisgICAgICAgIHVybFdpdGhDcmVk ZW50aWFscy5zZXRQYXNzKGQtPm1fcGFzcyk7CisgICAgICAgIGQtPm1fcmVxdWVzdC5zZXRVUkwo dXJsV2l0aENyZWRlbnRpYWxzKTsKKyAgICB9CisgICAgCiAgICAgZ2V0SW50ZXJuYWwoKS0+bV9m cmFtZSA9IHN0YXRpY19jYXN0PEZyYW1lTG9hZGVyQ2xpZW50UXQqPihmcmFtZS0+bG9hZGVyKCkt PmNsaWVudCgpKS0+d2ViRnJhbWUoKTsKICNpZiBRVF9WRVJTSU9OIDwgMHgwNDA0MDAKICAgICBy ZXR1cm4gUVdlYk5ldHdvcmtNYW5hZ2VyOjpzZWxmKCktPmFkZCh0aGlzLCBnZXRJbnRlcm5hbCgp LT5tX2ZyYW1lLT5wYWdlKCktPmQtPm5ldHdvcmtJbnRlcmZhY2UpOwo= 42752 2009-11-09 08:01:45 -0800 2009-11-09 09:27:44 -0800 Patch 31208.patch text/plain 2623 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDY1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMDktMTEtMDkgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gUGFzcyBjcmVkZW50aWFscyBwcm92aWRlZCBieSBYTUxIVFRQUmVxdWVzdCB0byB0aGUg bmV0d29yayByZXF1ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzEyMDgKKworICAgICAgICBBZnRlciByNDI0ODMsIHRoZSBjcmVkZW50aWFscyBh cmUgbm8gbG9uZ2VyIHBhc3NlZCB0byB0aGUgbmV0d29yayByZXF1ZXN0CisgICAgICAgIGluIHRo ZSBVUkwgb2YgdGhlIHJlcXVlc3QuCisgICAgICAgIFBhc3MgdGhlIGNyZWRlbnRpYWxzIGZyb20g WE1MSFRUUFJlcXVlc3QgdG8gdGhlIG5ldHdvcmsgcmVxdWVzdCwgdGhlIHNhbWUKKyAgICAgICAg d2F5IHRoYXQgb3RoZXIgcG9ydHMgZG8uCisKKyAgICAgICAgQWZ0ZXIgdGhpcyBwYXRjaCBMYXlv dXRUZXN0cy9odHRwL3htbGh0dHByZXF1ZXN0L2Jhc2ljLWF1dGguaHRtbCBwYXNzZXMuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlSGFuZGxlUXQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OnN0YXJ0KToKKyAgICAgICAgKFdlYkNvcmU6OlJl c291cmNlSGFuZGxlOjpsb2FkUmVzb3VyY2VTeW5jaHJvbm91c2x5KToKKwogMjAwOS0xMS0wOSAg Wm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlSGFuZGxlUXQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9SZXNvdXJjZUhhbmRs ZVF0LmNwcAkocmV2aXNpb24gNTA1NzYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQv UmVzb3VyY2VIYW5kbGVRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzMSw2ICsxMzEsMTUgQEAK ICAgICBpZiAoIXBhZ2UpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgIGlmICghKGQtPm1f dXNlci5pc0VtcHR5KCkgfHwgZC0+bV9wYXNzLmlzRW1wdHkoKSkpIHsKKyAgICAgICAgLy8gSWYg Y3JlZGVudGlhbHMgd2VyZSBzcGVjaWZpZWQgZm9yIHRoaXMgcmVxdWVzdCwgYWRkIHRoZW0gdG8g dGhlIHVybCwKKyAgICAgICAgLy8gc28gdGhhdCB0aGV5IHdpbGwgYmUgcGFzc2VkIHRvIFFOZXR3 b3JrUmVxdWVzdC4KKyAgICAgICAgS1VSTCB1cmxXaXRoQ3JlZGVudGlhbHMoZC0+bV9yZXF1ZXN0 LnVybCgpKTsKKyAgICAgICAgdXJsV2l0aENyZWRlbnRpYWxzLnNldFVzZXIoZC0+bV91c2VyKTsK KyAgICAgICAgdXJsV2l0aENyZWRlbnRpYWxzLnNldFBhc3MoZC0+bV9wYXNzKTsKKyAgICAgICAg ZC0+bV9yZXF1ZXN0LnNldFVSTCh1cmxXaXRoQ3JlZGVudGlhbHMpOworICAgIH0KKyAgICAKICAg ICBnZXRJbnRlcm5hbCgpLT5tX2ZyYW1lID0gc3RhdGljX2Nhc3Q8RnJhbWVMb2FkZXJDbGllbnRR dCo+KGZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCkpLT53ZWJGcmFtZSgpOwogI2lmIFFUX1ZFUlNJ T04gPCAweDA0MDQwMAogICAgIHJldHVybiBRV2ViTmV0d29ya01hbmFnZXI6OnNlbGYoKS0+YWRk KHRoaXMsIGdldEludGVybmFsKCktPm1fZnJhbWUtPnBhZ2UoKS0+ZC0+bmV0d29ya0ludGVyZmFj ZSk7CkBAIC0yMDQsNiArMjEzLDE0IEBACiAgICAgfQogI2Vsc2UKICAgICBSZXNvdXJjZUhhbmRs ZUludGVybmFsICpkID0gaGFuZGxlLmdldEludGVybmFsKCk7CisgICAgaWYgKCEoZC0+bV91c2Vy LmlzRW1wdHkoKSB8fCBkLT5tX3Bhc3MuaXNFbXB0eSgpKSkgeworICAgICAgICAvLyBJZiBjcmVk ZW50aWFscyB3ZXJlIHNwZWNpZmllZCBmb3IgdGhpcyByZXF1ZXN0LCBhZGQgdGhlbSB0byB0aGUg dXJsLAorICAgICAgICAvLyBzbyB0aGF0IHRoZXkgd2lsbCBiZSBwYXNzZWQgdG8gUU5ldHdvcmtS ZXF1ZXN0LgorICAgICAgICBLVVJMIHVybFdpdGhDcmVkZW50aWFscyhkLT5tX3JlcXVlc3QudXJs KCkpOworICAgICAgICB1cmxXaXRoQ3JlZGVudGlhbHMuc2V0VXNlcihkLT5tX3VzZXIpOworICAg ICAgICB1cmxXaXRoQ3JlZGVudGlhbHMuc2V0UGFzcyhkLT5tX3Bhc3MpOworICAgICAgICBkLT5t X3JlcXVlc3Quc2V0VVJMKHVybFdpdGhDcmVkZW50aWFscyk7CisgICAgfQogICAgIGQtPm1fZnJh bWUgPSBzdGF0aWNfY2FzdDxGcmFtZUxvYWRlckNsaWVudFF0Kj4oZnJhbWUtPmxvYWRlcigpLT5j bGllbnQoKSktPndlYkZyYW1lKCk7CiAgICAgZC0+bV9qb2IgPSBuZXcgUU5ldHdvcmtSZXBseUhh bmRsZXIoJmhhbmRsZSwgUU5ldHdvcmtSZXBseUhhbmRsZXI6OkxvYWROb3JtYWwpOwogI2VuZGlm Cg==