31140 2009-11-04 13:24:23 -0800 [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest 2009-11-16 06:53:05 -0800 1 1 1 Unclassified WebKit XML 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 29799 1 yael webkit-unassigned commit-queue eric hausmann kenneth laszlo.gombos thiago.macieira tonikitoo vestbo oldest_to_newest 160584 0 yael 2009-11-04 13:24:23 -0800 The following script fragment should add a request header to xhr, but in Qt it does not xhr.setRequestHeader("Custom", ""); The reason is that a NULL value causes QNetworkRequest::setRawHeader to remove the header, instead of adding it. 160592 1 42518 yael 2009-11-04 13:57:05 -0800 Created attachment 42518 Patch This patch converts the header value from null string to empty string before passing the header to QtNetwork. QtNetwork would add headers with empty strings, but not with null strings. 160832 2 hausmann 2009-11-05 08:12:41 -0800 Hm, we should talk to Thiago about this. Clearly calling setRawHeader() with a null value is currently the only way to _remove_ a header field from a request. But I think it would be cleaner if QNetworkRequest had a removeRawHeader() function and would allow empty header values. Your use-case is a good example of why supporting it would make sense, and therefore it would be nice to not have to work around Qt's behaviour in WebKit if possible. But yes, the last resort is your patch, which looks fine otherwise :) 160836 3 yael 2009-11-05 08:29:17 -0800 (In reply to comment #2) > Hm, we should talk to Thiago about this. Clearly calling setRawHeader() with a > null value is currently the only way to _remove_ a header field from a request. > But I think it would be cleaner if QNetworkRequest had a removeRawHeader() > function and would allow empty header values. > > Your use-case is a good example of why supporting it would make sense, and > therefore it would be nice to not have to work around Qt's behaviour in WebKit > if possible. > > But yes, the last resort is your patch, which looks fine otherwise :) Simon, I completely agree with you that this is a workaround for a QtNetwork issue. However, if we change QtNetwork, we will break its backwards compatibility, and I did not think Thiago will agree to that. 160847 4 tonikitoo 2009-11-05 09:24:49 -0800 thiago, they need you (see comment :) 160994 5 eric 2009-11-05 15:31:20 -0800 If this is a workaround for a QTNetwork issue, shouldn't it have a link to the QtNetwork bug in a comment? 161316 6 42518 zecke 2009-11-07 00:27:54 -0800 Comment on attachment 42518 Patch I agree with Eric that we at least need some documentation here, and it would be nice if you could come up with a simple http test. E.g. I think we already have a perl script that will return the http header... we should have a dump as text test for that. 161533 7 thiago.macieira 2009-11-09 02:28:26 -0800 setSomething with a null value is the way to remove that something. This pattern appears in multiple places in Qt. If you need an empty value, please use an empty-but-not-null QString. So attachment 42518 looks correct for me. 161542 8 kenneth 2009-11-09 05:02:17 -0800 Would be nice to add a comment above the change as well. Something along the lines of what Thiago said. 161705 9 42782 yael 2009-11-09 12:34:02 -0800 Created attachment 42782 Patch Added regression test and a comment for this patch. 161714 10 42782 commit-queue 2009-11-09 12:46:18 -0800 Comment on attachment 42782 Patch Clearing flags on attachment: 42782 Committed r50679: <http://trac.webkit.org/changeset/50679> 161715 11 commit-queue 2009-11-09 12:46:28 -0800 All reviewed patches have been landed. Closing bug. 42518 2009-11-04 13:57:05 -0800 2009-11-09 12:34:02 -0800 Patch 31140.patch text/plain 1431 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDUyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMDQgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gQWxsb3cgc2V0dGluZyBIVFRQIGhlYWRlcnMgd2l0aCBlbXB0eSB2YWx1ZSBpbiBYTUxI VFRQUmVxdWVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzExNDAKKworICAgICAgICBRdE5ldHdvcmsgaW50ZXJwcmV0cyBudWxsIHN0cmluZyBhcyBy ZXF1ZXN0IHRvIHJlbW92ZSB0aGUgaGVhZGVyLCBub3QgYWRkIGl0LgorICAgICAgICBTbyBpZiBh IGhlYWRlciBkb2VzIG5vdCBoYXZlIGEgdmFsdWUsIHBhc3MgUXROZXR3b3JrIGFuIGVtcHR5IHN0 cmluZyBpbnN0ZWFkLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9xdC9SZXNvdXJjZVJl cXVlc3RRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Q6OnRvTmV0d29y a1JlcXVlc3QpOgorCiAyMDA5LTExLTA0ICBCZW5qYW1pbiBPdHRlICA8b3R0ZUBnbm9tZS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhLgpJbmRleDogV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlUmVxdWVzdFF0LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUmVzb3VyY2VSZXF1ZXN0UXQuY3BwCShyZXZpc2lv biA1MDUyNCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9SZXNvdXJjZVJlcXVlc3RR dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQxLDcgKzQxLDEwIEBACiAgICAgICAgICBpdCAhPSBl bmQ7ICsraXQpIHsKICAgICAgICAgUUJ5dGVBcnJheSBuYW1lID0gUVN0cmluZyhpdC0+Zmlyc3Qp LnRvQXNjaWkoKTsKICAgICAgICAgUUJ5dGVBcnJheSB2YWx1ZSA9IFFTdHJpbmcoaXQtPnNlY29u ZCkudG9Bc2NpaSgpOwotICAgICAgICByZXF1ZXN0LnNldFJhd0hlYWRlcihuYW1lLCB2YWx1ZSk7 CisgICAgICAgIGlmICghdmFsdWUuaXNOdWxsKCkpCisgICAgICAgICAgICByZXF1ZXN0LnNldFJh d0hlYWRlcihuYW1lLCB2YWx1ZSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHJlcXVlc3Qu c2V0UmF3SGVhZGVyKG5hbWUsICIiKTsKICAgICB9CiAKICAgICBzd2l0Y2ggKGNhY2hlUG9saWN5 KCkpIHsK 42782 2009-11-09 12:34:02 -0800 2009-11-09 12:46:17 -0800 Patch 31140.patch text/plain 4139 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDY3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTEtMDkgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gQWxsb3cgc2V0dGluZyBIVFRQIGhlYWRlcnMgd2l0aCBlbXB0eSB2YWx1ZSBpbiBYTUxI VFRQUmVxdWVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzExNDAKKworICAgICAgICBRdE5ldHdvcmsgaW50ZXJwcmV0cyBudWxsIHN0cmluZyBhcyBy ZXF1ZXN0IHRvIHJlbW92ZSB0aGUgaGVhZGVyLCBub3QgYWRkIGl0LgorICAgICAgICBSZXBsYWNl IG51bGwgdmFsdWVzIHdpdGggZW1wdHkgdmFsdWVzIGJlZm9yZSBwYXNzaW5nIHRoZW0gdG8gUXRO ZXR3b3JrLgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QveG1saHR0 cHJlcXVlc3Qtc2V0cmVxdWVzdGhlYWRlci1uby12YWx1ZS5odG1sCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlUmVxdWVzdFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlc291cmNlUmVxdWVzdDo6dG9OZXR3b3JrUmVxdWVzdCk6CisKIDIwMDktMTEtMDkgIFNoaW5p Y2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUmVz b3VyY2VSZXF1ZXN0UXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9xdC9SZXNvdXJjZVJlcXVlc3RRdC5jcHAJKHJldmlzaW9uIDUwNjcyKQorKysgV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlUmVxdWVzdFF0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDEsNyArNDEsMTIgQEAKICAgICAgICAgIGl0ICE9IGVuZDsgKytpdCkgewogICAgICAgICBR Qnl0ZUFycmF5IG5hbWUgPSBRU3RyaW5nKGl0LT5maXJzdCkudG9Bc2NpaSgpOwogICAgICAgICBR Qnl0ZUFycmF5IHZhbHVlID0gUVN0cmluZyhpdC0+c2Vjb25kKS50b0FzY2lpKCk7Ci0gICAgICAg IHJlcXVlc3Quc2V0UmF3SGVhZGVyKG5hbWUsIHZhbHVlKTsKKyAgICAgICAgLy8gUU5ldHdvcmtS ZXF1ZXN0OjpzZXRSYXdIZWFkZXIoKSB3b3VsZCByZW1vdmUgdGhlIGhlYWRlciBpZiB0aGUgdmFs dWUgaXMgbnVsbAorICAgICAgICAvLyBNYWtlIHN1cmUgdG8gc2V0IGFuIGVtcHR5IGhlYWRlciBp bnN0ZWFkIG9mIG51bGwgaGVhZGVyLgorICAgICAgICBpZiAoIXZhbHVlLmlzTnVsbCgpKQorICAg ICAgICAgICAgcmVxdWVzdC5zZXRSYXdIZWFkZXIobmFtZSwgdmFsdWUpOworICAgICAgICBlbHNl CisgICAgICAgICAgICByZXF1ZXN0LnNldFJhd0hlYWRlcihuYW1lLCAiIik7CiAgICAgfQogCiAg ICAgc3dpdGNoIChjYWNoZVBvbGljeSgpKSB7CkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LXNldHJlcXVlc3RoZWFkZXItbm8tdmFsdWUu aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0 L3htbGh0dHByZXF1ZXN0LXNldHJlcXVlc3RoZWFkZXItbm8tdmFsdWUuaHRtbAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVl c3Qtc2V0cmVxdWVzdGhlYWRlci1uby12YWx1ZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDI0IEBACis8aHRtbD4KKzxib2R5PgorPHA+VGVzdCB0aGF0IHNldFJlcXVlc3RIZWFkZXIgY2Fu IGJlIHVzZWQgdG8gc2V0IGhlYWRlcnMgdGhhdCBoYXZlIGEgbmFtZSwgYnV0IG5vIHZhbHVlLjwv cD4KKzxwcmUgaWQ9cmVzdWx0PkZBSUw6IHNjcmlwdCBkaWRuJ3QgcnVuIG9yIHJhaXNlZCBhbiB1 bmV4cGVjdGVkIGV4Y2VwdGlvbi48L3ByZT4KKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlv dXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4 dCgpOworICAgIAorICAgIHJlcSA9IG5ldyBYTUxIdHRwUmVxdWVzdDsKKyAgICByZXEub3Blbigi R0VUIiwgInJlc291cmNlcy9wcmludC1oZWFkZXJzLmNnaSIsIGZhbHNlKTsKKworICAgIHJlcS5z ZXRSZXF1ZXN0SGVhZGVyKCJDVVNUT01fSEVBREVSIiwgIiIpOworICAgIHRyeSB7CisgICAgICAg IHJlcS5zZW5kKCIiKTsKKyAgICAgICAgaWYgKHJlcS5yZXNwb25zZVRleHQuaW5kZXhPZigiSFRU UF9DVVNUT01fSEVBREVSIikgPj0gMCkKKyAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJyZXN1bHQiKS50ZXh0Q29udGVudCA9ICJTVUNDRVNTIjsKKyAgICAgICAgZWxzZQorICAg ICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLnRleHRDb250ZW50ID0g cmVxLnJlc3BvbnNlVGV4dDsKKyAgICB9IGNhdGNoIChleCkgeworICAgICAgICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgicmVzdWx0IikudGV4dENvbnRlbnQgPSBleDsKKyAgICB9Cis8L3Njcmlw dD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0 cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qtc2V0cmVxdWVzdGhlYWRlci1uby12YWx1ZS1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVz dC94bWxodHRwcmVxdWVzdC1zZXRyZXF1ZXN0aGVhZGVyLW5vLXZhbHVlLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QveG1s aHR0cHJlcXVlc3Qtc2V0cmVxdWVzdGhlYWRlci1uby12YWx1ZS1leHBlY3RlZC50eHQJKHJldmlz aW9uIDApCkBAIC0wLDAgKzEsMyBAQAorVGVzdCB0aGF0IHNldFJlcXVlc3RIZWFkZXIgY2FuIGJl IHVzZWQgdG8gc2V0IGhlYWRlcnMgdGhhdCBoYXZlIGEgbmFtZSwgYnV0IG5vIHZhbHVlLgorCitT VUNDRVNTCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1MDY3NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDA5LTExLTA5ICBZYWVsIEFoYXJv biAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbUXRdIEFsbG93IHNldHRpbmcgSFRUUCBoZWFkZXJzIHdpdGgg ZW1wdHkgdmFsdWUgaW4gWE1MSFRUUFJlcXVlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMTQwCisKKyAgICAgICAgVGVzdCB0aGF0IFhIUiByZXF1 ZXN0IGNhbiBzZXQgaHR0cCBoZWFkZXJzIHdpdGggbm8gdmFsdWUuCisKKyAgICAgICAgKiBodHRw L3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LXNldHJlcXVlc3RoZWFkZXItbm8t dmFsdWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL3htbGh0dHBy ZXF1ZXN0L3htbGh0dHByZXF1ZXN0LXNldHJlcXVlc3RoZWFkZXItbm8tdmFsdWUuaHRtbDogQWRk ZWQuCisKIDIwMDktMTEtMDkgIE1hcmsgTWVudG92YWkgIDxtYXJrQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgo=