31092 2009-11-03 16:35:48 -0800 bugzilla-tool crashed with exception 2009-11-06 11:53:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 30683 1 eric webkit-unassigned abarth commit-queue oldest_to_newest 160268 0 eric 2009-11-03 16:35:48 -0800 From Adam: File "/Users/abarth/git/webkit/WebKitTools/Scripts/modules/bugzilla.py", line 227, in _validate_setter_email log("Warning, attachment %s on bug %s has invalid %s (%s)", (patch['id'], patch['bug_id'], result_key, setter_email)) TypeError: log() takes exactly 1 argument (2 given) Fix coming up. 160269 1 42436 eric 2009-11-03 16:36:44 -0800 Created attachment 42436 Patch 160325 2 42436 abarth 2009-11-03 22:58:54 -0800 Comment on attachment 42436 Patch Sorry, I should have caught that in an earlier code review, I'm sure. 160372 3 42436 commit-queue 2009-11-04 01:23:46 -0800 Comment on attachment 42436 Patch Rejecting patch 42436 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: tting to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebKitTools/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/libexec/git-core//git-svn line 469 160375 4 eric 2009-11-04 01:25:35 -0800 svn-apply (and thus the commit-queue) can't handle this diff due to bug 30683. Hopefully that will land soon, otherwise I can land this manually. 160729 5 42436 eric 2009-11-04 22:19:33 -0800 Comment on attachment 42436 Patch Try again now that bug 30683 is in the queue to be landed. 160736 6 42436 commit-queue 2009-11-04 22:59:46 -0800 Comment on attachment 42436 Patch Rejecting patch 42436 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: tting to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebKitTools/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/libexec/git-core//git-svn line 469 160843 7 eric 2009-11-05 08:49:39 -0800 Strange. Now that bug 30683 is fixed, this should land correctly. I'll investigate. 161206 8 42436 eric 2009-11-06 11:41:27 -0800 Comment on attachment 42436 Patch bugzilla-tool apply-patches worked just fine, so I assume the commit-queue's svn-apply just hadn't been updated yet when I last queued this. We'll try on last time. 161215 9 42436 commit-queue 2009-11-06 11:53:27 -0800 Comment on attachment 42436 Patch Clearing flags on attachment: 42436 Committed r50602: <http://trac.webkit.org/changeset/50602> 161216 10 commit-queue 2009-11-06 11:53:32 -0800 All reviewed patches have been landed. Closing bug. 42436 2009-11-03 16:36:44 -0800 2009-11-06 11:53:27 -0800 Patch bug-31092-20091103163643.patch text/plain 1449 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA4MjAwZjk1Li5lMGZkMzk1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTUgQEAKIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBidWd6aWxsYS10b29sIGNy YXNoZWQgd2l0aCBleGNlcHRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMxMDkyCisKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvYnVnemlsbGEu cHk6IENoYW5nZSBhICcsJyB0byBhICclJyB0byBmaXggdGhlIGVycm9yLgorCisyMDA5LTExLTAz ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBjb21taXQtcXVldWUgaXMgY3Jhc2hpbmcgd2hlbiB0 cnlpbmcgdG8gcmVqZWN0IHBhdGNoZXMgYWZ0ZXIgdW5rbm93biBmYWlsdXJlcwogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzEwOTEKIApkaWZmIC0tZ2l0 IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5IGIvV2ViS2l0VG9vbHMv U2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5CmluZGV4IGZlODFiNDguLjk1MzkyOGIgMTAwNjQ0 Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5weQorKysgYi9XZWJL aXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHkKQEAgLTIyNCw3ICsyMjQsNyBAQCBj bGFzcyBCdWd6aWxsYToKICAgICAgICAgICAgIGZhaWx1cmVfbWVzc2FnZSA9ICIlcyBkb2VzIG5v dCBoYXZlICVzIHBlcm1pc3Npb25zIGFjY29yZGluZyB0byAlcy4iICUgKHNldHRlcl9lbWFpbCwg cmVzdWx0X2tleSwgc2VsZi5fdmlld19zb3VyY2VfbGluayhjb21taXR0ZXJfbGlzdCkpCiAgICAg ICAgICAgICByZWplY3Rpb25fZnVuY3Rpb24ocGF0Y2hbJ2lkJ10sIGZhaWx1cmVfbWVzc2FnZSkK ICAgICAgICAgZWxzZToKLSAgICAgICAgICAgIGxvZygiV2FybmluZywgYXR0YWNobWVudCAlcyBv biBidWcgJXMgaGFzIGludmFsaWQgJXMgKCVzKSIsIChwYXRjaFsnaWQnXSwgcGF0Y2hbJ2J1Z19p ZCddLCByZXN1bHRfa2V5LCBzZXR0ZXJfZW1haWwpKQorICAgICAgICAgICAgbG9nKCJXYXJuaW5n LCBhdHRhY2htZW50ICVzIG9uIGJ1ZyAlcyBoYXMgaW52YWxpZCAlcyAoJXMpIiAlIChwYXRjaFsn aWQnXSwgcGF0Y2hbJ2J1Z19pZCddLCByZXN1bHRfa2V5LCBzZXR0ZXJfZW1haWwpKQogICAgICAg ICByZXR1cm4gTm9uZQogCiAgICAgZGVmIF92YWxpZGF0ZV9yZXZpZXdlcihzZWxmLCBwYXRjaCwg cmVqZWN0X2ludmFsaWRfcGF0Y2hlcyk6