31077 2009-11-03 12:12:29 -0800 [Qt] ASSERT failure when receiving 401 HTTP Authentication response. 2009-11-17 05:37:19 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 29799 1 yael yael commit-queue hausmann kenneth oldest_to_newest 160160 0 yael 2009-11-03 12:12:29 -0800 QNetworkReplyHandler::sendResponseIfNeeded() does not send the response for any error situation, but QNetworkReplyHandler::finish() calls client->didFinishLoading() for some error conditions. That leads to ASSERT(!m_response.isNull()) , in MainResourceLoader::didReceiveData(). If we decide to handle the error response as if there was no error, we should also send the response to the client in sendResponseIfNeeded(). 160208 1 42417 yael 2009-11-03 14:16:16 -0800 Created attachment 42417 Patch This patch is only handling the ASSERT. HTTP auth support would be a separate bug. 160456 2 42417 commit-queue 2009-11-04 09:09:01 -0800 Comment on attachment 42417 Patch Clearing flags on attachment: 42417 Committed r50514: <http://trac.webkit.org/changeset/50514> 160457 3 commit-queue 2009-11-04 09:09:07 -0800 All reviewed patches have been landed. Closing bug. 161560 4 kenneth 2009-11-09 06:42:26 -0800 Did this patch fix any layout tests? Or should we add one? 42417 2009-11-03 14:16:16 -0800 2009-11-04 09:09:01 -0800 Patch 31077.patch text/plain 1268 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDQ4MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMDMgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gQVNTRVJUIGZhaWx1cmUgd2hlbiByZWNlaXZpbmcgNDAxIEhUVFAgQXV0aGVudGljYXRp b24gcmVzcG9uc2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMTA3NworCisgICAgICAgIEFsbG93IHNlbmRpbmcgdGhlIHJlc3BvbnNlIGJvZHkgdW5k ZXIgdGhlIHNhbWUgY29uZGl0aW9ucyB0aGF0IHdlCisgICAgICAgIGFsbG93IGl0IHRvIGZpbmlz aCB3aXRob3V0IHJlcG9ydGluZyBhbiBlcnJvci4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdv cmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UU5ldHdv cmtSZXBseUhhbmRsZXI6OnNlbmRSZXNwb25zZUlmTmVlZGVkKToKKwogMjAwOS0xMS0wMyAgRG1p dHJ5IFRpdG92ICA8ZGltaWNoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQs IFF0IGJ1aWxkIGZpeC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29y a1JlcGx5SGFuZGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcAkocmV2aXNpb24gNTA0ODMpCisrKyBXZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yNTksNyArMjU5LDcgQEAKICAgICBpZiAobV9zaG91bGRTZW5kUmVzcG9uc2UpCiAg ICAgICAgIHJldHVybjsKIAotICAgIGlmIChtX3JlcGx5LT5lcnJvcigpKQorICAgIGlmIChtX3Jl cGx5LT5lcnJvcigpICYmICFpZ25vcmVIdHRwRXJyb3IobV9yZXBseSwgbV9yZXNwb25zZURhdGFT ZW50KSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgaWYgKG1fcmVzcG9uc2VTZW50IHx8ICFtX3Jl c291cmNlSGFuZGxlKQo=