30894 2009-10-28 19:51:12 -0700 [Qt] Implement DELETE HTTP method for XmlHttpRequest 2009-10-29 11:29:37 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 29799 1 laszlo.gombos webkit-unassigned commit-queue kenneth oldest_to_newest 158818 0 laszlo.gombos 2009-10-28 19:51:12 -0700 DELETE method is not implemented for QtWebKit as the underlying QtNetwork module did not supported this HTTP method up until now. The next version of the QtNetwork library (v4.5) will support the DELETE method. The following patch takes advantage of the new QtNetwork feature and implements the DELETE method for XHR. 158819 1 42079 laszlo.gombos 2009-10-28 20:11:15 -0700 Created attachment 42079 proposed patch 158876 2 kenneth 2009-10-29 06:20:36 -0700 4.6 you mean? 158879 3 laszlo.gombos 2009-10-29 06:48:10 -0700 (In reply to comment #2) > 4.6 you mean? Kenneth, yes type - I meant 4.6 in the original bug description. ChangeLog and code looks good. 158880 4 laszlo.gombos 2009-10-29 06:48:40 -0700 (In reply to comment #3) > (In reply to comment #2) > > 4.6 you mean? > > Kenneth, yes type - I meant 4.6 in the original bug description. ChangeLog and > code looks good. I meant typo not type.. 158983 5 42079 commit-queue 2009-10-29 11:29:33 -0700 Comment on attachment 42079 proposed patch Clearing flags on attachment: 42079 Committed r50288: <http://trac.webkit.org/changeset/50288> 158984 6 commit-queue 2009-10-29 11:29:37 -0700 All reviewed patches have been landed. Closing bug. 42079 2009-10-28 20:11:15 -0700 2009-10-29 11:29:33 -0700 proposed patch 30894.patch text/plain 3663 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDI1NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMTAtMjggIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gSW1wbGVtZW50IERFTEVURSBIVFRQIG1ldGhvZCBmb3IgWG1sSHR0cFJlcXVl c3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwODk0 CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIHRoaXMgZnVuY3Rpb25hbGl0eSBpcyBhbHJlYWR5 IHRlc3RlZCBieSB0aGUgCisgICAgICAgIHhtbGh0dHByZXF1ZXN0IExheW91dFRlc3RzLiBBcyB0 aGlzIHBhdGNoIGRlcGVuZHMgb24gYW4gdW5yZWxlYXNlZAorICAgICAgICB2ZXJzaW9uIG9mIHRo ZSBkZXBlbmRlbnQgUXROZXR3b3JrIGxpYnJhcnkgYW5kIHRoZSB0ZXN0cyB3aWxsIGJlCisgICAg ICAgIGVuYWJsZWQgbGF0ZXIgb25jZSB0aGUgZGVwZW5kZW50IGxpYnJhcnkgaXMgcmVsZWFzZWQg KGFuZCB0aGUKKyAgICAgICAgYnVpbGRib3QgaXMgdXBkYXRlZCkuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlFOZXR3b3JrUmVwbHlIYW5kbGVyOjpRTmV0d29ya1JlcGx5SGFuZGxlcik6CisgICAgICAg IChXZWJDb3JlOjpRTmV0d29ya1JlcGx5SGFuZGxlcjo6c3RhcnQpOgorCiAyMDA5LTEwLTI3ICBD aHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdv cmtSZXBseUhhbmRsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAJKHJldmlzaW9uIDUwMTI2KQorKysgV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTQwLDYgKzE0MCwxMCBAQCBRTmV0d29ya1JlcGx5SGFuZGxlcjo6UU5ldHdvcmtS ZXBseUhhbmRsCiAgICAgICAgIG1fbWV0aG9kID0gUU5ldHdvcmtBY2Nlc3NNYW5hZ2VyOjpQb3N0 T3BlcmF0aW9uOwogICAgIGVsc2UgaWYgKHIuaHR0cE1ldGhvZCgpID09ICJQVVQiKQogICAgICAg ICBtX21ldGhvZCA9IFFOZXR3b3JrQWNjZXNzTWFuYWdlcjo6UHV0T3BlcmF0aW9uOworI2lmIFFU X1ZFUlNJT04gPj0gMHgwNDA2MDAKKyAgICBlbHNlIGlmIChyLmh0dHBNZXRob2QoKSA9PSAiREVM RVRFIikKKyAgICAgICAgbV9tZXRob2QgPSBRTmV0d29ya0FjY2Vzc01hbmFnZXI6OkRlbGV0ZU9w ZXJhdGlvbjsKKyNlbmRpZgogICAgIGVsc2UKICAgICAgICAgbV9tZXRob2QgPSBRTmV0d29ya0Fj Y2Vzc01hbmFnZXI6OlVua25vd25PcGVyYXRpb247CiAKQEAgLTM5OCw2ICs0MDIsMTIgQEAgdm9p ZCBRTmV0d29ya1JlcGx5SGFuZGxlcjo6c3RhcnQoKQogICAgICAgICAgICAgcHV0RGV2aWNlLT5z ZXRQYXJlbnQobV9yZXBseSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQorI2lmIFFU X1ZFUlNJT04gPj0gMHgwNDA2MDAKKyAgICAgICAgY2FzZSBRTmV0d29ya0FjY2Vzc01hbmFnZXI6 OkRlbGV0ZU9wZXJhdGlvbjogeworICAgICAgICAgICAgbV9yZXBseSA9IG1hbmFnZXItPmRlbGV0 ZVJlc291cmNlKG1fcmVxdWVzdCk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorI2Vu ZGlmCiAgICAgICAgIGNhc2UgUU5ldHdvcmtBY2Nlc3NNYW5hZ2VyOjpVbmtub3duT3BlcmF0aW9u OiB7CiAgICAgICAgICAgICBtX3JlcGx5ID0gMDsKICAgICAgICAgICAgIFJlc291cmNlSGFuZGxl Q2xpZW50KiBjbGllbnQgPSBtX3Jlc291cmNlSGFuZGxlLT5jbGllbnQoKTsKSW5kZXg6IFdlYktp dC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5nZUxvZwkocmV2aXNp b24gNTAyNTYpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMDktMTAtMjggIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gSW1wbGVtZW50IERFTEVURSBIVFRQIG1ldGhvZCBmb3IgWG1sSHR0cFJlcXVlc3QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwODk0CisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIGFzIHRoaXMgZnVuY3Rpb25hbGl0eSBpcyBhbHJlYWR5IHRlc3Rl ZCBieSB0aGUKKyAgICAgICAgeG1saHR0cHJlcXVlc3QgTGF5b3V0VGVzdHMuIEFzIHRoaXMgcGF0 Y2ggZGVwZW5kcyBvbiBhbiB1bnJlbGVhc2VkCisgICAgICAgIHZlcnNpb24gb2YgdGhlIGRlcGVu ZGVudCBRdE5ldHdvcmsgbGlicmFyeSBhbmQgdGhlIHRlc3RzIHdpbGwgYmUKKyAgICAgICAgZW5h YmxlZCBsYXRlciBvbmNlIHRoZSBkZXBlbmRlbnQgbGlicmFyeSBpcyByZWxlYXNlZCAoYW5kIHRo ZQorICAgICAgICBidWlsZGJvdCBpcyB1cGRhdGVkKS4KKworICAgICAgICAqIEFwaS9xd2ViZnJh bWUuY3BwOgorICAgICAgICAoUVdlYkZyYW1lOjpsb2FkKToKKwogMjAwOS0xMC0yOCAgU2hpbmlj aGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEVyaWMgU2VpZGVsLgpJbmRleDogV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcAkocmV2aXNpb24gNTAxMjYpCisrKyBX ZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcyMyw2ICs3MjMs MTEgQEAgdm9pZCBRV2ViRnJhbWU6OmxvYWQoY29uc3QgUU5ldHdvcmtSZXF1ZQogICAgICAgICBj YXNlIFFOZXR3b3JrQWNjZXNzTWFuYWdlcjo6UG9zdE9wZXJhdGlvbjoKICAgICAgICAgICAgIHJl cXVlc3Quc2V0SFRUUE1ldGhvZCgiUE9TVCIpOwogICAgICAgICAgICAgYnJlYWs7CisjaWYgUVRf VkVSU0lPTiA+PSAweDA0MDYwMAorICAgICAgICBjYXNlIFFOZXR3b3JrQWNjZXNzTWFuYWdlcjo6 RGVsZXRlT3BlcmF0aW9uOgorICAgICAgICAgICAgcmVxdWVzdC5zZXRIVFRQTWV0aG9kKCJERUxF VEUiKTsKKyAgICAgICAgICAgIGJyZWFrOworI2VuZGlmCiAgICAgICAgIGNhc2UgUU5ldHdvcmtB Y2Nlc3NNYW5hZ2VyOjpVbmtub3duT3BlcmF0aW9uOgogICAgICAgICAgICAgLy8gZWg/CiAgICAg ICAgICAgICBicmVhazsK