30882 2009-10-28 14:41:58 -0700 [Qt] WebFrame::counterValueForElementById must not be exposed 2009-10-28 15:20:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned vestbo oldest_to_newest 158708 0 hamaji 2009-10-28 14:41:58 -0700 As suggested in Bug 30555 , we should not expose API only for DumpRenderTree. 158709 1 42054 hamaji 2009-10-28 14:43:27 -0700 Created attachment 42054 Patch v1 158719 2 42054 eric 2009-10-28 14:56:52 -0700 Comment on attachment 42054 Patch v1 OK. LGTM. 158729 3 vestbo 2009-10-28 15:12:10 -0700 Nice, thanks! 158733 4 hamaji 2009-10-28 15:20:17 -0700 Committed r50241: <http://trac.webkit.org/changeset/50241> 42054 2009-10-28 14:43:27 -0700 2009-10-28 14:56:51 -0700 Patch v1 bug-30882-20091029064325.patch text/plain 4425 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcCBiL1dlYktpdC9xdC9BcGkv cXdlYmZyYW1lLmNwcAppbmRleCA1OTk2Yjc0Li42MDZkYWU0IDEwMDY0NAotLS0gYS9XZWJLaXQv cXQvQXBpL3F3ZWJmcmFtZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCkBA IC0xODUsNiArMTg1LDE3IEBAIHZvaWQgUVdFQktJVF9FWFBPUlQgcXRfZHJ0X2dhcmJhZ2VDb2xs ZWN0b3JfY29sbGVjdE9uQWx0ZXJuYXRlVGhyZWFkKGJvb2wgd2FpdFVuCiAgICAgZ2NDb250cm9s bGVyKCkuZ2FyYmFnZUNvbGxlY3RPbkFsdGVybmF0ZVRocmVhZEZvckRlYnVnZ2luZyh3YWl0VW50 aWxEb25lKTsKIH0KIAorLy8gUmV0dXJucyB0aGUgdmFsdWUgb2YgY291bnRlciBpbiB0aGUgZWxl bWVudCBzcGVjaWZpZWQgYnkgXGEgaWQuCitRU3RyaW5nIFFXRUJLSVRfRVhQT1JUIHF0X2RydF9j b3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZChRV2ViRnJhbWUqIHFGcmFtZSwgY29uc3QgUVN0cmlu ZyYgaWQpCit7CisgICAgRnJhbWUqIGZyYW1lID0gUVdlYkZyYW1lUHJpdmF0ZTo6Y29yZShxRnJh bWUpOworICAgIGlmIChEb2N1bWVudCogZG9jdW1lbnQgPSBmcmFtZS0+ZG9jdW1lbnQoKSkgewor ICAgICAgICBFbGVtZW50KiBlbGVtZW50ID0gZG9jdW1lbnQtPmdldEVsZW1lbnRCeUlkKGlkKTsK KyAgICAgICAgcmV0dXJuIFdlYkNvcmU6OmNvdW50ZXJWYWx1ZUZvckVsZW1lbnQoZWxlbWVudCk7 CisgICAgfQorICAgIHJldHVybiBRU3RyaW5nKCk7Cit9CisKIFFXZWJGcmFtZURhdGE6OlFXZWJG cmFtZURhdGEoV2ViQ29yZTo6UGFnZSogcGFyZW50UGFnZSwgV2ViQ29yZTo6RnJhbWUqIHBhcmVu dEZyYW1lLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICBXZWJDb3JlOjpIVE1MRnJhbWVP d25lckVsZW1lbnQqIG93bmVyRnJhbWVFbGVtZW50LAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBjb25zdCBXZWJDb3JlOjpTdHJpbmcmIGZyYW1lTmFtZSkKQEAgLTQ3NiwxOSArNDg3LDYg QEAgUVN0cmluZyBRV2ViRnJhbWU6OnJlbmRlclRyZWVEdW1wKCkgY29uc3QKIH0KIAogLyohCi0g ICAgUmV0dXJucyB0aGUgdmFsdWUgb2YgY291bnRlciBpbiB0aGUgZWxlbWVudCBzcGVjaWZpZWQg YnkgXGEgaWQuCi0qLwotUVN0cmluZyBRV2ViRnJhbWU6OmNvdW50ZXJWYWx1ZUZvckVsZW1lbnRC eUlkKGNvbnN0IFFTdHJpbmcgJmlkKSBjb25zdAotewotICAgIGlmIChEb2N1bWVudCAqZG9jdW1l bnQgPSBkLT5mcmFtZS0+ZG9jdW1lbnQoKSkgewotICAgICAgICBFbGVtZW50ICplbGVtZW50ID0g ZG9jdW1lbnQtPmdldEVsZW1lbnRCeUlkKGlkKTsKLSAgICAgICAgcmV0dXJuIFdlYkNvcmU6OmNv dW50ZXJWYWx1ZUZvckVsZW1lbnQoZWxlbWVudCk7Ci0gICAgfQotICAgIHJldHVybiBRU3RyaW5n KCk7Ci0KLX0KLQotLyohCiAgICAgXHByb3BlcnR5IFFXZWJGcmFtZTo6dGl0bGUKICAgICBcYnJp ZWYgdGhlIHRpdGxlIG9mIHRoZSBmcmFtZSBhcyBkZWZpbmVkIGJ5IHRoZSBIVE1MICZsdDt0aXRs ZSZndDsgZWxlbWVudAogCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5oIGIv V2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuaAppbmRleCA4OWUwYmUyLi4wODI4NWY4IDEwMDY0NAot LS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5oCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYmZy YW1lLmgKQEAgLTEzOCw3ICsxMzgsNiBAQCBwdWJsaWM6CiAgICAgUVN0cmluZyB0b0h0bWwoKSBj b25zdDsKICAgICBRU3RyaW5nIHRvUGxhaW5UZXh0KCkgY29uc3Q7CiAgICAgUVN0cmluZyByZW5k ZXJUcmVlRHVtcCgpIGNvbnN0OwotICAgIFFTdHJpbmcgY291bnRlclZhbHVlRm9yRWxlbWVudEJ5 SWQoY29uc3QgUVN0cmluZyAmaWQpIGNvbnN0OwogCiAgICAgUVN0cmluZyB0aXRsZSgpIGNvbnN0 OwogICAgIHZvaWQgc2V0VXJsKGNvbnN0IFFVcmwgJnVybCk7CmRpZmYgLS1naXQgYS9XZWJLaXQv cXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCAzZjkzZTZiLi5kNjQ2NDU2 IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0xMC0yOCAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1h amlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtRdF0gV2ViRnJhbWU6OmNvdW50ZXJWYWx1ZUZvckVsZW1lbnRCeUlkIG11c3Qg bm90IGJlIGV4cG9zZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMwODgyCisKKyAgICAgICAgKiBBcGkvcXdlYmZyYW1lLmNwcDoKKyAgICAgICAgKHF0 X2RydF9jb3VudGVyVmFsdWVGb3JFbGVtZW50QnlJZCk6CisgICAgICAgICogQXBpL3F3ZWJmcmFt ZS5oOgorCiAyMDA5LTEwLTI3ICBTaGluaWNoaXJvIEhhbWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJL aXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggZmI2NmZiZS4u MjhkNDIzNyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRv b2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDA5LTEwLTI4ICBTaGluaWNoaXJvIEhh bWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW1F0XSBXZWJGcmFtZTo6Y291bnRlclZhbHVlRm9yRWxlbWVu dEJ5SWQgbXVzdCBub3QgYmUgZXhwb3NlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzA4ODIKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L0xh eW91dFRlc3RDb250cm9sbGVyUXQuY3BwOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6 OmNvdW50ZXJWYWx1ZUZvckVsZW1lbnRCeUlkKToKKwogMjAwOS0xMC0yOCAgS2VubmV0aCBSb2hk ZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUnViYmVyc3Rh bXBlZCBieSBPbGl2ZXIgSHVudC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJU cmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAKaW5kZXggOGE3Yjg2OS4uYjhkZTZh NSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENv bnRyb2xsZXJRdC5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0 VGVzdENvbnRyb2xsZXJRdC5jcHAKQEAgLTQwLDYgKzQwLDcgQEAgZXh0ZXJuIGJvb2wgcXRfZHJ0 X3BhdXNlQW5pbWF0aW9uKFFXZWJGcmFtZSosIGNvbnN0IFFTdHJpbmcmIG5hbWUsIGRvdWJsZSB0 aW1lLAogZXh0ZXJuIGJvb2wgcXRfZHJ0X3BhdXNlVHJhbnNpdGlvbk9mUHJvcGVydHkoUVdlYkZy YW1lKiwgY29uc3QgUVN0cmluZyYgbmFtZSwgZG91YmxlIHRpbWUsIGNvbnN0IFFTdHJpbmcmIGVs ZW1lbnRJZCk7CiBleHRlcm4gaW50IHF0X2RydF9udW1iZXJPZkFjdGl2ZUFuaW1hdGlvbnMoUVdl YkZyYW1lKik7CiBleHRlcm4gdm9pZCBxdF9kcnRfd2hpdGVMaXN0QWNjZXNzRnJvbU9yaWdpbihj b25zdCBRU3RyaW5nJiBzb3VyY2VPcmlnaW4sIGNvbnN0IFFTdHJpbmcmIGRlc3RpbmF0aW9uUHJv dG9jb2wsIGNvbnN0IFFTdHJpbmcmIGRlc3RpbmF0aW9uSG9zdCwgYm9vbCBhbGxvd0Rlc3RpbmF0 aW9uU3ViZG9tYWlucyk7CitleHRlcm4gUVN0cmluZyBxdF9kcnRfY291bnRlclZhbHVlRm9yRWxl bWVudEJ5SWQoUVdlYkZyYW1lKiBxRnJhbWUsIGNvbnN0IFFTdHJpbmcmIGlkKTsKIAogTGF5b3V0 VGVzdENvbnRyb2xsZXI6OkxheW91dFRlc3RDb250cm9sbGVyKFdlYkNvcmU6OkR1bXBSZW5kZXJU cmVlKiBkcnQpCiAgICAgOiBRT2JqZWN0KCkKQEAgLTExMSw3ICsxMTIsNyBAQCB2b2lkIExheW91 dFRlc3RDb250cm9sbGVyOjp3YWl0VW50aWxEb25lKCkKIAogUVN0cmluZyBMYXlvdXRUZXN0Q29u dHJvbGxlcjo6Y291bnRlclZhbHVlRm9yRWxlbWVudEJ5SWQoY29uc3QgUVN0cmluZyYgaWQpCiB7 Ci0gICAgcmV0dXJuIG1fZHJ0LT53ZWJQYWdlKCktPm1haW5GcmFtZSgpLT5jb3VudGVyVmFsdWVG b3JFbGVtZW50QnlJZChpZCk7CisgICAgcmV0dXJuIHF0X2RydF9jb3VudGVyVmFsdWVGb3JFbGVt ZW50QnlJZChtX2RydC0+d2ViUGFnZSgpLT5tYWluRnJhbWUoKSwgaWQpOwogfQogCiB2b2lkIExh eW91dFRlc3RDb250cm9sbGVyOjprZWVwV2ViSGlzdG9yeSgp