30878 2009-10-28 14:09:23 -0700 [Gtk] atk_text_get_text() fails in entries when the end_offset is -1 2009-11-07 01:03:37 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 25531 0 jdiggs webkit-unassigned apinheiro commit-queue walker.willie xan.lopez oldest_to_newest 158695 0 jdiggs 2009-10-28 14:09:23 -0700 Steps to reproduce: 1. Navigate to Google 2. Type "foo" in the search entry 3. Launch Accerciser 4. Select the object of ROLE_ENTRY and get into the iPython console In [1]: acc.queryText().getText(0, -1) Out[1]: '' <--- wrong (should be 'foo') In [2]: acc.queryText().getText(0, 3) Out[2]: 'foo' <--- (everything else seems to work; just not an end_offset at -1) Also note that if you select other objects which implement AtkText (including the object of ROLE_TEXT which is the descendant of the entry above), atk_text_get_text(0, -1) works as expected. 161295 1 42683 jdiggs 2009-11-06 19:35:30 -0800 Created attachment 42683 substitute String length for an end_offset of -1 161321 2 42683 xan.lopez 2009-11-07 00:48:12 -0800 Comment on attachment 42683 substitute String length for an end_offset of -1 Looks good to me. 161329 3 42683 commit-queue 2009-11-07 01:03:33 -0800 Comment on attachment 42683 substitute String length for an end_offset of -1 Clearing flags on attachment: 42683 Committed r50615: <http://trac.webkit.org/changeset/50615> 161330 4 commit-queue 2009-11-07 01:03:37 -0800 All reviewed patches have been landed. Closing bug. 42683 2009-11-06 19:35:30 -0800 2009-11-07 01:03:32 -0800 substitute String length for an end_offset of -1 30878-1.patch text/plain 2121 jdiggs RnJvbSBmNTE1ZWY1ZjYzZGNhYTBjODAxNTQwMTEzMjNlMWZlODdiZGZlYjIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2FubWFyaWUgRGlnZ3MgPGpvYW5tYXJpZS5kaWdnc0BnbWFp bC5jb20+CkRhdGU6IEZyaSwgNiBOb3YgMjAwOSAyMjoxOTowMSAtMDUwMApTdWJqZWN0OiBbUEFU Q0ggMi8yXSAyMDA5LTExLTA2ICBKb2FubWFyaWUgRGlnZ3MgIDxqb2FubWFyaWUuZGlnZ3NAZ21h aWwuY29tPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwODc4CiAgICAgICAgW0d0a10g YXRrX3RleHRfZ2V0X3RleHQoKSBmYWlscyBpbiBlbnRyaWVzIHdoZW4gdGhlIGVuZF9vZmZzZXQg aXMgLTEKCiAgICAgICAgSWYgdGhlIGVuZF9vZmZzZXQgaXMgLTEsIHVzZSB0aGUgU3RyaW5nIGxl bmd0aCBhcyB0aGUgZW5kX29mZnNldC4KCiAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2d0ay9BY2Nl c3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHA6CiAgICAgICAgKHdlYmtpdF9hY2Nlc3NpYmxl X3RleHRfZ2V0X3RleHQpOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIC4uLi9ndGsvQWNjZXNzaWJpbGl0 eU9iamVjdFdyYXBwZXJBdGsuY3BwICAgICAgICAgIHwgICAgMiArKwogMiBmaWxlcyBjaGFuZ2Vk LCAxNCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmUzZDkyNy4uNzMyN2Q0NiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAwOS0xMS0wNiAgSm9hbm1hcmllIERpZ2dzICA8am9hbm1hcmllLmRpZ2dz QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA4NzgKKyAgICAg ICAgW0d0a10gYXRrX3RleHRfZ2V0X3RleHQoKSBmYWlscyBpbiBlbnRyaWVzIHdoZW4gdGhlIGVu ZF9vZmZzZXQgaXMgLTEKKworICAgICAgICBJZiB0aGUgZW5kX29mZnNldCBpcyAtMSwgdXNlIHRo ZSBTdHJpbmcgbGVuZ3RoIGFzIHRoZSBlbmRfb2Zmc2V0LgorCisgICAgICAgICogYWNjZXNzaWJp bGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwOgorICAgICAgICAod2Vi a2l0X2FjY2Vzc2libGVfdGV4dF9nZXRfdGV4dCk6CisKIDIwMDktMTEtMDQgIEpvYW5tYXJpZSBE aWdncyAgPGpvYW5tYXJpZS5kaWdnc0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0Fj Y2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcCBiL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9n dGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwCmluZGV4IDdjNzkxMDguLjEyZmNm MjggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXJBdGsuY3BwCisrKyBiL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNz aWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwCkBAIC03NzMsNiArNzczLDggQEAgc3RhdGljIGdj aGFyKiB3ZWJraXRfYWNjZXNzaWJsZV90ZXh0X2dldF90ZXh0KEF0a1RleHQqIHRleHQsIGdpbnQg c3RhcnRPZmZzZXQsIGcKICAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlT2JqZWN0ID0gY29y ZSh0ZXh0KTsKICAgICBTdHJpbmcgcmV0OwogICAgIHVuc2lnbmVkIHN0YXJ0ID0gc3RhcnRPZmZz ZXQ7CisgICAgaWYgKGVuZE9mZnNldCA9PSAtMSkKKyAgICAgICAgZW5kT2Zmc2V0ID0gY29yZU9i amVjdC0+c3RyaW5nVmFsdWUoKS5sZW5ndGgoKTsKICAgICBpbnQgbGVuZ3RoID0gZW5kT2Zmc2V0 IC0gc3RhcnRPZmZzZXQ7CiAKICAgICBpZiAoY29yZU9iamVjdC0+aXNUZXh0Q29udHJvbCgpKQot LSAKMS42LjMuMwoK