30817 2009-10-27 06:27:01 -0700 [Gtk] Use parentObjectUnignored instead of parentObject in webkit_accessible_get_parent 2009-10-28 17:12:56 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 25531 0 jdiggs webkit-unassigned commit-queue xan.lopez oldest_to_newest 158167 0 jdiggs 2009-10-27 06:27:01 -0700 As pointed out in https://bugs.webkit.org/show_bug.cgi?id=27011#c12, webkit_accessible_get_parent calls parentObject() instead of parentObjectUnignored(). Using the latter might be the proper way to solve the "work around bogus additional objects in the ancestry" issue that I hacked around by using the parent class. 158739 1 42058 jdiggs 2009-10-28 15:25:32 -0700 Created attachment 42058 proposed patch 158752 2 42058 xan.lopez 2009-10-28 15:38:39 -0700 Comment on attachment 42058 proposed patch Good! 158781 3 42058 commit-queue 2009-10-28 17:12:52 -0700 Comment on attachment 42058 proposed patch Clearing flags on attachment: 42058 Committed r50250: <http://trac.webkit.org/changeset/50250> 158782 4 commit-queue 2009-10-28 17:12:56 -0700 All reviewed patches have been landed. Closing bug. 42058 2009-10-28 15:25:32 -0700 2009-10-28 17:12:52 -0700 proposed patch 30817-1.patch text/plain 2571 jdiggs RnJvbSA0NTg3N2NlMWZhNTFiYTg2YTE5NTM0ODY1NzRhM2Y4Y2VjMmYxMzEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2FubWFyaWUgRGlnZ3MgPGpvYW5tYXJpZS5kaWdnc0BnbWFp bC5jb20+CkRhdGU6IFdlZCwgMjggT2N0IDIwMDkgMTg6MjA6NDEgLTA0MDAKU3ViamVjdDogW1BB VENIXSBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCmh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMDgxNwpVc2UgcGFyZW50T2JqZWN0VW5pZ25vcmVkIGluc3RlYWQg b2YgcGFyZW50T2JqZWN0IGluIHdlYmtpdF9hY2Nlc3NpYmxlX2dldF9wYXJlbnQKCkFsc28gcmVt b3ZlcyB0aGUgaGFjayBJIGhhZCBvcmlnaW5hbGx5IGFkZGVkIHRvIHNvbHZlIGJ1ZyAyNTQxMSwg YmVjYXVzZQp0aGUgZml4IGhlcmUgaXMgd2hhdCBJIHNob3VsZCBoYXZlIGRvbmUgaW4gdGhlIGZp cnN0IHBsYWNlLgoKKiBhY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBl ckF0ay5jcHA6Cih3ZWJraXRfYWNjZXNzaWJsZV9nZXRfcGFyZW50KToKLS0tCiBXZWJDb3JlL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysr KysrKwogLi4uL2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAgICAgICAgICAg fCAgICA4ICstLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDcgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCA5N2I2M2JkLi43NGM1MjhlIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDA5LTEwLTI4ICBK b2FubWFyaWUgRGlnZ3MgIDxqb2FubWFyaWUuZGlnZ3NAZ21haWwuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMDgxNworICAgICAgICBVc2UgcGFyZW50T2JqZWN0VW5pZ25v cmVkIGluc3RlYWQgb2YgcGFyZW50T2JqZWN0IGluIHdlYmtpdF9hY2Nlc3NpYmxlX2dldF9wYXJl bnQKKworICAgICAgICBBbHNvIHJlbW92ZXMgdGhlIGhhY2sgSSBoYWQgb3JpZ2luYWxseSBhZGRl ZCB0byBzb2x2ZSBidWcgMjU0MTEsIGJlY2F1c2UKKyAgICAgICAgdGhlIGZpeCBoZXJlIGlzIHdo YXQgSSBzaG91bGQgaGF2ZSBkb25lIGluIHRoZSBmaXJzdCBwbGFjZS4KKworICAgICAgICAqIGFj Y2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcDoKKyAgICAg ICAgKHdlYmtpdF9hY2Nlc3NpYmxlX2dldF9wYXJlbnQpOgorCiAyMDA5LTEwLTI4ICBHZW9yZ2Ug U3RhaWtvcyAgPGdlb3JnZS5zdGFpa29zQHRvcmNobW9iaWxlLmNvbT4KIAogICAgICAgICBBdHRl bXB0IHRvIGZpeCB0aGUgTWFjIGRlYnVnIGJ1aWxkIGFmdGVyIDUwMjI1LgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5j cHAgYi9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVy QXRrLmNwcAppbmRleCA1OTI0OWJlLi5iNjdkMmE3IDEwMDY0NAotLS0gYS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcAorKysgYi9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcApA QCAtMTg1LDEzICsxODUsNyBAQCBzdGF0aWMgZ3BvaW50ZXIgd2Via2l0X2FjY2Vzc2libGVfcGFy ZW50X2NsYXNzID0gTlVMTDsKIAogc3RhdGljIEF0a09iamVjdCogd2Via2l0X2FjY2Vzc2libGVf Z2V0X3BhcmVudChBdGtPYmplY3QqIG9iamVjdCkKIHsKLSAgICAvLyBUbyB3b3JrIGFyb3VuZCBi b2d1cyBhZGRpdGlvbmFsIG9iamVjdHMgaW4gdGhlIGFuY2VzdHJ5LCB3ZSBzZXQgdGhlCi0gICAg Ly8gcGFyZW50IHdoZW4gd2UgcmVmIHRoZSBjaGlsZC4gSWYgdGhlIGNoaWxkIGtub3dzIGl0cyBw YXJlbnQsIHVzZSB0aGF0LgotICAgIEF0a09iamVjdCogcGFyZW50ID0gQVRLX09CSkVDVF9DTEFT Uyh3ZWJraXRfYWNjZXNzaWJsZV9wYXJlbnRfY2xhc3MpLT5nZXRfcGFyZW50KG9iamVjdCk7Ci0g ICAgaWYgKHBhcmVudCkKLSAgICAgICAgcmV0dXJuIHBhcmVudDsKLQotICAgIEFjY2Vzc2liaWxp dHlPYmplY3QqIGNvcmVQYXJlbnQgPSBjb3JlKG9iamVjdCktPnBhcmVudE9iamVjdCgpOworICAg IEFjY2Vzc2liaWxpdHlPYmplY3QqIGNvcmVQYXJlbnQgPSBjb3JlKG9iamVjdCktPnBhcmVudE9i amVjdFVuaWdub3JlZCgpOwogCiAgICAgLy8gVGhlIHRvcCBsZXZlbCB3ZWIgdmlldyBjbGFpbXMg dG8gbm90IGhhdmUgYSBwYXJlbnQuIFRoaXMgbWFrZXMgaXQKICAgICAvLyBpbXBvc3NpYmxlIGZv ciBhc3Npc3RpdmUgdGVjaG5vbG9naWVzIHRvIGFzY2VuZCB0aGUgYWNjZXNzaWJsZQotLSAKMS42 LjMuMwoK