30671 2009-10-22 04:52:12 -0700 [Qt] NPAPI compilation failure in Symbian 2009-10-23 12:23:13 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) S60 Emulator S60 3rd edition RESOLVED FIXED Qt P2 Normal --- 27065 0 koshuin webkit-unassigned commit-queue darin eric yael oldest_to_newest 156855 0 koshuin 2009-10-22 04:52:12 -0700 npapi.h will undef NULL in Symbian emulator environment causing the compiler to fail when including QRegion. 156871 1 41657 koshuin 2009-10-22 06:53:06 -0700 Created attachment 41657 proposed fix for npapi.h 157150 2 41657 vestbo 2009-10-23 06:22:39 -0700 Comment on attachment 41657 proposed fix for npapi.h Thanks! 157151 3 41657 commit-queue 2009-10-23 06:30:29 -0700 Comment on attachment 41657 proposed fix for npapi.h Rejecting patch 41657 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11506 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 133.66s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output 157157 4 yael 2009-10-23 07:10:24 -0700 Is anyone still compiling NPAPI with CodeWarrior? Perhaps the code inside "#ifdef __MWERKS__" could just be removed ? 157231 5 41657 eric 2009-10-23 12:02:08 -0700 Comment on attachment 41657 proposed fix for npapi.h Sorry about the commit-queue trouble. Should work fine now. 157252 6 41657 commit-queue 2009-10-23 12:23:08 -0700 Comment on attachment 41657 proposed fix for npapi.h Clearing flags on attachment: 41657 Committed r49987: <http://trac.webkit.org/changeset/49987> 157253 7 commit-queue 2009-10-23 12:23:13 -0700 All reviewed patches have been landed. Closing bug. 41657 2009-10-22 06:53:06 -0700 2009-10-23 12:23:08 -0700 proposed fix for npapi.h npapi_h.diff text/plain 1768 koshuin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGVjNWEwOS4uYjVmODdmYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMC0yMiAgSmFubmUgS29za2lu ZW4gIDxqYW5uZS5wLmtvc2tpbmVuQGRpZ2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIGRvbid0IHVuZGVmIE5VTEwgaW4gU3ltYmlh biBlbXVsYXRvcgorCisgICAgICAgIG5wYXBpLmggd2F5IG9mIGRlZmluaW5nIG13ZXJrcyBjb21w aWxlcixfX2ludGVsX18KKyAgICAgICAgYW5kIHdpbjMyIGFyZSBhbGwgdHJ1ZSBmb3IgU3ltYmlh biBlbXVsYXRvci4KKyAgICAgICAgQ2hhbmdlZCB0aGUgZGVmaW5pb25zIHNvIHRoYXQgTlVMTCB3 b24ndCBiZSB1bmRlZmluZWQKKyAgICAgICAgd2hlbiBjb21waWxpbmcgZm9yIFN5bWJpYW4gZW11 bGF0b3Igbm9yIHRhcmdldCBIVy4KKworICAgICAgICAqIGJyaWRnZS9ucGFwaS5oOgorCiAyMDA5 LTEwLTIxICBTYXRvc2hpIE5ha2FnYXdhICA8cHN5Y2hzQGxpbWVjaGF0Lm5ldD4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYnJpZGdlL25w YXBpLmggYi9XZWJDb3JlL2JyaWRnZS9ucGFwaS5oCmluZGV4IGQ1N2I3NmQuLmM2Y2Q1NTcgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvYnJpZGdlL25wYXBpLmgKKysrIGIvV2ViQ29yZS9icmlkZ2UvbnBh cGkuaApAQCAtNTYsNiArNTYsMTIgQEAKICMgICAgZW5kaWYgLyogWFBfV0lOICovCiAjZW5kaWYg LyogX1dJTjMyICovCiAKKyNpZmRlZiBfX1NZTUJJQU4zMl9fCisjICAgaWZuZGVmIFhQX1NZTUJJ QU4KKyMgICAgICAgZGVmaW5lIFhQX1NZTUJJQU4gMQorIyAgIGVuZGlmCisjZW5kaWYgIC8qIF9f U1lNQklBTjMyX18gKi8KKwogI2lmZGVmIF9fTVdFUktTX18KICMgICAgZGVmaW5lIF9kZWNsc3Bl YyBfX2RlY2xzcGVjCiAjICAgIGlmZGVmIG1hY2ludG9zaApAQCAtNjQsMjAgKzcwLDE1IEBACiAj ICAgICAgICBlbmRpZiAvKiBYUF9NQUMgKi8KICMgICAgZW5kaWYgLyogbWFjaW50b3NoICovCiAj ICAgIGlmZGVmIF9fSU5URUxfXwotIyAgICAgICAgdW5kZWYgTlVMTAotIyAgICAgICAgaWZuZGVm IFhQX1dJTgotIyAgICAgICAgICAgIGRlZmluZSBYUF9XSU4gMQotIyAgICAgICAgZW5kaWYgLyog X19JTlRFTF9fICovCi0jICAgIGVuZGlmIC8qIFhQX1BDICovCisjICAgICAgIGlmbmRlZiBYUF9T WU1CSUFOCisjICAgICAgICAgICB1bmRlZiBOVUxMCisjICAgICAgICAgICBpZm5kZWYgWFBfV0lO CisjICAgICAgICAgICAgICAgZGVmaW5lIFhQX1dJTiAxCisjICAgICAgICAgICBlbmRpZiAvKiBY UF9XSU4gKi8KKyMgICAgICAgZW5kaWYgLyogWFBfU1lNQklBTiAqLworIyAgICBlbmRpZiAvKiBf X0lOVEVMX18gKi8KICNlbmRpZiAvKiBfX01XRVJLU19fICovCiAKLSNpZmRlZiBfX1NZTUJJQU4z Ml9fCi0jICAgaWZuZGVmIFhQX1NZTUJJQU4KLSMgICAgICAgZGVmaW5lIFhQX1NZTUJJQU4gMQot IyAgICAgICB1bmRlZiBYUF9XSU4KLSMgICBlbmRpZgotI2VuZGlmICAvKiBfX1NZTUJJQU4zMl9f ICovCi0KICNpZiBkZWZpbmVkKF9fQVBQTEVfQ0NfXykgJiYgIWRlZmluZWQoX19NQUNPU19DTEFT U0lDX18pICYmICFkZWZpbmVkKFhQX1VOSVgpCiAjICAgZGVmaW5lIFhQX01BQ09TWAogI2VuZGlm Cg==