30669 2009-10-22 02:41:45 -0700 http/tests/xmlhttprequest/cross-origin-no-authorization.html has missing "DONE" in one branch 2010-07-20 12:50:49 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P3 Minor --- 1 rolandsteiner webkit-unassigned ap eric levin oldest_to_newest 156841 0 rolandsteiner 2009-10-22 02:41:45 -0700 The layout test http/tests/xmlhttprequest/cross-origin-no-authorization.html outputs "DONE" when it has finished running through the whole test. However, currently this is only done if the last test ends with a (caught) error, but not when loading ends regularly. 156843 1 41650 rolandsteiner 2009-10-22 02:46:41 -0700 Created attachment 41650 patch - add "DONE" message when loading ended without an exception This patch adds a "DONE" message when loading ended without an exception (hopefully with a 401 result in that case). 156924 2 41650 eric 2009-10-22 10:42:53 -0700 Comment on attachment 41650 patch - add "DONE" message when loading ended without an exception What results does this affect? Why is this needed? 157050 3 41650 ap 2009-10-22 17:13:30 -0700 Comment on attachment 41650 patch - add "DONE" message when loading ended without an exception Seems harmless - the test was originally written to allow either outcome, so it should print DONE in both cases. It would be useful to document how you noticed this - did some browser engine you tested have a different behavior? Should we consider changing WebKit behavior? 157054 4 41650 levin 2009-10-22 17:21:03 -0700 Comment on attachment 41650 patch - add "DONE" message when loading ended without an exception Roland, I'm pretty sure this is the wrong fix for chromium. Please talk to me for more details. 157055 5 41650 commit-queue 2009-10-22 17:21:16 -0700 Comment on attachment 41650 patch - add "DONE" message when loading ended without an exception Rejecting patch 41650 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11484 test cases. fast/media/mq-transform-02.html -> failed Exiting early after 1 failures. 7441 tests run. 143.22s total testing time 7440 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output 157241 6 eric 2009-10-23 12:05:42 -0700 Sorry about the commit-queue trouble. Should work fine now. 253872 7 ap 2010-07-20 12:50:49 -0700 Fixed with bug 41531 in <http://trac.webkit.org/changeset/63766>. > Roland, I'm pretty sure this is the wrong fix for chromium. Please talk to me for more details. This discussion hasn't been captured in Bugzilla, let's fix whatever problems arise if/when they do. 41650 2009-10-22 02:46:41 -0700 2010-06-10 19:24:18 -0700 patch - add "DONE" message when loading ended without an exception xhr-noauth.patch text/plain 1408 rolandsteiner SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ5OTMzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTAtMjIgIFJvbGFuZCBTdGVpbmVyICA8 cm9sYW5kc3RlaW5lckBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCB0aGUgIkRPTkUiIG1lc3NhZ2UgdG8gdGhlIGJyYW5jaCBv ZiB0aGUgbGFzdCB0ZXN0IHdoZW4gbG9hZGluZyBlbmRlZAorICAgICAgICBub3JtYWxseSAoaS5l Liwgd2l0aG91dCBhbiBleGNlcHRpb24pLgorCisgICAgICAgIEJ1ZyAzMDY2OSAtICBodHRwL3Rl c3RzL3htbGh0dHByZXF1ZXN0L2Nyb3NzLW9yaWdpbi1uby1hdXRob3JpemF0aW9uLmh0bWwgaGFz IG1pc3NpbmcgIkRPTkUiIGluIG9uZSBicmFuY2gKKyAgICAgICAgKGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDY2OSkKKworICAgICAgICAqIGh0dHAvdGVzdHMveG1s aHR0cHJlcXVlc3QvY3Jvc3Mtb3JpZ2luLW5vLWF1dGhvcml6YXRpb24uaHRtbDoKKwogMjAwOS0x MC0yMSAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0 cHJlcXVlc3QvY3Jvc3Mtb3JpZ2luLW5vLWF1dGhvcml6YXRpb24uaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2Nyb3NzLW9yaWdpbi1uby1h dXRob3JpemF0aW9uLmh0bWwJKHJldmlzaW9uIDQ5OTMzKQorKysgTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy94bWxodHRwcmVxdWVzdC9jcm9zcy1vcmlnaW4tbm8tYXV0aG9yaXphdGlvbi5odG1sCSh3 b3JraW5nIGNvcHkpCkBAIC0xNDUsNiArMTQ1LDcgQEAgZnVuY3Rpb24gdGVzdF9hc3luY19hdXRo X2V4cGxpY2l0KCkKICAgICByZXEuc2VuZCgpOwogICAgIHJlcS5vbmxvYWQgPSBmdW5jdGlvbigp IHsKICAgICAgICAgbG9nKChyZXEuc3RhdHVzID09IDQwMSkgPyAiUEFTUzogNDAxIEF1dGhvcml6 YXRpb24gcmVxdWlyZWQiIDogIkZBSUw6IExvYWRlZCIpOworICAgICAgICBsb2coIkRPTkUiKTsK ICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgICAgICAgICAgIGxh eW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKICAgICB9Cg==