30637 2009-10-21 11:10:33 -0700 Fix a compiler warning in windows. 2009-10-21 14:41:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 28003 1 jorlow jorlow ap eric fishd michaeln oldest_to_newest 156553 0 jorlow 2009-10-21 11:10:33 -0700 Fix a compiler warning in windows. 156557 1 41583 jorlow 2009-10-21 11:13:34 -0700 Created attachment 41583 patch 156589 2 eric 2009-10-21 12:01:35 -0700 I thought we already tried to fix all these. I'm surprised we're still haunted by this nonsense. 156591 3 41583 eric 2009-10-21 12:02:13 -0700 Comment on attachment 41583 patch LGTM, assuming you searched for any other examples of this and this was the only one. 156596 4 jorlow 2009-10-21 12:07:05 -0700 On Windows while compiling Chromium, yes it's the only one. 156638 5 ap 2009-10-21 13:59:24 -0700 (In reply to comment #2) > I thought we already tried to fix all these. We're still waiting for Google to land bug 28003. 156643 6 jorlow 2009-10-21 14:05:09 -0700 Oh. I wasn't aware of the other bug. Well, I already landed so I guess when the other one lands it should undo what I just did. 41583 2009-10-21 11:13:34 -0700 2009-10-21 12:02:13 -0700 patch warning.patch text/plain 963 jorlow SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTkwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMTAtMjEgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNjM3CisgICAgICAgIEZp eCBhIGNvbXBpbGVyIHdhcm5pbmcgaW4gd2luZG93cy4KKworICAgICAgICAqIGxvYWRlci9SZXNv dXJjZUxvYWROb3RpZmllci5oOgorCiAyMDA5LTEwLTIxICBEYW4gQmVybnN0ZWluICA8bWl0ekBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFdlYkNv cmUvbG9hZGVyL1Jlc291cmNlTG9hZE5vdGlmaWVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9s b2FkZXIvUmVzb3VyY2VMb2FkTm90aWZpZXIuaAkocmV2aXNpb24gNDk4OTUpCisrKyBXZWJDb3Jl L2xvYWRlci9SZXNvdXJjZUxvYWROb3RpZmllci5oCSh3b3JraW5nIGNvcHkpCkBAIC00MCw4ICs0 MCw4IEBAIGNsYXNzIEZyYW1lOwogY2xhc3MgUmVzb3VyY2VFcnJvcjsKIGNsYXNzIFJlc291cmNl TG9hZGVyOwogY2xhc3MgUmVzb3VyY2VSZXNwb25zZTsKLWNsYXNzIFJlc291cmNlUmVxdWVzdDsK IGNsYXNzIFNjcmlwdFN0cmluZzsKK3N0cnVjdCBSZXNvdXJjZVJlcXVlc3Q7CiAKIGNsYXNzIFJl c291cmNlTG9hZE5vdGlmaWVyIDogcHVibGljIE5vbmNvcHlhYmxlIHsKIHB1YmxpYzoK