30559 2009-10-20 03:08:19 -0700 [v8] Set debug id for contexts of isolated worlds 2009-10-20 12:11:56 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys webkit-unassigned pfeldman oldest_to_newest 156117 0 yurys 2009-10-20 03:08:19 -0700 V8Proxy provides debug data for frame context and for contexts created in V8Proxy::evaluateInNewContext but the data are not set for isolated worlds. This makes user scripts indistinguishable from scripts in the utility context and as such they are filtered out in JS debugger in Chromium DevTools. 156122 1 41495 yurys 2009-10-20 03:38:15 -0700 Created attachment 41495 patch 156148 2 41495 commit-queue 2009-10-20 06:55:45 -0700 Comment on attachment 41495 patch Rejecting patch 41495 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 60 Last 500 characters of output: ages while\n\trunning as root. There are known race conditions that\n\twill allow any local user to read any file on the system.\n\tIf you still desire to serve pages as root then\n\tadd -DBIG_SECURITY_HOLE to the CFLAGS env variable\n\tand then rebuild the server.\n\tIt is strongly suggested that you instead modify the User\n\tdirective in your httpd.conf file to list a non-root\n\tuser.\n Timed out waiting for httpd to start at WebKitTools/Scripts/run-webkit-tests line 1359, <IN> line 30183. 156159 3 yurys 2009-10-20 08:07:33 -0700 Password for 'yurys@chromium.org': Sending WebCore/ChangeLog Sending WebCore/bindings/v8/V8Proxy.cpp Sending WebCore/bindings/v8/V8Proxy.h Transmitting file data ... Committed revision 49856. 156248 4 41495 eric 2009-10-20 12:11:56 -0700 Comment on attachment 41495 patch Sorry about the commit-queue troubles. 41495 2009-10-20 03:38:15 -0700 2009-10-20 12:11:56 -0700 patch isolated-context-debug-id.patch text/plain 3551 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTEwNzNhOC4uNzQ1YzgxNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMC0yMCAgWXVyeSBTZW1pa2hh dHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTZXQgZGVidWcgaWQgZm9yIGNvbnRleHRzIG9mIGlzb2xhdGVk IHdvcmxkcyB0byBkaXN0aW5ndWlzaCB0aGVtIGluIGRlYnVnZ2VyLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDU1OQorCisgICAgICAgICogYmlu ZGluZ3MvdjgvVjhQcm94eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFByb3h5OjpldmFsdWF0 ZUluSXNvbGF0ZWRXb3JsZCk6CisgICAgICAgIChXZWJDb3JlOjpWOFByb3h5OjpldmFsdWF0ZUlu TmV3Q29udGV4dCk6CisgICAgICAgIChXZWJDb3JlOjpWOFByb3h5OjpzZXRJbmplY3RlZFNjcmlw dENvbnRleHREZWJ1Z0lkKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFByb3h5Lmg6CisKIDIw MDktMTAtMjAgIEFuZHJhcyBCZWNzaSAgPGJlY3NpLmFuZHJhc0BzdHVkLnUtc3plZ2VkLmh1Pgog CiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGRmaXguCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4UHJveHkuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAppbmRl eCAxOTUzOWUyLi41M2Y2ZTViIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJv eHkuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAKQEAgLTI4MSw2ICsy ODEsOSBAQCB2b2lkIFY4UHJveHk6OmV2YWx1YXRlSW5Jc29sYXRlZFdvcmxkKGludCB3b3JsZElE LCBjb25zdCBWZWN0b3I8U2NyaXB0U291cmNlQ29kZQogICAgICAgICB9IGVsc2UgewogICAgICAg ICAgICAgd29ybGQgPSBuZXcgVjhJc29sYXRlZFdvcmxkKHRoaXMsIGV4dGVuc2lvbkdyb3VwKTsK ICAgICAgICAgICAgIG1faXNvbGF0ZWRXb3JsZHMuc2V0KHdvcmxkSUQsIHdvcmxkKTsKKworICAg ICAgICAgICAgLy8gU2V0dXAgY29udGV4dCBpZCBmb3IgSlMgZGVidWdnZXIuCisgICAgICAgICAg ICBzZXRJbmplY3RlZFNjcmlwdENvbnRleHREZWJ1Z0lkKHdvcmxkLT5jb250ZXh0KCkpOwogICAg ICAgICB9CiAgICAgfSBlbHNlIHsKICAgICAgICAgd29ybGQgPSBuZXcgVjhJc29sYXRlZFdvcmxk KHRoaXMsIGV4dGVuc2lvbkdyb3VwKTsKQEAgLTMxMiwxNCArMzE1LDcgQEAgdm9pZCBWOFByb3h5 OjpldmFsdWF0ZUluTmV3Q29udGV4dChjb25zdCBWZWN0b3I8U2NyaXB0U291cmNlQ29kZT4mIHNv dXJjZXMsIGludAogICAgIHY4OjpDb250ZXh0OjpTY29wZSBjb250ZXh0U2NvcGUoY29udGV4dCk7 CiAKICAgICAvLyBTZXR1cCBjb250ZXh0IGlkIGZvciBKUyBkZWJ1Z2dlci4KLSAgICB2ODo6SGFu ZGxlPHY4OjpPYmplY3Q+IGNvbnRleHREYXRhID0gdjg6Ok9iamVjdDo6TmV3KCk7Ci0gICAgdjg6 OkhhbmRsZTx2ODo6VmFsdWU+IHdpbmRvd0NvbnRleHREYXRhID0gd2luZG93Q29udGV4dC0+R2V0 RGF0YSgpOwotICAgIGlmICh3aW5kb3dDb250ZXh0RGF0YS0+SXNPYmplY3QoKSkgewotICAgICAg ICB2ODo6SGFuZGxlPHY4OjpTdHJpbmc+IHByb3BlcnR5TmFtZSA9IHY4OjpTdHJpbmc6Ok5ldyhr Q29udGV4dERlYnVnRGF0YVZhbHVlKTsKLSAgICAgICAgY29udGV4dERhdGEtPlNldChwcm9wZXJ0 eU5hbWUsIHY4OjpPYmplY3Q6OkNhc3QoKndpbmRvd0NvbnRleHREYXRhKS0+R2V0KHByb3BlcnR5 TmFtZSkpOwotICAgIH0KLSAgICBjb250ZXh0RGF0YS0+U2V0KHY4OjpTdHJpbmc6Ok5ldyhrQ29u dGV4dERlYnVnRGF0YVR5cGUpLCB2ODo6U3RyaW5nOjpOZXcoImluamVjdGVkIikpOwotICAgIGNv bnRleHQtPlNldERhdGEoY29udGV4dERhdGEpOworICAgIHNldEluamVjdGVkU2NyaXB0Q29udGV4 dERlYnVnSWQoY29udGV4dCk7CiAKICAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGdsb2JhbCA9 IGNvbnRleHQtPkdsb2JhbCgpOwogCkBAIC0zNDUsNiArMzQxLDIxIEBAIHZvaWQgVjhQcm94eTo6 ZXZhbHVhdGVJbk5ld0NvbnRleHQoY29uc3QgVmVjdG9yPFNjcmlwdFNvdXJjZUNvZGU+JiBzb3Vy Y2VzLCBpbnQKICAgICBjb250ZXh0LkRpc3Bvc2UoKTsKIH0KIAordm9pZCBWOFByb3h5OjpzZXRJ bmplY3RlZFNjcmlwdENvbnRleHREZWJ1Z0lkKHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+IHRhcmdl dENvbnRleHQpCit7CisgICAgLy8gU2V0dXAgY29udGV4dCBpZCBmb3IgSlMgZGVidWdnZXIuCisg ICAgdjg6OkNvbnRleHQ6OlNjb3BlIGNvbnRleHRTY29wZSh0YXJnZXRDb250ZXh0KTsKKyAgICB2 ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGNvbnRleHREYXRhID0gdjg6Ok9iamVjdDo6TmV3KCk7CisK KyAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gd2luZG93Q29udGV4dERhdGEgPSBjb250ZXh0KCkt PkdldERhdGEoKTsKKyAgICBpZiAod2luZG93Q29udGV4dERhdGEtPklzT2JqZWN0KCkpIHsKKyAg ICAgICAgdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBwcm9wZXJ0eU5hbWUgPSB2ODo6U3RyaW5nOjpO ZXcoa0NvbnRleHREZWJ1Z0RhdGFWYWx1ZSk7CisgICAgICAgIGNvbnRleHREYXRhLT5TZXQocHJv cGVydHlOYW1lLCB2ODo6T2JqZWN0OjpDYXN0KCp3aW5kb3dDb250ZXh0RGF0YSktPkdldChwcm9w ZXJ0eU5hbWUpKTsKKyAgICB9CisgICAgY29udGV4dERhdGEtPlNldCh2ODo6U3RyaW5nOjpOZXco a0NvbnRleHREZWJ1Z0RhdGFUeXBlKSwgdjg6OlN0cmluZzo6TmV3KCJpbmplY3RlZCIpKTsKKyAg ICB0YXJnZXRDb250ZXh0LT5TZXREYXRhKGNvbnRleHREYXRhKTsKK30KKwogdjg6OkxvY2FsPHY4 OjpWYWx1ZT4gVjhQcm94eTo6ZXZhbHVhdGUoY29uc3QgU2NyaXB0U291cmNlQ29kZSYgc291cmNl LCBOb2RlKiBub2RlKQogewogICAgIEFTU0VSVCh2ODo6Q29udGV4dDo6SW5Db250ZXh0KCkpOwpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmggYi9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4UHJveHkuaAppbmRleCBlODY0YmE0Li5lNTJjNThkIDEwMDY0NAotLS0gYS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJv eHkuaApAQCAtMzYyLDYgKzM2Miw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgCiAg ICAgICAgIHZvaWQgcmVzZXRJc29sYXRlZFdvcmxkcygpOwogCisgICAgICAgIHZvaWQgc2V0SW5q ZWN0ZWRTY3JpcHRDb250ZXh0RGVidWdJZCh2ODo6SGFuZGxlPHY4OjpDb250ZXh0PiB0YXJnZXRD b250ZXh0KTsKKwogICAgICAgICBzdGF0aWMgYm9vbCBjYW5BY2Nlc3NQcml2YXRlKERPTVdpbmRv dyopOwogCiAgICAgICAgIHN0YXRpYyBjb25zdCBjaGFyKiByYW5nZUV4Y2VwdGlvbk5hbWUoaW50 IGV4Y2VwdGlvbkNvZGUpOwo=