<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>305520</bug_id>
          
          <creation_ts>2026-01-14 16:32:01 -0800</creation_ts>
          <short_desc>Digital Credentials: Fix safer C++ checker warnings in WKDigitalCredentialsPicker.mm</short_desc>
          <delta_ts>2026-07-13 20:42:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>268516</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Marcos Caceres">marcosc</reporter>
          <assigned_to name="Marcos Caceres">marcosc</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2172002</commentid>
    <comment_count>0</comment_count>
    <who name="Marcos Caceres">marcosc</who>
    <bug_when>2026-01-14 16:32:01 -0800</bug_when>
    <thetext>WebKit&apos;s safer C++ checker flagged several memory safety issues in WKDigitalCredentialsPicker.mm related to improper smart pointer usage when calling non-trivial member functions.

The safer C++ checker identified four violations of WebKit&apos;s safer C++ guidelines:

* fetchRawRequestsWithCompletionHandler:line 242 - &quot;Uncounted call argument for a raw pointer/reference parameter&quot;
* handleNSError:line 413 - &quot;Uncounted call argument for a raw pointer/reference parameter&quot;
* presentationAnchor:line 236 - &quot;Unretained call argument for a raw pointer/reference parameter&quot;
* mapRequestAuthentications:line 192 - &quot;Unretained raw pointer or reference not provably backed by a RetainPtr&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2172007</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2026-01-14 16:40:29 -0800</bug_when>
    <thetext>&lt;rdar://problem/168182333&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2172012</commentid>
    <comment_count>2</comment_count>
    <who name="Marcos Caceres">marcosc</who>
    <bug_when>2026-01-14 16:42:56 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/56599</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2172182</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2026-01-15 07:56:53 -0800</bug_when>
    <thetext>Committed 305642@main (b8dfd19251f6): &lt;https://commits.webkit.org/305642@main&gt;

Reviewed commits have been landed. Closing PR #56599 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>