30489 2009-10-17 22:48:18 -0700 [Gtk] The document frame/html container claims to be parentless 2009-10-19 04:58:49 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 25531 0 jdiggs webkit-unassigned apinheiro commit-queue walker.willie xan.lopez oldest_to_newest 155449 0 jdiggs 2009-10-17 22:48:18 -0700 +++ This bug was initially created as a clone of Bug #25411 +++ Steps to reproduce: 1. In WebKit Gtk or Epiphany, view http://google.com 2. In Accerciser's tree of accessibles, locate the app chosen in step 1, and select the scroll pane (i.e. the parent of the document frame/html container) 3. In Accerciser's iPython console, type: acc[0].parent == acc Expected results: Step 3 would cause True to be returned. Actual results: Step 3 causes False to be returned. For some reason asking for the parent of the document frame returns None rather than the scroll pane which is its parent. I *believe* this has to do with how apps embed WebKit because we saw this very issue with Yelp (embeds Gecko currently). Besides, what seems to fix 25411 doesn't fix this issue so it's a different bug. :-) 155552 1 41392 jdiggs 2009-10-18 20:45:36 -0700 Created attachment 41392 possible fix It's ugly, but it works. If there's already a method that works to reliably get the accessible parent of the WebView, and I managed to miss it, do please let me know. Otherwise, please review. Thanks! 155652 2 41411 jdiggs 2009-10-19 04:42:55 -0700 Created attachment 41411 revision 2 - made changes Xan suggested xan: OK, two really minor things: I think it's worth adding a comment here explaining why are we doing this, and the last NULL check I think you can get rid of, since you'd return NULL anyway xan: I mean the one checking what gtk_widget_get_accessible returns, just return gtk_widget_get_accessible ---- Done. 155654 3 41411 xan.lopez 2009-10-19 04:44:05 -0700 Comment on attachment 41411 revision 2 - made changes Xan suggested Bam! 155660 4 41411 commit-queue 2009-10-19 04:58:46 -0700 Comment on attachment 41411 revision 2 - made changes Xan suggested Clearing flags on attachment: 41411 Committed r49775: <http://trac.webkit.org/changeset/49775> 155661 5 commit-queue 2009-10-19 04:58:49 -0700 All reviewed patches have been landed. Closing bug. 41392 2009-10-18 20:45:36 -0700 2009-10-19 04:42:55 -0700 possible fix 30489-1.patch text/plain 2999 jdiggs RnJvbSA4YjJjMjBhMGI4MjQzMjVmYmMyZWQ1MGI0ZTAxYzMxZWI2Y2E5YThkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2FubWFyaWUgRGlnZ3MgPGpvYW5tYXJpZS5kaWdnc0BnbWFp bC5jb20+CkRhdGU6IFN1biwgMTggT2N0IDIwMDkgMjM6NDA6MjcgLTA0MDAKU3ViamVjdDogW1BB VENIXSBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCmh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMDQ4OQpbR3RrXSBUaGUgZG9jdW1lbnQgZnJhbWUvaHRtbCBjb250 YWluZXIgY2xhaW1zIHRvIGJlIHBhcmVudGxlc3MKCldvcmsgYXJvdW5kIGZvciB0aGUgcGFyZW50 bGVzcyBjbGFpbSBtYWRlIGJ5IHRoZSBhY2Nlc3NpYmxlIGFzc29jaWF0ZWQKd2l0aCB0aGUgZW1i ZWRkZWQgV2ViVmlldy4gV2hlbiB3ZSBpZGVudGlmeSB0aGlzIGNvbmRpdGlvbiwgZ2V0IHRoZQp3 aWRnZXQncyBwYXJlbnQsIGFuZCB0aGVuIGdldCB0aGUgQXRrT2JqZWN0IGZyb20gdGhhdC4gQWRt aXR0ZWRseSBhbiB1Z2x5CmhhY2ssIGJ1dCB3ZSdsbCBuZWVkIGl0IGZvciBZZWxwIGFuZCBvdGhl ciBHdGsrL0dOT01FIGFwcGxpY2F0aW9ucyB3aGljaApwbGFuIHRvIHN3aXRjaCBvdmVyIHRvIFdl YktpdC4KCiogYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsu Y3BwOgood2Via2l0X2FjY2Vzc2libGVfZ2V0X3BhcmVudCk6Ci0tLQogV2ViQ29yZS9DaGFuZ2VM b2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE2ICsrKysrKysrKysrKysr KysKIC4uLi9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwICAgICAgICAgIHwg ICAxNSArKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwg MCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IGQxZmFlNTIuLmIwYTdiMmIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDktMTAt MTggIEpvYW5tYXJpZSBEaWdncyAgPGpvYW5tYXJpZS5kaWdnc0BnbWFpbC5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNDg5CisgICAgICAgIFtHdGtdIFRoZSBkb2N1bWVu dCBmcmFtZS9odG1sIGNvbnRhaW5lciBjbGFpbXMgdG8gYmUgcGFyZW50bGVzcworCisgICAgICAg IFdvcmsgYXJvdW5kIGZvciB0aGUgcGFyZW50bGVzcyBjbGFpbSBtYWRlIGJ5IHRoZSBhY2Nlc3Np YmxlIGFzc29jaWF0ZWQKKyAgICAgICAgd2l0aCB0aGUgZW1iZWRkZWQgV2ViVmlldy4gV2hlbiB3 ZSBpZGVudGlmeSB0aGlzIGNvbmRpdGlvbiwgZ2V0IHRoZQorICAgICAgICB3aWRnZXQncyBwYXJl bnQsIGFuZCB0aGVuIGdldCB0aGUgQXRrT2JqZWN0IGZyb20gdGhhdC4gQWRtaXR0ZWRseSBhbiB1 Z2x5CisgICAgICAgIGhhY2ssIGJ1dCB3ZSdsbCBuZWVkIGl0IGZvciBZZWxwIGFuZCBvdGhlciBH dGsrL0dOT01FIGFwcGxpY2F0aW9ucyB3aGljaAorICAgICAgICBwbGFuIHRvIHN3aXRjaCBvdmVy IHRvIFdlYktpdC4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlP YmplY3RXcmFwcGVyQXRrLmNwcDoKKyAgICAgICAgKHdlYmtpdF9hY2Nlc3NpYmxlX2dldF9wYXJl bnQpOgorCiAyMDA5LTEwLTE4ICBEaXJrIFNjaHVsemUgIDxrcml0QHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgTmlrb2xhcyBaaW1tZXJtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAgYi9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNw cAppbmRleCBjZTlkNTY1Li40MTc4ZTIxIDEwMDY0NAotLS0gYS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcAorKysgYi9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcApAQCAtMTM2 LDYgKzEzNiwyMSBAQCBzdGF0aWMgQXRrT2JqZWN0KiB3ZWJraXRfYWNjZXNzaWJsZV9nZXRfcGFy ZW50KEF0a09iamVjdCogb2JqZWN0KQogewogICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIGNvcmVQ YXJlbnQgPSBjb3JlKG9iamVjdCktPnBhcmVudE9iamVjdCgpOwogCisgICAgaWYgKCFjb3JlUGFy ZW50ICYmIGNvcmUob2JqZWN0KS0+aXNXZWJBcmVhKCkpIHsKKyAgICAgICAgSG9zdFdpbmRvdyog aG9zdFdpbmRvdyA9IGNvcmUob2JqZWN0KS0+ZG9jdW1lbnQoKS0+dmlldygpLT5ob3N0V2luZG93 KCk7CisgICAgICAgIGlmIChob3N0V2luZG93KSB7CisgICAgICAgICAgICBQbGF0Zm9ybVBhZ2VD bGllbnQgd2ViVmlldyA9IGhvc3RXaW5kb3ctPnBsYXRmb3JtUGFnZUNsaWVudCgpOworICAgICAg ICAgICAgaWYgKHdlYlZpZXcpIHsKKyAgICAgICAgICAgICAgICBHdGtXaWRnZXQqIHdlYlZpZXdQ YXJlbnQgPSBndGtfd2lkZ2V0X2dldF9wYXJlbnQod2ViVmlldyk7CisgICAgICAgICAgICAgICAg aWYgKHdlYlZpZXdQYXJlbnQpIHsKKyAgICAgICAgICAgICAgICAgICAgQXRrT2JqZWN0KiBhdGtX ZWJWaWV3UGFyZW50ID0gZ3RrX3dpZGdldF9nZXRfYWNjZXNzaWJsZSh3ZWJWaWV3UGFyZW50KTsK KyAgICAgICAgICAgICAgICAgICAgaWYgKGF0a1dlYlZpZXdQYXJlbnQpCisgICAgICAgICAgICAg ICAgICAgICAgICByZXR1cm4gYXRrV2ViVmlld1BhcmVudDsKKyAgICAgICAgICAgICAgICB9Cisg ICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICB9CisKICAgICBpZiAoIWNvcmVQYXJlbnQpCiAg ICAgICAgIHJldHVybiBOVUxMOwogCi0tIAoxLjYuMy4zCgo= 41411 2009-10-19 04:42:55 -0700 2009-10-19 04:58:45 -0700 revision 2 - made changes Xan suggested 30489-2.patch text/plain 3069 jdiggs RnJvbSA4MzU3YzE3NTRiZjg2ZDhhOTE4YzllNTQ4NTU2NDBlYTgzZjI1NGUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2FubWFyaWUgRGlnZ3MgPGpvYW5tYXJpZS5kaWdnc0BnbWFp bC5jb20+CkRhdGU6IFN1biwgMTggT2N0IDIwMDkgMjM6NDA6MjcgLTA0MDAKU3ViamVjdDogW1BB VENIXSBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCmh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMDQ4OQpbR3RrXSBUaGUgZG9jdW1lbnQgZnJhbWUvaHRtbCBjb250 YWluZXIgY2xhaW1zIHRvIGJlIHBhcmVudGxlc3MKCldvcmsgYXJvdW5kIGZvciB0aGUgcGFyZW50 bGVzcyBjbGFpbSBtYWRlIGJ5IHRoZSBhY2Nlc3NpYmxlIGFzc29jaWF0ZWQKd2l0aCB0aGUgZW1i ZWRkZWQgV2ViVmlldy4gV2hlbiB3ZSBpZGVudGlmeSB0aGlzIGNvbmRpdGlvbiwgZ2V0IHRoZQp3 aWRnZXQncyBwYXJlbnQsIGFuZCB0aGVuIGdldCB0aGUgQXRrT2JqZWN0IGZyb20gdGhhdC4gQWRt aXR0ZWRseSBhbiB1Z2x5CmhhY2ssIGJ1dCB3ZSdsbCBuZWVkIGl0IGZvciBZZWxwIGFuZCBvdGhl ciBHdGsrL0dOT01FIGFwcGxpY2F0aW9ucyB3aGljaApwbGFuIHRvIHN3aXRjaCBvdmVyIHRvIFdl YktpdC4KCiogYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsu Y3BwOgood2Via2l0X2FjY2Vzc2libGVfZ2V0X3BhcmVudCk6Ci0tLQogV2ViQ29yZS9DaGFuZ2VM b2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE2ICsrKysrKysrKysrKysr KysKIC4uLi9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwICAgICAgICAgIHwg ICAxNSArKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwg MCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IGQxZmFlNTIuLmIwYTdiMmIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDktMTAt MTggIEpvYW5tYXJpZSBEaWdncyAgPGpvYW5tYXJpZS5kaWdnc0BnbWFpbC5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwNDg5CisgICAgICAgIFtHdGtdIFRoZSBkb2N1bWVu dCBmcmFtZS9odG1sIGNvbnRhaW5lciBjbGFpbXMgdG8gYmUgcGFyZW50bGVzcworCisgICAgICAg IFdvcmsgYXJvdW5kIGZvciB0aGUgcGFyZW50bGVzcyBjbGFpbSBtYWRlIGJ5IHRoZSBhY2Nlc3Np YmxlIGFzc29jaWF0ZWQKKyAgICAgICAgd2l0aCB0aGUgZW1iZWRkZWQgV2ViVmlldy4gV2hlbiB3 ZSBpZGVudGlmeSB0aGlzIGNvbmRpdGlvbiwgZ2V0IHRoZQorICAgICAgICB3aWRnZXQncyBwYXJl bnQsIGFuZCB0aGVuIGdldCB0aGUgQXRrT2JqZWN0IGZyb20gdGhhdC4gQWRtaXR0ZWRseSBhbiB1 Z2x5CisgICAgICAgIGhhY2ssIGJ1dCB3ZSdsbCBuZWVkIGl0IGZvciBZZWxwIGFuZCBvdGhlciBH dGsrL0dOT01FIGFwcGxpY2F0aW9ucyB3aGljaAorICAgICAgICBwbGFuIHRvIHN3aXRjaCBvdmVy IHRvIFdlYktpdC4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlP YmplY3RXcmFwcGVyQXRrLmNwcDoKKyAgICAgICAgKHdlYmtpdF9hY2Nlc3NpYmxlX2dldF9wYXJl bnQpOgorCiAyMDA5LTEwLTE4ICBEaXJrIFNjaHVsemUgIDxrcml0QHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgTmlrb2xhcyBaaW1tZXJtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAgYi9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNw cAppbmRleCBjZTlkNTY1Li5jMzNlMzc1IDEwMDY0NAotLS0gYS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcAorKysgYi9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcApAQCAtMTM2 LDYgKzEzNiwyMSBAQCBzdGF0aWMgQXRrT2JqZWN0KiB3ZWJraXRfYWNjZXNzaWJsZV9nZXRfcGFy ZW50KEF0a09iamVjdCogb2JqZWN0KQogewogICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIGNvcmVQ YXJlbnQgPSBjb3JlKG9iamVjdCktPnBhcmVudE9iamVjdCgpOwogCisgICAgLy8gVGhlIHRvcCBs ZXZlbCB3ZWIgdmlldyBjbGFpbXMgdG8gbm90IGhhdmUgYSBwYXJlbnQuIFRoaXMgbWFrZXMgaXQK KyAgICAvLyBpbXBvc3NpYmxlIGZvciBhc3Npc3RpdmUgdGVjaG5vbG9naWVzIHRvIGFzY2VuZCB0 aGUgYWNjZXNzaWJsZQorICAgIC8vIGhpZXJhcmNoeSBhbGwgdGhlIHdheSB0byB0aGUgYXBwbGlj YXRpb24uIChCdWcgMzA0ODkpCisgICAgaWYgKCFjb3JlUGFyZW50ICYmIGNvcmUob2JqZWN0KS0+ aXNXZWJBcmVhKCkpIHsKKyAgICAgICAgSG9zdFdpbmRvdyogaG9zdFdpbmRvdyA9IGNvcmUob2Jq ZWN0KS0+ZG9jdW1lbnQoKS0+dmlldygpLT5ob3N0V2luZG93KCk7CisgICAgICAgIGlmIChob3N0 V2luZG93KSB7CisgICAgICAgICAgICBQbGF0Zm9ybVBhZ2VDbGllbnQgd2ViVmlldyA9IGhvc3RX aW5kb3ctPnBsYXRmb3JtUGFnZUNsaWVudCgpOworICAgICAgICAgICAgaWYgKHdlYlZpZXcpIHsK KyAgICAgICAgICAgICAgICBHdGtXaWRnZXQqIHdlYlZpZXdQYXJlbnQgPSBndGtfd2lkZ2V0X2dl dF9wYXJlbnQod2ViVmlldyk7CisgICAgICAgICAgICAgICAgaWYgKHdlYlZpZXdQYXJlbnQpCisg ICAgICAgICAgICAgICAgICAgIHJldHVybiBndGtfd2lkZ2V0X2dldF9hY2Nlc3NpYmxlKHdlYlZp ZXdQYXJlbnQpOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgfQorCiAgICAgaWYgKCFj b3JlUGFyZW50KQogICAgICAgICByZXR1cm4gTlVMTDsKIAotLSAKMS42LjMuMwoK