30476 2009-10-16 23:39:14 -0700 [Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian 2009-10-24 08:28:33 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC S60 3rd edition RESOLVED FIXED Qt P2 Normal --- 27065 1 laszlo.gombos webkit-unassigned commit-queue koshuin norbert.leser oldest_to_newest 155377 0 laszlo.gombos 2009-10-16 23:39:14 -0700 It seems that by default a Qt app has no Symbian capability assigned, which means for example that QtLauncher has no access to networking. In addition QtWebkit needs more memory than the default Qt Symbian app. 155378 1 41353 laszlo.gombos 2009-10-16 23:44:50 -0700 Created attachment 41353 1st try. Assign all Symbian app capabilities except the Location capability. Set the heap size to the 128kB - 32MB range. 155385 2 koshuin 2009-10-17 02:07:40 -0700 I think CAP_APPLICATION is Nokia S60 specific MACRO and might not work on all Symbian development environments. Current required capabilities for using QtWebkit are ReadUserData,WriteUserData and NetworkServices. ReadUserData and WriteUserData for database access and NetworkServices for connection. 155532 3 norbert.leser 2009-10-18 16:29:18 -0700 Thanks, for working on a cleanup. - Removing EPOCALLOWDLLDATA from all executables makes sense. - You are right, it appears that EPOCSTACKSIZE is set by qmake to the max value (0x14000) already, and it would be redundant. The problem though is that it may not be guaranteed that all qmake versions will set that value. If not set, the symbian's build system falls back to the default, which is way lower than needed. It might be safer to keep the definition in all exe's .pro files, even if redundant. - Janne is right that the basic capabilities needed are "ReadUserData WriteUserData NetworkServices". We should set these explicitly for all executables under WebKit/qt, instead of CAP_APPLICATION (I also saw that this macro is not available on public SDKs). - The problem with the previous one is that you set it in WebKit.pri, which is also processed by WebCore.pro. QtWebKit.dll, however, should have the max set of capabilities that calling processes may require. Per convention, for shared libraries that are used by a variety of apps, it is "All -Tcb". Otherwise, we run into the problem that apps which require certain capabilities outside the minimally needed ones cannot load the dll (the side-effect of the weird capabilities model in symbian). We could add the missing capabilities in WebCore.pro (I think), but that doesn't appear to be clean. Thus, I'd suggest to keep TARGET.CAPABILITY definitions in the respective .pro files of the executables (QtLauncher, QVGLauncher, all tst_*). - This patch only addresses WebKit.pri but I assume that your intention was to also cleanup the respective .pro files as well, once we have an understand what goes where. 155548 4 laszlo.gombos 2009-10-18 19:46:55 -0700 (In reply to comment #3) > Thanks, for working on a cleanup. Thanks for the review. > > - Removing EPOCALLOWDLLDATA from all executables makes sense. > > - You are right, it appears that EPOCSTACKSIZE is set by qmake to the max value > (0x14000) already, and it would be redundant. The problem though is that it may > not be guaranteed that all qmake versions will set that value. If not set, the > symbian's build system falls back to the default, which is way lower than > needed. It might be safer to keep the definition in all exe's .pro files, even > if redundant. Ok, will add EPOCSTACKSIZE to the patch. > - Janne is right that the basic capabilities needed are "ReadUserData > WriteUserData NetworkServices". We should set these explicitly for all > executables under WebKit/qt, instead of CAP_APPLICATION (I also saw that this > macro is not available on public SDKs). Good catch on the public SDK - will fix the patch. > - The problem with the previous one is that you set it in WebKit.pri, which is > also processed by WebCore.pro. WebCore.pro does include WebKit.pri, but it will never reach the patched section. I admit it is hard to follow all the conditions in WebKit.pri (hint check out building-libs). The change only impacts executables (QtLauncher, QVGLauncher, all tst_*) and not QtWebKit.dll (you can test it by temporary adding an error() to the patched section of WebKit.pri and qmake WebCore.pro). > QtWebKit.dll, however, should have the max set > of capabilities that calling processes may require. Per convention, for shared > libraries that are used by a variety of apps, it is "All -Tcb". Otherwise, we > run into the problem that apps which require certain capabilities outside the > minimally needed ones cannot load the dll (the side-effect of the weird > capabilities model in symbian). We could add the missing capabilities in > WebCore.pro (I think), but that doesn't appear to be clean. Thus, I'd suggest > to keep TARGET.CAPABILITY definitions in the respective .pro files of the > executables (QtLauncher, QVGLauncher, all tst_*). > > - This patch only addresses WebKit.pri but I assume that your intention was to > also cleanup the respective .pro files as well, once we have an understand what > goes where. I think this change will set the correct capabilities/mem attributes for (QtLauncher, QVGLauncher, all tst_*) in one location. 155549 5 41390 laszlo.gombos 2009-10-18 19:58:48 -0700 Created attachment 41390 proposed patch Thanks for Janne and Norbert for the comments - the patch addressing their input. Changes: - Use explicit Symbian capabilities instead of CAP_APPLICATION - and use only those capabilities that is actually needed. - Set the stack size to 80 Kb. 155550 6 41391 laszlo.gombos 2009-10-18 20:01:03 -0700 Created attachment 41391 proposed patch Previous patch contains and extra line - remove it; sorry. 155551 7 norbert.leser 2009-10-18 20:09:27 -0700 I understand that putting TARGET.CAPABILITY in WebKit.pri keeps it in one location instead of every single .pro for executables. Still, specifically since it it hard to parse where it actually applies, I believe that the .pro files for each exe is the right place for this sort of thing. It defeats security if it is not fully transparent to the user. Also, there might me certain executables in the future, such as specific tests, that may need to have different capabilities (e.f., tests for plugins that access local resources). 155605 8 koshuin 2009-10-19 00:39:36 -0700 (In reply to comment #7) > I understand that putting TARGET.CAPABILITY in WebKit.pri keeps it in one > location instead of every single .pro for executables. Still, specifically > since it it hard to parse where it actually applies, I believe that the .pro > files for each exe is the right place for this sort of thing. It defeats > security if it is not fully transparent to the user. Also, there might me > certain executables in the future, such as specific tests, that may need to > have different capabilities (e.f., tests for plugins that access local > resources). I have to agree. Better place for capabilities is the application .pro file. target.epocheapsize and target.epocstacksize could be in the webkit.pri file. Although, I don't agree with setting the stacksize, can't see situation when qmake wouldn't set this. 155782 9 41430 laszlo.gombos 2009-10-19 10:58:44 -0700 Created attachment 41430 3rd try Place Symbian capabilities in the application .pro files (instead of WebKit.pri) - as it was suggested by Norbert and Janne. 157422 10 41430 zecke 2009-10-23 21:16:50 -0700 Comment on attachment 41430 3rd try I see no harm with that. 157446 11 41430 commit-queue 2009-10-24 08:28:28 -0700 Comment on attachment 41430 3rd try Clearing flags on attachment: 41430 Committed r50026: <http://trac.webkit.org/changeset/50026> 157447 12 commit-queue 2009-10-24 08:28:33 -0700 All reviewed patches have been landed. Closing bug. 41353 2009-10-16 23:44:50 -0700 2009-10-18 19:58:48 -0700 1st try. 30476.patch text/plain 1206 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ5NzM1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMTAt MTYgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gW1N5bWJpYW5dIFNl dCB0aGUgY2FwYWJpbGl0eSBhbmQgbWVtb3J5IHJlcXVpcmVkIHRvIHJ1biBRdFdlYktpdCBmb3Ig U3ltYmlhbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzA0NzYKKworICAgICAgICBBc3NpZ24gYWxsIFN5bWJpYW4gYXBwIGNhcGFiaWxpdGllcyBleGNl cHQgdGhlIExvY2F0aW9uCisgICAgICAgIGNhcGFiaWxpdHkuCisgICAgICAgCisgICAgICAgIFNl dCB0aGUgaGVhcCBzaXplIHRvIHRoZSAxMjhrQiAtIDMyTUIgcmFuZ2UuICAgICAgIAorCisgICAg ICAgICogV2ViS2l0LnByaToKKwogMjAwOS0xMC0xNSAgSmFuIE1pY2hhZWwgQWxvbnpvICA8am1h bG9uem9Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCkluZGV4 OiBXZWJLaXQucHJpCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC5wcmkJKHJldmlzaW9uIDQ5NzM0KQor KysgV2ViS2l0LnByaQkod29ya2luZyBjb3B5KQpAQCAtMjUsNiArMjUsMTAgQEAgYnVpbGRpbmct bGlicyB7CiAgICAgICAgICAgICAgICAgTElCUyArPSAtbFF0V2ViS2l0JCR7UVRfTUFKT1JfVkVS U0lPTn0KICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAgTElCUyArPSAtbFF0 V2ViS2l0CisgICAgICAgICAgICAgICAgc3ltYmlhbiB7CisgICAgICAgICAgICAgICAgICAgIFRB UkdFVC5FUE9DSEVBUFNJWkUgPSAweDIwMDAwIDB4MjAwMDAwMCAvLyBNaW4gMTI4a0IsIE1heCAz Mk1CCisgICAgICAgICAgICAgICAgICAgIFRBUkdFVC5DQVBBQklMSVRZID0gQ0FQX0FQUExJQ0FU SU9OIC1Mb2NhdGlvbgorICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KICAgICAgICAg fQogICAgIH0K 41390 2009-10-18 19:58:48 -0700 2009-10-18 20:01:03 -0700 proposed patch 30476_2.patch text/plain 1629 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ5NzYy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMTAt MTggIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gW1N5bWJpYW5dIFNl dCB0aGUgY2FwYWJpbGl0eSBhbmQgbWVtb3J5IHJlcXVpcmVkIHRvIHJ1biBRdFdlYktpdCBmb3Ig U3ltYmlhbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzA0NzYKKworICAgICAgICBBc3NpZ24gUmVhZFVzZXJEYXRhIFdyaXRlVXNlckRhdGEgTmV0d29y a1NlcnZpY2VzIFN5bWJpYW4gY2FwYWJpbGl0aWVzIAorICAgICAgICB0byBhbGwgZXhlY3V0YWJs ZXMgbGlua2luZyBhZ2FpbnN0IFdlYktpdCBsaWJyYXJ5LgorICAgICAgIAorICAgICAgICBTZXQg dGhlIHN0YWNrIHNpemUgdG8gODAgS2IgYW5kIGhlYXAgc2l6ZSB0byB0aGUgMTI4a0IgLSAzMk1C IHJhbmdlCisgICAgICAgIHRvIGFsbCBleGVjdXRhYmxlcyBsaW5raW5nIGFnYWluc3QgV2ViS2l0 IGxpYnJhcnkuCisKKyAgICAgICAgKiBXZWJLaXQucHJpOgorCiAyMDA5LTEwLTE4ICBKYW4gTWlj aGFlbCBBbG9uem8gIDxqbWFsb256b0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEhvbGdlciBGcmV5dGhlci4KSW5kZXg6IFdlYktpdC5wcmkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 LnByaQkocmV2aXNpb24gNDk3NjIpCisrKyBXZWJLaXQucHJpCSh3b3JraW5nIGNvcHkpCkBAIC0y MSwxMCArMjEsMTYgQEAgYnVpbGRpbmctbGlicyB7CiAgICAgICAgICAgICBMSUJTICs9IC1mcmFt ZXdvcmsgUXRXZWJLaXQKICAgICAgICAgICAgIFFNQUtFX0ZSQU1FV09SS1BBVEggPSAkJE9VVFBV VF9ESVIvbGliICQkUU1BS0VfRlJBTUVXT1JLUEFUSAogICAgICAgICB9IGVsc2UgeworZXJyb3Io T25seSBpbmNsdWRlIHRoaXMgZmlsZSBmb3IgU3ltYmlhbiBwbGF0Zm9ybXMpCiAgICAgICAgICAg ICB3aW4zMi0qfHdpbmNlKiB7CiAgICAgICAgICAgICAgICAgTElCUyArPSAtbFF0V2ViS2l0JCR7 UVRfTUFKT1JfVkVSU0lPTn0KICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAg TElCUyArPSAtbFF0V2ViS2l0CisgICAgICAgICAgICAgICAgc3ltYmlhbiB7CisgICAgICAgICAg ICAgICAgICAgIFRBUkdFVC5FUE9DU1RBQ0tTSVpFID0gMHgxNDAwMAorICAgICAgICAgICAgICAg ICAgICBUQVJHRVQuRVBPQ0hFQVBTSVpFID0gMHgyMDAwMCAweDIwMDAwMDAgLy8gTWluIDEyOGtC LCBNYXggMzJNQgorICAgICAgICAgICAgICAgICAgICBUQVJHRVQuQ0FQQUJJTElUWSA9IFJlYWRV c2VyRGF0YSBXcml0ZVVzZXJEYXRhIE5ldHdvcmtTZXJ2aWNlcworICAgICAgICAgICAgICAgIH0K ICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0K 41391 2009-10-18 20:01:03 -0700 2009-10-19 10:58:44 -0700 proposed patch 30476_2.patch text/plain 1412 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ5NzYy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMTAt MTggIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gW1N5bWJpYW5dIFNl dCB0aGUgY2FwYWJpbGl0eSBhbmQgbWVtb3J5IHJlcXVpcmVkIHRvIHJ1biBRdFdlYktpdCBmb3Ig U3ltYmlhbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzA0NzYKKworICAgICAgICBBc3NpZ24gUmVhZFVzZXJEYXRhIFdyaXRlVXNlckRhdGEgTmV0d29y a1NlcnZpY2VzIFN5bWJpYW4gY2FwYWJpbGl0aWVzIAorICAgICAgICB0byBhbGwgZXhlY3V0YWJs ZXMgbGlua2luZyBhZ2FpbnN0IFdlYktpdCBsaWJyYXJ5LgorICAgICAgIAorICAgICAgICBTZXQg dGhlIHN0YWNrIHNpemUgdG8gODAgS2IgYW5kIGhlYXAgc2l6ZSB0byB0aGUgMTI4a0IgLSAzMk1C IHJhbmdlCisgICAgICAgIHRvIGFsbCBleGVjdXRhYmxlcyBsaW5raW5nIGFnYWluc3QgV2ViS2l0 IGxpYnJhcnkuCisKKyAgICAgICAgKiBXZWJLaXQucHJpOgorCiAyMDA5LTEwLTE4ICBKYW4gTWlj aGFlbCBBbG9uem8gIDxqbWFsb256b0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEhvbGdlciBGcmV5dGhlci4KSW5kZXg6IFdlYktpdC5wcmkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 LnByaQkocmV2aXNpb24gNDk3NjIpCisrKyBXZWJLaXQucHJpCSh3b3JraW5nIGNvcHkpCkBAIC0y NSw2ICsyNSwxMSBAQCBidWlsZGluZy1saWJzIHsKICAgICAgICAgICAgICAgICBMSUJTICs9IC1s UXRXZWJLaXQkJHtRVF9NQUpPUl9WRVJTSU9OfQogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAg ICAgICAgICAgICBMSUJTICs9IC1sUXRXZWJLaXQKKyAgICAgICAgICAgICAgICBzeW1iaWFuIHsK KyAgICAgICAgICAgICAgICAgICAgVEFSR0VULkVQT0NTVEFDS1NJWkUgPSAweDE0MDAwCisgICAg ICAgICAgICAgICAgICAgIFRBUkdFVC5FUE9DSEVBUFNJWkUgPSAweDIwMDAwIDB4MjAwMDAwMCAv LyBNaW4gMTI4a0IsIE1heCAzMk1CCisgICAgICAgICAgICAgICAgICAgIFRBUkdFVC5DQVBBQklM SVRZID0gUmVhZFVzZXJEYXRhIFdyaXRlVXNlckRhdGEgTmV0d29ya1NlcnZpY2VzCisgICAgICAg ICAgICAgICAgfQogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQo= 41430 2009-10-19 10:58:44 -0700 2009-10-24 08:28:28 -0700 3rd try 30476_3.patch text/plain 9736 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ5Nzg5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTAt MTkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gW1N5bWJpYW5dIFNl dCB0aGUgY2FwYWJpbGl0eSBhbmQgbWVtb3J5IHJlcXVpcmVkIHRvIHJ1biBRdFdlYktpdCBmb3Ig U3ltYmlhbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzA0NzYKKworICAgICAgICBTZXQgdGhlIHN0YWNrIHNpemUgdG8gODAgS2IgYW5kIGhlYXAgc2l6 ZSB0byB0aGUgMTI4a0IgLSAzMk1CIHJhbmdlCisgICAgICAgIHRvIGFsbCBleGVjdXRhYmxlcyBs aW5raW5nIGFnYWluc3QgV2ViS2l0IGxpYnJhcnkuCisKKyAgICAgICAgKiBXZWJLaXQucHJpOgor CiAyMDA5LTEwLTE4ICBKYW4gTWljaGFlbCBBbG9uem8gIDxqbWFsb256b0B3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEhvbGdlciBGcmV5dGhlci4KSW5kZXg6IFdlYktpdC5wcmkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0LnByaQkocmV2aXNpb24gNDk3ODQpCisrKyBXZWJLaXQucHJp CSh3b3JraW5nIGNvcHkpCkBAIC0yNSw2ICsyNSwxMCBAQCBidWlsZGluZy1saWJzIHsKICAgICAg ICAgICAgICAgICBMSUJTICs9IC1sUXRXZWJLaXQkJHtRVF9NQUpPUl9WRVJTSU9OfQogICAgICAg ICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICBMSUJTICs9IC1sUXRXZWJLaXQKKyAgICAg ICAgICAgICAgICBzeW1iaWFuIHsKKyAgICAgICAgICAgICAgICAgICAgVEFSR0VULkVQT0NTVEFD S1NJWkUgPSAweDE0MDAwIC8vIDgwIGtCCisgICAgICAgICAgICAgICAgICAgIFRBUkdFVC5FUE9D SEVBUFNJWkUgPSAweDIwMDAwIDB4MjAwMDAwMCAvLyBNaW4gMTI4a0IsIE1heCAzMk1CCisgICAg ICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQpJbmRleDogSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwkocmV2aXNpb24gNDk3OTIpCisrKyBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMC0xOSAgTGFzemxvIEdvbWJvcyAgPGxh c3psby4xLmdvbWJvc0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBbU3ltYmlhbl0gU2V0IHRoZSBjYXBhYmlsaXR5IGFuZCBt ZW1vcnkgcmVxdWlyZWQgdG8gcnVuIFF0V2ViS2l0IGZvciBTeW1iaWFuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDQ3NgorCisgICAgICAgIEFzc2ln biBSZWFkVXNlckRhdGEgV3JpdGVVc2VyRGF0YSBOZXR3b3JrU2VydmljZXMgU3ltYmlhbiBjYXBh YmlsaXRpZXMKKyAgICAgICAgdG8ganNjLmV4ZS4KKworICAgICAgICAqIGpzYy5wcm86CisKIDIw MDktMTAtMTggIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2pzYy5wcm8K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvanNjLnBybwkocmV2aXNpb24gNDk3ODQpCisr KyBKYXZhU2NyaXB0Q29yZS9qc2MucHJvCSh3b3JraW5nIGNvcHkpCkBAIC0yOSwzICsyOSw3IEBA IGxlc3NUaGFuKFFUX01JTk9SX1ZFUlNJT04sIDQpIHsKIAogKi1nKysqOlFNQUtFX0NYWEZMQUdT X1JFTEVBU0UgLT0gLU8yCiAqLWcrKyo6UU1BS0VfQ1hYRkxBR1NfUkVMRUFTRSArPSAtTzMKKwor c3ltYmlhbiB7CisgICAgVEFSR0VULkNBUEFCSUxJVFkgPSBSZWFkVXNlckRhdGEgV3JpdGVVc2Vy RGF0YSBOZXR3b3JrU2VydmljZXMKK30KSW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L3F0L0NoYW5nZUxvZwkocmV2aXNpb24gNDk3ODkpCisrKyBXZWJLaXQv cXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMDktMTAtMTkg IExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gW1N5bWJpYW5dIFNldCB0 aGUgY2FwYWJpbGl0eSBhbmQgbWVtb3J5IHJlcXVpcmVkIHRvIHJ1biBRdFdlYktpdCBmb3IgU3lt YmlhbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA0 NzYKKworICAgICAgICBBc3NpZ24gUmVhZFVzZXJEYXRhIFdyaXRlVXNlckRhdGEgTmV0d29ya1Nl cnZpY2VzIFN5bWJpYW4gY2FwYWJpbGl0aWVzCisgICAgICAgIHRvIGFsbCBRdFdlYmtpdCBleGVj dXRhYmxlcy4KKworICAgICAgICAqIFFHVkxhdW5jaGVyL1FHVkxhdW5jaGVyLnBybzoKKyAgICAg ICAgKiBRdExhdW5jaGVyL1F0TGF1bmNoZXIucHJvOgorICAgICAgICAqIHRlc3RzL2JlbmNobWFy a3MvbG9hZGluZy90c3RfbG9hZGluZy5wcm86CisgICAgICAgICogdGVzdHMvYmVuY2htYXJrcy9w YWludGluZy90c3RfcGFpbnRpbmcucHJvOgorICAgICAgICAqIHRlc3RzL3FncmFwaGljc3dlYnZp ZXcvcWdyYXBoaWNzd2Vidmlldy5wcm86CisgICAgICAgICogdGVzdHMvcXdlYmVsZW1lbnQvcXdl YmVsZW1lbnQucHJvOgorICAgICAgICAqIHRlc3RzL3F3ZWJmcmFtZS9xd2ViZnJhbWUucHJvOgor ICAgICAgICAqIHRlc3RzL3F3ZWJoaXN0b3J5L3F3ZWJoaXN0b3J5LnBybzoKKyAgICAgICAgKiB0 ZXN0cy9xd2ViaGlzdG9yeWludGVyZmFjZS9xd2ViaGlzdG9yeWludGVyZmFjZS5wcm86CisgICAg ICAgICogdGVzdHMvcXdlYnBhZ2UvcXdlYnBhZ2UucHJvOgorICAgICAgICAqIHRlc3RzL3F3ZWJw bHVnaW5kYXRhYmFzZS9xd2VicGx1Z2luZGF0YWJhc2UucHJvOgorICAgICAgICAqIHRlc3RzL3F3 ZWJ2aWV3L3F3ZWJ2aWV3LnBybzoKKwogMjAwOS0xMC0xOSAgVmlhdGNoZXNsYXYgT3N0YXBlbmtv ICA8b3N0YXBlbmtvLnZpYXRjaGVzbGF2QG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBcml5YSBIaWRheWF0LgpJbmRleDogV2ViS2l0L3F0L1FHVkxhdW5jaGVyL1FHVkxhdW5jaGVy LnBybwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvUUdWTGF1bmNoZXIvUUdWTGF1bmNoZXIucHJv CShyZXZpc2lvbiA0OTc4NCkKKysrIFdlYktpdC9xdC9RR1ZMYXVuY2hlci9RR1ZMYXVuY2hlci5w cm8JKHdvcmtpbmcgY29weSkKQEAgLTEwLDQgKzEwLDcgQEAgUVQgKz0gbmV0d29yawogbWFjeDpR VCs9eG1sCiBRTUFLRV9SUEFUSERJUiA9ICQkT1VUUFVUX0RJUi9saWIgJCRRTUFLRV9SUEFUSERJ UgogCi1zeW1iaWFuOlRBUkdFVC5VSUQzID0gMHhBMDAwRTU0NAorc3ltYmlhbiB7CisgICAgVEFS R0VULlVJRDMgPSAweEEwMDBFNTQ0CisgICAgVEFSR0VULkNBUEFCSUxJVFkgPSBSZWFkVXNlckRh dGEgV3JpdGVVc2VyRGF0YSBOZXR3b3JrU2VydmljZXMKK30KSW5kZXg6IFdlYktpdC9xdC9RdExh dW5jaGVyL1F0TGF1bmNoZXIucHJvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9RdExhdW5jaGVy L1F0TGF1bmNoZXIucHJvCShyZXZpc2lvbiA0OTc4NCkKKysrIFdlYktpdC9xdC9RdExhdW5jaGVy L1F0TGF1bmNoZXIucHJvCSh3b3JraW5nIGNvcHkpCkBAIC0xMCw0ICsxMCw3IEBAIFFUICs9IG5l dHdvcmsKIG1hY3g6UVQrPXhtbAogUU1BS0VfUlBBVEhESVIgPSAkJE9VVFBVVF9ESVIvbGliICQk UU1BS0VfUlBBVEhESVIKIAotc3ltYmlhbjpUQVJHRVQuVUlEMyA9IDB4QTAwMEU1NDMKK3N5bWJp YW4geworICAgIFRBUkdFVC5VSUQzID0gMHhBMDAwRTU0MworICAgIFRBUkdFVC5DQVBBQklMSVRZ ID0gUmVhZFVzZXJEYXRhIFdyaXRlVXNlckRhdGEgTmV0d29ya1NlcnZpY2VzCit9CkluZGV4OiBX ZWJLaXQvcXQvdGVzdHMvYmVuY2htYXJrcy9sb2FkaW5nL3RzdF9sb2FkaW5nLnBybwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvcXQvdGVzdHMvYmVuY2htYXJrcy9sb2FkaW5nL3RzdF9sb2FkaW5nLnBy bwkocmV2aXNpb24gNDk3ODQpCisrKyBXZWJLaXQvcXQvdGVzdHMvYmVuY2htYXJrcy9sb2FkaW5n L3RzdF9sb2FkaW5nLnBybwkod29ya2luZyBjb3B5KQpAQCAtNSw0ICs1LDcgQEAgU09VUkNFUyAr PSB0c3RfbG9hZGluZy5jcHAKIFFUICs9IHRlc3RsaWIgbmV0d29yawogUU1BS0VfUlBBVEhESVIg PSAkJE9VVFBVVF9ESVIvbGliICQkUU1BS0VfUlBBVEhESVIKIAotc3ltYmlhbjpUQVJHRVQuVUlE MyA9IDB4QTAwMEU1NDEKK3N5bWJpYW4geworICAgIFRBUkdFVC5VSUQzID0gMHhBMDAwRTU0MQor ICAgIFRBUkdFVC5DQVBBQklMSVRZID0gUmVhZFVzZXJEYXRhIFdyaXRlVXNlckRhdGEgTmV0d29y a1NlcnZpY2VzCit9CkluZGV4OiBXZWJLaXQvcXQvdGVzdHMvYmVuY2htYXJrcy9wYWludGluZy90 c3RfcGFpbnRpbmcucHJvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC90ZXN0cy9iZW5jaG1hcmtz L3BhaW50aW5nL3RzdF9wYWludGluZy5wcm8JKHJldmlzaW9uIDQ5Nzg0KQorKysgV2ViS2l0L3F0 L3Rlc3RzL2JlbmNobWFya3MvcGFpbnRpbmcvdHN0X3BhaW50aW5nLnBybwkod29ya2luZyBjb3B5 KQpAQCAtNSw0ICs1LDcgQEAgU09VUkNFUyArPSB0c3RfcGFpbnRpbmcuY3BwCiBRVCArPSB0ZXN0 bGliIG5ldHdvcmsKIFFNQUtFX1JQQVRIRElSID0gJCRPVVRQVVRfRElSL2xpYiAkJFFNQUtFX1JQ QVRIRElSCiAKLXN5bWJpYW46VEFSR0VULlVJRDMgPSAweEEwMDBFNTQyCitzeW1iaWFuIHsKKyAg ICBUQVJHRVQuVUlEMyA9IDB4QTAwMEU1NDIKKyAgICBUQVJHRVQuQ0FQQUJJTElUWSA9IFJlYWRV c2VyRGF0YSBXcml0ZVVzZXJEYXRhIE5ldHdvcmtTZXJ2aWNlcworfQpJbmRleDogV2ViS2l0L3F0 L3Rlc3RzL3FncmFwaGljc3dlYnZpZXcvcWdyYXBoaWNzd2Vidmlldy5wcm8KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0L3F0L3Rlc3RzL3FncmFwaGljc3dlYnZpZXcvcWdyYXBoaWNzd2Vidmlldy5wcm8J KHJldmlzaW9uIDQ5Nzg0KQorKysgV2ViS2l0L3F0L3Rlc3RzL3FncmFwaGljc3dlYnZpZXcvcWdy YXBoaWNzd2Vidmlldy5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTQsMyArNCw3IEBAIGluY2x1ZGUo Li4vLi4vLi4vLi4vV2ViS2l0LnByaSkKIFNPVVJDRVMgICs9IHRzdF9xZ3JhcGhpY3N3ZWJ2aWV3 LmNwcAogUVQgKz0gdGVzdGxpYiBuZXR3b3JrCiBRTUFLRV9SUEFUSERJUiA9ICQkT1VUUFVUX0RJ Ui9saWIgJCRRTUFLRV9SUEFUSERJUgorCitzeW1iaWFuIHsKKyAgICBUQVJHRVQuQ0FQQUJJTElU WSA9IFJlYWRVc2VyRGF0YSBXcml0ZVVzZXJEYXRhIE5ldHdvcmtTZXJ2aWNlcworfQpJbmRleDog V2ViS2l0L3F0L3Rlc3RzL3F3ZWJlbGVtZW50L3F3ZWJlbGVtZW50LnBybwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXQvcXQvdGVzdHMvcXdlYmVsZW1lbnQvcXdlYmVsZW1lbnQucHJvCShyZXZpc2lvbiA0 OTc4NCkKKysrIFdlYktpdC9xdC90ZXN0cy9xd2ViZWxlbWVudC9xd2ViZWxlbWVudC5wcm8JKHdv cmtpbmcgY29weSkKQEAgLTYsNCArNiw3IEBAIFJFU09VUkNFUyArPSBxd2ViZWxlbWVudC5xcmMK IFFUICs9IHRlc3RsaWIgbmV0d29yawogUU1BS0VfUlBBVEhESVIgPSAkJE9VVFBVVF9ESVIvbGli ICQkUU1BS0VfUlBBVEhESVIKIAotc3ltYmlhbjpUQVJHRVQuVUlEMyA9IDB4QTAwMEU1M0EKK3N5 bWJpYW4geworICAgIFRBUkdFVC5VSUQzID0gMHhBMDAwRTUzQQorICAgIFRBUkdFVC5DQVBBQklM SVRZID0gUmVhZFVzZXJEYXRhIFdyaXRlVXNlckRhdGEgTmV0d29ya1NlcnZpY2VzCit9CkluZGV4 OiBXZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3F3ZWJmcmFtZS5wcm8KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS9xd2ViZnJhbWUucHJvCShyZXZpc2lvbiA0OTc4NCkK KysrIFdlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvcXdlYmZyYW1lLnBybwkod29ya2luZyBjb3B5 KQpAQCAtNyw0ICs3LDcgQEAgUVQgKz0gdGVzdGxpYiBuZXR3b3JrCiBRTUFLRV9SUEFUSERJUiA9 ICQkT1VUUFVUX0RJUi9saWIgJCRRTUFLRV9SUEFUSERJUgogREVGSU5FUyArPSBTUkNESVI9XFxc IiQkUFdEL3Jlc291cmNlc1xcXCIKIAotc3ltYmlhbjpUQVJHRVQuVUlEMyA9IDB4QTAwMEU1M0QK K3N5bWJpYW4geworICAgIFRBUkdFVC5VSUQzID0gMHhBMDAwRTUzRAorICAgIFRBUkdFVC5DQVBB QklMSVRZID0gUmVhZFVzZXJEYXRhIFdyaXRlVXNlckRhdGEgTmV0d29ya1NlcnZpY2VzCit9Cklu ZGV4OiBXZWJLaXQvcXQvdGVzdHMvcXdlYmhpc3RvcnkvcXdlYmhpc3RvcnkucHJvCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdC9xdC90ZXN0cy9xd2ViaGlzdG9yeS9xd2ViaGlzdG9yeS5wcm8JKHJldmlz aW9uIDQ5Nzg0KQorKysgV2ViS2l0L3F0L3Rlc3RzL3F3ZWJoaXN0b3J5L3F3ZWJoaXN0b3J5LnBy bwkod29ya2luZyBjb3B5KQpAQCAtNiw0ICs2LDcgQEAgUkVTT1VSQ0VTICArPSB0c3RfcXdlYmhp c3RvcnkucXJjCiBRVCArPSB0ZXN0bGliIG5ldHdvcmsKIFFNQUtFX1JQQVRIRElSID0gJCRPVVRQ VVRfRElSL2xpYiAkJFFNQUtFX1JQQVRIRElSCiAKLXN5bWJpYW46VEFSR0VULlVJRDMgPSAweEEw MDBFNTNCCitzeW1iaWFuIHsKKyAgICBUQVJHRVQuVUlEMyA9IDB4QTAwMEU1M0IKKyAgICBUQVJH RVQuQ0FQQUJJTElUWSA9IFJlYWRVc2VyRGF0YSBXcml0ZVVzZXJEYXRhIE5ldHdvcmtTZXJ2aWNl cworfQpJbmRleDogV2ViS2l0L3F0L3Rlc3RzL3F3ZWJoaXN0b3J5aW50ZXJmYWNlL3F3ZWJoaXN0 b3J5aW50ZXJmYWNlLnBybwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvdGVzdHMvcXdlYmhpc3Rv cnlpbnRlcmZhY2UvcXdlYmhpc3RvcnlpbnRlcmZhY2UucHJvCShyZXZpc2lvbiA0OTc4NCkKKysr IFdlYktpdC9xdC90ZXN0cy9xd2ViaGlzdG9yeWludGVyZmFjZS9xd2ViaGlzdG9yeWludGVyZmFj ZS5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTUsNCArNSw3IEBAIFNPVVJDRVMgICs9IHRzdF9xd2Vi aGlzdG9yeWludGVyZmFjZS5jcHAKIFFUICs9IHRlc3RsaWIgbmV0d29yawogUU1BS0VfUlBBVEhE SVIgPSAkJE9VVFBVVF9ESVIvbGliICQkUU1BS0VfUlBBVEhESVIKIAotc3ltYmlhbjpUQVJHRVQu VUlEMyA9IDB4QTAwMEU1M0MKK3N5bWJpYW4geworICAgIFRBUkdFVC5VSUQzID0gMHhBMDAwRTUz QworICAgIFRBUkdFVC5DQVBBQklMSVRZID0gUmVhZFVzZXJEYXRhIFdyaXRlVXNlckRhdGEgTmV0 d29ya1NlcnZpY2VzCit9CkluZGV4OiBXZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvcXdlYnBhZ2Uu cHJvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC90ZXN0cy9xd2VicGFnZS9xd2VicGFnZS5wcm8J KHJldmlzaW9uIDQ5Nzg0KQorKysgV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3F3ZWJwYWdlLnBy bwkod29ya2luZyBjb3B5KQpAQCAtNyw0ICs3LDcgQEAgUVQgKz0gdGVzdGxpYiBuZXR3b3JrCiBR TUFLRV9SUEFUSERJUiA9ICQkT1VUUFVUX0RJUi9saWIgJCRRTUFLRV9SUEFUSERJUgogREVGSU5F UyArPSBTUkNESVI9XFxcIiQkUFdEL1xcXCIKIAotc3ltYmlhbjpUQVJHRVQuVUlEMyA9IDB4QTAw MEU1M0UKK3N5bWJpYW4geworICAgIFRBUkdFVC5VSUQzID0gMHhBMDAwRTUzRQorICAgIFRBUkdF VC5DQVBBQklMSVRZID0gUmVhZFVzZXJEYXRhIFdyaXRlVXNlckRhdGEgTmV0d29ya1NlcnZpY2Vz Cit9CkluZGV4OiBXZWJLaXQvcXQvdGVzdHMvcXdlYnBsdWdpbmRhdGFiYXNlL3F3ZWJwbHVnaW5k YXRhYmFzZS5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwbHVnaW5kYXRh YmFzZS9xd2VicGx1Z2luZGF0YWJhc2UucHJvCShyZXZpc2lvbiA0OTc4NCkKKysrIFdlYktpdC9x dC90ZXN0cy9xd2VicGx1Z2luZGF0YWJhc2UvcXdlYnBsdWdpbmRhdGFiYXNlLnBybwkod29ya2lu ZyBjb3B5KQpAQCAtNSw0ICs1LDcgQEAgU09VUkNFUyAgKz0gdHN0X3F3ZWJwbHVnaW5kYXRhYmFz ZS5jcHAKIFFUICs9IHRlc3RsaWIgbmV0d29yawogUU1BS0VfUlBBVEhESVIgPSAkJE9VVFBVVF9E SVIvbGliICQkUU1BS0VfUlBBVEhESVIKIAotc3ltYmlhbjpUQVJHRVQuVUlEMyA9IDB4QTAwMEU1 NDAKK3N5bWJpYW4geworICAgIFRBUkdFVC5VSUQzID0gMHhBMDAwRTU0MAorICAgIFRBUkdFVC5D QVBBQklMSVRZID0gUmVhZFVzZXJEYXRhIFdyaXRlVXNlckRhdGEgTmV0d29ya1NlcnZpY2VzCit9 CkluZGV4OiBXZWJLaXQvcXQvdGVzdHMvcXdlYnZpZXcvcXdlYnZpZXcucHJvCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdC9xdC90ZXN0cy9xd2Vidmlldy9xd2Vidmlldy5wcm8JKHJldmlzaW9uIDQ5Nzg0 KQorKysgV2ViS2l0L3F0L3Rlc3RzL3F3ZWJ2aWV3L3F3ZWJ2aWV3LnBybwkod29ya2luZyBjb3B5 KQpAQCAtNiw0ICs2LDcgQEAgUVQgKz0gdGVzdGxpYiBuZXR3b3JrCiBRTUFLRV9SUEFUSERJUiA9 ICQkT1VUUFVUX0RJUi9saWIgJCRRTUFLRV9SUEFUSERJUgogREVGSU5FUyArPSBTUkNESVI9XFxc IiQkUFdEL1xcXCIKIAotc3ltYmlhbjpUQVJHRVQuVUlEMyA9IDB4QTAwMEU1M0YKK3N5bWJpYW4g eworICAgIFRBUkdFVC5VSUQzID0gMHhBMDAwRTUzRgorICAgIFRBUkdFVC5DQVBBQklMSVRZID0g UmVhZFVzZXJEYXRhIFdyaXRlVXNlckRhdGEgTmV0d29ya1NlcnZpY2VzCit9Cg==