302416 2025-11-12 13:09:34 -0800 Inspector agents should use CheckedRef for InspectorEnvironment references 2025-12-09 12:58:20 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 302559 303870 1 basuke basuke webkit-bug-importer oldest_to_newest 2158313 0 basuke 2025-11-12 13:09:34 -0800 Inspector agents hold references to their InspectorEnvironment through the AgentContext structure. Currently, this uses a raw reference which doesn't provide any lifetime safety guarantees. If an agent outlives its environment (which should never happen but could be a bug), we'd have undefined behavior. This change makes InspectorEnvironment inherit from CanMakeCheckedPtr and updates AgentContext to hold a CheckedRef<InspectorEnvironment>. This provides runtime checking that the environment is never destroyed while agents still reference it, making bugs more actionable by causing immediate crashes rather than subtle memory corruption. The change required: 1. Making InspectorEnvironment support CheckedPtr/CheckedRef 2. JSGlobalObjectInspectorController implementing the AbstractCanMakeCheckedPtr interface 3. Updating AgentContext to use CheckedRef instead of a raw reference 4. Including InspectorEnvironment.h instead of forward declaring it (required for CheckedRef) 2158314 1 basuke 2025-11-12 13:11:12 -0800 rdar://164582768 2158315 2 basuke 2025-11-12 13:13:53 -0800 Pull request: https://github.com/WebKit/WebKit/pull/53828 2158666 3 ews-feeder 2025-11-13 16:47:28 -0800 Committed 303022@main (3db54ba8bc59): <https://commits.webkit.org/303022@main> Reviewed commits have been landed. Closing PR #53828 and removing active labels. 2158955 4 darbinyan 2025-11-14 18:35:57 -0800 Reopened Bugzilla. REGRESSION(303022@main): [macOS Release wk1] webaudio/audiobuffersource-not-gced-until-ended.html is a flaky crash, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=302559. 2159736 5 basuke 2025-11-18 17:15:09 -0800 <rdar://problem/165006365> 2159737 6 basuke 2025-11-18 17:15:23 -0800 Pull request: https://github.com/WebKit/WebKit/pull/54147 2163734 7 ews-feeder 2025-12-05 14:02:01 -0800 Committed 304015@main (0f0653d9eddc): <https://commits.webkit.org/304015@main> Reviewed commits have been landed. Closing PR #54147 and removing active labels.