30157 2009-10-07 01:16:32 -0700 [Qt] Symbian SBSv2 .code segment is too big for linker 2009-10-07 09:39:21 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED Qt P1 Blocker --- 27065 0 koshuin webkit-unassigned commit-queue eric oldest_to_newest 152985 0 koshuin 2009-10-07 01:16:32 -0700 Symbian's new build toolchain SBSv2 (Symbian Build System version 2) creates more code than the old SBSv1. Toolchain has a fixed start address for .data segment that .code segment overlaps with in SBSv2 causing the link stage to fail when building qtwebkit.dll. 152986 1 40771 koshuin 2009-10-07 01:21:48 -0700 Created attachment 40771 proposed fix for webcore.pro Patch increases the base address of .data segment by passing linkeroption to RVCT's armlink. 152998 2 40776 koshuin 2009-10-07 02:29:26 -0700 Created attachment 40776 proposed fix for webcore.pro take 2 removed the test cases missing part from changelog. 153001 3 40776 commit-queue 2009-10-07 03:04:57 -0700 Comment on attachment 40776 proposed fix for webcore.pro take 2 Rejecting patch 40776 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11400 test cases. storage/close-during-stress-test.html -> crashed Exiting early after 1 failures. 9384 tests run. 481.84s total testing time 9383 test cases (99%) succeeded 1 test case (<1%) crashed 6 test cases (<1%) had stderr output 153005 4 40776 hausmann 2009-10-07 03:48:18 -0700 Comment on attachment 40776 proposed fix for webcore.pro take 2 Overriding the bot here, this patch cannot possibly have affected the failing test :) 153006 5 40776 commit-queue 2009-10-07 03:58:23 -0700 Comment on attachment 40776 proposed fix for webcore.pro take 2 Clearing flags on attachment: 40776 Committed r49239: <http://trac.webkit.org/changeset/49239> 153007 6 commit-queue 2009-10-07 03:58:26 -0700 All reviewed patches have been landed. Closing bug. 153080 7 eric 2009-10-07 09:39:21 -0700 (In reply to comment #4) > (From update of attachment 40776 [details]) > Overriding the bot here, this patch cannot possibly have affected the failing > test :) Agreed. Although when that happens we need to be sure to file bugs about the flakey tests. :) (Which is my job, don't get me wrong. But if somehow I don't notice a flakey test like this in the future, feel free/encouraged to ping me about it or CC me on the bug.) Filed bug 30172. 40771 2009-10-07 01:21:48 -0700 2009-10-07 02:29:26 -0700 proposed fix for webcore.pro webcorepro.diff text/plain 1147 koshuin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTllYmU0YS4uMzk1N2ViYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMC0wNiAgSmFubmUgS29za2lu ZW4gIDxqYW5uZS5wLmtvc2tpbmVuQGRpZ2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFN5bWJpYW4gU0JTdjIgLmRhdGEgc2VnbWVu dCBhZHJlc3MgZml4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMDE1NworICAgICAgICAKKyAgICAgICAgUk8tc2VjdGlvbiBpbiBxdHdlYmtpdC5kbGwg ZXhjZWVkcyBhbGxvY2F0ZWQgc3BhY2UgaW4gU0JTdjIuIE1vdmUgUlctc2VjdGlvbgorICAgICAg ICBiYXNlIGFkZHJlc3MgdG8gc3RhcnQgZnJvbSAweDgwMDAwMCBpbnN0ZWFkIG9mIHRoZSB0b29s Y2hhaW4gZGVmYXVsdCAweDQwMDAwMAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQor CisgICAgICAgICogV2ViQ29yZS5wcm86CisKIDIwMDktMTAtMDYgIERhdmlkIExldmluICA8bGV2 aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9XZWJDb3JlLnBybyBiL1dlYkNvcmUvV2ViQ29yZS5wcm8KaW5kZXgg OTk2M2I0Ni4uYzc5ZWRlNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9XZWJDb3JlLnBybworKysgYi9X ZWJDb3JlL1dlYkNvcmUucHJvCkBAIC0xMyw2ICsxMyw5IEBAIHN5bWJpYW46IHsKIAogICAgIFRB UkdFVC5VSUQzID0gMHgyMDAyNjdDMgogfQorIyBSTy1zZWN0aW9uIGluIHF0d2Via2l0LmRsbCBl eGNlZWRzIGFsbG9jYXRlZCBzcGFjZSBpbiBTQlN2Mi4gTW92ZSBSVy1zZWN0aW9uCisjIGJhc2Ug YWRkcmVzcyB0byBzdGFydCBmcm9tIDB4ODAwMDAwIGluc3RlYWQgb2YgdGhlIHRvb2xjaGFpbiBk ZWZhdWx0IDB4NDAwMDAwLgorc3ltYmlhbi1zYnN2MjogTU1QX1JVTEVTICs9ICJMSU5LRVJPUFRJ T04gIGFybWNjIC0tcnctYmFzZSAweDgwMDAwMCIKIAogaW5jbHVkZSgkJFBXRC8uLi9XZWJLaXQu cHJpKQogCg== 40776 2009-10-07 02:29:26 -0700 2009-10-07 03:58:23 -0700 proposed fix for webcore.pro take 2 webcorepro2.diff text/plain 1106 koshuin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTllYmU0YS4uNzYzZGY4NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMC0wNiAgSmFubmUgS29za2lu ZW4gIDxqYW5uZS5wLmtvc2tpbmVuQGRpZ2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFN5bWJpYW4gU0JTdjIgLmRhdGEgc2VnbWVu dCBhZHJlc3MgZml4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMDE1NworCisgICAgICAgIFJPLXNlY3Rpb24gaW4gcXR3ZWJraXQuZGxsIGV4Y2VlZHMg YWxsb2NhdGVkIHNwYWNlIGluIFNCU3YyLiBNb3ZlIFJXLXNlY3Rpb24KKyAgICAgICAgYmFzZSBh ZGRyZXNzIHRvIHN0YXJ0IGZyb20gMHg4MDAwMDAgaW5zdGVhZCBvZiB0aGUgdG9vbGNoYWluIGRl ZmF1bHQgMHg0MDAwMDAKKworICAgICAgICAqIFdlYkNvcmUucHJvOgorCiAyMDA5LTEwLTA2ICBE YXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBP bGl2ZXIgSHVudC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5wcm8gYi9XZWJDb3JlL1dl YkNvcmUucHJvCmluZGV4IDk5NjNiNDYuLmM3OWVkZTcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2Vi Q29yZS5wcm8KKysrIGIvV2ViQ29yZS9XZWJDb3JlLnBybwpAQCAtMTMsNiArMTMsOSBAQCBzeW1i aWFuOiB7CiAKICAgICBUQVJHRVQuVUlEMyA9IDB4MjAwMjY3QzIKIH0KKyMgUk8tc2VjdGlvbiBp biBxdHdlYmtpdC5kbGwgZXhjZWVkcyBhbGxvY2F0ZWQgc3BhY2UgaW4gU0JTdjIuIE1vdmUgUlct c2VjdGlvbgorIyBiYXNlIGFkZHJlc3MgdG8gc3RhcnQgZnJvbSAweDgwMDAwMCBpbnN0ZWFkIG9m IHRoZSB0b29sY2hhaW4gZGVmYXVsdCAweDQwMDAwMC4KK3N5bWJpYW4tc2JzdjI6IE1NUF9SVUxF UyArPSAiTElOS0VST1BUSU9OICBhcm1jYyAtLXJ3LWJhc2UgMHg4MDAwMDAiCiAKIGluY2x1ZGUo JCRQV0QvLi4vV2ViS2l0LnByaSkKIAo=