29856 2009-09-29 05:34:18 -0700 [Qt] gotoAnchor in QtWebKit 2010-02-16 18:30:51 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt P2 Enhancement --- 31552 1 vestbo webkit-unassigned ariya.hidayat tonikitoo oldest_to_newest 150874 0 vestbo 2009-09-29 05:34:18 -0700 This bug report originated from issue QTBUG-3390 http://bugreports.qt.nokia.com/browse/QTBUG-3390 --- Description --- The gotoAnchor function is available in webkit, but it does not have a Qt wrapper function so that it is available to use. It is the function that scrolls the web page to an html anchor on that page. I am using setHtml to load locally generated html and I want to be able to scroll to a specified point in that html. This should be very easy to fix since only a Qt wrapper function is needed to access an existing function in webkit. 158250 1 tonikitoo 2009-10-27 10:33:24 -0700 *** Bug 29885 has been marked as a duplicate of this bug. *** 190608 2 48791 ariya.hidayat 2010-02-15 23:15:42 -0800 Created attachment 48791 Patch 190630 3 48791 hausmann 2010-02-16 01:47:18 -0800 Comment on attachment 48791 Patch Nice! > +void QWebFrame::scrollToAnchor(const QString &anchor) [...] > + void scrollToAnchor(const QString &anchor); Would be good to fix the & position before landing :) 190643 4 ariya.hidayat 2010-02-16 02:28:35 -0800 > > +void QWebFrame::scrollToAnchor(const QString &anchor) > [...] > > + void scrollToAnchor(const QString &anchor); > > Would be good to fix the & position before landing :) The whole file is still using Qt code style for this. Should I switch to WebKit's for this particular function only? 190849 5 ariya.hidayat 2010-02-16 18:30:51 -0800 Manually committed in r54857: http://trac.webkit.org/changeset/54857 48791 2010-02-15 23:15:42 -0800 2010-02-16 01:47:17 -0800 Patch bug-29856-20100215231535.patch text/plain 3361 ariya.hidayat ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcCBiL1dlYktpdC9xdC9BcGkv cXdlYmZyYW1lLmNwcAppbmRleCA0YzFmMzE4Li41NTIxYTcxIDEwMDY0NAotLS0gYS9XZWJLaXQv cXQvQXBpL3F3ZWJmcmFtZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCkBA IC0xMTQwLDYgKzExNDAsMTcgQEAgdm9pZCBRV2ViRnJhbWU6OnNldFNjcm9sbFBvc2l0aW9uKGNv bnN0IFFQb2ludCAmcG9zKQogfQogCiAvKiEKKyAgXHNpbmNlIDQuNworICBTY3JvbGxzIHRoZSBm cmFtZSB0byB0aGUgZ2l2ZW4gXGEgYW5jaG9yIG5hbWUuCisqLwordm9pZCBRV2ViRnJhbWU6OnNj cm9sbFRvQW5jaG9yKGNvbnN0IFFTdHJpbmcgJmFuY2hvcikKK3sKKyAgICBGcmFtZVZpZXcgKnZp ZXcgPSBkLT5mcmFtZS0+dmlldygpOworICAgIGlmICh2aWV3KQorICAgICAgICB2aWV3LT5zY3Jv bGxUb0FuY2hvcihhbmNob3IpOworfQorCisvKiEKICAgXHNpbmNlIDQuNgogICBSZW5kZXIgdGhl IFxhIGxheWVyIG9mIHRoZSBmcmFtZSB1c2luZyBcYSBwYWludGVyIGNsaXBwaW5nIHRvIFxhIGNs aXAuCiAKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmggYi9XZWJLaXQvcXQv QXBpL3F3ZWJmcmFtZS5oCmluZGV4IDI1ZjZjOWIuLmVhZGFiM2IgMTAwNjQ0Ci0tLSBhL1dlYktp dC9xdC9BcGkvcXdlYmZyYW1lLmgKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuaApAQCAt MTYwLDYgKzE2MCw4IEBAIHB1YmxpYzoKICAgICBRUG9pbnQgc2Nyb2xsUG9zaXRpb24oKSBjb25z dDsKICAgICB2b2lkIHNldFNjcm9sbFBvc2l0aW9uKGNvbnN0IFFQb2ludCAmcG9zKTsKIAorICAg IHZvaWQgc2Nyb2xsVG9BbmNob3IoY29uc3QgUVN0cmluZyAmYW5jaG9yKTsKKwogICAgIGVudW0g UmVuZGVyTGF5ZXIgewogICAgICAgICBDb250ZW50c0xheWVyID0gMHgxMCwKICAgICAgICAgU2Ny b2xsQmFyTGF5ZXIgPSAweDIwLApkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dl YktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggNDVhMjRkMC4uMDcxOTg3ZSAxMDA2NDQKLS0tIGEvV2Vi S2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTAtMDItMTUgIEFyaXlhIEhpZGF5YXQgIDxhcml5YS5oaWRheWF0QGdtYWlsLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEFs bG93IHNjcm9sbGluZyB0byBhbiBhbmNob3IgcHJvZ3JhbW1hdGljYWxseS4KKworICAgICAgICAq IEFwaS9xd2ViZnJhbWUuY3BwOgorICAgICAgICAoUVdlYkZyYW1lOjpzY3JvbGxUb0FuY2hvcik6 IE5ldyBBUEkgZnVuY3Rpb24uCisgICAgICAgICogQXBpL3F3ZWJmcmFtZS5oOgorICAgICAgICAq IHRlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcDogTmV3IHRlc3RzIGZvciBzY3JvbGxU b0FuY2hvcigpLgorCiAyMDEwLTAyLTE1ICBOb2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFs QG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAt LWdpdCBhL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAgYi9XZWJL aXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCmluZGV4IGY1YzBlZmIuLjVh YzM3NjkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFt ZS5jcHAKKysrIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcApA QCAtNTg0LDYgKzU4NCw3IEBAIHByaXZhdGUgc2xvdHM6CiAgICAgdm9pZCBoYXNTZXRGb2N1cygp OwogICAgIHZvaWQgcmVuZGVyKCk7CiAgICAgdm9pZCBzY3JvbGxQb3NpdGlvbigpOworICAgIHZv aWQgc2Nyb2xsVG9BbmNob3IoKTsKICAgICB2b2lkIGV2YWx1YXRlV2lsbENhdXNlUmVwYWludCgp OwogICAgIHZvaWQgcU9iamVjdFdyYXBwZXJXaXRoU2FtZUlkZW50aXR5KCk7CiAgICAgdm9pZCBz Y3JvbGxSZWN1cnNpdmVseSgpOwpAQCAtMjc2NCw2ICsyNzY1LDM4IEBAIHZvaWQgdHN0X1FXZWJG cmFtZTo6c2Nyb2xsUG9zaXRpb24oKQogICAgIFFDT01QQVJFKHksIDI5KTsKIH0KIAordm9pZCB0 c3RfUVdlYkZyYW1lOjpzY3JvbGxUb0FuY2hvcigpCit7CisgICAgUVdlYlBhZ2UgcGFnZTsKKyAg ICBwYWdlLnNldFZpZXdwb3J0U2l6ZShRU2l6ZSg0ODAsIDgwMCkpOworICAgIFFXZWJGcmFtZSog ZnJhbWUgPSBwYWdlLm1haW5GcmFtZSgpOworCisgICAgUVN0cmluZyBodG1sKCI8aHRtbD48Ym9k eT48cCBzdHlsZT1cIm1hcmdpbi1ib3R0b206IDE1MDBweDtcIj5IZWxsby48L3A+IgorICAgICAg ICAgICAgICAgICAiPHA+PGEgaWQ9XCJmb29cIj5UaGlzPC9hPiBpcyBhbiBhbmNob3I8L3A+Igor ICAgICAgICAgICAgICAgICAiPHAgc3R5bGU9XCJtYXJnaW4tYm90dG9tOiAxNTAwcHg7XCI+PGEg aWQ9XCJiYXJcIj5UaGlzPC9hPiBpcyBhbm90aGVyIGFuY2hvcjwvcD4iCisgICAgICAgICAgICAg ICAgICI8L2JvZHk+PC9odG1sPiIpOworICAgIGZyYW1lLT5zZXRIdG1sKGh0bWwpOworICAgIGZy YW1lLT5zZXRTY3JvbGxQb3NpdGlvbihRUG9pbnQoMCwgMCkpOworICAgIFFDT01QQVJFKGZyYW1l LT5zY3JvbGxQb3NpdGlvbigpLngoKSwgMCk7CisgICAgUUNPTVBBUkUoZnJhbWUtPnNjcm9sbFBv c2l0aW9uKCkueSgpLCAwKTsKKworICAgIFFXZWJFbGVtZW50IGZvb0FuY2hvciA9IGZyYW1lLT5m aW5kRmlyc3RFbGVtZW50KCJhW2lkPWZvb10iKTsKKworICAgIGZyYW1lLT5zY3JvbGxUb0FuY2hv cigiZm9vIik7CisgICAgUUNPTVBBUkUoZnJhbWUtPnNjcm9sbFBvc2l0aW9uKCkueSgpLCBmb29B bmNob3IuZ2VvbWV0cnkoKS50b3AoKSk7CisKKyAgICBmcmFtZS0+c2Nyb2xsVG9BbmNob3IoImJh ciIpOworICAgIGZyYW1lLT5zY3JvbGxUb0FuY2hvcigiZm9vIik7CisgICAgUUNPTVBBUkUoZnJh bWUtPnNjcm9sbFBvc2l0aW9uKCkueSgpLCBmb29BbmNob3IuZ2VvbWV0cnkoKS50b3AoKSk7CisK KyAgICBmcmFtZS0+c2Nyb2xsVG9BbmNob3IoInRvcCIpOworICAgIFFDT01QQVJFKGZyYW1lLT5z Y3JvbGxQb3NpdGlvbigpLnkoKSwgMCk7CisKKyAgICBmcmFtZS0+c2Nyb2xsVG9BbmNob3IoImJh ciIpOworICAgIGZyYW1lLT5zY3JvbGxUb0FuY2hvcigibm90ZXhpc3QiKTsKKyAgICBRVkVSSUZZ KGZyYW1lLT5zY3JvbGxQb3NpdGlvbigpLnkoKSAhPSAwKTsKK30KKwogdm9pZCB0c3RfUVdlYkZy YW1lOjpldmFsdWF0ZVdpbGxDYXVzZVJlcGFpbnQoKQogewogICAgIFFXZWJWaWV3IHZpZXc7Cg==