29808 2009-09-28 08:32:33 -0700 [Qt] assertions to be visible on Symbian 2009-09-29 09:10:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED Qt P3 Normal --- 27065 1 koshuin webkit-unassigned commit-queue ddkilzer oldest_to_newest 150516 0 40236 koshuin 2009-09-28 08:32:33 -0700 Created attachment 40236 vprintf patch Qt port of Symbian uses Open C to access posix libraries. assertions.h uses vprintf to print out the assert messages into stderr. In Open C stderr prints are lost somewhere and only stdout can be seen from log files. This change that makes assert messages to be visible on Symbian. 150713 1 40236 ddkilzer 2009-09-28 16:35:00 -0700 Comment on attachment 40236 vprintf patch > diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog > index f6a644a..894ff9a 100644 > --- a/JavaScriptCore/ChangeLog > +++ b/JavaScriptCore/ChangeLog > @@ -1,3 +1,15 @@ > +2009-09-28 Janne Koskinen <janne.p.koskinen@digia.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [Qt] Assert messages prints visible in Symbian > + > + Asserts use vprintf to print the messages to stderr. > + In Symbian Open C it is not possible to see stderr so > + I routed the messages to stdout instead. > + > + * wtf/Assertions.cpp: > + Please include a reference to the bug URL in the ChangeLog entry. > +#ifdef PLATFORM(SYMBIAN) This should be: #if PLATFORM(SYMBIAN) r- to address the above issues. 150816 2 40286 koshuin 2009-09-29 00:38:50 -0700 Created attachment 40286 vprintf patch second attempt Corrected patch based on review comments. 150819 3 40287 koshuin 2009-09-29 00:48:38 -0700 Created attachment 40287 vprintf patch third attempt Corrected based on review comments. Added bug url and changed to use #if instead of #ifdef. 150932 4 40287 ddkilzer 2009-09-29 09:01:23 -0700 Comment on attachment 40287 vprintf patch third attempt r=me 150935 5 40287 commit-queue 2009-09-29 09:10:30 -0700 Comment on attachment 40287 vprintf patch third attempt Clearing flags on attachment: 40287 Committed r48878: <http://trac.webkit.org/changeset/48878> 150936 6 commit-queue 2009-09-29 09:10:45 -0700 All reviewed patches have been landed. Closing bug. 40236 2009-09-28 08:32:33 -0700 2009-09-29 00:37:00 -0700 vprintf patch assertions.diff text/plain 1115 koshuin ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBmNmE2NDRhLi44OTRmZjlhIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMDktMDktMjggIEphbm5lIEtvc2tpbmVuICA8amFubmUucC5rb3NraW5lbkBkaWdpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBBc3NlcnQgbWVzc2FnZXMgcHJpbnRzIHZpc2libGUgaW4gU3ltYmlhbgorCisgICAgICAgIEFz c2VydHMgdXNlIHZwcmludGYgdG8gcHJpbnQgdGhlIG1lc3NhZ2VzIHRvIHN0ZGVyci4KKyAgICAg ICAgSW4gU3ltYmlhbiBPcGVuIEMgaXQgaXMgbm90IHBvc3NpYmxlIHRvIHNlZSBzdGRlcnIgc28K KyAgICAgICAgSSByb3V0ZWQgdGhlIG1lc3NhZ2VzIHRvIHN0ZG91dCBpbnN0ZWFkLgorCisgICAg ICAgICogd3RmL0Fzc2VydGlvbnMuY3BwOgorCiAyMDA5LTA5LTI4ICBKb2VyZyBCb3JuZW1hbm4g IDxqb2VyZy5ib3JuZW1hbm5Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9u IEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuY3Bw IGIvSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuY3BwCmluZGV4IDgxOWVkOWEuLmE1MTU3 MGUgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9Bc3NlcnRpb25zLmNwcAorKysgYi9K YXZhU2NyaXB0Q29yZS93dGYvQXNzZXJ0aW9ucy5jcHAKQEAgLTEwNSw3ICsxMDUsMTEgQEAgc3Rh dGljIHZvaWQgdnByaW50Zl9zdGRlcnJfY29tbW9uKGNvbnN0IGNoYXIqIGZvcm1hdCwgdmFfbGlz dCBhcmdzKQogICAgICAgICB9IHdoaWxlIChzaXplID4gMTAyNCk7CiAgICAgfQogI2VuZGlmCisj aWZkZWYgUExBVEZPUk0oU1lNQklBTikKKyAgICB2ZnByaW50ZihzdGRvdXQsIGZvcm1hdCwgYXJn cyk7CisjZWxzZQogICAgIHZmcHJpbnRmKHN0ZGVyciwgZm9ybWF0LCBhcmdzKTsKKyNlbmRpZgog fQogCiBXVEZfQVRUUklCVVRFX1BSSU5URigxLCAyKQo= 40286 2009-09-29 00:38:50 -0700 2009-09-29 00:39:59 -0700 vprintf patch second attempt assertions2.diff text/plain 1112 koshuin ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBmNmE2NDRhLi44OTRmZjlhIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMDktMDktMjggIEphbm5lIEtvc2tpbmVuICA8amFubmUucC5rb3NraW5lbkBkaWdpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBBc3NlcnQgbWVzc2FnZXMgcHJpbnRzIHZpc2libGUgaW4gU3ltYmlhbgorCisgICAgICAgIEFz c2VydHMgdXNlIHZwcmludGYgdG8gcHJpbnQgdGhlIG1lc3NhZ2VzIHRvIHN0ZGVyci4KKyAgICAg ICAgSW4gU3ltYmlhbiBPcGVuIEMgaXQgaXMgbm90IHBvc3NpYmxlIHRvIHNlZSBzdGRlcnIgc28K KyAgICAgICAgSSByb3V0ZWQgdGhlIG1lc3NhZ2VzIHRvIHN0ZG91dCBpbnN0ZWFkLgorCisgICAg ICAgICogd3RmL0Fzc2VydGlvbnMuY3BwOgorCiAyMDA5LTA5LTI4ICBKb2VyZyBCb3JuZW1hbm4g IDxqb2VyZy5ib3JuZW1hbm5Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9u IEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuY3Bw IGIvSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuY3BwCmluZGV4IDgxOWVkOWEuLjZjNWUy ZTMgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9Bc3NlcnRpb25zLmNwcAorKysgYi9K YXZhU2NyaXB0Q29yZS93dGYvQXNzZXJ0aW9ucy5jcHAKQEAgLTEwNSw3ICsxMDUsMTEgQEAgc3Rh dGljIHZvaWQgdnByaW50Zl9zdGRlcnJfY29tbW9uKGNvbnN0IGNoYXIqIGZvcm1hdCwgdmFfbGlz dCBhcmdzKQogICAgICAgICB9IHdoaWxlIChzaXplID4gMTAyNCk7CiAgICAgfQogI2VuZGlmCisj aWYgUExBVEZPUk0oU1lNQklBTikKKyAgICB2ZnByaW50ZihzdGRvdXQsIGZvcm1hdCwgYXJncyk7 CisjZWxzZQogICAgIHZmcHJpbnRmKHN0ZGVyciwgZm9ybWF0LCBhcmdzKTsKKyNlbmRpZgogfQog CiBXVEZfQVRUUklCVVRFX1BSSU5URigxLCAyKQo= 40287 2009-09-29 00:48:38 -0700 2009-09-29 09:10:30 -0700 vprintf patch third attempt assertions3.diff text/plain 1167 koshuin ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBmNmE2NDRhLi5lY2RlNTFmIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMDktMDktMjggIEphbm5lIEtvc2tpbmVuICA8amFubmUucC5rb3NraW5lbkBkaWdpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBBc3NlcnQgbWVzc2FnZXMgcHJpbnRzIHZpc2libGUgaW4gU3ltYmlhbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk4MDgKKworICAgICAgICBBc3Nl cnRzIHVzZSB2cHJpbnRmIHRvIHByaW50IHRoZSBtZXNzYWdlcyB0byBzdGRlcnIuCisgICAgICAg IEluIFN5bWJpYW4gT3BlbiBDIGl0IGlzIG5vdCBwb3NzaWJsZSB0byBzZWUgc3RkZXJyIHNvCisg ICAgICAgIEkgcm91dGVkIHRoZSBtZXNzYWdlcyB0byBzdGRvdXQgaW5zdGVhZC4KKworICAgICAg ICAqIHd0Zi9Bc3NlcnRpb25zLmNwcDoKKwogMjAwOS0wOS0yOCAgSm9lcmcgQm9ybmVtYW5uICA8 am9lcmcuYm9ybmVtYW5uQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBI YXVzbWFubi4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9Bc3NlcnRpb25zLmNwcCBi L0phdmFTY3JpcHRDb3JlL3d0Zi9Bc3NlcnRpb25zLmNwcAppbmRleCA4MTllZDlhLi42YzVlMmUz IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvQXNzZXJ0aW9ucy5jcHAKKysrIGIvSmF2 YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuY3BwCkBAIC0xMDUsNyArMTA1LDExIEBAIHN0YXRp YyB2b2lkIHZwcmludGZfc3RkZXJyX2NvbW1vbihjb25zdCBjaGFyKiBmb3JtYXQsIHZhX2xpc3Qg YXJncykKICAgICAgICAgfSB3aGlsZSAoc2l6ZSA+IDEwMjQpOwogICAgIH0KICNlbmRpZgorI2lm IFBMQVRGT1JNKFNZTUJJQU4pCisgICAgdmZwcmludGYoc3Rkb3V0LCBmb3JtYXQsIGFyZ3MpOwor I2Vsc2UKICAgICB2ZnByaW50ZihzdGRlcnIsIGZvcm1hdCwgYXJncyk7CisjZW5kaWYKIH0KIAog V1RGX0FUVFJJQlVURV9QUklOVEYoMSwgMikK