29743 2009-09-25 11:29:08 -0700 Add a sqlite3_io_methods finder to Chromium's POSIX VFS 2009-09-28 16:33:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 dumi webkit-unassigned andersca aroben beidson commit-queue dglazkov eric michaeln oldest_to_newest 150084 0 dumi 2009-09-25 11:29:08 -0700 The code that registers Chromium's POSIX VFS has a bug: it doesn't specify a sqlite3_io_methods finder. This can result in a crash. 150088 1 40128 dumi 2009-09-25 11:37:52 -0700 Created attachment 40128 patch Please do NOT commit-queue+ this patch. 150096 2 40128 dglazkov 2009-09-25 12:08:22 -0700 Comment on attachment 40128 patch r=me. 150218 3 40157 dumi 2009-09-25 18:17:58 -0700 Created attachment 40157 patch Same patch, but without requiring a change to the SQLite code. Please DO commit-queue+ this patch when you r+ it. 150240 4 40157 dglazkov 2009-09-25 20:33:04 -0700 Comment on attachment 40157 patch even better! r=me. 150245 5 40157 commit-queue 2009-09-25 22:10:24 -0700 Comment on attachment 40157 patch Rejecting patch 40157 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11332 test cases. http/tests/xmlhttprequest/cross-origin-authorization.html -> failed Exiting early after 1 failures. 8966 tests run. 247.85s total testing time 8965 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output 150267 6 40157 eric 2009-09-26 01:26:19 -0700 Comment on attachment 40157 patch Flakey test. Bug 29322. 150296 7 40157 commit-queue 2009-09-26 07:52:36 -0700 Comment on attachment 40157 patch Rejecting patch 40157 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11332 test cases. http/tests/xmlhttprequest/cross-origin-authorization.html -> failed Exiting early after 1 failures. 8966 tests run. 251.00s total testing time 8965 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output 150297 8 40157 dglazkov 2009-09-26 07:56:13 -0700 Comment on attachment 40157 patch Let's spin again. 150311 9 eric 2009-09-26 11:03:02 -0700 That's bug 29322. I have a patch up for review to skip the test due to these types of failures. :( 150322 10 eric 2009-09-26 11:38:38 -0700 The commit-queue got stuck on this patch because of a programming error (calling error() instead of using ScriptError to return the failure). It will shortly be rejecting this patch due to an extra character before the date line in the WebCore ChangeLog. The extra '[' will need to be removed for someone to land this. (Or an updated patch can be posted and the commit-queue can land it.) 150325 11 40157 commit-queue 2009-09-26 11:47:30 -0700 Comment on attachment 40157 patch Rejecting patch 40157 from commit-queue. Failed to parse ChangeLog: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog 150440 12 40209 dumi 2009-09-27 18:20:24 -0700 Created attachment 40209 patch Remove the '[' in WebCore/ChangeLog. Sorry about that typo... 150610 13 40209 dumi 2009-09-28 12:52:53 -0700 Comment on attachment 40209 patch Testing the ability to post "reviews" for a patch. Please ignore. 150681 14 40209 dglazkov 2009-09-28 15:19:29 -0700 Comment on attachment 40209 patch one more time. 150704 15 40209 commit-queue 2009-09-28 16:18:22 -0700 Comment on attachment 40209 patch Rejecting patch 40209 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11339 test cases. fast/workers/dedicated-worker-lifecycle.html -> failed Exiting early after 1 failures. 8221 tests run. 172.19s total testing time 8220 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 4 test cases (<1%) had stderr output 150706 16 40209 eric 2009-09-28 16:19:51 -0700 Comment on attachment 40209 patch We're having no luck here. Now you hit bug 29344! Damn flakey tests! 150711 17 40209 commit-queue 2009-09-28 16:33:32 -0700 Comment on attachment 40209 patch Clearing flags on attachment: 40209 Committed r48845: <http://trac.webkit.org/changeset/48845> 150712 18 commit-queue 2009-09-28 16:33:37 -0700 All reviewed patches have been landed. Closing bug. 40128 2009-09-25 11:37:52 -0700 2009-09-25 18:17:58 -0700 patch patch text/plain 1625 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODc2MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDktMjUgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZWdpc3RlciBDaHJvbWl1bSdzIFBPU0lYIFZGUyB3aXRoIGEgcHJvcGVyIHNxbGl0ZTNfaW9f bWV0aG9kcworICAgICAgICBmaW5kZXIuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI5NzQzCisKKyAgICAgICAgKiBwbGF0Zm9ybS9zcWwvY2hyb21p dW0vU1FMaXRlRmlsZVN5c3RlbUNocm9taXVtUG9zaXguY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U1FMaXRlRmlsZVN5c3RlbTo6cmVnaXN0ZXJTUUxpdGVWRlMpOgorCiAyMDA5LTA5LTI1ICBZdWFu IFNvbmcgIDxzb25nLnl1YW5AZXJpY3Nzb24uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9zcWwvY2hyb21pdW0vU1FMaXRlRmls ZVN5c3RlbUNocm9taXVtUG9zaXguY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0v c3FsL2Nocm9taXVtL1NRTGl0ZUZpbGVTeXN0ZW1DaHJvbWl1bVBvc2l4LmNwcAkocmV2aXNpb24g NDg3NjEpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3NxbC9jaHJvbWl1bS9TUUxpdGVGaWxlU3lzdGVt Q2hyb21pdW1Qb3NpeC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyLDggKzQyLDEwIEBAIHVzaW5n IG5hbWVzcGFjZSBXZWJDb3JlOwogCiAvLyBEZWZpbmVkIGluIENocm9taXVtJ3MgY29kZWJhc2Ug aW4gdGhpcmRfcGFydHkvc3FsaXRlL3NyYy9vc191bml4LmMKIGV4dGVybiAiQyIgeworc3RydWN0 IHVuaXhGaWxlOwogdm9pZCBpbml0VW5peEZpbGUoc3FsaXRlM19maWxlKiBmaWxlKTsKIGludCBm aWxsSW5Vbml4RmlsZShzcWxpdGUzX3ZmcyogdmZzLCBpbnQgZmQsIGludCBkaXJmZCwgc3FsaXRl M19maWxlKiBmaWxlLCBjb25zdCBjaGFyKiBmaWxlTmFtZSwgaW50IG5vTG9jayk7CitzcWxpdGUz X2lvX21ldGhvZHMqIHBvc2l4SW9GaW5kZXIoY29uc3QgY2hhciAqZmlsZVBhdGgsIHVuaXhGaWxl ICp1bml4RmlsZSk7CiB9CiAKIC8vIENocm9taXVtJ3MgUG9zaXggaW1wbGVtZW50YXRpb24gb2Yg U1FMaXRlIFZGUwpAQCAtMTcwLDcgKzE3Miw3IEBAIHZvaWQgU1FMaXRlRmlsZVN5c3RlbTo6cmVn aXN0ZXJTUUxpdGVWRlMKICAgICAgICAgdW5peF92ZnMtPm14UGF0aG5hbWUsCiAgICAgICAgIDAs CiAgICAgICAgICJjaHJvbWl1bV92ZnMiLAotICAgICAgICAwLAorICAgICAgICAodm9pZCopJnBv c2l4SW9GaW5kZXIsCiAgICAgICAgIGNocm9taXVtT3BlbiwKICAgICAgICAgY2hyb21pdW1EZWxl dGUsCiAgICAgICAgIGNocm9taXVtQWNjZXNzLAo= 40157 2009-09-25 18:17:58 -0700 2009-09-27 18:20:24 -0700 patch patch text/plain 2052 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODc2MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKK1syMDA5LTA5LTI1ICBEdW1pdHJ1IERhbmlsaXVjICA8ZHVtaUBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVnaXN0ZXIgQ2hyb21pdW0ncyBWRlNzIHdpdGggYSBwcm9wZXIgc3FsaXRlM19pb19tZXRo b2RzCisgICAgICAgIGZpbmRlci4gVGhpcyBzaG91bGQgb25seSBhZmZlY3QgdGhlIFBPU0lYIGlt cGxlbWVudGF0aW9uLiBUaGUKKyAgICAgICAgV2luZG93cyBjaGFuZ2UgaXMgaW5jbHVkZWQgZm9y IGNvbnNpc3RlbmN5IGFuZCBpbiBjYXNlIHNxbGl0ZQorICAgICAgICBzdGFydHMgdXNpbmcgc29t ZXRoaW5nIHNpbWlsYXIgaW4gaXRzIFdpbmRvd3MgVkZTIGluIHRoZSBmdXR1cmUuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5NzQzCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9zcWwvY2hyb21pdW0vU1FMaXRlRmlsZVN5c3RlbUNocm9taXVtUG9zaXgu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U1FMaXRlRmlsZVN5c3RlbTo6cmVnaXN0ZXJTUUxpdGVW RlMpOgorICAgICAgICAqIHBsYXRmb3JtL3NxbC9jaHJvbWl1bS9TUUxpdGVGaWxlU3lzdGVtQ2hy b21pdW1XaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1FMaXRlRmlsZVN5c3RlbTo6cmVnaXN0 ZXJTUUxpdGVWRlMpOgorCiAyMDA5LTA5LTI1ICBZdWFuIFNvbmcgIDxzb25nLnl1YW5AZXJpY3Nz b24uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29y ZS9wbGF0Zm9ybS9zcWwvY2hyb21pdW0vU1FMaXRlRmlsZVN5c3RlbUNocm9taXVtUG9zaXguY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vc3FsL2Nocm9taXVtL1NRTGl0ZUZpbGVT eXN0ZW1DaHJvbWl1bVBvc2l4LmNwcAkocmV2aXNpb24gNDg3NjEpCisrKyBXZWJDb3JlL3BsYXRm b3JtL3NxbC9jaHJvbWl1bS9TUUxpdGVGaWxlU3lzdGVtQ2hyb21pdW1Qb3NpeC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE3MCw3ICsxNzAsNyBAQCB2b2lkIFNRTGl0ZUZpbGVTeXN0ZW06OnJlZ2lz dGVyU1FMaXRlVkZTCiAgICAgICAgIHVuaXhfdmZzLT5teFBhdGhuYW1lLAogICAgICAgICAwLAog ICAgICAgICAiY2hyb21pdW1fdmZzIiwKLSAgICAgICAgMCwKKyAgICAgICAgdW5peF92ZnMtPnBB cHBEYXRhLAogICAgICAgICBjaHJvbWl1bU9wZW4sCiAgICAgICAgIGNocm9taXVtRGVsZXRlLAog ICAgICAgICBjaHJvbWl1bUFjY2VzcywKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vc3FsL2Nocm9t aXVtL1NRTGl0ZUZpbGVTeXN0ZW1DaHJvbWl1bVdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wbGF0Zm9ybS9zcWwvY2hyb21pdW0vU1FMaXRlRmlsZVN5c3RlbUNocm9taXVtV2luLmNwcAko cmV2aXNpb24gNDg3NjEpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3NxbC9jaHJvbWl1bS9TUUxpdGVG aWxlU3lzdGVtQ2hyb21pdW1XaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTUsNyArMTU1LDcg QEAgdm9pZCBTUUxpdGVGaWxlU3lzdGVtOjpyZWdpc3RlclNRTGl0ZVZGUwogICAgICAgICB3aW4z Ml92ZnMtPm14UGF0aG5hbWUsCiAgICAgICAgIDAsCiAgICAgICAgICJjaHJvbWl1bV92ZnMiLAot ICAgICAgICAwLAorICAgICAgICB3aW4zMl92ZnMtPnBBcHBEYXRhLAogICAgICAgICBjaHJvbWl1 bU9wZW4sCiAgICAgICAgIGNocm9taXVtRGVsZXRlLAogICAgICAgICBjaHJvbWl1bUFjY2VzcywK 40209 2009-09-27 18:20:24 -0700 2009-09-28 16:33:31 -0700 patch patch text/plain 2051 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODc2MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDktMjUgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZWdpc3RlciBDaHJvbWl1bSdzIFZGU3Mgd2l0aCBhIHByb3BlciBzcWxpdGUzX2lvX21ldGhv ZHMKKyAgICAgICAgZmluZGVyLiBUaGlzIHNob3VsZCBvbmx5IGFmZmVjdCB0aGUgUE9TSVggaW1w bGVtZW50YXRpb24uIFRoZQorICAgICAgICBXaW5kb3dzIGNoYW5nZSBpcyBpbmNsdWRlZCBmb3Ig Y29uc2lzdGVuY3kgYW5kIGluIGNhc2Ugc3FsaXRlCisgICAgICAgIHN0YXJ0cyB1c2luZyBzb21l dGhpbmcgc2ltaWxhciBpbiBpdHMgV2luZG93cyBWRlMgaW4gdGhlIGZ1dHVyZS4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk3NDMKKworICAgICAg ICAqIHBsYXRmb3JtL3NxbC9jaHJvbWl1bS9TUUxpdGVGaWxlU3lzdGVtQ2hyb21pdW1Qb3NpeC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTUUxpdGVGaWxlU3lzdGVtOjpyZWdpc3RlclNRTGl0ZVZG Uyk6CisgICAgICAgICogcGxhdGZvcm0vc3FsL2Nocm9taXVtL1NRTGl0ZUZpbGVTeXN0ZW1DaHJv bWl1bVdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTUUxpdGVGaWxlU3lzdGVtOjpyZWdpc3Rl clNRTGl0ZVZGUyk6CisKIDIwMDktMDktMjUgIFl1YW4gU29uZyAgPHNvbmcueXVhbkBlcmljc3Nv bi5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3Jl L3BsYXRmb3JtL3NxbC9jaHJvbWl1bS9TUUxpdGVGaWxlU3lzdGVtQ2hyb21pdW1Qb3NpeC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9zcWwvY2hyb21pdW0vU1FMaXRlRmlsZVN5 c3RlbUNocm9taXVtUG9zaXguY3BwCShyZXZpc2lvbiA0ODc2MSkKKysrIFdlYkNvcmUvcGxhdGZv cm0vc3FsL2Nocm9taXVtL1NRTGl0ZUZpbGVTeXN0ZW1DaHJvbWl1bVBvc2l4LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTcwLDcgKzE3MCw3IEBAIHZvaWQgU1FMaXRlRmlsZVN5c3RlbTo6cmVnaXN0 ZXJTUUxpdGVWRlMKICAgICAgICAgdW5peF92ZnMtPm14UGF0aG5hbWUsCiAgICAgICAgIDAsCiAg ICAgICAgICJjaHJvbWl1bV92ZnMiLAotICAgICAgICAwLAorICAgICAgICB1bml4X3Zmcy0+cEFw cERhdGEsCiAgICAgICAgIGNocm9taXVtT3BlbiwKICAgICAgICAgY2hyb21pdW1EZWxldGUsCiAg ICAgICAgIGNocm9taXVtQWNjZXNzLApJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9zcWwvY2hyb21p dW0vU1FMaXRlRmlsZVN5c3RlbUNocm9taXVtV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3BsYXRmb3JtL3NxbC9jaHJvbWl1bS9TUUxpdGVGaWxlU3lzdGVtQ2hyb21pdW1XaW4uY3BwCShy ZXZpc2lvbiA0ODc2MSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vc3FsL2Nocm9taXVtL1NRTGl0ZUZp bGVTeXN0ZW1DaHJvbWl1bVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1NSw3ICsxNTUsNyBA QCB2b2lkIFNRTGl0ZUZpbGVTeXN0ZW06OnJlZ2lzdGVyU1FMaXRlVkZTCiAgICAgICAgIHdpbjMy X3Zmcy0+bXhQYXRobmFtZSwKICAgICAgICAgMCwKICAgICAgICAgImNocm9taXVtX3ZmcyIsCi0g ICAgICAgIDAsCisgICAgICAgIHdpbjMyX3Zmcy0+cEFwcERhdGEsCiAgICAgICAgIGNocm9taXVt T3BlbiwKICAgICAgICAgY2hyb21pdW1EZWxldGUsCiAgICAgICAgIGNocm9taXVtQWNjZXNzLAo=