<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>29509</bug_id>
          
          <creation_ts>2009-09-18 15:12:00 -0700</creation_ts>
          <short_desc>svn-create-patch or check-webkit-style should warn about tabs</short_desc>
          <delta_ts>2009-12-16 12:17:23 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>32538</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>148413</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-09-18 15:12:00 -0700</bug_when>
    <thetext>svn-create-patch or check-webkit-style should warn about tabs

Right now we only find out about tabs in files/ChangeLogs until commit time.  This means reviewers have to manually reject patches due to tabs, or the commit-queue ends up rejecting them later.  We need a tighter feedback loop for contributers.  This is a common problem for new contributers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>168561</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-12-03 15:11:27 -0800</bug_when>
    <thetext>This is extra annoying now that we have the style-queue which should be catching this type of thing:
https://bugs.webkit.org/show_bug.cgi?id=32100#c5</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>168563</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-12-03 15:11:35 -0800</bug_when>
    <thetext>*** Bug 32039 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>172461</commentid>
    <comment_count>3</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-12-16 12:17:23 -0800</bug_when>
    <thetext>Resolving as a dup of a later bug since that other bug has the patch with a fix for svn-create-patch or check-webkit-style should warn about tabs and that seems like a good place for this.

*** This bug has been marked as a duplicate of bug 32538 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>