29345 2009-09-17 13:41:51 -0700 The test tst_QWebFrame::popupFocus() depends on the computer's speed 2009-09-19 11:22:39 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 0 benjamin webkit-unassigned commit-queue tonikitoo oldest_to_newest 147927 0 benjamin 2009-09-17 13:41:51 -0700 The test tst_QWebFrame::popupFocus() fails on slow computers because the focus is not yet set when the value is tested. QTRY_COMPARE should be used instead of QCOMPARE when the event loop is involved. 147932 1 39722 benjamin 2009-09-17 13:52:19 -0700 Created attachment 39722 proposed patch 148485 2 39722 hausmann 2009-09-19 04:04:01 -0700 Comment on attachment 39722 proposed patch r=me 148514 3 39722 commit-queue 2009-09-19 11:08:10 -0700 Comment on attachment 39722 proposed patch Rejecting patch 39722 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11284 test cases. http/tests/xmlhttprequest/cross-origin-no-authorization.html -> failed Exiting early after 1 failures. 8923 tests run. 255.73s total testing time 8922 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output 148517 4 39722 eric 2009-09-19 11:11:50 -0700 Comment on attachment 39722 proposed patch I believe that's just a flakey test. bug 29322. Sorry for the slow feedback, the commit-queue was paused for the last 17 hours due to red builders. http://webkit-commit-queue.appspot.com/ 148521 5 39722 commit-queue 2009-09-19 11:22:35 -0700 Comment on attachment 39722 proposed patch Clearing flags on attachment: 39722 Committed r48561: <http://trac.webkit.org/changeset/48561> 148522 6 commit-queue 2009-09-19 11:22:39 -0700 All reviewed patches have been landed. Closing bug. 39722 2009-09-17 13:52:19 -0700 2009-09-19 11:22:35 -0700 proposed patch fix_qwebframe_test.patch text/plain 4874 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDk0YTVhYTIuLjM3NDhjNWMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDA5LTA5LTE3ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI5MzQ1CisgICAgICAgIFRoZSB0ZXN0cyBvZiBRV2ViRnJhbWUg ZGlkIG5vdCB1c2UgUVRSWV9WRVJJRlkgZm9yCisgICAgICAgIHRlc3RzIGludm9sdmluZyB0aGUg ZXZlbnQgbG9vcC4KKworICAgICAgICAqIHRlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNw cDoKKyAgICAgICAgKiB0ZXN0cy91dGlsLmg6IEFkZGVkLiBDb3B5IG9mIHRlc3RzL3NoYXJlZC91 dGlsLmggb2YgUXQKKwogMjAwOS0wOS0xNCAgSmFrdWIgV2llY3pvcmVrICA8ZmF3MjE3QGdtYWls LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBh L1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAgYi9XZWJLaXQvcXQv dGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCmluZGV4IDU2MTA4N2YuLjcyOWI5NzEg MTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAK KysrIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcApAQCAtMzQs NiArMzQsNyBAQAogI2luY2x1ZGUgPFFOZXR3b3JrUmVxdWVzdD4KICNpbmNsdWRlIDxRTmV0d29y a1JlcGx5PgogI2luY2x1ZGUgPHFzc2xlcnJvci5oPgorI2luY2x1ZGUgIi4uL3V0aWwuaCIKIAog Ly9URVNURURfQ0xBU1M9CiAvL1RFU1RFRF9GSUxFUz0KQEAgLTI0NDYsMjMgKzI0NDcsMTcgQEAg dm9pZCB0c3RfUVdlYkZyYW1lOjpwb3B1cEZvY3VzKCkKICAgICB2aWV3LnJlc2l6ZSg0MDAsIDEw MCk7CiAgICAgdmlldy5zaG93KCk7CiAgICAgdmlldy5zZXRGb2N1cygpOwotICAgIFFUZXN0Ojpx V2FpdCgyMDApOwotICAgIFFWRVJJRlkyKHZpZXcuaGFzRm9jdXMoKSwKLSAgICAgICAgICAgICAi VGhlIFdlYlZpZXcgc2hvdWxkIGJlIGNyZWF0ZWQiKTsKKyAgICBRVFJZX1ZFUklGWSh2aWV3Lmhh c0ZvY3VzKCkpOwogCiAgICAgLy8gb3BlbiB0aGUgcG9wdXAgYnkgY2xpY2tpbmcuIGNoZWNrIGlm IGZvY3VzIGlzIG9uIHRoZSBwb3B1cAogICAgIFFUZXN0Ojptb3VzZUNsaWNrKCZ2aWV3LCBRdDo6 TGVmdEJ1dHRvbiwgMCwgUVBvaW50KDI1LCAyNSkpOwogICAgIFFPYmplY3QqIHdlYnBvcHVwID0g Zmlyc3RDaGlsZEJ5Q2xhc3NOYW1lKCZ2aWV3LCAiV2ViQ29yZTo6UVdlYlBvcHVwIik7CiAgICAg UUNvbWJvQm94KiBjb21ibyA9IHFvYmplY3RfY2FzdDxRQ29tYm9Cb3gqPih3ZWJwb3B1cCk7Ci0g ICAgUVRlc3Q6OnFXYWl0KDUwMCk7Ci0gICAgUVZFUklGWTIoIXZpZXcuaGFzRm9jdXMoKSAmJiBj b21iby0+dmlldygpLT5oYXNGb2N1cygpLAotICAgICAgICAgICAgICJGb2N1cyBzb3VsZCBiZSBv biB0aGUgUG9wdXAiKTsKKyAgICBRVFJZX1ZFUklGWSghdmlldy5oYXNGb2N1cygpICYmIGNvbWJv LT52aWV3KCktPmhhc0ZvY3VzKCkpOyAvLyBGb2N1cyBzaG91bGQgYmUgb24gdGhlIHBvcHVwCiAK ICAgICAvLyBoaWRlIHRoZSBwb3B1cCBhbmQgY2hlY2sgaWYgZm9jdXMgaXMgb24gdGhlIHBhZ2UK ICAgICBjb21iby0+aGlkZVBvcHVwKCk7Ci0gICAgUVRlc3Q6OnFXYWl0KDUwMCk7Ci0gICAgUVZF UklGWTIodmlldy5oYXNGb2N1cygpICYmICFjb21iby0+dmlldygpLT5oYXNGb2N1cygpLAotICAg ICAgICAgICAgICJGb2N1cyBzb3VsZCBiZSBiYWNrIG9uIHRoZSBXZWJWaWV3Iik7CisgICAgUVRS WV9WRVJJRlkodmlldy5oYXNGb2N1cygpICYmICFjb21iby0+dmlldygpLT5oYXNGb2N1cygpKTsg Ly8gRm9jdXMgc2hvdWxkIGJlIGJhY2sgb24gdGhlIFdlYlZpZXcKIAogICAgIC8vIHRyaXBsZSB0 aGUgZmxhc2hpbmcgdGltZSwgc2hvdWxkIGF0IGxlYXN0IGJsaW5rIHR3aWNlIGFscmVhZHkKICAg ICBpbnQgZGVsYXkgPSBxQXBwLT5jdXJzb3JGbGFzaFRpbWUoKSAqIDM7CkBAIC0yNjMwLDE2ICsy NjI1LDE2IEBAIHZvaWQgdHN0X1FXZWJGcmFtZTo6aGFzU2V0Rm9jdXMoKQogICAgIFFDT01QQVJF KGxvYWRTcHkuc2l6ZSgpLCAyKTsKIAogICAgIG1fcGFnZS0+bWFpbkZyYW1lKCktPnNldEZvY3Vz KCk7Ci0gICAgUVZFUklGWShtX3BhZ2UtPm1haW5GcmFtZSgpLT5oYXNGb2N1cygpKTsKKyAgICBR VFJZX1ZFUklGWShtX3BhZ2UtPm1haW5GcmFtZSgpLT5oYXNGb2N1cygpKTsKIAogICAgIGZvciAo aW50IGkgPSAwOyBpIDwgY2hpbGRyZW4uc2l6ZSgpOyArK2kpIHsKICAgICAgICAgY2hpbGRyZW4u YXQoaSktPnNldEZvY3VzKCk7Ci0gICAgICAgIFFWRVJJRlkoY2hpbGRyZW4uYXQoaSktPmhhc0Zv Y3VzKCkpOworICAgICAgICBRVFJZX1ZFUklGWShjaGlsZHJlbi5hdChpKS0+aGFzRm9jdXMoKSk7 CiAgICAgICAgIFFWRVJJRlkoIW1fcGFnZS0+bWFpbkZyYW1lKCktPmhhc0ZvY3VzKCkpOwogICAg IH0KIAogICAgIG1fcGFnZS0+bWFpbkZyYW1lKCktPnNldEZvY3VzKCk7Ci0gICAgUVZFUklGWSht X3BhZ2UtPm1haW5GcmFtZSgpLT5oYXNGb2N1cygpKTsKKyAgICBRVFJZX1ZFUklGWShtX3BhZ2Ut Pm1haW5GcmFtZSgpLT5oYXNGb2N1cygpKTsKIH0KIAogdm9pZCB0c3RfUVdlYkZyYW1lOjpyZW5k ZXIoKQpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L3Rlc3RzL3V0aWwuaCBiL1dlYktpdC9xdC90ZXN0 cy91dGlsLmgKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uN2Y3ZTYxMwotLS0g L2Rldi9udWxsCisrKyBiL1dlYktpdC9xdC90ZXN0cy91dGlsLmgKQEAgLTAsMCArMSw0OCBAQAor LyoKKyAgICBDb3B5cmlnaHQgKEMpIDIwMDkgTm9raWEgQ29ycG9yYXRpb24gYW5kL29yIGl0cyBz dWJzaWRpYXJ5KC1pZXMpCisKKyAgICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91 IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgICAgbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJt cyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKKyAgICBMaWNlbnNlIGFzIHB1Ymxp c2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAgICB2ZXJzaW9u IDIgb2YgdGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24u CisKKyAgICBUaGlzIGxpYnJhcnkgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3 aWxsIGJlIHVzZWZ1bCwKKyAgICBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZl biB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorICAgIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNT IEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCisgICAgTGlicmFyeSBHZW5l cmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisKKyAgICBZb3Ugc2hvdWxkIGhh dmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNl bnNlCisgICAgYWxvbmcgd2l0aCB0aGlzIGxpYnJhcnk7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJ Qi4gIElmIG5vdCwgd3JpdGUgdG8KKyAgICB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJ bmMuLCA1MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRoIEZsb29yLAorICAgIEJvc3RvbiwgTUEgMDIx MTAtMTMwMSwgVVNBLgorKi8KKy8vIEZ1bmN0aW9ucyBhbmQgbWFjcm9zIHRoYXQgcmVhbGx5IG5l ZWQgdG8gYmUgaW4gUVRlc3RMaWIKKworLy8gV2lsbCB0cnkgdG8gd2FpdCBmb3IgdGhlIGNvbmRp dGlvbiB3aGlsZSBhbGxvd2luZyBldmVudCBwcm9jZXNzaW5nCisjZGVmaW5lIFFUUllfVkVSSUZZ KF9fZXhwcikgXAorICAgIGRvIHsgXAorICAgICAgICBjb25zdCBpbnQgX19zdGVwID0gNTA7IFwK KyAgICAgICAgY29uc3QgaW50IF9fdGltZW91dCA9IDUwMDA7IFwKKyAgICAgICAgaWYgKCEoX19l eHByKSkgeyBcCisgICAgICAgICAgICBRVGVzdDo6cVdhaXQoMCk7IFwKKyAgICAgICAgfSBcCisg ICAgICAgIGZvciAoaW50IF9faSA9IDA7IF9faSA8IF9fdGltZW91dCAmJiAhKF9fZXhwcik7IF9f aSs9X19zdGVwKSB7IFwKKyAgICAgICAgICAgIFFUZXN0OjpxV2FpdChfX3N0ZXApOyBcCisgICAg ICAgIH0gXAorICAgICAgICBRVkVSSUZZKF9fZXhwcik7IFwKKyAgICB9IHdoaWxlKDApCisKKy8v IFdpbGwgdHJ5IHRvIHdhaXQgZm9yIHRoZSBjb25kaXRpb24gd2hpbGUgYWxsb3dpbmcgZXZlbnQg cHJvY2Vzc2luZworI2RlZmluZSBRVFJZX0NPTVBBUkUoX19leHByLCBfX2V4cGVjdGVkKSBcCisg ICAgZG8geyBcCisgICAgICAgIGNvbnN0IGludCBfX3N0ZXAgPSA1MDsgXAorICAgICAgICBjb25z dCBpbnQgX190aW1lb3V0ID0gNTAwMDsgXAorICAgICAgICBpZiAoKF9fZXhwcikgIT0gKF9fZXhw ZWN0ZWQpKSB7IFwKKyAgICAgICAgICAgIFFUZXN0OjpxV2FpdCgwKTsgXAorICAgICAgICB9IFwK KyAgICAgICAgZm9yIChpbnQgX19pID0gMDsgX19pIDwgX190aW1lb3V0ICYmICgoX19leHByKSAh PSAoX19leHBlY3RlZCkpOyBfX2krPV9fc3RlcCkgeyBcCisgICAgICAgICAgICBRVGVzdDo6cVdh aXQoX19zdGVwKTsgXAorICAgICAgICB9IFwKKyAgICAgICAgUUNPTVBBUkUoX19leHByLCBfX2V4 cGVjdGVkKTsgXAorICAgIH0gd2hpbGUoMCkKKwo=