29186 2009-09-11 08:53:13 -0700 template specialisation error on WINSCW 2009-09-17 03:47:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) S60 Emulator S60 3rd edition RESOLVED FIXED P2 Blocker --- 27065 0 koshuin webkit-unassigned eric hausmann oldest_to_newest 146577 0 koshuin 2009-09-11 08:53:13 -0700 Compiling literalparser.cpp for WINSCW complains about "undefined identifier mode". "mode" has been defined in the template specialisation, but the prototype of the function has a diffrent variable name for it "parserMode". This is addenum for https://bugs.webkit.org/show_bug.cgi?id=28069. Even after the inlining Literalparser.cpp fails to compile with mwccsym Version 3.2.5 build 482 (Build 482). There is two ways of fixing the compiler issue. Either remove the parserMode from prototype or make the prototype to have the same name for argument as the implementation. I chose the latter as it makes it more clear that we are dealing here with template specialisation. 146582 1 39438 koshuin 2009-09-11 08:59:57 -0700 Created attachment 39438 literalparser.h patch 147088 2 eric 2009-09-14 10:10:57 -0700 I continue to be entertained by this compiler. :) I think "parserMode" is clearer than "mode" and would have changed them both to "parserMode", but this is also OK. 147777 3 39438 hausmann 2009-09-17 03:35:45 -0700 Comment on attachment 39438 literalparser.h patch Please don't mark the patch as r+ but use r? instead to ask for a review :) 147780 4 39438 hausmann 2009-09-17 03:45:53 -0700 Comment on attachment 39438 literalparser.h patch There we go, r=me. This is a really simple fix :) 147781 5 hausmann 2009-09-17 03:47:25 -0700 Landed in r48462 39438 2009-09-11 08:59:57 -0700 2009-09-17 03:45:53 -0700 literalparser.h patch literalparser.diff text/plain 1136 koshuin ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAyMjRhY2E3Li4zMGNjODcwIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEg QEAKKzIwMDktMDktMTEgIEphbm5lIEtvc2tpbmVuICA8amFubmUucC5rb3NraW5lbkBkaWdpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0lO U0NXIFRlbXBsYXRlIHNwZWNpYWxpc2F0aW9uIG5hbWUgaW4gZGVjbGFyYXRpb24gbXVzdCB0aGUg YmUgdGhlIHNhbWUgYXMgaW4gaW1wbGVtZW50YXRpb24uCisKKyAgICAgICAgKiBydW50aW1lL0xp dGVyYWxQYXJzZXIuaDoKKwogMjAwOS0wOS0wNCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoQnVpbGQgZml4KS4KZGlmZiAtLWdp dCBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTGl0ZXJhbFBhcnNlci5oIGIvSmF2YVNjcmlwdENv cmUvcnVudGltZS9MaXRlcmFsUGFyc2VyLmgKaW5kZXggYmNlZWU3Yy4uMGY4MDcyYiAxMDA2NDQK LS0tIGEvSmF2YVNjcmlwdENvcmUvcnVudGltZS9MaXRlcmFsUGFyc2VyLmgKKysrIGIvSmF2YVNj cmlwdENvcmUvcnVudGltZS9MaXRlcmFsUGFyc2VyLmgKQEAgLTg5LDcgKzg5LDcgQEAgbmFtZXNw YWNlIEpTQyB7CiAgICAgICAgICAgICAKICAgICAgICAgcHJpdmF0ZToKICAgICAgICAgICAgIFRv a2VuVHlwZSBsZXgoTGl0ZXJhbFBhcnNlclRva2VuJik7Ci0gICAgICAgICAgICB0ZW1wbGF0ZSA8 UGFyc2VyTW9kZSBwYXJzZXJNb2RlPiBUb2tlblR5cGUgbGV4U3RyaW5nKExpdGVyYWxQYXJzZXJU b2tlbiYpOworICAgICAgICAgICAgdGVtcGxhdGUgPFBhcnNlck1vZGUgbW9kZT4gVG9rZW5UeXBl IGxleFN0cmluZyhMaXRlcmFsUGFyc2VyVG9rZW4mKTsKICAgICAgICAgICAgIFRva2VuVHlwZSBs ZXhOdW1iZXIoTGl0ZXJhbFBhcnNlclRva2VuJik7CiAgICAgICAgICAgICBMaXRlcmFsUGFyc2Vy VG9rZW4gbV9jdXJyZW50VG9rZW47CiAgICAgICAgICAgICBVU3RyaW5nIG1fc3RyaW5nOwo=