29159 2009-09-10 16:25:30 -0700 Undo r47992 2009-09-11 14:52:38 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 estade webkit-unassigned commit-queue eric oldest_to_newest 146391 0 estade 2009-09-10 16:25:30 -0700 Darin F has pointed out that we should just use RenderTheme::setCustomFocusRingColor(). This patch should only be committed after http://codereview.chromium.org/195059/show. 146392 1 39391 estade 2009-09-10 16:26:23 -0700 Created attachment 39391 revert 146398 2 39391 darin 2009-09-10 16:52:12 -0700 Comment on attachment 39391 revert Rolling out a change normally doesn't require review. rs=me 146429 3 eric 2009-09-10 18:13:18 -0700 estade says this depends on some chromium change so it can't be commit-queued. 146430 4 39391 commit-queue 2009-09-10 18:17:46 -0700 Comment on attachment 39391 revert Rejecting patch 39391 from commit-queue. estade@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. 146738 5 39391 estade 2009-09-11 14:11:21 -0700 Comment on attachment 39391 revert ready for commit 146746 6 39391 commit-queue 2009-09-11 14:34:18 -0700 Comment on attachment 39391 revert Rejecting patch 39391 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 146747 7 eric 2009-09-11 14:35:46 -0700 We were bitten again by bug 28845. :( media/controls-after-reload.html -> crashed I'm working right now on making the error messages nicer. 146750 8 39391 commit-queue 2009-09-11 14:52:33 -0700 Comment on attachment 39391 revert Clearing flags on attachment: 39391 Committed r48317: <http://trac.webkit.org/changeset/48317> 146751 9 commit-queue 2009-09-11 14:52:38 -0700 All reviewed patches have been landed. Closing bug. 39391 2009-09-10 16:26:23 -0700 2009-09-11 14:52:33 -0700 revert revert.diff text/plain 2606 estade SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODI3MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDktMTAgIEV2YW4gU3RhZGUgIDxlc3RhZGVAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl dmVydCByNDc5OTI6IEV4cG9zZSBmdW5jdGlvbnMgdG8gY2hhbmdlIHRoZSBmb2N1cyByaW5nIGNv bG9yIGZvcgorICAgICAgICBMaW51eCBDaHJvbWl1bS4KKworICAgICAgICBBcyBEYXJpbiBGaXNo ZXIgaGFzIHBvaW50ZWQgb3V0LCB0aGVyZSBpcyBhIGJldHRlciB3YXkgdG8gZG8gdGhpcy4KKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTGludXguY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4OjpSZW5kZXJUaGVtZUNocm9taXVt TGludXgpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTGludXguaDoK KwogMjAwOS0wOS0xMCAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIFJ1 YmJlci1zdGFtcGVkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUaGVtZUNocm9taXVtTGludXguY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5jcHAJKHJldmlzaW9uIDQ4MjY5KQorKysgV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDQsNyArNDQsNiBAQCBQYXNzUmVmUHRyPFJlbmRlclRoZW1lPiBSZW5kZXJUaGVtZTo6dGhl CiB9CiAKIFJlbmRlclRoZW1lQ2hyb21pdW1MaW51eDo6UmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4 KCkKLSAgICA6IG1fdXNlRGVmYXVsdEZvY3VzUmluZ0NvbG9yKHRydWUpCiB7CiAgICAgbV9jYXJl dEJsaW5rSW50ZXJ2YWwgPSBSZW5kZXJUaGVtZTo6Y2FyZXRCbGlua0ludGVydmFsKCk7CiB9CkBA IC0xMDgsMTkgKzEwNyw2IEBAIHZvaWQgUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4OjphZGp1c3RT bGkKICAgICAgICAgUmVuZGVyVGhlbWVDaHJvbWl1bVNraWE6OmFkanVzdFNsaWRlclRodW1iU2l6 ZShvKTsKIH0KIAotdm9pZCBSZW5kZXJUaGVtZUNocm9taXVtTGludXg6OnNldEZvY3VzUmluZ0Nv bG9yKGNvbnN0IENvbG9yJiBjb2xvcikKLXsKLSAgICBtX2ZvY3VzUmluZ0NvbG9yID0gY29sb3I7 Ci0gICAgbV91c2VEZWZhdWx0Rm9jdXNSaW5nQ29sb3IgPSBmYWxzZTsKLX0KLQotQ29sb3IgUmVu ZGVyVGhlbWVDaHJvbWl1bUxpbnV4OjpwbGF0Zm9ybUZvY3VzUmluZ0NvbG9yKCkgY29uc3QKLXsK LSAgICBpZiAobV91c2VEZWZhdWx0Rm9jdXNSaW5nQ29sb3IpCi0gICAgICAgIHJldHVybiBSZW5k ZXJUaGVtZUNocm9taXVtU2tpYTo6cGxhdGZvcm1Gb2N1c1JpbmdDb2xvcigpOwotICAgIHJldHVy biBtX2ZvY3VzUmluZ0NvbG9yOwotfQotCiBib29sIFJlbmRlclRoZW1lQ2hyb21pdW1MaW51eDo6 c3VwcG9ydHNDb250cm9sVGludHMoKSBjb25zdAogewogICAgIHJldHVybiB0cnVlOwpJbmRleDog V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4LmgJKHJldmlzaW9u IDQ4MjY5KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4LmgJ KHdvcmtpbmcgY29weSkKQEAgLTU0LDkgKzU0LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAg ICAgICB2b2lkIHNldENhcmV0QmxpbmtJbnRlcnZhbChkb3VibGUgaW50ZXJ2YWwpOwogICAgICAg ICB2aXJ0dWFsIGRvdWJsZSBjYXJldEJsaW5rSW50ZXJ2YWxJbnRlcm5hbCgpIGNvbnN0OwogCi0g ICAgICAgIHZvaWQgc2V0Rm9jdXNSaW5nQ29sb3IoY29uc3QgQ29sb3ImKTsKLSAgICAgICAgdmly dHVhbCBDb2xvciBwbGF0Zm9ybUZvY3VzUmluZ0NvbG9yKCkgY29uc3Q7Ci0KICAgICBwcml2YXRl OgogICAgICAgICBSZW5kZXJUaGVtZUNocm9taXVtTGludXgoKTsKICAgICAgICAgdmlydHVhbCB+ UmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4KCk7CkBAIC02NSw5ICs2Miw2IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKICAgICAgICAgdmlydHVhbCBib29sIHN1cHBvcnRzQ29udHJvbFRpbnRzKCkgY29u c3Q7CiAKICAgICAgICAgZG91YmxlIG1fY2FyZXRCbGlua0ludGVydmFsOwotCi0gICAgICAgIENv bG9yIG1fZm9jdXNSaW5nQ29sb3I7Ci0gICAgICAgIGJvb2wgbV91c2VEZWZhdWx0Rm9jdXNSaW5n Q29sb3I7CiAgICAgfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=