29154 2009-09-10 14:53:36 -0700 storage/database-lock-after-reload.html is flakey 2012-09-19 13:10:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 33289 1 eric eric benm commit-queue hamaji simon.fraser oldest_to_newest 146353 0 eric 2009-09-10 14:53:36 -0700 storage/database-lock-after-reload.html is flakey It has now caused 2 commit-queue runs to fail (patches from bug 27632 and bug 29041). The failing result is: --- /tmp/layout-test-results/storage/database-lock-after-reload-expected.txt 2009-09-10 14:42:33.000000000 -0700 +++ /tmp/layout-test-results/storage/database-lock-after-reload-actual.txt 2009-09-10 14:42:33.000000000 -0700 @@ -1,3 +1,4 @@ Inserting some data +Test failed - database is locked Test part 2 Complete I've not looked through the buildbot logs yet, but I suspect that we'll find a failure of this test on them as well. 146354 1 eric 2009-09-10 14:55:06 -0700 DumpRenderTree uses its own separate database storage, right? It wouldn't be using the same storage as Safari? Also DumpRenderTree makes sure to unlock/re-init/whatever the database before running all the tests, right? 146506 2 benm 2009-09-11 02:53:40 -0700 (In reply to comment #1) > DumpRenderTree uses its own separate database storage, right? It wouldn't be > using the same storage as Safari? Yes, it should create it's databases in a separate folder to Safari. > Also DumpRenderTree makes sure to unlock/re-init/whatever the database before > running all the tests, right? There's a method on the layoutTestController to clear the databases that should reset everything but I think each test needs to invoke it during setup. database-lock-after-reload does, however. Can we tell from what point the test started to become flakey? It was checked in under r45594 about 2 months ago and as far as I know didn't cause any problems then. Cheers, Ben 148937 3 eric 2009-09-21 18:54:43 -0700 Failed again just now: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r48615%20(5210)/results.html 148939 4 eric 2009-09-21 19:09:18 -0700 Unfortunately, we're not tracking flakey tests across time like Chromium does: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html so I can't tell you when it started failing. 150221 5 eric 2009-09-25 18:46:59 -0700 It looks like sometimes it causes DumpRenderTree to crash! http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r48779%20(5418)/results.html This is even more bad news bears. :( 153082 6 eric 2009-10-07 09:40:00 -0700 Bug 30172 may be related. 180960 7 eric 2010-01-14 15:20:36 -0800 This failed on Tiger just now: http://build.webkit.org/results/Tiger%20Intel%20Release/r53291%20(7775)/storage/database-lock-after-reload-diffs.txt --- layout-test-results/storage/database-lock-after-reload-expected.txt 2010-01-14 14:58:12.000000000 -0800 +++ layout-test-results/storage/database-lock-after-reload-actual.txt 2010-01-14 14:58:12.000000000 -0800 @@ -1,3 +1 @@ -Inserting some data -Test part 2 Complete 180992 8 eric 2010-01-14 16:23:25 -0800 This just failed on Leopard Intel Release as well: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r53292%20(9385)/storage/database-lock-after-reload-diffs.txt This is vying for most-flakey test. :( 184122 9 eric 2010-01-24 17:16:52 -0800 Failed on Tiger again just now: http://build.webkit.org/results/Tiger%20Intel%20Release/r53784%20(8113)/storage/database-lock-after-reload-diffs.txt Same results a seen in comment #7 184179 10 eric 2010-01-24 23:19:56 -0800 Another failure: http://build.webkit.org/results/Tiger%20Intel%20Release/r53790%20(8118)/storage/database-lock-after-reload-diffs.txt 185578 11 eric 2010-01-28 12:33:16 -0800 Another failure: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r54007%20(9995)/storage/database-lock-after-reload-diffs.txt 185579 12 47642 eric 2010-01-28 12:40:59 -0800 Created attachment 47642 Patch 187673 13 47642 hamaji 2010-02-04 00:57:44 -0800 Comment on attachment 47642 Patch I totally agree to disable this test until Bug 34506 is closed! This flakiness is alive long time... 188237 14 eric 2010-02-05 12:02:47 -0800 Attachment 47642 was posted by a committer and has review+, assigning to Eric Seidel for commit. 188900 15 47642 commit-queue 2010-02-08 22:32:19 -0800 Comment on attachment 47642 Patch Rejecting patch 47642 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Shinichiro Hamaji', '--force']" exit_code: 1 patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/mac/Skipped Hunk #1 FAILED at 101. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej Full output: http://webkit-commit-queue.appspot.com/results/251169 188932 16 eric 2010-02-09 02:02:00 -0800 Committed r54540: <http://trac.webkit.org/changeset/54540> 723749 17 simon.fraser 2012-09-19 13:10:36 -0700 Seems to work now. Going to try unskipping. 47642 2010-01-28 12:40:59 -0800 2010-02-08 22:32:19 -0800 Patch bug-29154-20100128124058.patch text/plain 1096 eric ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ZThkZWE4Li4zNmE3OTQ3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDEt MjggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHN0b3JhZ2UvZGF0YWJhc2UtbG9jay1hZnRlci1y ZWxvYWQuaHRtbCBpcyBmbGFrZXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI5MTU0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2tpcHBlZDogU2tp cCBmb3Igbm93IHRvIGtlZXAgdGhlIGJvdHMgZ3JlZW4gdW50aWwgc29tZW9uZSBjYW4gdGFrZSBh IGxvb2suCisKIDIwMTAtMDEtMjYgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAg ICAgICAgIE5vIHJldmlldywgcm9sbGluZyBvdXQgcjUzODYxLgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tp cHBlZAppbmRleCBiZDIwYjFmLi5jOWQ2NmM0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZApA QCAtMTAxLDMgKzEwMSw3IEBAIHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2NoYW5nZS1ub3Rp ZmljYXRpb24tb24tc2Nyb2xsLmh0bWwKIAogIyBTa2lwIEdlb2xvY2F0aW9uIHVudGlsIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDAyNSBpcyBsYW5kZWQKIGZhc3Qv ZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVydGllcy1nZW9sb2NhdGlvbi5odG1sCisKKyMgRmFpbHMg aW50ZXJtaXR0ZW50bHkgb24gTGVvcGFyZCBhbmQgVGlnZXIuCisjIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTE1NAorc3RvcmFnZS9kYXRhYmFzZS1sb2NrLWFmdGVy LXJlbG9hZC5odG1sCg==