29068 2009-09-08 23:01:48 -0700 NPAPI Plugin NPP_AsFile not working on Qt Webkit 2009-09-09 02:53:30 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC S60 3rd edition RESOLVED FIXED P2 Critical --- 0 rohini.ananth webkit-unassigned hausmann oldest_to_newest 145653 0 rohini.ananth 2009-09-08 23:01:48 -0700 For NPAPI Plugins having stream transfer mode other than NP_NORMAL, a QTemporaryFile through openTemporaryFile() call in PluginStream::startstream gets created and in PluginStream::destroystream the file handle is closed before passing the file path in NPP_AsFile to plugin. By default, the property ‘autoremove’ of QTemporaryFile is true and such a setting deletes the file for closeFileHandle() itself, hence plugin does not see any created temp file. 145658 1 39247 rohini.ananth 2009-09-08 23:09:41 -0700 Created attachment 39247 Patch which solves the deletion of created temp file before passing to plugin in NPP_AsFile In the patch, in openTemporaryFile() method implemented for platform Qt in FileSystemQt.cpp, the autoremove property has been set to false.Hence closeFileHandle() just closes and does not delete the file before passing it to plugin. As last step of PluginStream::destroystream, anyways the deletion of this temp file has been taken care. 145687 2 39247 hausmann 2009-09-09 01:40:19 -0700 Comment on attachment 39247 Patch which solves the deletion of created temp file before passing to plugin in NPP_AsFile Your patch looks good in principle, thanks for tracking down this bug! > + QTemporaryFile *tempFile = new QTemporaryFile(QLatin1String(prefix)); > + tempFile->setAutoRemove(false); > + QFile *temp = tempFile; Please fix the coding style for the newly added lines, the position of the * should be next to the type, not the variable. Also please include a ChangeLog entry explaining your fix, using the same (very good btw) explanation you mentioned in this bugzilla entry. r- because of that, but otherwise ok :-) 145689 3 39255 rohini.ananth 2009-09-09 02:24:14 -0700 Created attachment 39255 Final Patch with review comments incorporated Thanks for the review Simon ! 145691 4 39255 hausmann 2009-09-09 02:53:02 -0700 Comment on attachment 39255 Final Patch with review comments incorporated r=me. You don't have to fill out the "Reviewed by" in the ChangeLog, it's okay to leave it with the "NOBODY (OOPS)" field. It will be filled out when landing. 145692 5 hausmann 2009-09-09 02:53:30 -0700 Landed in r48204 39247 2009-09-08 23:09:41 -0700 2009-09-09 01:40:18 -0700 Patch which solves the deletion of created temp file before passing to plugin in NPP_AsFile NPPAsFile_FileSystemQt.patch text/plain 730 rohini.ananth SW5kZXg6IHdlYmtpdC9XZWJDb3JlL3BsYXRmb3JtL3F0L0ZpbGVTeXN0ZW1RdC5jcHANCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0NCi0tLSB3ZWJraXQvV2ViQ29yZS9wbGF0Zm9ybS9xdC9GaWxlU3lzdGVtUXQuY3BwCShy ZXZpc2lvbiAxNzc1MykNCisrKyB3ZWJraXQvV2ViQ29yZS9wbGF0Zm9ybS9xdC9GaWxlU3lzdGVt UXQuY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtMTE3LDggKzExNywxMCBAQA0KIAogQ1N0cmluZyBv cGVuVGVtcG9yYXJ5RmlsZShjb25zdCBjaGFyKiBwcmVmaXgsIFBsYXRmb3JtRmlsZUhhbmRsZSYg aGFuZGxlKQogewotICAgIFFGaWxlICp0ZW1wID0gbmV3IFFUZW1wb3JhcnlGaWxlKFFMYXRpbjFT dHJpbmcocHJlZml4KSk7Ci0gICAgaWYgKHRlbXAtPm9wZW4oUUlPRGV2aWNlOjpSZWFkV3JpdGUp KSB7CisgICAgIFFUZW1wb3JhcnlGaWxlICp0ZW1wRmlsZSA9IG5ldyBRVGVtcG9yYXJ5RmlsZShR TGF0aW4xU3RyaW5nKHByZWZpeCkpOworICAgICB0ZW1wRmlsZS0+c2V0QXV0b1JlbW92ZShmYWxz ZSk7CisgICAgIFFGaWxlICp0ZW1wID0gdGVtcEZpbGU7CisgICAgIGlmICh0ZW1wLT5vcGVuKFFJ T0RldmljZTo6UmVhZFdyaXRlKSkgewogICAgICAgICBoYW5kbGUgPSB0ZW1wOwogICAgICAgICBy ZXR1cm4gU3RyaW5nKHRlbXAtPmZpbGVOYW1lKCkpLnV0ZjgoKTsKICAgICB9Cg== 39255 2009-09-09 02:24:14 -0700 2009-09-09 02:53:02 -0700 Final Patch with review comments incorporated NPP_AsFile_29068.patch text/plain 1468 rohini.ananth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODIwMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDktMDkgIFJvaGluaSBBbmFudGggPHJvaGluaS5hbmFudGhA bm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uCisKKyAgICAg ICAgTlBBUEkgUGx1Z2luIE5QUF9Bc0ZpbGUgbm90IHdvcmtpbmcgb24gUXQgV2Via2l0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTA2OAorCisgICAg ICAgICogcGxhdGZvcm0vcXQvRmlsZVN5c3RlbVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om9w ZW5UZW1wb3JhcnlGaWxlKQorICAgICAgICBBdXRvcmVtb3ZlIHByb3BlcnR5IG9mIFFUZW1wb3Jh cnlGaWxlIGhhcyBiZWVuIHNldCB0byBmYWxzZS4gSGVuY2UgY2xvc2VGaWxlKCkganVzdCBjbG9z ZXMgYW5kIGRvZXMgbm90IGRlbGV0ZSB0aGUgZmlsZS4KKyAgICAgICAgVGhpcyBzb2x2ZXMgdGhl IGRlbGV0aW9uIG9mIGNyZWF0ZWQgdGVtcCBmaWxlIGluIFBsdWdpblN0cmVhbTo6ZGVzdHJveVN0 cmVhbSgpIGJlZm9yZSBwYXNzaW5nIHRvIHBsdWdpbiBpbiBOUFBfQXNGaWxlLgorCiAyMDA5LTA5 LTA4ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChCdWlsZCBmaXgpLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9xdC9GaWxlU3lz dGVtUXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vcXQvRmlsZVN5c3RlbVF0 LmNwcAkocmV2aXNpb24gNDgyMDMpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3F0L0ZpbGVTeXN0ZW1R dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNyw3ICsxMTcsOSBAQAogCiBDU3RyaW5nIG9wZW5U ZW1wb3JhcnlGaWxlKGNvbnN0IGNoYXIqIHByZWZpeCwgUGxhdGZvcm1GaWxlSGFuZGxlJiBoYW5k bGUpCiB7Ci0gICAgUUZpbGUgKnRlbXAgPSBuZXcgUVRlbXBvcmFyeUZpbGUoUUxhdGluMVN0cmlu ZyhwcmVmaXgpKTsKKyAgICBRVGVtcG9yYXJ5RmlsZSogdGVtcEZpbGUgPSBuZXcgUVRlbXBvcmFy eUZpbGUoUUxhdGluMVN0cmluZyhwcmVmaXgpKTsKKyAgICB0ZW1wRmlsZS0+c2V0QXV0b1JlbW92 ZShmYWxzZSk7CisgICAgUUZpbGUqIHRlbXAgPSB0ZW1wRmlsZTsKICAgICBpZiAodGVtcC0+b3Bl bihRSU9EZXZpY2U6OlJlYWRXcml0ZSkpIHsKICAgICAgICAgaGFuZGxlID0gdGVtcDsKICAgICAg ICAgcmV0dXJuIFN0cmluZyh0ZW1wLT5maWxlTmFtZSgpKS51dGY4KCk7Cg==