29011 2009-09-07 08:11:18 -0700 Build fix when USE(LOCKFREE_THREADSAFESHARED) is not defined 2009-10-01 09:35:21 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 27065 0 laszlo.gombos webkit-unassigned ben eric koshuin oldest_to_newest 145157 0 laszlo.gombos 2009-09-07 08:11:18 -0700 Some WebKit ports (e.g. Symbian QtWebKit port) does not (yet) define atomicIncrement and atomicDecrement functions. This is a "supported" configuration and the USE(LOCKFREE_THREADSAFESHARED) is used to determine if atomicIncrement and atomicDecrement functions are available. ChangeSet http://trac.webkit.org/changeset/47845 introduced a change in Threading.h which would require to implement atomicIncrement and atomicDecrement functions for all ports. Guarding some of the changes in Threading.h with USE(LOCKFREE_THREADSAFESHARED) would fix this problem (and would fix the Symbian QtWebKit build). Patch will follow. 145160 1 39148 laszlo.gombos 2009-09-07 08:17:40 -0700 Created attachment 39148 proposed patch. 145185 2 39148 hausmann 2009-09-07 09:40:17 -0700 Comment on attachment 39148 proposed patch. r=me 145311 3 mrowe 2009-09-08 03:29:04 -0700 *** Bug 29028 has been marked as a duplicate of this bug. *** 145360 4 39148 eric 2009-09-08 08:23:45 -0700 Comment on attachment 39148 proposed patch. Exception: Unknown committer: laszlo.1.gombos@nokia.com If you're a committer, please make sure you're in LayoutTests/WebKitTools/Scripts/modules/committers.py 145382 5 39148 laszlo.gombos 2009-09-08 09:14:16 -0700 Comment on attachment 39148 proposed patch. Thanks Eric ! Added myself to list of committers -- http://trac.webkit.org/changeset/48159. Let's try the commit-queue again. 145415 6 39148 eric 2009-09-08 10:15:09 -0700 Comment on attachment 39148 proposed patch. Clearing flags on attachment: 39148 Committed r48161: <http://trac.webkit.org/changeset/48161> 145416 7 eric 2009-09-08 10:15:15 -0700 All reviewed patches have been landed. Closing bug. 146370 8 mrowe 2009-09-10 15:29:01 -0700 *** Bug 29149 has been marked as a duplicate of this bug. *** 39148 2009-09-07 08:17:40 -0700 2009-09-08 10:15:08 -0700 proposed patch. patch_29011.txt text/plain 1137 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ4MTE1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDktMDcgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1aWxkIGZpeCB3aGVuIFVTRShMT0NLRlJFRV9U SFJFQURTQUZFU0hBUkVEKSBpcyBub3QgZGVmaW5lZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjkwMTEKKworICAgICAgICAqIHd0Zi9UaHJlYWRpbmcu aDogVXNlIExPQ0tGUkVFX1RIUkVBRFNBRkVTSEFSRUQgZ3VhcmQgZm9yIAorICAgICAgICBhdG9t aWNJbmNyZW1lbnQgYW5kIGF0b21pY0RlY3JlbWVudAorCiAyMDA5LTA5LTA0ICBPbGl2ZXIgSHVu dCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChCdWls ZCBmaXgpLgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZy5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmcuaAkocmV2aXNpb24gNDgxMDApCisrKyBK YXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nLmgJKHdvcmtpbmcgY29weSkKQEAgLTMyNSw4ICsz MjUsMTEgQEAgdXNpbmcgV1RGOjpUaHJlYWRDb25kaXRpb247CiB1c2luZyBXVEY6OlRocmVhZElk ZW50aWZpZXI7CiB1c2luZyBXVEY6OlRocmVhZFNhZmVTaGFyZWQ7CiAKKyNpZiBVU0UoTE9DS0ZS RUVfVEhSRUFEU0FGRVNIQVJFRCkKIHVzaW5nIFdURjo6YXRvbWljRGVjcmVtZW50OwogdXNpbmcg V1RGOjphdG9taWNJbmNyZW1lbnQ7CisjZW5kaWYKKwogdXNpbmcgV1RGOjpjcmVhdGVUaHJlYWQ7 CiB1c2luZyBXVEY6OmN1cnJlbnRUaHJlYWQ7CiB1c2luZyBXVEY6OmlzTWFpblRocmVhZDsK