28981 2009-09-04 12:18:06 -0700 [Qt] make npapi.h compile in winscw compiler. 2009-09-08 12:21:25 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) S60 Emulator S60 3rd edition RESOLVED FIXED Qt P2 Minor --- 27065 1 yongjun.zhang webkit-unassigned eric laszlo.gombos oldest_to_newest 144890 0 yongjun.zhang 2009-09-04 12:18:06 -0700 Winscw compiler by default defines _WIN32 macro; in npapi.h, this macro assumes the target environment is Windows and it tries to include <windows.h> and other windows specific code into Symbian build, the compilation as a result fails. 144894 1 39084 yongjun.zhang 2009-09-04 12:25:33 -0700 Created attachment 39084 Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian. 145461 2 39084 eric 2009-09-08 11:12:57 -0700 Comment on attachment 39084 Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian. Rejecting patch 39084 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 145482 3 39084 eric 2009-09-08 12:11:07 -0700 Comment on attachment 39084 Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian. media/video-source-error.html -> timed out Yet another flakey media test. :( bug 28624 145490 4 39084 eric 2009-09-08 12:21:21 -0700 Comment on attachment 39084 Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian. Clearing flags on attachment: 39084 Committed r48174: <http://trac.webkit.org/changeset/48174> 145491 5 eric 2009-09-08 12:21:25 -0700 All reviewed patches have been landed. Closing bug. 39084 2009-09-04 12:25:33 -0700 2009-09-08 12:21:21 -0700 Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian. npapi.patch text/plain 1228 yongjun.zhang SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODA2OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDktMDQgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVuLnpoYW5n QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg5ODEKKworICAg ICAgICBbUXRdIG1ha2UgbnBhcGkuaCBjb21waWxlIGluIHdpbnNjdyBjb21waWxlci4KKworICAg ICAgICBBZGQgWFBfU1lNQklBTiBtYWNybyB0byBpZGVudGlmeSBTeW1iaWFuIE9TOyB0aGlzIG1h Y3JvIHNob3VsZCBiZSB1c2VkIGZvciBTeW1iaWFuCisgICAgICAgIHNwZWNpZmljIGNoYW5nZXMg aW4gbnBhcGkuaC4KKyAgICAgICAgVW5kZWZpbmUgWFBfV0lOIHdoZW4gYnVpbGRpbmcgZm9yIFN5 bWJpYW4gdG8gYXZvaWQgaW5jbHVkaW5nIFdpbmRvd3Mgc3BlY2lmaWMgY29kZS4KKworICAgICAg ICAqIGJyaWRnZS9ucGFwaS5oOgorCiAyMDA5LTA5LTA0ICBEYXZlIEh5YXR0ICA8aHlhdHRAYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBXZWJDb3Jl L2JyaWRnZS9ucGFwaS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYnJpZGdlL25wYXBpLmgJKHJl dmlzaW9uIDQ4MDQ3KQorKysgV2ViQ29yZS9icmlkZ2UvbnBhcGkuaAkod29ya2luZyBjb3B5KQpA QCAtNzEsNiArNzEsMTMgQEAKICMgICAgZW5kaWYgLyogWFBfUEMgKi8KICNlbmRpZiAvKiBfX01X RVJLU19fICovCiAKKyNpZmRlZiBfX1NZTUJJQU4zMl9fCisjICAgaWZuZGVmIFhQX1NZTUJJQU4K KyMgICAgICAgZGVmaW5lIFhQX1NZTUJJQU4gMQorIyAgICAgICB1bmRlZiBYUF9XSU4KKyMgICBl bmRpZgorI2VuZGlmICAvKiBfX1NZTUJJQU4zMl9fICovCisKICNpZiBkZWZpbmVkKF9fQVBQTEVf Q0NfXykgJiYgIWRlZmluZWQoX19NQUNPU19DTEFTU0lDX18pICYmICFkZWZpbmVkKFhQX1VOSVgp CiAjICAgZGVmaW5lIFhQX01BQ09TWAogI2VuZGlmCg==