28931 2009-09-02 18:30:55 -0700 [chromium] Linux: Expose functions to set the caret blink interval 2009-09-07 00:12:05 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 joel webkit-unassigned dglazkov eric fishd levin oldest_to_newest 144362 0 joel 2009-09-02 18:30:55 -0700 Chromium on Linux will use gtk-cursor-blink from GtkSettings for setting the blink interval. 144363 1 38959 joel 2009-09-02 18:32:26 -0700 Created attachment 38959 patch 144371 2 38962 joel 2009-09-02 19:14:19 -0700 Created attachment 38962 patch 144396 3 38962 eric 2009-09-03 00:08:32 -0700 Comment on attachment 38962 patch RenderTheme is private to WebCore, how is WebKit ever going to use this method to set this interval? It seems to me that we would need a different way to pumb this down into WebCore, no? 144399 4 joel 2009-09-03 00:18:16 -0700 (In reply to comment #3) > (From update of attachment 38962 [details]) > RenderTheme is private to WebCore, how is WebKit ever going to use this method > to set this interval? It seems to me that we would need a different way to > pumb this down into WebCore, no? I don't understand. Is this not possible, or the wrong way to do it? The chromium side of this patch is: http://codereview.chromium.org/186009/show The user is in webkit/glue/webview_impl.cc: void WebViewImpl::SetCaretBlinkInterval(double interval) { reinterpret_cast<RenderThemeChromiumLinux*>(theme())-> setCaretBlinkInterval(interval); } 144458 5 eric 2009-09-03 02:15:56 -0700 I guess in other ports RenderTheme is not exposed to the WebKit layer. It's not the end of the world that it's exposed here. 144681 6 38962 joel 2009-09-03 21:16:49 -0700 Comment on attachment 38962 patch Can this be looked at again? Thanks. 144682 7 38962 eric 2009-09-03 21:50:11 -0700 Comment on attachment 38962 patch Rejecting patch 38962 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=38962 from bug 28931 failed to download and apply. 144701 8 eric 2009-09-04 00:01:11 -0700 Applying 38962 from bug 28931. patching file WebCore/ChangeLog patch: **** malformed patch at line 20: Reviewed by Darin Adler. 144702 9 eric 2009-09-04 00:02:43 -0700 Looks like you manually edited the patch file to remove a line w/o updating the line numbers. :) 144705 10 joel 2009-09-04 00:07:34 -0700 Yes, I did :( Sorry about that. Thanks for your help. 144708 11 joel 2009-09-04 00:08:43 -0700 Do you need me to upload a fixed patch? 144710 12 eric 2009-09-04 00:09:47 -0700 Our tools (like the commit-queue) cannot automatically handle this patch. So either someone can land this manually, or you can upload a fixed version. The latter is probably quicker for you. 144711 13 39042 joel 2009-09-04 00:15:05 -0700 Created attachment 39042 fixed patch Here is the same patch with correct line numbers. 144739 14 39042 eric 2009-09-04 00:59:39 -0700 Comment on attachment 39042 fixed patch Rejecting patch 39042 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 144777 15 eric 2009-09-04 03:21:05 -0700 media/video-source-error.html -> timed out Bah. You were bitten by bug 28845 I think. 144990 16 39042 eric 2009-09-05 01:24:23 -0700 Comment on attachment 39042 fixed patch Bitten again! media/video-source-error.html -> timed out 144995 17 39042 eric 2009-09-05 02:06:04 -0700 Comment on attachment 39042 fixed patch Clearing flags on attachment: 39042 Committed r48094: <http://trac.webkit.org/changeset/48094> 144996 18 eric 2009-09-05 02:06:09 -0700 All reviewed patches have been landed. Closing bug. 145019 19 dglazkov 2009-09-05 16:06:45 -0700 Landing this broke a bunch of layout tests on Linux: http://build.chromium.org/buildbot/waterfall.fyi/waterfall?builder=Webkit%20Linux%20(webkit.org) Any idea why? 145029 20 dglazkov 2009-09-05 18:58:45 -0700 Oy. What's the value if you never call the setter? Like in test_shell? 145031 21 dglazkov 2009-09-05 21:10:40 -0700 Rolled out in http://trac.webkit.org/changeset/48098. Please make sure to rely on RenderTheme::caretBlinkInterval as a default value in case setCaretBlinkInterval hasn't been called yet. 145033 22 39118 joel 2009-09-05 21:19:44 -0700 Created attachment 39118 fix I should have implemented caretBlinkInterval instead of caretBlinkIntervalInternal as blinking wasn't being disabled for the layout tests (see WebCore/rendering/RenderThemeChromiumSkia.cpp 194). There was no default value being set, like you asked. I am using git so this patch might not be formatted the way you need. Is there an equivalent of svn-create-patch for git? 145034 23 39119 joel 2009-09-05 22:15:46 -0700 Created attachment 39119 second version 145074 24 39119 dglazkov 2009-09-06 18:56:15 -0700 Comment on attachment 39119 second version r=me. 145076 25 39119 eric 2009-09-06 19:08:09 -0700 Comment on attachment 39119 second version Rejecting patch 39119 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 145080 26 39119 eric 2009-09-06 21:15:45 -0700 Comment on attachment 39119 second version Clearing flags on attachment: 39119 Committed r48105: <http://trac.webkit.org/changeset/48105> 145081 27 eric 2009-09-06 21:15:49 -0700 All reviewed patches have been landed. Closing bug. 145105 28 eric 2009-09-07 00:12:05 -0700 The failure was: media/video-loop.html -> failed Which is possibly just another symptom of bug 28845. 38959 2009-09-02 18:32:26 -0700 2009-09-02 19:14:19 -0700 patch gtk-blink.patch text/plain 2197 joel SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODAwMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDktMDIgIEpvZWwgU3RhbmxleSAgPGpvZWxAam1zLmlkLmF1 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cG9z ZSBmdW5jdGlvbnMgdG8gc2V0IHRoZSBjYXJldCBibGluayBpbnRlcnZhbCBmb3IgTGludXggQ2hy b21pdW0uCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQ2hyb21pdW1MaW51eDo6c2V0Q2FyZXRC bGlua0ludGVydmFsKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQ2hyb21pdW1MaW51 eDo6Y2FyZXRCbGlua0ludGVydmFsKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVD aHJvbWl1bUxpbnV4Lmg6CisKIDIwMDktMDktMDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTGludXguY3BwCShyZXZpc2lvbiA0 ODAwMSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTExMCw0ICsxMTAsMTQgQEAgYm9vbCBSZW5kZXJUaGVtZUNocm9t aXVtTGludXg6OnN1cHBvcnRzQwogICAgIHJldHVybiB0cnVlOwogfQogCit2b2lkIFJlbmRlclRo ZW1lQ2hyb21pdW1MaW51eDo6c2V0Q2FyZXRCbGlua0ludGVydmFsKGRvdWJsZSBpbnRlcnZhbCkK K3sKKyAgICBtX2NhcmV0QmxpbmtJbnRlcnZhbCA9IGludGVydmFsOworfQorCitkb3VibGUgUmVu ZGVyVGhlbWVDaHJvbWl1bUxpbnV4OjpjYXJldEJsaW5rSW50ZXJ2YWwoKSBjb25zdAoreworICAg IHJldHVybiBtX2NhcmV0QmxpbmtJbnRlcnZhbDsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4LmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4LmgJ KHJldmlzaW9uIDQ4MDAxKQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1 bUxpbnV4LmgJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDYgKzQ5LDkgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogICAgICAgICB2aXJ0dWFsIENvbG9yIGluYWN0aXZlTGlzdEJveFNlbGVjdGlvbkJhY2tn cm91bmRDb2xvcigpIGNvbnN0OwogICAgICAgICB2aXJ0dWFsIENvbG9yIGluYWN0aXZlTGlzdEJv eFNlbGVjdGlvbkZvcmVncm91bmRDb2xvcigpIGNvbnN0OwogCisgICAgICAgIHZvaWQgc2V0Q2Fy ZXRCbGlua0ludGVydmFsKGRvdWJsZSBpbnRlcnZhbCk7CisgICAgICAgIHZpcnR1YWwgZG91Ymxl IGNhcmV0QmxpbmtJbnRlcnZhbCgpIGNvbnN0OworCiAgICAgICAgIHZvaWQgc2V0Rm9jdXNSaW5n Q29sb3IoY29uc3QgQ29sb3ImKTsKICAgICAgICAgdmlydHVhbCBDb2xvciBwbGF0Zm9ybUZvY3Vz UmluZ0NvbG9yKCkgY29uc3Q7CiAKQEAgLTU5LDYgKzYyLDggQEAgbmFtZXNwYWNlIFdlYkNvcmUg ewogICAgICAgICAvLyBBIGdlbmVyYWwgbWV0aG9kIGFza2luZyBpZiBhbnkgY29udHJvbCB0aW50 aW5nIGlzIHN1cHBvcnRlZCBhdCBhbGwuCiAgICAgICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c0Nv bnRyb2xUaW50cygpIGNvbnN0OwogCisgICAgICAgIGRvdWJsZSBtX2NhcmV0QmxpbmtJbnRlcnZh bDsKKwogICAgICAgICBDb2xvciBtX2ZvY3VzUmluZ0NvbG9yOwogICAgICAgICBib29sIG1fdXNl RGVmYXVsdEZvY3VzUmluZ0NvbG9yOwogICAgIH07Cg== 38962 2009-09-02 19:14:19 -0700 2009-09-04 00:15:05 -0700 patch gtk-blink.patch text/plain 2252 joel SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODAwMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDktMDIgIEpvZWwgU3RhbmxleSAgPGpvZWxAam1zLmlkLmF1 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cG9z ZSBmdW5jdGlvbnMgdG8gc2V0IHRoZSBjYXJldCBibGluayBpbnRlcnZhbCBmb3IgTGludXggQ2hy b21pdW0uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y ODkzMQorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUNocm9taXVtTGludXg6OnNldENhcmV0Qmxp bmtJbnRlcnZhbCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUNocm9taXVtTGludXg6 OmNhcmV0QmxpbmtJbnRlcnZhbCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hy b21pdW1MaW51eC5oOgorCiAyMDA5LTA5LTAyICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4LmNwcAkocmV2aXNpb24gNDgw MDEpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTGludXguY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMTAsNCArMTEwLDE0IEBAIGJvb2wgUmVuZGVyVGhlbWVDaHJvbWl1 bUxpbnV4OjpzdXBwb3J0c0MKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAordm9pZCBSZW5kZXJUaGVt ZUNocm9taXVtTGludXg6OnNldENhcmV0QmxpbmtJbnRlcnZhbChkb3VibGUgaW50ZXJ2YWwpCit7 CisgICAgbV9jYXJldEJsaW5rSW50ZXJ2YWwgPSBpbnRlcnZhbDsKK30KKworZG91YmxlIFJlbmRl clRoZW1lQ2hyb21pdW1MaW51eDo6Y2FyZXRCbGlua0ludGVydmFsKCkgY29uc3QKK3sKKyAgICBy ZXR1cm4gbV9jYXJldEJsaW5rSW50ZXJ2YWw7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5oCShy ZXZpc2lvbiA0ODAwMSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1M aW51eC5oCSh3b3JraW5nIGNvcHkpCkBAIC00OSw2ICs0OSw5IEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKICAgICAgICAgdmlydHVhbCBDb2xvciBpbmFjdGl2ZUxpc3RCb3hTZWxlY3Rpb25CYWNrZ3Jv dW5kQ29sb3IoKSBjb25zdDsKICAgICAgICAgdmlydHVhbCBDb2xvciBpbmFjdGl2ZUxpc3RCb3hT ZWxlY3Rpb25Gb3JlZ3JvdW5kQ29sb3IoKSBjb25zdDsKIAorICAgICAgICB2b2lkIHNldENhcmV0 QmxpbmtJbnRlcnZhbChkb3VibGUgaW50ZXJ2YWwpOworICAgICAgICB2aXJ0dWFsIGRvdWJsZSBj YXJldEJsaW5rSW50ZXJ2YWwoKSBjb25zdDsKKwogICAgICAgICB2b2lkIHNldEZvY3VzUmluZ0Nv bG9yKGNvbnN0IENvbG9yJik7CiAgICAgICAgIHZpcnR1YWwgQ29sb3IgcGxhdGZvcm1Gb2N1c1Jp bmdDb2xvcigpIGNvbnN0OwogCkBAIC01OSw2ICs2Miw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK ICAgICAgICAgLy8gQSBnZW5lcmFsIG1ldGhvZCBhc2tpbmcgaWYgYW55IGNvbnRyb2wgdGludGlu ZyBpcyBzdXBwb3J0ZWQgYXQgYWxsLgogICAgICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNDb250 cm9sVGludHMoKSBjb25zdDsKIAorICAgICAgICBkb3VibGUgbV9jYXJldEJsaW5rSW50ZXJ2YWw7 CisKICAgICAgICAgQ29sb3IgbV9mb2N1c1JpbmdDb2xvcjsKICAgICAgICAgYm9vbCBtX3VzZURl ZmF1bHRGb2N1c1JpbmdDb2xvcjsKICAgICB9Owo= 39042 2009-09-04 00:15:05 -0700 2009-09-05 21:11:07 -0700 fixed patch gtk-blink.patch text/plain 2252 joel SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODAzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDktMDQgIEpvZWwgU3RhbmxleSAgPGpvZWxAam1zLmlkLmF1 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cG9z ZSBmdW5jdGlvbnMgdG8gc2V0IHRoZSBjYXJldCBibGluayBpbnRlcnZhbCBmb3IgTGludXggQ2hy b21pdW0uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y ODkzMQorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUNocm9taXVtTGludXg6OnNldENhcmV0Qmxp bmtJbnRlcnZhbCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUNocm9taXVtTGludXg6 OmNhcmV0QmxpbmtJbnRlcnZhbCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hy b21pdW1MaW51eC5oOgorCiAyMDA5LTA5LTAzICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KSW5kZXg6IFdlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4LmNwcAkocmV2aXNpb24gNDgw MzgpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTGludXguY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMTAsNCArMTEwLDE0IEBAIGJvb2wgUmVuZGVyVGhlbWVDaHJvbWl1 bUxpbnV4OjpzdXBwb3J0c0MKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAordm9pZCBSZW5kZXJUaGVt ZUNocm9taXVtTGludXg6OnNldENhcmV0QmxpbmtJbnRlcnZhbChkb3VibGUgaW50ZXJ2YWwpCit7 CisgICAgbV9jYXJldEJsaW5rSW50ZXJ2YWwgPSBpbnRlcnZhbDsKK30KKworZG91YmxlIFJlbmRl clRoZW1lQ2hyb21pdW1MaW51eDo6Y2FyZXRCbGlua0ludGVydmFsKCkgY29uc3QKK3sKKyAgICBy ZXR1cm4gbV9jYXJldEJsaW5rSW50ZXJ2YWw7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5oCShy ZXZpc2lvbiA0ODAzOCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1M aW51eC5oCSh3b3JraW5nIGNvcHkpCkBAIC00OSw2ICs0OSw5IEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKICAgICAgICAgdmlydHVhbCBDb2xvciBpbmFjdGl2ZUxpc3RCb3hTZWxlY3Rpb25CYWNrZ3Jv dW5kQ29sb3IoKSBjb25zdDsKICAgICAgICAgdmlydHVhbCBDb2xvciBpbmFjdGl2ZUxpc3RCb3hT ZWxlY3Rpb25Gb3JlZ3JvdW5kQ29sb3IoKSBjb25zdDsKIAorICAgICAgICB2b2lkIHNldENhcmV0 QmxpbmtJbnRlcnZhbChkb3VibGUgaW50ZXJ2YWwpOworICAgICAgICB2aXJ0dWFsIGRvdWJsZSBj YXJldEJsaW5rSW50ZXJ2YWwoKSBjb25zdDsKKwogICAgICAgICB2b2lkIHNldEZvY3VzUmluZ0Nv bG9yKGNvbnN0IENvbG9yJik7CiAgICAgICAgIHZpcnR1YWwgQ29sb3IgcGxhdGZvcm1Gb2N1c1Jp bmdDb2xvcigpIGNvbnN0OwogCkBAIC01OSw2ICs2Miw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK ICAgICAgICAgLy8gQSBnZW5lcmFsIG1ldGhvZCBhc2tpbmcgaWYgYW55IGNvbnRyb2wgdGludGlu ZyBpcyBzdXBwb3J0ZWQgYXQgYWxsLgogICAgICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNDb250 cm9sVGludHMoKSBjb25zdDsKIAorICAgICAgICBkb3VibGUgbV9jYXJldEJsaW5rSW50ZXJ2YWw7 CisKICAgICAgICAgQ29sb3IgbV9mb2N1c1JpbmdDb2xvcjsKICAgICAgICAgYm9vbCBtX3VzZURl ZmF1bHRGb2N1c1JpbmdDb2xvcjsKICAgICB9Owo= 39118 2009-09-05 21:19:44 -0700 2009-09-05 22:15:46 -0700 fix gtk-blink-2.patch text/plain 2435 joel ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yjc3OTU1Ny4uZjBmZjVkYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wOS0wNSAgSm9lbCBTdGFubGV5 ICA8am9lbEBqbXMuaWQuYXU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVXNlIGNhcmV0QmxpbmtJbnRlcnZhbEludGVybmFsIHRvIHNldCBjYXJldCBi bGFuay4KKyAgICAgICAgQXMgaW5kaWNhdGVkIGluIFJlbmRlclRoZW1lQ2hyb21pdW1Ta2lhOjpj YXJldEJsaW5rSW50ZXJ2YWwgdGhlIGNhcmV0CisgICAgICAgIGJsaW5rIGlzIGRpc2FibGVkIGZv ciBsYXlvdXQgdGVzdHMsIGFuZCBpbiBvdGhlciBjYXNlcyBpdCBjYWxscworICAgICAgICBjYXJl dEJsaW5rSW50ZXJ2YWxJbnRlcm5hbCB0byBzZXQgdGhlIGludGVydmFsLiAgRml4ZXMgbGF5b3V0 IHRlc3QKKyAgICAgICAgZmFpbHVyZXMgaW50cm9kdWNlZCBpbiByNDgwOTQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODkzMQorCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJUaGVtZUNocm9taXVtTGludXg6OlJlbmRlclRoZW1lQ2hyb21pdW1MaW51eCk6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUNocm9taXVtTGludXg6OmNhcmV0QmxpbmtJbnRl cnZhbEludGVybmFsKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxp bnV4Lmg6CisKIDIwMDktMDktMDUgIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoQ2hyb21pdW0gcmVsaWFiaWxpdHkgYnVpbGQgYnJl YWspLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxp bnV4LmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5jcHAK aW5kZXggM2E2YmIyNy4uY2QwYWI3NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGhlbWVDaHJvbWl1bUxpbnV4LmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJU aGVtZUNocm9taXVtTGludXguY3BwCkBAIC00Niw2ICs0Niw3IEBAIFBhc3NSZWZQdHI8UmVuZGVy VGhlbWU+IFJlbmRlclRoZW1lOjp0aGVtZUZvclBhZ2UoUGFnZSogcGFnZSkKIFJlbmRlclRoZW1l Q2hyb21pdW1MaW51eDo6UmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4KCkKICAgICA6IG1fdXNlRGVm YXVsdEZvY3VzUmluZ0NvbG9yKHRydWUpCiB7CisgICAgbV9jYXJldEJsaW5rSW50ZXJ2YWwgPSBS ZW5kZXJUaGVtZTo6Y2FyZXRCbGlua0ludGVydmFsKCk7CiB9CiAKIFJlbmRlclRoZW1lQ2hyb21p dW1MaW51eDo6flJlbmRlclRoZW1lQ2hyb21pdW1MaW51eCgpCkBAIC0xMzAsNyArMTMxLDcgQEAg dm9pZCBSZW5kZXJUaGVtZUNocm9taXVtTGludXg6OnNldENhcmV0QmxpbmtJbnRlcnZhbChkb3Vi bGUgaW50ZXJ2YWwpCiAgICAgbV9jYXJldEJsaW5rSW50ZXJ2YWwgPSBpbnRlcnZhbDsKIH0KIAot ZG91YmxlIFJlbmRlclRoZW1lQ2hyb21pdW1MaW51eDo6Y2FyZXRCbGlua0ludGVydmFsKCkgY29u c3QKK2RvdWJsZSBSZW5kZXJUaGVtZUNocm9taXVtTGludXg6OmNhcmV0QmxpbmtJbnRlcnZhbElu dGVybmFsKCkgY29uc3QKIHsKICAgICByZXR1cm4gbV9jYXJldEJsaW5rSW50ZXJ2YWw7CiB9CmRp ZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTGludXguaCBi L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5oCmluZGV4IDA0YjQ0 YzAuLjk3ZmMxNDUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hy b21pdW1MaW51eC5oCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1M aW51eC5oCkBAIC01Miw3ICs1Miw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdmly dHVhbCB2b2lkIGFkanVzdFNsaWRlclRodW1iU2l6ZShSZW5kZXJPYmplY3QqKSBjb25zdDsKIAog ICAgICAgICB2b2lkIHNldENhcmV0QmxpbmtJbnRlcnZhbChkb3VibGUgaW50ZXJ2YWwpOwotICAg ICAgICB2aXJ0dWFsIGRvdWJsZSBjYXJldEJsaW5rSW50ZXJ2YWwoKSBjb25zdDsKKyAgICAgICAg dmlydHVhbCBkb3VibGUgY2FyZXRCbGlua0ludGVydmFsSW50ZXJuYWwoKSBjb25zdDsKIAogICAg ICAgICB2b2lkIHNldEZvY3VzUmluZ0NvbG9yKGNvbnN0IENvbG9yJik7CiAgICAgICAgIHZpcnR1 YWwgQ29sb3IgcGxhdGZvcm1Gb2N1c1JpbmdDb2xvcigpIGNvbnN0Owo= 39119 2009-09-05 22:15:46 -0700 2009-09-06 21:15:45 -0700 second version gtk-blink-try2.patch text/plain 2802 joel ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTk4OGM3Ni4uNmEwNjZiZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAwOS0wOS0wNSAgSm9lbCBTdGFubGV5 ICA8am9lbEBqbXMuaWQuYXU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRXhwb3NlIGZ1bmN0aW9ucyB0byBzZXQgdGhlIGNhcmV0IGJsaW5rIGludGVy dmFsIGZvciBMaW51eCBDaHJvbWl1bS4KKyAgICAgICAgRGVmYXVsdCB2YWx1ZSBpcyBzZXQgdG8g dGhhdCBvZiBSZW5kZXJUaGVtZTo6Y2FyZXRCbGFua0ludGVydmFsKCkuCisgICAgICAgIFVzZXMg Y2FyZXRCbGlua0ludGVydmFsSW50ZXJuYWwgdG8gYXZvaWQgb3ZlcnJpZGluZworICAgICAgICBS ZW5kZXJUaGVtZUNocm9taXVtU2tpYTo6Y2FyZXRCbGFua0ludGVydmFsIHRvIHByZXNlcnZlIHRo ZSBkaXNhYmxpbmcKKyAgICAgICAgb2YgYmxpbmtpbmcgY2FyZXQgcmVxdWlyZWQgZm9yIGxheW91 dCB0ZXN0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI4OTMxCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQ2hyb21pdW1MaW51eDo6UmVuZGVyVGhl bWVDaHJvbWl1bUxpbnV4KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQ2hyb21pdW1M aW51eDo6c2V0Q2FyZXRCbGlua0ludGVydmFsKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRo ZW1lQ2hyb21pdW1MaW51eDo6Y2FyZXRCbGlua0ludGVydmFsSW50ZXJuYWwpOgorICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTGludXguaDoKKwogMjAwOS0wOS0wNSAgRGlt aXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l Q2hyb21pdW1MaW51eC5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVt TGludXguY3BwCmluZGV4IDEyMGZiOWUuLmNkMGFiNzcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4LmNwcApAQCAtNDYsNiArNDYsNyBAQCBQYXNzUmVm UHRyPFJlbmRlclRoZW1lPiBSZW5kZXJUaGVtZTo6dGhlbWVGb3JQYWdlKFBhZ2UqIHBhZ2UpCiBS ZW5kZXJUaGVtZUNocm9taXVtTGludXg6OlJlbmRlclRoZW1lQ2hyb21pdW1MaW51eCgpCiAgICAg OiBtX3VzZURlZmF1bHRGb2N1c1JpbmdDb2xvcih0cnVlKQogeworICAgIG1fY2FyZXRCbGlua0lu dGVydmFsID0gUmVuZGVyVGhlbWU6OmNhcmV0QmxpbmtJbnRlcnZhbCgpOwogfQogCiBSZW5kZXJU aGVtZUNocm9taXVtTGludXg6On5SZW5kZXJUaGVtZUNocm9taXVtTGludXgoKQpAQCAtMTI1LDQg KzEyNiwxNCBAQCBib29sIFJlbmRlclRoZW1lQ2hyb21pdW1MaW51eDo6c3VwcG9ydHNDb250cm9s VGludHMoKSBjb25zdAogICAgIHJldHVybiB0cnVlOwogfQogCit2b2lkIFJlbmRlclRoZW1lQ2hy b21pdW1MaW51eDo6c2V0Q2FyZXRCbGlua0ludGVydmFsKGRvdWJsZSBpbnRlcnZhbCkKK3sKKyAg ICBtX2NhcmV0QmxpbmtJbnRlcnZhbCA9IGludGVydmFsOworfQorCitkb3VibGUgUmVuZGVyVGhl bWVDaHJvbWl1bUxpbnV4OjpjYXJldEJsaW5rSW50ZXJ2YWxJbnRlcm5hbCgpIGNvbnN0Cit7Cisg ICAgcmV0dXJuIG1fY2FyZXRCbGlua0ludGVydmFsOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTGlu dXguaCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5oCmluZGV4 IDk0MTU5NjQuLjk3ZmMxNDUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lQ2hyb21pdW1MaW51eC5oCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hy b21pdW1MaW51eC5oCkBAIC01MSw2ICs1MSw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAg ICAgICB2aXJ0dWFsIHZvaWQgYWRqdXN0U2xpZGVyVGh1bWJTaXplKFJlbmRlck9iamVjdCopIGNv bnN0OwogCisgICAgICAgIHZvaWQgc2V0Q2FyZXRCbGlua0ludGVydmFsKGRvdWJsZSBpbnRlcnZh bCk7CisgICAgICAgIHZpcnR1YWwgZG91YmxlIGNhcmV0QmxpbmtJbnRlcnZhbEludGVybmFsKCkg Y29uc3Q7CisKICAgICAgICAgdm9pZCBzZXRGb2N1c1JpbmdDb2xvcihjb25zdCBDb2xvciYpOwog ICAgICAgICB2aXJ0dWFsIENvbG9yIHBsYXRmb3JtRm9jdXNSaW5nQ29sb3IoKSBjb25zdDsKIApA QCAtNjEsNiArNjQsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIC8vIEEgZ2VuZXJh bCBtZXRob2QgYXNraW5nIGlmIGFueSBjb250cm9sIHRpbnRpbmcgaXMgc3VwcG9ydGVkIGF0IGFs bC4KICAgICAgICAgdmlydHVhbCBib29sIHN1cHBvcnRzQ29udHJvbFRpbnRzKCkgY29uc3Q7CiAK KyAgICAgICAgZG91YmxlIG1fY2FyZXRCbGlua0ludGVydmFsOworCiAgICAgICAgIENvbG9yIG1f Zm9jdXNSaW5nQ29sb3I7CiAgICAgICAgIGJvb2wgbV91c2VEZWZhdWx0Rm9jdXNSaW5nQ29sb3I7 CiAgICAgfTsK