288283 2025-02-21 22:31:31 -0800 Encapsulate containing block calculations for positioned layout 2025-02-25 20:34:33 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 288398 275447 1 fantasai.bugs fantasai.bugs bfulgham kiet.ho simon.fraser webkit-bug-importer zalan oldest_to_newest 2097037 0 fantasai.bugs 2025-02-21 22:31:31 -0800 Positioned layout in RenderBox is tangled up in ways that make it hard to build on: * Setting and calculating values from containing block geometry is scattered throughout the code. * Offset calculations for converting to/from container coordinates are unnecessarily confusing and not well separated from layout rule implementations. * We repeat some calculations for no other reason that someone happened to put them in a function that's called multiple times. * We pass around long lists of parameters in order to pass cached information from one function to another, which makes it hard to notice the parameters that actually changed between function calls. To have a better foundation for adding position-area and alignment code, we should: * Encapsulate containing block geometry logic and data. * Package up cached values into a single struct so they can be passed as a single parameter. * Better organize calculations into phases so that position-area adjustments to the containing block and alignment logic can be more easily and correctly integrated. 2097038 1 webkit-bug-importer 2025-02-21 22:31:39 -0800 <rdar://problem/145348582> 2097287 2 fantasai.bugs 2025-02-23 19:40:07 -0800 https://github.com/WebKit/WebKit/pull/41180 2098120 3 ews-feeder 2025-02-25 20:34:31 -0800 Committed 291088@main (6512cb0009b0): <https://commits.webkit.org/291088@main> Reviewed commits have been landed. Closing PR #41180 and removing active labels.